D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification. REPOSI

D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 431 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/431/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Feb 2020 04:43:29 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 306 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/306/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 16 Feb 2020 04:43:29 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 298 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/298/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 16 Feb 2020 04:43:30 + Build duration: 10 min and counting JUnit Tests Name: projectroot Fai

D27419: Update Japanese holidays

nhiga added a comment. In D27419#612064 , @winterz wrote: > I tested these changes locally. works > > do you have commit access? No, I do not have commit access. (I think commit access is only granted to active developers/contributor

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. Works fine as far as I can tell, amazing no one else noticed this before! REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #framework

D26749: WIP: Support NDK r20 and Qt 5.14

apol added a comment. Patch makes sense to me overall, we could consider landing it. INLINE COMMENTS > vkrause wrote in Android.cmake:173 > It's "better" in the way that it actually works with NDK r20, while CMake > 3.16 failed to even pass the basic compiler checks. For a toolchain file >

Re: 2 kirigami fixes for a point release

On Sat, Feb 15, 2020 at 8:10 AM Nate Graham wrote: > > On 2020-02-13 00:42, Ben Cooksley wrote: > > A better way of approaching this would be to freeze the Frameworks > > version you are going to require API wise at an earlier point in the > > Plasma development cycle. This would allow for a full

T12641: Refactor KFileProtocol::copy

dfaure added a comment. I don't really understand the relation to ksmserver, surely kioslaves are not part of session management. I also don't really understand what would happen in the new event loop (select/poll) of the kioslave while the non-blocking I/O is happening. It's not like t

D27223: add kirigami-gallery icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. You've got a duplicate copy of the icon in there. The bottom shadow should also be changed to be dark gray, like a darker version of the normal background color rather than a dark

D27224: add Kongress icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. The pixel alignment for all parts of the inner symbol is off. The style of the inner symbol is a bit too rounded for the breeze style as well. For instance, the podium should have

D27419: Update Japanese holidays

aacid added a comment. No, she (i think) does not have commit access. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, dcaliste, michael

D27419: Update Japanese holidays

winterz accepted this revision. winterz added a comment. I tested these changes locally. works do you have commit access? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: #kde_pim, kde-frameworks-devel, LeGast

D27363: KHolidays: Convert license statements to SPDX expressions

winterz added a comment. looks ok to me. INLINE COMMENTS > cgiboudeaux wrote in lunarphase.cpp:6 > This looks suspicious > > @winterz ? no, it's fine. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz, kde-framework

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75740. meven added a comment. Add an assertion to JobTest::stat()^Ccomment out other tests debug output REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=75567&id=75740 BRANCH arcpatch-D25010_2 REVISION DETAIL htt

Re: New Framework Review: KDAV

Hi, sorry for this very late mail, missed the call for reviews... Would it be possible to do some license clarifications before moving kdav into the frameworks section? In mostly all files it is not clear if the LGPL or the GPL is meant (stating "GNU Library General Public License" and referrin

Re: New Framework Review: KDAV

On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It > would

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75737. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Make snippet copyright statement more verbose REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75736&id=75737 BRANCH s

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 5 inline comments as done. cordlandwehr added a comment. Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim. INLINE COMMENTS > cgiboudeaux wrote in holidayscannerplan.cpp:1297-1301 > and t

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75736. cordlandwehr added a comment. Clarified several statements - Recovered origin of weekNumber method and its original license - Unified verbose license statements - Clarified snippet licensing REPOSITORY R175 KHolidays CHANGES SINCE L

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a subscriber: kde-mac. rjvbb added a comment. Well, I got as far as confirming you're probably right, when I finally got to sit at my Mac yesterday night ... and then when I woke up it was 3am. I'm tempted to green-light this but I think someone is going to have to verify the

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 15 Feb 2020 08:47:37 + Build duration: 2 min 24 sec and counting JUnit Tests Name:

D27419: Update Japanese holidays

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, dcaliste, mic