Re: 2 kirigami fixes for a point release

2020-02-12 Thread Kai Uwe Broulik
Hi, > We have to ask: what causes buggy releases? People rushing things in at the last minute, even better if unreviewed. Plasma 5.18 was a prime example of this. Every single time there's drama on Beta tagging day for some last minute change that should go in. To remedy this I wanted Beta fe

Re: 2 kirigami fixes for a point release

2020-02-12 Thread Ben Cooksley
On Thu, Feb 13, 2020 at 10:00 AM Nate Graham wrote: > > [+ frameworks and plasma mailing lists] > > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va > > escriure: > >> Personally I think it would be nice to have > >> 86f9884

D27355: POC: Make kstatusnotifieritem available without dbus

2020-02-12 Thread Johnny Jazeix
jjazeix added a comment. thank you! I did the same but way worse. I think we can at least push this fix to remove all failing jobs then clean it up? INLINE COMMENTS > CMakeLists.txt:94 > if (NOT WIN32 AND NOT ANDROID) > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)

Re: 2 kirigami fixes for a point release

2020-02-12 Thread Kevin Ottens
Hello, Since I'm not on release-team I'm discovering this just now. On Wednesday, 12 February 2020 21:59:32 CET Nate Graham wrote: > [+ frameworks and plasma mailing lists] > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va

D27355: POC: Make kstatusnotifieritem available without dbus

2020-02-12 Thread Ben Cooksley
bcooksley added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:48 > + > +#include > #include New header? > kstatusnotifieritem.cpp:617 > void KStatusNotifierItem::showMessage(const QString &title, const QString > &message, const QString &icon, int timeout) > { > #ifdef Q_OS_M

D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R266:96cf15e1905d: Add icon for org.kde.Ikona (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75577&id=75578 REVISION DETAIL https:

D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Carson Black
cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, mich

D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Noah Davis
ndavis added a comment. please update the test plan before landing though REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Carson Black
cblack updated this revision to Diff 75577. cblack added a comment. Adjust style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75506&id=75577 BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218 A

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 60 - Unstable!

2020-02-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/60/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 12 Feb 2020 22:56:47 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-r

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-12 Thread Dominik Haumann
dhaumann added a comment. No offense meant, but even with the screenshots I still have no idea what this is about :) Can you add a before/after screenshot so we can see the visual difference? Also, the "fill left" and "fill right" wording is new, and not intuitively understandable f

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

2020-02-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 22:56:47 + Build duration: 6 min 28 sec and counting JUnit Tests Name: proje

Re: 2 kirigami fixes for a point release

2020-02-12 Thread Nate Graham
[+ frameworks and plasma mailing lists] On 2020-02-12 11:31, Albert Astals Cid wrote: El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va escriure: Personally I think it would be nice to have 86f988434cd657e77cc9429e78f7290ce6b5713d since otherwise LTS Plasma users will be hi

D27355: POC: Make kstatusnotifieritem available without dbus

2020-02-12 Thread Hannah von Reth
vonreth added a comment. While preparing this I discovered that we should also review the locations where if MAC is used, as thats not the only platform that should use the systray icon REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27355 To: vonreth, bcook

D27355: POC: Make kstatusnotifieritem available without dbus

2020-02-12 Thread Hannah von Reth
vonreth retitled this revision from "Make kstatusnotifieritem available without dbus" to "POC: Make kstatusnotifieritem available without dbus". vonreth edited the summary of this revision. vonreth added reviewers: bcooksley, jjazeix. REPOSITORY R289 KNotifications REVISION DETAIL https://ph

D27355: Make kstatusnotifieritem available without dbus

2020-02-12 Thread Hannah von Reth
vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27355 AFFECTED FILES CMakeLists.txt

D27246: add buho icon

2020-02-12 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. the shadow on the folded corners needs to be changed. diagonal shadows only go down and to the right REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/

D27354: Remove hardcoded colors

2020-02-12 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27354 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter added a comment. I think I tried with moving. Currently not at home to check. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

2020-02-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 20:13:40 + Build duration: 1 min 14 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Unstable!

2020-02-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 12 Feb 2020 19:29:40 + Build duration: 14 min and counting JUnit Tests Name: p

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi
niccolove added a reviewer: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27354 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/ BUG:417511

D27352: retain atime properly

2020-02-12 Thread Nathaniel Graham
ngraham added a comment. The modified time changes too. Am I testing this right? F8100051: vokoscreenNG-2020-02-12_11-52-33.mp4 REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngrah

T12641: Refactor KFileProtocol::copy

2020-02-12 Thread Méven Car
meven added a comment. @dfaure does this makes sense to you ? TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, m

Fwd: DBus on Windows - failing Jenkins builds

2020-02-12 Thread Johnny Jazeix
Hi, sorry for the direct forward. TLDR: Notifications uses dbus. On Windows and Mac, there is no dbus so classes using dbus are not compiled. But KStatusNotifierItem still uses dbus internally and this causes link error. Is there a clean and easy way to bypass dbus calls for Windows? Johnny --

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter added a comment. No, the access time is always the current time, the modified time should not change. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasen

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 91 - Fixed!

2020-02-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/91/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 12 Feb 2020 17:47:19 + Build duration: 5 min 7 sec and counting BUILD ARTIFACTS acc/KF5Win

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2020-02-12 Thread Méven Car
meven updated this revision to Diff 75567. meven marked an inline comment as done. meven added a comment. Make setDetails(KIO::StatDetail detail) compile only when deprecated since 5.68 is enabled REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=75566&i

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2020-02-12 Thread Méven Car
meven updated this revision to Diff 75566. meven marked 3 inline comments as done. meven added a comment. Add a test for setDetails(KIO::StatDetails), fix comment, add a KIOCORE_ENABLE_DEPRECATED_SINCE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=75

D26858: Provide an implementation for the tablet interface

2020-02-12 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 75564. apol added a comment. Only call destruction if it was an owned tablet, this way we don't crash. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=75561&id=75564 BRANCH arcpatch-D26858 REVISION DETAIL ht

D27351: call smb_cutime on the correct url to actually set mtime properly

2020-02-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. It works! Fantastic! REPOSITORY R320 KIO Extras BRANCH bug356651 REVISION DETAIL https://phabricator.kde.org/D27351 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberes

D26858: Provide an implementation for the tablet interface

2020-02-12 Thread Aleix Pol Gonzalez
apol added a comment. In D26858#605869 , @davidedmundson wrote: > Feedback from some testing: > > - we're adding the same tool a bunch of times when a new client is created > - sometimes we fail to enter the surface leaving the cursor "stuc

D27352: retain atime properly

2020-02-12 Thread Nathaniel Graham
ngraham added a comment. So when I copy a file from my samba share to my desktop, the accessed time of the copied file on my machine should match the accessed time of the version on the server? If so, it doesn't seem to work for me; the accessed time is reset to the time when the file was co

D27352: retain atime properly

2020-02-12 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug410624 REVISION DETAIL https://phabricator.kde.org/D27352 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, Mr

D26858: Provide an implementation for the tablet interface

2020-02-12 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 75561. apol added a comment. rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74473&id=75561 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeL

D27352: retain atime properly

2020-02-12 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this was broken since forever I guess. when the .part resume tech was

D27351: call smb_cutime on the correct url to actually set mtime properly

2020-02-12 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY since the introduction of partial resume dstUrl would can be the .part

D27350: Port away from Title and towards level 1 Heading

2020-02-12 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY `Title` is deprecated. TEST PLAN No visual changes anywhere; level 1 Heading is ide

D27328: Drop qmake pri file generation & installation, currently broken

2020-02-12 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27328#610115 , @jgrulich wrote: > Looking at some other frameworks, they basically have same code to generate pri files, are they all broken? > > For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists

D27279: Port away from QWidget

2020-02-12 Thread Aleksei Nikiforov
alnikiforov added a comment. I've managed to reproduce it and take a backtrace. It's an infinite recursion. Eventually stack's end is reached, although it takes some time to do it. Here's a piece of backtrace I got: #460 0x764dcbec in KIdleTimePrivate::_k_resumingFromIdle (thi

D27210: add KDEconnect Icons

2020-02-12 Thread Albert Vaca Cintora
albertvaka added a comment. Hey, thanks for working on this! A "brand" re-design is something that we could really use. One of the things that I would like to change from the current icon/logo, though (and that this new one doesn't change), is the fact that there is a mobile phone in it.

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-02-12 Thread Kevin Ottens
ervin added a comment. @dfaure, any opinion on the separator character? It came from me checking which character is forbidden in group names, and it seems that only "group separator" is, so it started a bit like a joke with "I wonder if we'd need to patch KConfigSkeleton at all for subgroups

D20507: Update Japanese holidays

2020-02-12 Thread Ryunosuke Toda
Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D20507 To: nhiga, #kde_pim, dvratil Cc: kde-frameworks-devel, ryunosuke, dvratil, kde-pim, LeGast00n, cblack, fbampaloukas, GB_2, dcalis

D26877: Simplify calls to whitespace() and use it in more places.

2020-02-12 Thread Kevin Ottens
ervin added a comment. In D26877#604672 , @dfaure wrote: > I don't like it either. It doesn't "read" well. > Looking at cout or qDebug it's much more common to `[the usual stream] << [some modifier] << some more stuff`. Yep, that's wha

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-12 Thread Kevin Ottens
ervin added a comment. LGTM, giving a couple more days for @dfaure to react to it though. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27279: Port away from QWidget

2020-02-12 Thread Kai Uwe Broulik
broulik added a comment. > How can I reproduce crash in resume on idle? For me I set screen turn off to 1 minute, waited for the screen to fade to black, waited a bit more, got curious why it didn't actually turn it off, wiggled the mouse, and then found it crashed. You might need to t

D27279: Port away from QWidget

2020-02-12 Thread Aleksei Nikiforov
alnikiforov added a comment. I've tested this patch in it's current form, and powerdevil no longer crashes for me on launch too. How can I reproduce crash in resume on idle? Can it be done in virtual machine? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27279

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:86e132a3a829: Makefile highlight: fix variable names in "else" conditionals (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabr

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix! REPOSITORY R216 Syntax Highlighting BRANCH fix-makefile REVISION DETAIL https://phabricator.kde.org/D27343 To: nibags, #framework_syntax_highlighting, dhauma

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27343 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraha

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 417379 Allow highl

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Benjamin Port
This revision was automatically updated to reflect the committed changes. Closed by commit R237:059a4feee45b: Add setNotifyFunction to KPropertySkeletonItem (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27342?vs=75540&id=75542 REVISION D

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27342 To: bport, ervin, meven, crossi Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Benjamin Port
bport marked 2 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27342 To: bport, ervin, meven, crossi Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Benjamin Port
bport updated this revision to Diff 75540. bport added a comment. Fix doc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27342?vs=75535&id=75540 REVISION DETAIL https://phabricator.kde.org/D27342 AFFECTED FILES src/core/kcoreconfigskeleton.cpp src/c

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann added a comment. Ok, tested on Win10 => This solves the issue. I see no proper way to cleanup this without thinking more about how sonnet does cache the dictionaries internally. It just cleans up "too late" with a global static. Given sonnet anyways will keep all stuff loa

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.h:297 > void swapDefault() override; > +/** > + * Set a function called when property change Add an empty line before > kcorec

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 75536. cullmann added a comment. adapt api to used QMap REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75534&id=75536 BRANCH arcpatch-D27332 REVISION DETAIL https://phabricator.kde.org/D27332 AFFECTED FI

D27342: Add setNotifyFunction to KPropertySkeletonItem

2020-02-12 Thread Benjamin Port
bport created this revision. bport added reviewers: ervin, meven, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This function will be called when the property value change REPOSITORY R237

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 75534. cullmann added a comment. add missing include for windows REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75532&id=75534 BRANCH arcpatch-D27332 REVISION DETAIL https://phabricator.kde.org/D27332 AF

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-12 Thread eudoxos
eudoxos added a comment. This is the current dialogue, with two new options at the bottom (the circle had horizontal spring before an unrelated option, I think it was there by accident...?!). F8099358: image.png REPOSITORY R39 KTextEditor REVISI

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-12 Thread eudoxos
eudoxos updated this revision to Diff 75533. eudoxos added a comment. Rename config keys as per discussion under D27238 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75440&id=75533 BRANCH dynwrap-marker

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 75532. cullmann added a comment. fix argument to create spell checker REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75527&id=75532 BRANCH arcpatch-D27332 REVISION DETAIL https://phabricator.kde.org/D2733

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 75527. cullmann added a comment. sonnet cleanup for the dictionaries seems to be too late try what happen if we leak them, too REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75516&id=75527 BRANCH arcpat

D27332: try to fix issue with ispellchecker on windows

2020-02-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 75516. cullmann added a comment. any cleanup crashs silently REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75513&id=75516 BRANCH arcpatch-D27332 REVISION DETAIL https://phabricator.kde.org/D27332 AFFECT

D27328: Drop qmake pri file generation & installation, currently broken

2020-02-12 Thread Jan Grulich
jgrulich added a comment. Looking at some other frameworks, they basically have same code to generate pri files, are they all broken? For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists.txt#n195 REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.

D27238: Add an option to dynamic-break inside words

2020-02-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a08d45f2b56: Add an option to dynamic-break inside words (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27238?vs=75509&id=75514 REVISION

D27238: Add an option to dynamic-break inside words

2020-02-12 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, happy with that, thanks! REVISION DETAIL https://phabricator.kde.org/D27238 To: eudoxos, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, LeGast