D27082: [Tests]Make radiobutton3.qml use PC3

gvgeo removed a reviewer: ndavis. gvgeo added a subscriber: ndavis. gvgeo added a comment. In D27082#604556 , @ndavis wrote: > poor horizontal alignment Don't make me redraw PC3 tests too. The basis of the issue is the same, differe

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/108/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 23:00:32 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS acc/KF5Servi

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/82/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 01 Feb 2020 23:00:32 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 23:00:31 + Build duration: 4 min 47 sec and counting JUnit Tests Name: proje

Banning QNetworkAccessManager

Hi all, For an extremely long time now, it has been a known issue with the QNetworkAccessManager that by default it does not follow redirects as issued by the server it is accessing. This is something the Qt Project has refused to address using the justification of 'behavioural compatibility' Thi

D26931: Introduce SPDX license headers

cordlandwehr added inline comments. INLINE COMMENTS > kossebau wrote in MIT.txt:1 > Does the " " work here? The statement is correct, it directly comes from the SPDX license text registry and is installed via the "reuse download" tool to ensure that the original header is deployed. REPOSITOR

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 179 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/179/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 20:19:37 + Build duration: 7 min 13 sec and counting JUnit Tests Name: p

D23410: improve word completion to use highlighting to detect word boundaries

cullmann planned changes to this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23410: improve word completion to use highlighting to detect word boundaries

cullmann added a comment. Reverted atm... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23410: improve word completion to use highlighting to detect word boundaries

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Did lead to regressions, see https://bugs.kde.org/show_bug.cgi?id=412502 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kw

D27082: [Tests]Make radiobutton3.qml use PC3

ndavis added a comment. Well, it has the correct size in that it's 16x16, but it's like it was stretched and cropped. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27082 To: gvgeo, #plasma, ndavis Cc: kde-frameworks-devel, Orage, LeGast00n, The-

D27082: [Tests]Make radiobutton3.qml use PC3

ndavis added a comment. I'm not really the best person to review this, but it seems to work. The test still has poor horizontal alignment and the button doesn't have the correct size. F8074583: Screenshot_20200201_142426.PNG REPOSITORY R242 Plasma Fr

D26931: Introduce SPDX license headers

kossebau added inline comments. INLINE COMMENTS > MIT.txt:1 > +MIT License Copyright (c) > + Does the " " work here? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, GB

D27092: Update license statements to SPDX identifiers

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27092: Update license statements to SPDX identifiers

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Update all existing license and copyright statements to SPDX identifiers. REPOSITORY R280 Prison BRANCH

D27091: Convert license statements to SPDX

cgiboudeaux added a comment. +1 LGTM REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27091: Convert license statements to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27091: Convert license statements to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add required files in LICENSES folder. REPOSITORY R246 Sonnet BRA

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/81/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 01 Feb 2020 17:29:08 + Build duration: 7 min 15 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 17:29:08 + Build duration: 4 min 39 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/107/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 17:29:08 + Build duration: 3 min 8 sec and counting BUILD ARTIFACTS abi-compatibi

D27087: Add HEIF thumbnailer

broulik added a comment. https://codereview.qt-project.org/c/qt/qtimageformats/+/236077 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: cfeck, broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, M

D27087: Add HEIF thumbnailer

cfeck added a comment. Where can we see the status of the HEIF Qt loader? If it correctly implements scaled image loading, then a separate thumbnailer indeed makes not much sense. If, however, it always loads the full image, then scales it down, we got a case for a separate thumbnailer such

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann updated this revision to Diff 74839. cullmann added a comment. set normal or dark icons based on current palette REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25119?vs=69194&id=74839 BRANCH arcpatch-D25119 REVISION DETAIL https://phabri

D27087: Add HEIF thumbnailer

zzag added a comment. In D27087#604479 , @broulik wrote: > There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

D27087: Add HEIF thumbnailer

zzag abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michae

D27087: Add HEIF thumbnailer

broulik added a comment. -1 for making a dedicated thumbnailer. There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly. REPOSITORY R320 KIO Extras REVISION DETAIL

D27087: Add HEIF thumbnailer

zzag added a comment. In D27087#604477 , @ngraham wrote: > Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview? No, as far as I know there is no `QImageIOHandler` for HEIF files. However

D27087: Add HEIF thumbnailer

ngraham added a comment. Very cool. So QImage support this file format now such that you could open the image in, say, Gwenview? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasen

D27087: Add HEIF thumbnailer

zzag updated this revision to Diff 74836. zzag added a comment. missing copyright stuff in Findlibheif.cmake REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27087?vs=74835&id=74836 BRANCH heic-thumbnailer REVISION DETAIL https://phabricator.kde.org/

D27087: Add HEIF thumbnailer

zzag edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D27087: Add HEIF thumbnailer

zzag created this revision. zzag added a reviewer: Plasma. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R320 KIO Extras BRANCH heic-thumbnailer REVISION DETAIL https://phabricator.k

D26931: Introduce SPDX license headers

This revision was automatically updated to reflect the committed changes. Closed by commit R274:11f5cd0390e4: Introduce SPDX license headers (authored by cordlandwehr). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74768&id=74834 REVISION DETAIL

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/80/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 01 Feb 2020 10:19:55 + Build duration: 19 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/79/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 01 Feb 2020 09:07:12 + Build duration: 1 hr 12 min and counting BUILD ARTIFACTS abi-compatibil

D27083: [PC2]Give Label integer width.

gvgeo added a comment. The Checkbox takes fractional position, caused from the fractional width of the Label. This lead to blurriness. F8071229: Screenshot_20200201_100353_2.png I don't understand what the problem is. Height can also take the `Math.

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/106/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 10:11:34 + Build duration: 3 min 25 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 10:11:34 + Build duration: 1 min 45 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/58/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:09:33 + Build duration: 59 min and counting JUnit Tests Name: projectroot Fa

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

gvgeo added a comment. F8071207: alignment.png This shows the problem. Don't know what is the correct approach: 1 Label needs to be shorter, like PC3. 2 Give correct height in checkbox, and center the buttons. 3 Override label height in radiobutt

D25698: New query mechanism for applications: KApplicationTrader

dfaure added a comment. ping? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.12 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 09:10:03 + Build duration: 45 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:07:51 + Build duration: 45 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:07:10 + Build duration: 39 min and counting JUnit Tests Name: projectroot

D27083: [PC2]Give Label integer width.

davidedmundson added a comment. I don't understand from the screenshot what changed wrt widths in your screenshots. Could you expand on what the bug identified is? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, nda

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:06:41 + Build duration: 36 min and counting JUnit Tests Name: projectroot Fai

D27083: [PC2]Give Label integer width.

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The math.ceil changes. Absolutely. Binding width to painted width doesn't make sense. They're different things. It'll break any alignment REPOSITORY R242 Pl

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:06:13 + Build duration: 33 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 09:07:11 + Build duration: 31 min and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 282 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/282/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:04:45 + Build duration: 33 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:04:28 + Build duration: 27 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/2/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 01 Feb 2020 09:00:11 + Build duration: 22 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/2/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 01 Feb 2020 09:00:21 + Build duration: 21 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:02:39 + Build duration: 15 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/58/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:02:17 + Build duration: 15 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/155/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 01 Feb 2020 09:01:32 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:01:59 + Build duration: 13 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/103/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:01:32 + Build duration: 12 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 01 Feb 2020 09:00:29 + Build duration: 8 min 25 sec and counting JUnit Tests Name:

D27083: [PC2]Give Label integer width.

gvgeo edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh,

D27083: [PC2]Give Label integer width.

gvgeo added a comment. PC3 label gives integer size. If this patch is right, will make a patch to change all the tests to use PC2/PC3 label, instead of QQC2 for proper display. The 2 vertical misalignment problems are not the focus of this patch, created by: 1. PC2 label height is

D27083: [PC2]Give Label integer width.

gvgeo edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, Zr

D27083: [PC2]Give Label integer width.

gvgeo edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh,

D27082: [Tests]Make radiobutton3.qml use PC3

gvgeo retitled this revision from "Make radiobutton3.qml use PC3" to "[Tests]Make radiobutton3.qml use PC3". gvgeo edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27082 To: gvgeo, #plasma, ndavis Cc: kde-frameworks

D27083: [PC2]Give Label integer width.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, ndavis. gvgeo added a project: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gvgeo requested review of this revision. REVISION SUMMARY Label paintedWidth creates alingment issues when

D27082: Make radiobutton3.qml use PC3

gvgeo added a comment. Because PC3 label is shorter that PC3 checkbox, there is a misalignment than need fixing. Either need to change label to have a height similar to PC2 (1.6*fontHeight). Or need to change this test's text vertical alignment. REPOSITORY R242 Plasma Framework (Library)

D27082: Make radiobutton3.qml use PC3

gvgeo created this revision. gvgeo added reviewers: Plasma, ndavis. gvgeo added a project: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gvgeo requested review of this revision. REVISION SUMMARY Correct radiobutton3.qml to use Plasma Components 3 in