Re: Get Hot New Stuff - Legacy Endpoints and Multiple Requests (Discover?)

On Fri, Jan 31, 2020 at 1:05 AM Michael Reeves wrote: > > There seems to be some sort of ssl certificate issue with autoconfig.kde.org. > On kubuntu this triggers a warning as soon as discover starts that may be a > contributing factor. I've checked and can find no fault with autoconfig.kde.org

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/102/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 31 Jan 2020 01:49:27 + Build duration: 5 min 55 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 154 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/154/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 31 Jan 2020 01:49:27 + Build duration: 4 min 30 sec and counting BUILD ARTIFACTS acc/KF5Co

WARNING: was bad recommendation (Re: Recommendation: drop ProvidersUrl entry to rely on default value)

Hi, TLDR: removing the ProvidersUrl entry actually breaks things in non-Plasma installations, so for now has to be hardcoded, using the non-deprecated ProvidersUrl=https://autoconfig.kde.org/ocs/providers.xml See below for investigation results: Am Freitag, 31. Januar 2020, 00:14:19 CET schrie

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added inline comments. INLINE COMMENTS > kmessagewidget.cpp:39 > + > +constexpr int borderSize = 2; > + I don't think so: > internal linkage > [...] > variables, variable templates (since C++14), functions, or function templates > declared static; > non-volatile non-template (since C++

Re: Recommendation: drop ProvidersUrl entry to rely on default value

On 01/30/20 13:53, Friedrich W. H. Kossebau wrote: as found out by discussion on irc, a good solution for everyone relying on the default GHNS storage as provided by KDE is to just not hard-code any value for ProvidersUrl, but leave it out and let KNewStuff default to what is built into the KNewS

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

cfeck added inline comments. INLINE COMMENTS > kmessagewidget.cpp:39 > + > +constexpr int borderSize = 2; > + Does it need to be `static` to avoid an external symbol? REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035

Re: Get Hot New Stuff - Legacy Endpoints and Multiple Requests (Discover?)

There seems to be some sort of ssl certificate issue with autoconfig.kde.org. On kubuntu this triggers a warning as soon as discover starts that may be a contributing factor. On Thu, Jan 30, 2020, 4:20 AM Ben Cooksley wrote: > Hi all, > > While diagnosing an issue this evening with cdn.kde.org,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

dhaumann added a comment. Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a minor detail, but imho such details are important. But indeed, the screenshots look goo

D27044: create Breeze style Kate icon based on new design by Tyson Tan

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5df044e6614: create Breeze style Kate icon based on new design by Tyson Tan (authored by cullmann). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27044?vs=74

D27044: create Breeze style Kate icon based on new design by Tyson Tan

ngraham accepted this revision. ngraham added a comment. Shipit! Shipit good! Just shipit! If the icon comes along, you must shipit Before pixels set out too long, you must ship it When something's going ~~wrong~~ right, you must ship it Now shipit! It's not too late! REPOS

D26697: Message-related methods: Use more member-function-pointer-based connect

dhaumann added a comment. In two days we have the next KDE Frameworks tag. I'd have preferred a commit on Sunday ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26697 To: kossebau, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, Le

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann updated this revision to Diff 74728. cullmann added a comment. - use optimized version by ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27044?vs=74727&id=74728 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27044 AFF

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. Thanks! REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27044 To: cullmann, ngraham, #vdg, ndavis, tysontan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM If you're not sure, use `scour` because it's the least likely to screw anything up. As long as the code is formatted well and not filled with useless noise, it's fine if it isn't

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. In D27044#603597 , @ngraham wrote: > LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run the icon through an SVG optimizer. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tip

D27044: create Breeze style Kate icon based on new design by Tyson Tan

ngraham accepted this revision as: ngraham. ngraham added a comment. LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run the icon through an SVG optimizer. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization. Personally I use

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann updated this revision to Diff 74727. cullmann added a comment. - delete different sized icons, new icon scales well enough REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27044?vs=74720&id=74727 BRANCH master REVISION DETAIL https://phabr

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. >> For the other icons, I see, there are even more in other subdirs: >> >>  cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"

D27044: create Breeze style Kate icon based on new design by Tyson Tan

ngraham added a comment. Thanks, much better now. In D27044#603538 , @cullmann wrote: > In D27044#603537 , @cullmann wrote: > > > 2 questions: > > > > 1. should I use the same icon for dark?

D27034: Fix message box when passing a remote url that includes a file

This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabric

D26983: Enable adding place as first child

gvgeo planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26697: Message-related methods: Use more member-function-pointer-based connect

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6db5cb3ea2ba: Message-related methods: Use more member-function-pointer-based connect (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26697

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

This revision was automatically updated to reflect the committed changes. Closed by commit R39:da4c983d1f6b: DocumentPrivate::postMessage: avoid multiple hash lookups (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26696?vs=74712&id=7

D26697: Message-related methods: Use more member-function-pointer-based connect

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, too, thanks! REPOSITORY R39 KTextEditor BRANCH moremodernconnect REVISION DETAIL https://phabricator.kde.org/D26697 To: kossebau, dhaumann, cullmann Cc: cullmann, kwri

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann updated this revision to Diff 74720. cullmann added a comment. - cut PNG part from kate.svg + update dark icon, too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27044?vs=74719&id=74720 BRANCH master REVISION DETAIL https://phabricator.

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann marked an inline comment as done. cullmann added a comment. PNG part is gone, seems to have no effect. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27044 To: cullmann, ngraham, #vdg, ndavis, tysontan Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. In D27044#603537 , @cullmann wrote: > 2 questions: > > 1. should I use the same icon for dark? > 2. what to do with the PNG part? Can this just be stripped? And how? ;=) > > Sorry for the noob questions, but S

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. 2 questions: 1. should I use the same icon for dark? 2. what to do with the PNG part? Can this just be stripped? And how? ;=) Sorry for the noob questions, but SVG-wise I have no ideas ;=) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricat

D27044: create Breeze style Kate icon based on new design by Tyson Tan

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27044 To: cullmann, ngraham, #vdg, ndavis, tysontan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Upsa, missed that, looks OK IMHO ;=) REPOSITORY R39 KTextEditor BRANCH avoidmultiplehashaccess REVISION DETAIL https://phabricator.kde.org/D26696 To: kossebau, dhaumann, cullman

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added a comment. I tried to follow the guide on https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips and what was said in https://phabricator.kde.org/T12594 I used the kate-source-derivatives.svg from that task as input, set the size to 48 (4 pixel margin inside)

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann added reviewers: VDG, ndavis, tysontan. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27044 To: cullmann, ngraham, #vdg, ndavis, tysontan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

cullmann created this revision. cullmann added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY details see https://phabricator.kde.org/T12594 REPOSITORY R266 Breeze Icons BR

D26903: allow programLogo property to be a QIcon, too

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Then shortly reopen this, otherwise I forget to do this ;=) Thanks for the feedback. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. Kate with this patch and Oxygen style: F8030118: Screenshot_20200130_181731.PNG The misplacement I spotted earlier is specific to QtCurve and also happens with the current KMessageWidget. REPOSITORY R236 KWidgetsAddons BR

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 74714. davidre added a comment. Draw opaque and mix the colors manually again. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=74697&id=74714 BRANCH no-css (branched from master) REVISION DETAIL htt

D26903: allow programLogo property to be a QIcon, too

kossebau added a comment. In D26903#600771 , @cullmann wrote: > Would something like this be ok? > > Not sure what to write about sizes, e.g. for the program icon we don't mention anything either. The program icon I have and such woul

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

davidre updated this revision to Diff 74713. davidre added a comment. Fix code style REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27039?vs=74704&id=74713 BRANCH messagewidget (branched from master) REVISION DETAIL https://phabricator.k

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

kossebau updated this revision to Diff 74712. kossebau added a comment. rebase to latest master ping? :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26696?vs=73659&id=74712 BRANCH avoidmultiplehashaccess REVISION DETAIL https://phabricator.kde

D26697: Message-related methods: Use more member-function-pointer-based connect

kossebau updated this revision to Diff 74711. kossebau added a comment. rebase to latest master ping? :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26697?vs=73660&id=74711 BRANCH moremodernconnect REVISION DETAIL https://phabricator.kde.org/D

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. In D27035#603460 , @dhaumann wrote: > Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or wheth

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. In D27035#603460 , @dhaumann wrote: > Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or wheth

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

dhaumann added a comment. Can you provide screenshots of more styles? :-) REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

dhaumann added a comment. Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were t

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a dependent revision: D27038: [KMessageWidget] Allow the style to change our palette. REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel,

D27038: [KMessageWidget] Allow the style to change our palette

davidre added a dependency: D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

davidre added a dependency: D27038: [KMessageWidget] Allow the style to change our palette. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

davidre added a dependent revision: D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

davidre edited the test plan for this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

davidre created this revision. davidre added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY KMessageWidget has to rely on hardcoded colors because it's in a Tier 1 framework

D27038: [KMessageWidget] Allow the style to change our palette

davidre created this revision. davidre added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY After we set our palette give the current QStyle a chance to give us a better pa

D27034: Fix message box when passing a remote url that includes a file

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D27034 To: apol, #frameworks, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. In D27035#603375 , @davidre wrote: > The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4 Nevermind that was because of above mistake R

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 74697. davidre added a comment. Tiny mistakes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=74693&id=74697 BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4 REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidr

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. Much simpler and more comprehensible now. REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: dav

D26983: Enable adding place as first child

meven added a comment. Before: Adding a place as first child will place it at the end. What is after ? How do I test this exactly ? REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, brou

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre created this revision. davidre added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY While being a prepatory step to KMessageWidget respecting the current color sche

D27034: Fix message box when passing a remote url that includes a file

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore R

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74690. gvgeo added a comment. This revision is now accepted and ready to land. count -1 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26983?vs=74689&id=74690 BRANCH after (branched from master) REVISION DETAIL https://

D26983: Enable adding place as first child

gvgeo planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74689. gvgeo added a comment. Revert style edit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26983?vs=74688&id=74689 BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 AFFECTED FIL

D26983: Enable adding place as first child

gvgeo marked 3 inline comments as done. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo retitled this revision from "[WIP]Enable adding place as first child" to "Enable adding place as first child". REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-framework

D26983: [WIP]Enable adding place as first child

gvgeo updated this revision to Diff 74688. gvgeo added a comment. Removed duplicate code, and used count instead. I was hopping for something better, this has couple more steps to complete. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26983?vs=74549&id=7

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/57/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 12:51:48 + Build duration: 16 min and counting JUnit Tests Name: projectroot Fa

D27028: Switch from download.k.o to autoconfig

leinir updated this revision to Diff 74687. leinir added a comment. Thanks to broulik for noticing (or making me notice) this - Don't change a thing that deals with legacy data REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27028?vs=74676&id=74687 B

D27028: Switch from download.k.o to autoconfig

leinir added inline comments. INLINE COMMENTS > broulik wrote in cache.cpp:160 > We use `https` everywhere these days Yup, this wants to be left alone... i'll add a little comment to that effect. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27028 To: leinir, bcoo

Recommendation: drop ProvidersUrl entry to rely on default value (was: Re: Get Hot New Stuff - Legacy Endpoints)

Hi, as found out by discussion on irc, a good solution for everyone relying on the default GHNS storage as provided by KDE is to just not hard-code any value for ProvidersUrl, but leave it out and let KNewStuff default to what is built into the KNewStuff library as current value. So: --- 8< --

D27028: Switch from download.k.o to autoconfig

leinir added inline comments. INLINE COMMENTS > broulik wrote in cache.cpp:160 > We use `https` everywhere these days Yes, quite, we certainly do. (i'm also wondering if this is really something that wants changing or not, as it's... in a bit that loads KNS2 cache files... from KDE3) REPOSITO

D27028: Switch from download.k.o to autoconfig

broulik added inline comments. INLINE COMMENTS > cache.cpp:160 > +if > (e.payload().startsWith(QLatin1String("http://download.kde.org/khotnewstuff";)) > + || > e.payload().startsWith(QLatin1String("http://autoconfig.kde.org/khotnewstuff";))) > { > // Th

D27025: Add signals for udev events with actions bind and unbind

This revision was automatically updated to reflect the committed changes. Closed by commit R245:8036f148fb66: Add signals for udev events with actions bind and unbind (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27025?vs=74684&id=74685 RE

D27025: Add signals for udev events with actions bind and unbind

meven updated this revision to Diff 74684. meven added a comment. s/binded/ound REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27025?vs=74683&id=74684 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27025 AFFECTED FILES src/solid/devices/b

D27025: Add signals for udev events with actions bind and unbind

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

broulik added a comment. I think it's "bound" REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

meven updated this revision to Diff 74683. meven added a comment. Add signals for bind/unbind actions REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27025?vs=74671&id=74683 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27025 AFFECTED FILES

D27025: Add signals for udev events with actions bind and unbind

meven marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

meven retitled this revision from "Ignore udev monitoring notifications with actions bind and unbind" to "Add signals for udev events with actions bind and unbind". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel,

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

fvogt edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: [WIP]Enable adding place as first child

gvgeo added a dependent revision: D27032: Enable adding a place as first item.. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

meven added inline comments. INLINE COMMENTS > fvogt wrote in kurlnavigatorplacesselector.cpp:75 > How would that make a difference? Misconception on my part, .children() is not affected by .clear() REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #framewo

D27028: Switch from download.k.o to autoconfig

leinir updated this revision to Diff 74676. leinir added a comment. As suggested by frinring, do not suggest setting a ProvidersUrl unless it is actually needed. - Rework the knsrc description comment, suggest not setting ProvidersUrl REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDA

D27028: Switch from download.k.o to autoconfig

leinir added reviewers: bcooksley, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27028 To: leinir, bcooksley, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Rather than suggest using dko for provider files, we should be suggesting autoconfig.k.o, which is a more capable servic

D27025: Ignore udev monitoring notifications with actions bind and unbind

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > udevqtclient.cpp:119 > +} else if (action == "bind") { > +// ignored > +} else if (action == "unbind") { Can you instead add signals for t

D26133: Enable Auto Save

apol added a comment. In D26133#603118 , @tcanabrava wrote: > > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. > > I disagree here. >

D26691: Optimize code when dropping files into the desktop

trmdi added a comment. @mart Do you have any objection? REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anth

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 11:41:44 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS acc/KF5Qui

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/21/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 30 Jan 2020 11:41:44 + Build duration: 1 min 29 sec and counting BUILD ARTIFACTS acc/KF5Qui

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 11:41:44 + Build duration: 59 sec and counting JUnit Tests Name: projectr

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 74672. trmdi added a comment. - Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74036&id=74672 BRANCH improve-file-drop-menu (branched from master) REVISION DETAIL https://phabricat

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 11:31:19 + Build duration: 47 sec and counting CONSOLE OUTPUT [...truncated 250

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 11:31:19 + Build duration: 24 sec and counting CONSOLE OUTPUT [...truncat

  1   2   >