D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

2020-01-29 Thread Noah Davis
ndavis added reviewers: Frameworks, dfaure. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

2020-01-29 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This patch provides ways to get just the hue or just the chroma in the HCY colorspace and a way to get a QColor based on

D26874: Use KStandardAction convenience method for switchApplicationLanguage

2020-01-29 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R263:821b25609c05: Use KStandardAction convenience method for switchApplicationLanguage (authored by kossebau). REPOSITORY

D26873: KStandardAction: add method for SwitchApplicationLanguage action creation

2020-01-29 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R265:db71c8dee3ff: KStandardAction: add method for SwitchApplicationLanguage action creation (authored by kossebau). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D26873: KStandardAction: add method for SwitchApplicationLanguage action creation

2020-01-29 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH addconveniencemethodforlanguageswitchaction REVISION DETAIL https://phabricator.kde.org/D26873 To: kossebau, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

2020-01-29 Thread Laurent Montel
mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QApplication::globalStrut() will be removed in qt6 REPOSITORY R236 KWidgetsAddons BRANCH remove_globalStrut (bra

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

2020-01-29 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27010 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27009: Makefile highlight: add substitutions

2020-01-29 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 416685 Add substit

D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine

2020-01-29 Thread Albert Astals Cid
aacid added a comment. Seems reasonable to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26990 To: leinir, #knewstuff, aacid, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26979: KWallet-PAM SELinux context transition support

2020-01-29 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:17 > +find_library(SELINUX selinux) > > find_program(SOCAT_EXECUTABLE socat) instead of message() set_package_properties(SELINUX PROPERTIES DESCRIPTION "some security thing" TYPE OPTIONAL

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-01-29 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This method gets called each time solid notices a change, which can in some setups be very frequent. It leaked memory as the submenus a

D26979: KWallet-PAM SELinux context transition support

2020-01-29 Thread Nathaniel Graham
ngraham added reviewers: Plasma, Frameworks. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D26979 To: secureworkstation, #plasma, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh,

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. I am not a #Frameworks reviewer Please give some time to others to have a look as well INLINE COMMENTS > gvgeo wrote in kfileplacesmodel.cpp:10

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread Méven Car
meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Also compared binary size? ;) You still want to use QLatin1Char with single characters, that is less undisputed agreed upon as better choice :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26868 To: tcanabrava, ervin, dfaure Cc: kossebau

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 74601. ahiemstra added a comment. - Use QQmlParserStatus to slightly delay syncing of role names REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=74592&id=74601 BRANCH arcpatch-D25326 REVISION DETAIL

D26868: Move newItem to private method in KConfigSourceGenerator

2020-01-29 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 74600. tcanabrava added a comment. - Fix code style REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26868?vs=74234&id=74600 BRANCH simplify_newEntry REVISION DETAIL https://phabricator.kde.org/D26868 AFFECTED F

D26868: Move newItem to private method in KConfigSourceGenerator

2020-01-29 Thread Tomaz Canabrava
tcanabrava added a comment. In D26868#602162 , @kossebau wrote: > In D26868#602150 , @dfaure wrote: > > > There is indeed a QString overload for concatenating QLatin1String, but it will have to be co

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26127 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26128 To: tcanabrava, ervin Cc: ervin, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26126: Simplify param method: Return Early, Use a Map and Assert.

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava, ervin, dfaure Cc: dfaure, ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26130: Simplify return logic

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26129: Remove Iterator based loops for range based loops

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26129 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

2020-01-29 Thread Tomaz Canabrava
tcanabrava added a comment. update / rebased. INLINE COMMENTS > ervin wrote in KConfigHeaderGenerator.cpp:252 > I lost track of constness here so I might be wrong, shouldn't this use > qAsConst in this context? yeah. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL h

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

2020-01-29 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 74596. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Use qAsConst REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26876?vs=74253&id=74596 BRANCH remove_enum_hack REVISION DETAIL http

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

2020-01-29 Thread George Vogiatzis
gvgeo added a comment. @ndavis Any chance you missed my previous comment? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg, ngraham Cc: gvgeo, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread George Vogiatzis
gvgeo added a comment. Although the target of this patch is the `else` part below, there is a need to add a place at the end. INLINE COMMENTS > kfileplacesmodel.cpp:1046 > { > -addPlace(text, url, iconName, appName, QModelIndex()); > +KBookmark bookmark = KFilePlacesItem::createBook

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread David Edmundson
davidedmundson updated this revision to Diff 74592. davidedmundson marked 14 inline comments as done. davidedmundson added a comment. a load of review comments REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=71421&id=74592 BRANCH master REVI

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Tomaz Canabrava
tcanabrava added a comment. it's a +1 for me. @dfaure and @ervin ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:74 > +QJSValueList args = {QJSValue(source_row), > engine->toScriptValue(source_parent)}; > +return const_cast *>(this)->m_filterCallback.call(args).toBool(); > +} Suggestion: Instead of directly re

D20026: Go up in folder hierachy when in "edit mode"

2020-01-29 Thread Méven Car
meven added a comment. Another great patch someone could commandeer, it seems... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-01-29 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74590. zzag added a comment. s/const QWindow/QWindow/ REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=74098&id=74590 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread Méven Car
meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodel.cpp:1046 > { > -addPlace(text, url, iconName, appName, QModelIndex()); > +KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookm

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven updated this revision to Diff 74589. meven added a comment. Make isImmutable function constant PROPERTY when generateProperties is passed REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74582&id=74589 BRANCH arcpatch-D26368 REVISION DETAIL

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread Nathaniel Graham
ngraham added reviewers: meven, broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven updated this revision to Diff 74582. meven added a comment. Allow the isImmutable to be invokable from Qml when generateProperties is set REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74563&id=74582 BRANCH arcpatch-D26368 REVISION DETAIL

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:85 > +QJSValueList args = {QJSValue(source_column), > engine->toScriptValue(source_parent)}; > +return const_cast *>(this)->m_filterCallback.call(args).toBool(); > +} This is using the wrong callbac

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven added a comment. In D26368#602498 , @tcanabrava wrote: > I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind

D26848: Don't assume the manager and menu have the same lifetime

2020-01-29 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R265:a33675fdb3e4: Don't assume the manager and menu have the same lifetime (authored by davidre). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26848?vs=74271&i

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added a comment. Something I noticed just now while trying to use this: the `filterString` property has disappeared. PlasmaCore.SortFilterProxy does have this. I think we should restore it, otherwise you need to manually call QSFPM::setFilterFixedString or hope that you can set it

D26848: Don't assume the manager and menu have the same lifetime

2020-01-29 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH menumanager (branched from master) REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks, broulik Cc: anthonyfieroni, broulik, kde-frameworks-devel,

D26560: Fix selection printing

2020-01-29 Thread Robert Hoffmann
hoffmannrobert added a comment. Here is the fix for 1. I've tried number 2, but I didn't get anywhere. I think this would need huge efforts: To remove the empty space before (and after) the selection you would have to change the layout, which is tied to the document, so basically you wo

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Tomaz Canabrava
tcanabrava added a comment. I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind of code in Qml: enabled: !kcm.balooSettings.isImmutable("indexingE

D26948: [KColorSchemeManager] Don't list duplicates

2020-01-29 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R265:e9ca0991da32: [KColorSchemeManager] Don't list duplicates (authored by davidre). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26948?vs=74445&id=74578 REVI

D26560: Fix selection printing

2020-01-29 Thread Robert Hoffmann
hoffmannrobert updated this revision to Diff 74577. hoffmannrobert added a comment. - Fix 1: long lines wrapping over pages REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26560?vs=73197&id=74577 BRANCH fix_selection_printing REVISION DETAIL https:/

D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine

2020-01-29 Thread Dan Leinir Turthra Jensen
leinir added reviewers: KNewStuff, aacid, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26990 To: leinir, #knewstuff, aacid, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine

2020-01-29 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 74574. leinir added a comment. - Remove some unrelated changes REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26990?vs=74573&id=74574 BRANCH allow-setting-qtquick-itemsmodel-engine-with-either-engine-type (branched

D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine

2020-01-29 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This fixes a regression caused by the initial work to bring KNSQuick up to feature parity with KNewStuff's widget implem

D25117: file ioslave: stop copying as soon as the ioslave is killed

2020-01-29 Thread Méven Car
meven updated this revision to Diff 74570. meven added a comment. rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=74543&id=74570 BRANCH arcpatch-D25117 REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED FILES autotests/jobtest

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Kevin Ottens
ervin added subscribers: tcanabrava, dfaure. ervin added a comment. LGTM but lets' wait for a second pair of eyes. Mines are definitely not sharp today. :-) @tcanabrava @dfaure, opinions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > ahiemstra wrote in ksortfilterproxymodel_qml.cpp:111 > I don't think a unit test is the right place for example code. It's probably > better to either improve the documentation of the property or add an example > somewhere where it makes sense.

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven updated this revision to Diff 74563. meven added a comment. Clean unnecessary files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74561&id=74563 BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 AFFECTED FILES

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven updated this revision to Diff 74561. meven added a comment. Rebase & update tests REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=72618&id=74561 BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 AFFECTED FILES

D26873: KStandardAction: add method for SwitchApplicationLanguage action creation

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. No-one any opinion? :) My opinion is as before, for consistency there should also be a convenience method for that enum value. Would then proceed and merge on 31st January, unless someone objects before. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://p

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > kmaterka wrote in ksortfilterproxymodel_qml.cpp:111 > Can you add a test for sortColumn? It might be useful for newcomers (like me) > to understand how it works. I had real trouble understanding when it is > needed and when not (ConfigEntries.q

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread George Vogiatzis
gvgeo edited the summary of this revision. gvgeo added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread George Vogiatzis
gvgeo added a comment. Marked as WIP, cause I don't know how to avoid code duplication. Don't know what other places, that expect -1 to be last, need fix. Only have D26984 for dolphin, which is the reason I made this patch. REPOSITORY R241 KIO RE

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread George Vogiatzis
gvgeo added a dependent revision: D26984: Add a place, by drag into empty area of the panel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: [WIP]Enable adding place as first child

2020-01-29 Thread George Vogiatzis
gvgeo created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gvgeo requested review of this revision. REVISION SUMMARY When index after is null, Move new bookmark into first place, by sending null in moveBookmark. TEST PLAN Before: Addin

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Kevin Ottens
ervin added a comment. In D26368#602296 , @meven wrote: > In D26368#602254 , @ervin wrote: > > > Now that the refactoring landed, what about rebasing this one? > > > That's almost a complete rew

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Méven Car
meven added a comment. In D26368#602254 , @ervin wrote: > Now that the refactoring landed, what about rebasing this one? That's almost a complete rewrite ^^ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368

D26982: Convert a foreach, clean a bad comment

2020-01-29 Thread Méven Car
meven abandoned this revision. meven added a comment. No worth it REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26982 To: meven, #frameworks, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26982: Convert a foreach, clean a bad comment

2020-01-29 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R237 KConfig BRANCH foreach REVISION DETAIL https://phabricator.kde.org/D26982 AF

D26368: Add an isImmutable to know if a property is immutable

2020-01-29 Thread Kevin Ottens
ervin added a comment. Now that the refactoring landed, what about rebasing this one? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2020-01-29 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D21721#602167 , @aacid wrote: > FWIW this broke artikulate since you changed the expected entry for engine: in KNS.ItemsModel Ah, would've been wy easier to work out what you were talking about if you comme