D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/R245:3ff3aaa6640c0fb14bba5430110b20237105c203 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00

D26573: Add missing Import Env Variable

tcanabrava created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Without this, in Qt 5.14 I get an android-like QQC2 theme This used to work on Qt 5

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591657 , @ngraham wrote: > Looks like this needs a bit of CMake work to stop installing the old icons: > > # from directory: /home/nate/kde/build/plasma-framework > gmake[2]: *** No rule to mak

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham added a comment. Looks like this needs a bit of CMake work to stop installing the old icons: # from directory: /home/nate/kde/build/plasma-framework gmake[2]: *** No rule to make target '/home/nate/kde/src/plasma-framework/src/desktoptheme/air/icons/nepomuk.svg', needed by

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. @bruns @ngraham What do you two think about using the find icon as the search icon, given IIRC we used the find icon for search in Dolphin in the Oxygen-era/KDE4-era? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. There we go. Noticed there was a slight imperfection with the icon alignment in the previous edit so fixed that. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, b

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73235. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and redesign Oxygen/Air 'search' icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73233&i

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73233. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73230&id=73233 BRANCH master REVISION DETA

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. *sigh* It seems scour-icon decided to nuke the layer names that made the icons identifiable, working on fixing that now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, n

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. ^ that was just me scour-icon'ing the SVG file as I forgot to initially. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73230. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air Search Icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73229&id=7

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73229. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air's icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73225&id=73229

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. Hmph... Oxygen has a low-quality 'search' icon. I'll update the diff again in a bit to add a higher quality version of the icon in SVG form if I can find a higher quality SVG of the icon from Oxygen. REPOSITORY R242 Plasma Framework (Library) REVISION DET

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73225. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73161&id=73225 BRANCH master REVISION DETA

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham added a comment. Thanks! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26484: Popup menu again to reposition it

trmdi added a comment. @mart @dfaure I have some question. 1, Should `DropJob::setApplicationActions()` be called only one time? 2, I see this when I drop multiple file types at once to the desktop (e.g. 2 jpg and 1 zip), the `DropJob::setApplicationActions()` is called 3 times as fo

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

meven accepted this revision. meven added a comment. That seems good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082 To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven Cc: plasma-devel, meven, bport, LeGast00n, The-Fer

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73216. crossi added a comment. space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=73215&id=73216 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES libnotificationmanager/settings

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73215. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=71783&id=73215 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES libnotification

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 73214. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=71676&id=73214 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES libnotification

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. Alright, I'll look into having a replacement icon for Oxygen/Air. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis, davidr

D26564: Clean kbuildsycoca4 support

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26564 AFFECTE

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham requested changes to this revision. ngraham added a comment. Are we sure this is the right approach? In the Breeze theme, the icon is the same as the generic magnifying glass search icon, but in the Oxygen and Breeze theme, it's some kind of paint splatter, which as @bruns suggests, i

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The nepomuk icon is completely inappropriate for a generic "search" icon. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. If anyone has any issues with removing the 'nepomuk' icon theming, please be sure to let me know so I can add them back in again on this patch to be alongside the 'search' theming to sort that issue out. It appears that no 1st-party Plasmoids I can see i

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Icons in the desktop theme that are made to replace icons in the icon theme need to be kept up to date with the icon theme. I'm accepting this as it is, but if @davidre thinks we should con

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584484 , @hoffmannrobert wrote: > In D21563#584218 , @dhaumann wrote: > > > @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde

D26560: Fix selection printing

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Printing selected text only worked correctly if the lines from which text was selected

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 73195. GB_2 marked an inline comment as done. GB_2 added a comment. Use David's suggestion REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71675&id=73195 BRANCH arcpatch-D26043 REVISION DETAI

D26043: Add edit mode menu item to desktop widget context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R242:629db2f3b55b: Add edit mode menu item to desktop widget context menu (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73187. leinir added a comment. - Actually update the entry when it's updated, don't just ignore it REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73126&id=73187 BRANCH unbreak-changedentries-in-qtquick (bra

D26043: Add edit mode menu item to desktop widget context menu

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > containmentinterface.cpp:1129 > +if (m_containment->containmentType() == > Plasma::Types::DesktopContainment) { > + > desktopMenu->addAction(m_containment->corona()->actions()->action(QStri

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a comment. Ping :-) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart, ngraham Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73182. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73181&id=73182 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES src/core/desktopexecparser

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73181. meven added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73179&id=73181 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES src/core/desktopexecparser.cpp

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven created this revision. meven added reviewers: ervin, ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The Terminal field in .desktop file was not taken into account as the des

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 10 Jan 2020 08:34:37 + Build duration: 2 min 14 sec and counting JUnit Tests Name: projectr