D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

kossebau added a comment. @mlaurent Bonne année :) Hm, are we sure that endl is namespaced with Qt:: in 5.15 already? Isn't that rather Qt6 only? For Qt5 `endl` is in the namespace `QTextStreamFunctions` rather, which though is also inlined by `using namespace QTextStreamFunctions`, so

D26321: Expose show-line-count in the ConfigInterface

dhaumann accepted this revision. dhaumann added a comment. Ok with this... Thanks. A note " Since 5.6x would be nice". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26321 To: mludwig, #ktexteditor, cullmann, dhaumann Cc: dhaumann, cullmann, kwrite-devel, kde-fra

T11950: Reduce the pain of working on monochrome Breeze icons

ndavis added a comment. For the Inkscape optimized svg gradient problem: https://gitlab.com/inkscape/inbox/issues/1121 TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham, ndavis Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, LeGast00n, cblack, konki

D26326: Add application/x-audacity-project icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Just needs some optimization and it'll be good to go REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis Cc: ndavis, kde

D26306: Define more documentation search paths (also custom)

asturmlechner added a comment. Thanks for that, works for me! REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00

D26319: Port endl to \n (QFile flushs data when deleted)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26319 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

apol added inline comments. INLINE COMMENTS > CppGenerator.cpp:61 > writeCopyrightHeader(stream); > -stream << "#pragma once" << endl << endl; > -stream << "#include " << endl << endl; > -stream << "class QDBusObjectPath;" << endl << endl; > -stream << "na

D26318: Port endl to "\n" flush at the end + use const'ref in loop

apol added inline comments. INLINE COMMENTS > scalabletest.cpp:312 > QTextStream stream(&msg); > -stream << "Duplicated scalable icons:" << endl; > -for (auto icon : duplicatedScalableIcons.keys()) { > -stream << QString(" %1:").arg(icon) << e

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol added inline comments. INLINE COMMENTS > plugintest.cpp:60 > > -cout << "-- KPluginTrader Test --" << endl; > +cout << "-- KPluginTrader Test --" > +#if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) std::endl should just work with cout. REPOSITORY R309 KService REVISION DE

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pidgin_emoticons.cpp:221 > +out << QStringLiteral("Description=") + themeName() << "\n"; > +out << "Author=" << "\n"; > +out << "\n"; Put it in the same string

D26299: endl is namespaced in qt5.15

apol added inline comments. INLINE COMMENTS > prison-datamatrix.cpp:39 >QTextStream str(stdout); > - str << error << ": " << errormessage << endl; > + str << error << ": " << errormessage > + #if (QT_VERSION < QT_VERSION_CHECK(5, 15, 0)) Wouldn't make more sense to port to std::endl

D26294: Allow to load widget based KCMs from kcms subdir

apol added a comment. It would be useful if you were a bit more explicit about how you tested it on the commit message. INLINE COMMENTS > kcmoduleloader.cpp:103 > if (!cm) { > +module = factory->create(parent, args2); > +if (module) {

D26202: WIP: Refactor KConfigXT

dfaure added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

ngraham added reviewers: Frameworks, Dolphin. ngraham added a comment. It would be helpful if you could update the description to mention why this change is being made and when benefit comes from not reading desktop files' comment fields. Also, updating the Test Plan section with details

D26331: Removed reading description from desktop files

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26332: [KURISearchFilterEngine] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use const as need be. Use QList::at() where possible. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-ikw

D26331: Removed reading description from desktop files

count added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

count created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. count requested review of this revision. REVISION SUMMARY For https://bugs.kde.org/show_bug.cgi?id=382325 i've removed reading comments inside desktop files. REPOSITORY R241 KIO

D26321: Expose show-line-count in the ConfigInterface

mludwig added a comment. In D26321#585381 , @cullmann wrote: > I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document. > Y

D24932: Add button to open the folder in filelight to view more details

ltoscano added a comment. As a reference for the future: this change broke the two weeks string freeze - which we haven't enforced so strongly in the past months, but please keep an eye on it. Expecially this time of the year with many countries on vacation. REPOSITORY R241 KIO REVISION D

D26321: Expose show-line-count in the ConfigInterface

mludwig updated this revision to Diff 72484. mludwig added a comment. Add "line-count" to KTextEditor::ViewPrivate::configKeys() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26321?vs=72445&id=72484 REVISION DETAIL https://phabricator.kde.org/D26321

D26306: Define more documentation search paths (also custom)

lbeltrame added a comment. +1, would allow us to get rid of some downstream patches. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner, kde-frameworks-devel, kd

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

ltoscano added a comment. In D26317#585315 , @aacid wrote: > Isn't it better to just use `Qt::endl` ? > > I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')` > > But if we prefer to change to use \n it should be mer

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 259 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/259/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 30 Dec 2019 19:19:23 + Build duration: 17 hr and counting

D26321: Expose show-line-count in the ConfigInterface

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.

D24431: Restore cursor thumbnailer

broulik requested review of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, C

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

aacid added a comment. Ah, it works fine in 5.14. I was going to say we must report to Qt immediately that they broke source compatibility and that was unacceptable but then i realized that the old non namespaced version works just fine, it's just deprecated. I'm going to go back to

D24431: Restore cursor thumbnailer

broulik updated this revision to Diff 72476. broulik edited the summary of this revision. broulik added a comment. This revision is now accepted and ready to land. - Find XCursor specifically REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24431?vs=67357&

D26313: Add application/vnd.apple.pkpass icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:eca72cb0689b: Add application/vnd.apple.pkpass icon (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26313?vs=72464&id=72477 REVISION DET

D26319: Port endl to \n (QFile flushs data when deleted)

mlaurent updated this revision to Diff 72475. mlaurent added a comment. Use QLatin1Char REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26319?vs=72442&id=72475 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kd

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent added a comment. "/compile/kde5/framework/frameworks/kdoctools/src/docbookl10nhelper.cpp: Dans la fonction « int writeLangFile(const QString&, const QString&, const LangListType&) »: /compile/kde5/framework/frameworks/kdoctools/src/docbookl10nhelper.cpp:62:57: erreur: « endl » n'e

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent added a comment. "No, it's not. It's namespaced in Qt 5.15 means it should be ifdef guarded which makes things to suck." yep it's for that I switched to "\n" I don't want to add #ifdef if it's not necessary. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

aacid added a comment. But it is already namespaced in older Qt too, so no ifdef needed REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB

D26326: Add application/x-audacity-project icon

broulik edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

broulik edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415722 TEST PLAN - Takes the audacity app icon, simplifies it slightly and monoch

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

anthonyfieroni added a comment. In D26317#585315 , @aacid wrote: > Isn't it better to just use `Qt::endl` ? No, it's not. It's namespaced in Qt 5.15 means it should be ifdef guarded which makes things to suck. REPOSITORY R238 KDocTools

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

aacid added a comment. Isn't it better to just use `Qt::endl` ? I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')` But if we prefer to change to use \n it should be merged into the existing strings, doesn't make much sense to do `outStream << "" << QLatin1

D26313: Add application/vnd.apple.pkpass icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26313 To: broulik, #vdg, vkrause, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

broulik updated this revision to Diff 72464. broulik added a comment. - Fix misaligned object - Optimize SVGs (also remove unused stylesheet from monochrome icons) - Copy to breeze-dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26313?vs=72432&

D17816: Support for xattrs on kio copy/move

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:529 > > +QHash getSampleAttrs() > +{ prepend `static` > jobtest.cpp:626 > + > +QString getXattrCommand() > +{ prepend `static` > jobtest.cpp:

D26313: Add application/vnd.apple.pkpass icon

vkrause added a comment. Awesome, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26313 To: broulik, #vdg, vkrause, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26177: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:646 > I do, and they were, that was always a big selling point for Qt ;) > > (I started contributing to KDE at the time of Qt 1.1, in 1998) :D REPOSITORY R237 KConfig BRANCH l-qregularexpression (bran

D26177: Port QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in kconfig_compiler.cpp:646 > Yep; (and who knows if Qt docs were as expansive/exhaustive as they're now > :)). > > And then fileNameOnly() became unn

D26148: Add truncation support to FileJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filejob.h:109 > + * > + * @param length the desired length to truncate to > + */ Missing @since 5.66 > filejob.h:180 > + */ > +void trunc

D26321: Expose show-line-count in the ConfigInterface

mludwig created this revision. mludwig added a reviewer: KTextEditor. mludwig added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mludwig requested review of this revision. REVISION SUMMARY The show-line-count prope