D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:262 > Does this break API docs generation? Suddenly the /** ... */ comment is > separated from the enum. The comment didn't affect the doc generation. But the placement was awkward so I changed it. REPOSITORY R241

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 71754. chinmoyr added a comment. updated kf5 version. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=71041&id=71754 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES autotest

D12172: Android: Also install plugins, otherwise they are just not available

apol abandoned this revision. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12172 To: apol, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, vkrause, LeGast00n, GB_2, benc

D25865: kfilemetadata EBN transport protocol cleanup

jhayes updated this revision to Diff 71751. jhayes added a comment. - Reversed URI changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25865?vs=71236&id=71751 BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabric

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71744. apol added a comment. Just never draw over 20 ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71742&id=71744 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 A

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71742. apol added a comment. don't show too many ticks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71741&id=71742 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFEC

D26055: Enable wheel events on Slider {}

apol updated this revision to Diff 71741. apol added a comment. Include test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71685&id=71741 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 AFFECTED FILES s

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This also removes the last uses of KIconThemes from here. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D26057: Deprecate the top-level IconSize() function

This revision was automatically updated to reflect the committed changes. Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26057?vs=71689&id=71737 REVISIO

D26071: Avoid unwanted horizontal scrolling

sars created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sars requested review of this revision. REVISION SUMMARY It looks like the horizontal scrolling is a bit too sensitive while also scrolling vertically. This patch

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:1128 > Please check `m_containment->immutability()` so we don't add this if widgets > are locked Are you sure? It is already automatically disabled when immutability is `UserImmutable` and completely hidden

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

broulik created this revision. broulik added reviewers: Frameworks, VDG, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This includes: - Rendering hidden items desaturated when in "sho

D24522: Add presentwindows icon (old "task view" from windows)

GB_2 added a comment. In D24522#544338 , @Zren wrote: > > `preferences-system-windows-effect-presentwindows` > > That would look like the `homerun` icon, which looks like the "windows" logo. > > F7557693: 2019-10-09___13-01-07.png

D26066: [KProcessInfo] Add parent PID

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We basically get this information for free anyway. TEST PLAN - C

D23352: make button icons follow a reasonable size and layout

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D26061: QHash::insertMulti is deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R304:ab43b736f326: QHash::insertMulti is deprecated (authored by mlaurent). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26061?vs=71698&id=71712 REVISION DETAIL h

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

crossi added inline comments. INLINE COMMENTS > meven wrote in managedconfigmodule.h:205 > Mention importance of emitting configChanged signal to automatically call > settingsChanged as alternative to calling settingsChanged. It is not an alternative, configChanged is a KCoreConfigSkeleton's si

D26061: QHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH use_qmultihash_direcly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26061 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26057: Deprecate the top-level IconSize() function

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:1128 > +desktopMenu->addSeparator(); > +if (m_containment->containmentType() == > Plasma::Types::DesktopContainment) { > + > desktopMenu->addAction(m_containment->corona()->actions()->action(QStringLiteral(

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Not a fan of this becoming public API REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport, davidedmu