D25599: Fix plugin-metadata translations on windows

sars added reviewers: aacid, vonreth. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, cullmann, kfunk

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I just found that Totem has a "Show Containing Folder" feature. If I use it, it shows me that the video file is in fact being opened from the FUSE mount path! So that's good. But it still insists on downloading the whole thing locally before it starts to play it. Whe

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#569929 , @feverfew wrote: > This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've also blogged about: > https://bugs.kde.org/show_bug.cgi?id=330192 > https://pointiestst

D25533: Deprecate KFileWidget::toolBar

dfaure added a comment. I started a kdesrc-build with the method removed, and found that KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if in case EXCLUDE_DEPRECATED_BEFORE_AND_AT. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25533 To: ni

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

On samedi 30 novembre 2019 19:43:16 CET Ben Cooksley wrote: > For Windows, CMake will need to find Perl itself and invoke that with the > script in question as a parameter (which is a solution that will work on > all three platforms) This seems to be already done, in "if (WIN32)" specifically. So

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#569926 , @ngraham wrote: > In D23384#569645 , @fvogt wrote: > > > **Issue #1:** > > > > That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,h

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#569645 , @fvogt wrote: > **Issue #1:** > > That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`: > https://code.videolan.org/videolan/vlc/blob/master/share/

D17595: Upstream Dolphin's file rename dialog

lydia added a comment. For posterity's sake: I confirm that we have confirmation to the board list from (hope I didn't overlook anyone): - Emmanuel Pescosta - Roman Inflianskas - Alexander Richardson - David Faure - Matthias Fuchs - Artur Puzio - Kevin Funk - Aldo Matel

D25638: autotests: Find perl executable on all platforms

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:93 > - set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl) > - if(WIN32) > -set(_runner ${PERL_EXECUTABLE} ${_runner}) maybe it would make sense to check for BSD instead? I don't know much about BSD, but I'd expect the

D25620: Register ActionType enum with metaobject system

jbbgameich added inline comments. INLINE COMMENTS > apol wrote in personactionsmodel_p.h:24 > Why do we need the include? The enum ist defined in that header. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00

D25638: autotests: Find perl executable on all platforms

aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. aspotashev added a subscriber: Frameworks. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D25638 To: aspotashev, #frameworks Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampalouk

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

On Sun, Dec 1, 2019 at 7:34 AM Alexander Potashev wrote: > Hi Ben, > Hi Alexander, > > KCalendarCore's unit tests are failing all the time on FreeBSD CI. Could > you please check if perl interpreter needs to be installed? > Perl is definitely installed, however FreeBSD is a bit different to L

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

Hi Ben, KCalendarCore's unit tests are failing all the time on FreeBSD CI. Could you please check if perl interpreter needs to be installed? ср, 20 нояб. 2019 г. в 20:58, CI System : > *BUILD UNSTABLE* > Build URL > https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir added a comment. Thank you. REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D25631 To: ahmadsamir, #ark, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R36:aee422b0b2c4: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel (authored by ahmadsamir). REPOSITORY R36 Ark CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25631?vs=70624&id=706

D25511: Drop unused broken KGesture support

davidedmundson added a comment. kdelibs4support usage has now been destroyed REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R36 Ark BRANCH l-qsortproxy (branched from master) REVISION DETAIL https://phabricator.kde.org/D25631 To: ahmadsamir, #ark, elvisangelaccio, apol Cc: apol, kde-framework

D25629: Port away from KTextWidgets

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R263 KXmlGui BRANCH tw REVISION DETAIL https://phabricator.kde.org/D25629 To: nicolasfella, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25620: Register ActionType enum with metaobject system

apol added a comment. the Q_ENUM looks good. INLINE COMMENTS > personactionsmodel_p.h:24 > > +#include "widgets/actions.h" > + Why do we need the include? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast

D25632: Fix module imports with Python3

cordlandwehr created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY The broken module import was covered by the missleading warning "WARNING Missi

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir created this revision. ahmadsamir added reviewers: Ark, elvisangelaccio. Herald added a project: Ark. ahmadsamir requested review of this revision. REVISION SUMMARY KRecursiveFilterProxyModel was only needed to have recursive filtering, which became available upstream since Qt 5.10.

D25630: Port to json metadata

akulichalexandr added a comment. Hi! Thank you for taking this up. Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem. https://phabricator.kde.org/R871:498cd08a1956

D25630: Port to json metadata

ltoscano added inline comments. INLINE COMMENTS > ktp_integration_module.json:3 > +"KPlugin": { > +"Description": "Module providing deeper integration of Instant > Messaging with KDE.", > +"Name": "Telepathy Integration Module", I can't comment on the rest of the reivew, but

D25630: Port to json metadata

nicolasfella added a task: T11919: Port KDED modules from .desktop files to JSON metadata. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks

D25630: Port to json metadata

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. nicolasfella requested review of this revision. REPOSITORY R150 KDE Telepathy KDE Daemon Module BRANCH json REVISION DETAIL https://phabricator.kde.org/D25630 AFFECTED FILES CMakeLists.txt ktp_integration_m

D25630: Port to json metadata

nicolasfella added a reviewer: KDE Telepathy. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks, #kde_telepathy

D25533: Deprecate KFileWidget::toolBar

nicolasfella updated this revision to Diff 70622. nicolasfella added a comment. - Adjust version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25533?vs=70317&id=70622 BRANCH ktoolbar REVISION DETAIL https://phabricator.kde.org/D25533 AFFECTED FILES sr

D25629: Port away from KTextWidgets

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is only used for the bugreport dialog for non-KDE apps. By repla

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/76/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Nov 2019 14:09:04 + Build duration: 3 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/42/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 30 Nov 2019 14:09:04 + Build duration: 3 min 3 sec and counting JUnit Tests Name: p

D25626: Fix EcmGenerateExportHeader tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R240:bfdcec82d926: Fix EcmGenerateExportHeader tests on Windows (authored by davidre). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25626?vs=70610&id=70615

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

kossebau added a comment. In D16770#569723 , @dfaure wrote: > Hmmpf, indeed. I forgot about the objection I had here :) > > Are you interested in testing my suggested fix, since you seemed to have a testcase for this code? Been some t

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

dfaure added a comment. Hmmpf, indeed. I forgot about the objection I had here :) Are you interested in testing my suggested fix, since you seemed to have a testcase for this code? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc: aacid

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre added a comment. In D25626#569714 , @kossebau wrote: > Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the da

D25626: Fix EcmGenerateExportHeader tests on Windows

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark

D25626: Fix EcmGenerateExportHeader tests on Windows

davidre retitled this revision from "Fix EcmGenerateExportHeader tests on windows" to "Fix EcmGenerateExportHeader tests on Windows". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel,

D25626: Fix EcmGenerateExportHeader tests on windows

davidre added reviewers: kossebau, Windows, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25626 To: davidre, kossebau, #windows, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on windows

davidre created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY -we errors on warning . C4996 warns on deprecated declarations. TEST PLAN Tests

kde-frameworks-devel@kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R236:e50d2ffeedd5: Remove unused signal we can use directly "signal(const QUrl&) (authored by mlaurent). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25561?vs=7

kde-frameworks-devel@kde.org

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH remove_overload_signal (branched from master) REVISION DETAIL https://phabricator.kde.org/D25561 To: mlaurent, dfaure, kossebau Cc: cfeck, kde-frameworks-devel, LeGast00n,

kde-frameworks-devel@kde.org

mlaurent added a comment. ping ? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25561 To: mlaurent, dfaure, kossebau Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. **Issue #1:** That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`: https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124 **Issue #2:** The only explanation I have for that is that tot

D25530: Sonnet: Add locales that are missing in QLocale

waqar added a comment. > I honestly would prefer if you abandon this, but maybe let it open for a few days in case someone else disagrees. Alright. > Please shout if you need help with improving QLocale I sure do! :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricat

D25530: Sonnet: Add locales that are missing in QLocale

aacid added a comment. I honestly would prefer if you abandon this, but maybe let it open for a few days in case someone else disagrees. Thanks for your understanding :) Please shout if you need help with improving QLocale REPOSITORY R246 Sonnet REVISION DETAIL https://phabrica

D25622: partial solution to accept accentuated characters on windows

mgallien added a comment. I forgot to maybe give some explanations. The documentation of the constructor of TagLib::FileStream takes a char* and "file should be a be a C-string in the local file system encoding". This means that the proper fix would possibly involve doing changes in