KDE CI: Frameworks » kglobalaccel » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Fixed!

2019-11-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 05:16:13 + Build duration: 1 min 54 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

2019-11-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 05:16:12 + Build duration: 1 min 54 sec and counting JUnit Tests Name: project

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Failing!

2019-11-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 05:16:12 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 330 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/330/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 04:25:05 + Build duration: 24 min and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 214 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/214/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 23 Nov 2019 04:25:06 + Build duration: 23 min and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 199 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/199/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 04:25:06 + Build duration: 14 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 21:47:00 + Build duration: 4 min 56 sec and counting JUnit Tests Name

D25315: KDirModel: implement showing "/" as a root node, optionally

2019-11-22 Thread David Faure
dfaure updated this revision to Diff 70183. dfaure added a comment. Add ShowRoot flag, excellent idea! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25315?vs=69778&id=70183 BRANCH 2019_11_kdirmodel_root REVISION DETAIL https://phabricator.kde.org/D25315

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 213 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/213/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 19:31:03 + Build duration: 11 min and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 329 - Still unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/329/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 19:31:03 + Build duration: 8 min 28 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 198 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/198/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 19:31:03 + Build duration: 8 min 25 sec and counting JUnit Tests Name: projectro

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread David Faure
dfaure added a comment. Thanks for the notification. Fixed in https://commits.kde.org/kio/7b28a8326717c1afea05ff97e528fe014afd16d2 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25446 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, dfaure, kde-frameworks-devel, Le

D25315: KDirModel: implement showing "/" as a root node, optionally

2019-11-22 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kdirmodel.h:78 > + * Otherwise, this is equivalent to dirLister()->openUrl(url, flags) > + * @param url the URL of the directory whose contents should be > listed. The item for this directory will NOT be shown, the model starts at > its c

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Ben Cooksley
bcooksley added a comment. This change is incompatible with Qt 5.12 - see https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/326/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25446 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, d

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 66 - Fixed!

2019-11-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/66/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 18:39:32 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/61/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 18:39:32 + Build duration: 1 min 47 sec and counting JUnit Tests Name: pr

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R244:8f1952ecb156: Add a descriptive warning when inotify_add_watch returned ENOSPC (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25460?vs=7017

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car
meven updated this revision to Diff 70171. meven added a comment. Improve messange : ENOSPC for inotify_add_watch only when inotify_add_watch was reached REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25460?vs=70150&id=70171 BRANCH arcpatch-D25460

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25460 To: meven, #frameworks, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25460 To: meven, #frameworks, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 212 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/212/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 16:55:36 + Build duration: 23 min and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 197 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/197/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 16:55:35 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 328 - Still Failing!

2019-11-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/328/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 16:55:35 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT [...truncated 1275

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:81167ec94f8d: [DropJob] Minor grammar fix in API docs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25465?vs=70167&id=70169 REVISION DETAIL

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R241 KIO BRANCH l-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org/D25465 To: ahmadsamir, #frameworks, dfaure, apol, dhaumann Cc: dhau

D25465: [DropJob] Minor grammar fix in API docs

2019-11-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R241 KIO BRANCH l-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org/D25465 AFFECTED

D25461: [KCM GridDelegate] Use non-attached ToolTip

2019-11-22 Thread Nathaniel Graham
ngraham added a comment. This works for you? I still see that the tooltip for KCM grid delegates disappears almost immediately with this patch. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25461 To: broulik, #plasma, mart Cc: ngraham, kde-frameworks-devel, L

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 14:26:57 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 81 - Fixed!

2019-11-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/81/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 14:26:57 + Build duration: 9 min 39 sec and counting BUILD ARTIFACTS abi-compatibil

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes
jhayes added a comment. arc amend is not allowing me to correct the typo, it just shows it and then back to command line. REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-f

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread John Hayes
jhayes added a comment. No I don't have a commit account yet John Hayes REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 196 - Still unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/196/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 11:40:23 + Build duration: 1 hr 22 min and counting JUnit Tests Name: projectroo

D23579: port ftp slave to new error reporting system

2019-11-22 Thread David Faure
dfaure added a comment. @sitter The unittest just failed on CI, the test can't connect to the local FTP server, can you look into it? https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/211/testReport/junit/projectroot/autotests/kiocore_ftptest/ REPOSITORY R241 KIO

D25461: [KCM GridDelegate] Use non-attached ToolTip

2019-11-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Then it can just follow the style's delay and timeout. TEST PLAN - Hovered gri

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-22 Thread Méven Car
meven added a comment. In D25117#565877 , @dfaure wrote: > Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately > (genericsig_handler in slavebase.cpp). I didn't realize there was

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread Méven Car
meven added a comment. Please run `arc amend` to fix the typo in the commit message before landing. REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: meven, apol, kde-frameworks-devel, LeGast0

D25448: EBN cleanup of autests transfer protocol

2019-11-22 Thread Méven Car
meven retitled this revision from "EBN cleanup of autests transfer protocal" to "EBN cleanup of autests transfer protocol". REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: apol, kde-frameworks-

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 211 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/211/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 11:40:21 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 327 - Still Failing!

2019-11-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/327/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 11:40:21 + Build duration: 5 min 29 sec and counting CONSOLE OUTPUT [...truncated 799 l

D25438: Ftp ioslave: Fix ProxyUrls parameter passing

2019-11-22 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:04edc7738cc3: Ftp ioslave: Fix ProxyUrls parameter passing (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25438?vs=70104&id=70152 REVISION DETAIL

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

2019-11-22 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 387663 REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R252:06bd561dceb1: Set application name and version on the knshandler tool (authored by leinir). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25442?vs=70

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Dan Leinir Turthra Jensen
leinir added a comment. Thanks :) In D25442#566050 , @apol wrote: > Is the store having a big impact from this handler? We think it might very possibly - specifically, look and feel is under suspicion, but... suspicions are just that

D25442: Set application name and version on the knshandler tool

2019-11-22 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Is the store having a big impact from this handler? REPOSITORY R252 Framework Integration BRANCH set-knshandler-name-and-version (branched from master) REVISION DETAIL https://phabricato

D25448: EBN cleanup of autests transfer protocal

2019-11-22 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Do you have a commit account? REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: apol, kde-fr

D25429: JavaScript/TypeScript React: rename syntax definitions

2019-11-22 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:503dab974d34: JavaScript/TypeScript React: rename syntax definitions (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70143. nicolasfella added a comment. - Use stack REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70138&id=70143 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES src/core/chmo

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-11-22 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. In D25010#565502 , @meven wrote: > Funny thing is that statx includes always the name, down to syscall we can save at most STATX_SIZ

D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Méven Car
meven added inline comments. INLINE COMMENTS > ltoscano wrote in Messages.sh:2 > This does not work as it is, because it does not look into the > subdirectories. Hint for testing: > https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html > > I'm going to fix it (replace *

Re: kconfig-elektra

2019-11-22 Thread David Faure
On samedi 16 novembre 2019 12:22:08 CET k...@markus-raab.org wrote: > >> 2. If Elektra finds a merge conflict between the KConfig objects and the > >> > >>configuration files on the disc, should we then do a 3-way merge > >>which prefers "ours" or should we ask the user with a KDialog how

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 195 - Failure!

2019-11-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/195/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 09:10:10 + Build duration: 13 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 210 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/210/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 09:10:11 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 326 - Failure!

2019-11-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/326/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 09:10:11 + Build duration: 2 min 1 sec and counting CONSOLE OUTPUT [...truncated 1273 l

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:521453d71075: [kcoredirlister] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25446?vs=70137&id=70142 REVISION D

D25454: Prevent a crash when deleting a device Interface

2019-11-22 Thread Méven Car
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Double free of DeviceInterfacePrivate::m_backendObject BUG: 414200 FIXED-IN: 5.65

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kdili REVISION DETAIL https://phabricator.kde.org/D25446 To: nicolasfella, #frameworks, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread David Faure
dfaure added a comment. Indeed there's no reserve for std::list. And std::queue is FIFO, not LIFO. std::stack would be a more appropriate container here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks Cc: dfaure, bruns, fabi

D25389: Verify modes of the session config file

2019-11-22 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:911b7fa44f2a: Verify modes of the session config file (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25389?vs=69969&i

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
nicolasfella marked 3 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > bruns wrote in chmodjob.cpp:115 > For efficiency, probably do a > `m_infos.reserve(m_infos.capacity() + m_lstItems.size());` > here. Does that make sense with a linked list? REPOSITORY R241 KI

D25443: [chmodjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70138. nicolasfella added a comment. - Move REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70114&id=70138 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES src/core/chmodjob.

D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > Messages.sh:2 > +#! /usr/bin/env bash > +$XGETTEXT *.cpp -o $podir/kio5_network.pot This does not work as it is, because it does not look into the subdirectories. Hint for testing: https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 325 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/325/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Nov 2019 08:30:40 + Build duration: 9 min 30 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0

D25446: [kcoredirlister] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70137. nicolasfella added a comment. - Remove reserver REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25446?vs=70117&id=70137 BRANCH kdili REVISION DETAIL https://phabricator.kde.org/D25446 AFFECTED FILES src/

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 209 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/209/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 08:30:40 + Build duration: 8 min 26 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.65.0

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 194 - Still Unstable!

2019-11-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/194/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 08:30:40 + Build duration: 7 min 3 sec and counting JUnit Tests Name: projectroo

D25429: JavaScript/TypeScript React: rename syntax definitions

2019-11-22 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok for me :=) REPOSITORY R216 Syntax Highlighting BRANCH rename-def-jsx REVISION DETAIL https://phabricator.kde.org/D25429 To: nibags, #framework_syntax_highlighting, dhaumann,

D25445: [copyjob] Port away from QLinkedList

2019-11-22 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ddedd87456c9: [copyjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25445?vs=70116&id=70136 REVISION DETAIL