D25267: Improve XCF support

aacid added a comment. this very much needs test files :) REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25267 To: sandsmark, aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69649. tcanabrava marked 2 inline comments as done. tcanabrava added a comment. - Add KConfigXT - Remove wrong icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69400&id=69649 BRANCH

D25276: reStructuredText: Fix inline literals highlighting preceding characters

adrianchavesfernandez created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adrianchavesfernandez requested review of this revision. TEST PLAN Covered by automated tests, and tested locally (new sytanx file with stable Kate

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 12 Nov 2019 17:38:28 + Build duration: 1 min 43 sec and counting JUnit Tests Name: projectr

D20508: [udisks2] fix media change detection for external optical drives

This revision was automatically updated to reflect the committed changes. Closed by commit R245:4aa39aed1bd6: [udisks2] fix media change detection for external optical drives (authored by rokmandeljc, committed by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.

Re: KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

I'll go ahead and work on the system-level file to test changes, but please do let me know if you can think an way that I can avoid that in the future. On 2019-11-01 11:34, Adrian Chaves wrote: What does `ldd build/bin/syntax/testhighlighter_test` tell you? [adrian@pondal build]$ ldd bin/te

D20508: [udisks2] fix media change detection for external optical drives

ngraham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20508 To: rokmandeljc, bruns, broulik, dfaure, #frameworks, ngraham Cc: ngraham, bugseforuns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25223: Avoid side effects during menu initialization

nicolasfella added a comment. My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, br

D25223: Avoid side effects during menu initialization

kmaterka added a comment. In D25223#561570 , @davidedmundson wrote: > I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > > > ?https://codereview.qt-proj

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 157 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/157/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 12 Nov 2019 15:24:39 + Build duration: 20 min and counting

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 181 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/181/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 12 Nov 2019 15:17:31 + Build duration: 15 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 156 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/156/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 12 Nov 2019 14:24:24 + Build duration: 59 min and counting CONSOLE OUTPUT [...truncat

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 180 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/180/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 12 Nov 2019 14:24:24 + Build duration: 52 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 12 Nov 2019 14:10:34 + Build duration: 1 hr 1 min and counting JUnit Tests Name: pr

D25223: Avoid side effects during menu initialization

davidedmundson added a comment. I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > ?https://codereview.qt-project.org/c/qt/qtbase/+/168458 REPOSITORY R135 Integration for Qt applications in Plasma

D25249: KDirModel: port to qCDebug, with its own category

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25249 To: dfaure, mlaurent, sandsmark, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

nicolasfella added subscribers: davidedmundson, nicolasfella. nicolasfella added a comment. In D25223#561561 , @kmaterka wrote: > Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be bett

D25223: Avoid side effects during menu initialization

kmaterka marked an inline comment as done. kmaterka added a comment. Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be better to talk to DBus directly? From the other side, this may be a duplication of work... Was the idea discusse

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 12 Nov 2019 10:35:14 + Build duration: 3 hr 35 min and counting JUnit Tests Name: p

D25223: Avoid side effects during menu initialization

kmaterka updated this revision to Diff 69634. kmaterka marked an inline comment as done. kmaterka added a comment. QVariant related changes suggested in comments REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25223?vs=69548

D25223: Avoid side effects during menu initialization

kmaterka marked an inline comment as done. kmaterka added a comment. I will send fixes in 5 minutes INLINE COMMENTS > broulik wrote in kdeplatformsystemtrayicon.cpp:33 > Is this explicit initialization neccessary? Not mandatory, works without this. I just wanted to be... explicit. Documenta

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25272 To: leinir, #plasma, #knewstuff, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

leinir edited the test plan for this revision. leinir added reviewers: Plasma, KNewStuff, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25272 To: leinir, #plasma, #knewstuff, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This adds a new property which allows the user to ask the model to filter its contents by whether or not a comment has a

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven abandoned this revision. meven added a comment. Abandoned in favor of D24962 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate Cc: kde-frameworks-devel, jtamate, mar

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich closed this revision. jbbgameich added a comment. I think this was fixed in another way already. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma, davidedmundson Cc: broulik, davidedmundson, svuorela, ngraham

D22599: Make first and last name available separately

jbbgameich abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22599 To: jbbgameich, #plasma:_mobile, apol Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25270: Correctly set i18n arguments in one pass

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY i18n("asdf %1") will expand and fail as it has no arguments, leading to a warning. BUG: 414060 REP

D25211: Add KPropertySkeletonItem

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25211 To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25211: Add KPropertySkeletonItem

ervin updated this revision to Diff 69628. ervin added a comment. Avoid potential ownership problem on the propertyName REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69442&id=69628 REVISION DETAIL https://phabricator.kde.org/D25211 AFFECTED FI

D25223: Avoid side effects during menu initialization

broulik added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:27 > #include > +#include > Already included in the header file > kdeplatformsystemtrayicon.cpp:33 > : QPlatformMenu() > -, m_enabled(true) > -, m_visible(true) > -, m_separatorsCollapsible(true