D24378: WordDetect rule: detect delimiters at the inner edge of the string

nibags updated this revision to Diff 67238. nibags added a comment. - Add comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24378?vs=67237&id=67238 BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 AFFECTED FIL

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags added a comment. i did it in: D24378 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In WordDe

D24326: Add syntax highlighting for RenPy (.rpy)

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24326 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kd

D24354: Mustache/Handlebars: fix delimiters in HTML tags

dhaumann added a comment. Thanks a lot! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demski

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags added a comment. I think it makes sense to change this in WorDetect: verify delimiter characters on the left and right edge of the string, either inside or outside the string. I will make another diff with this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabrica

D24326: Add syntax highlighting for RenPy (.rpy)

jpoelen updated this revision to Diff 67235. jpoelen added a comment. - Renpy: folding sensitive to indentation REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67094&id=67235 BRANCH renpy (branched from master) REVISION DETAIL http

D24363: Fix several build system errors

alexeymin marked an inline comment as done. alexeymin added a comment. Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make IconThe

D24363: Fix several build system errors

alexeymin updated this revision to Diff 67233. alexeymin added a comment. - Bring back missing KF5_DEP_VERSION REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67207&id=67233 BRANCH alexeymin/fix-cmake-errors REVISION D

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#540033 , @dfaure wrote: > I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ Not sure what you exactly mean, can you please specify confirmation for what? And what this reco

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67222. kossebau edited the test plan for this revision. kossebau added a comment. - update to latest version of ecm_generate_export_header with deprecation text support REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67221. kossebau added a comment. - update to latest version of ecm_generate_export_header with deprecation text support REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23800?vs=65686&id=67221 BRANCH useECMGenera

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67220. kossebau added a comment. - extend *_VERSION_DEPRECATED to expect third argument "text" first experimental consumption time support for "text" output with GCC compiler - make *_NO_DEPRECATED a proper shortcut for DISABLE_BEFORE_AND_AT=CURRENT -

D7446: [Places panel] Revamp the Recently Saved section

pino added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:113 > case KFilePlacesModel::RecentlySavedType: > -m_groupName = i18nc("@item", "Recently Saved"); > +m_groupName = i18nc("@item", "Recent"); > break; this string needs a context, as "recent" basicall

D24372: Compile without deprecated foreach

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY src/core/* src/urifilters/* src/widgets/* TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH ahmad/foreach-urifil

D7446: [Places panel] Revamp the Recently Saved section

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask

D24363: Fix several build system errors

cgiboudeaux added a comment. Note: the metainfo file says this framework is tier 3. The subgroup value looks wrong INLINE COMMENTS > CMakeLists.txt:40-41 > +# IconThemes and ConfigWidgets are optional > +find_package(KF5IconThemes) > +find_package(KF5ConfigWidgets) > KF5_DEP_VERSION i

D24363: Fix several build system errors

alexeymin reopened this revision. alexeymin added a comment. Phabricator, you're drunk, it is not pushed to master REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-d

D24367: Some sanity verification

cfeck added inline comments. INLINE COMMENTS > pcx.cpp:312 > +qWarning() << "Failed to get scanline for" << y << "might be out > of bounds"; > +} > for (int x = 0; x < header.width(); ++x) { If `p` indeed could be zero, the next statements need to be in an `else` bl

D24363: Fix several build system errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem errors (authored by Aleksey Minnekhanov

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. Code is ready for review, tests pass @elvisangelaccio @dfaure Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks are only added when KDE_FULL_SESSION is set. D23557 will get merged after this one.

D24010: Fix generating properties that start with an uppercase letter

apol updated this revision to Diff 67204. apol added a comment. Update test, it seems like tests aren't comparing with .ref now :( REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66271&id=67204 BRANCH master REVISION DETAIL https://phabricator

D7446: [Places panel] Revamp the Recently Saved section

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, s

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67203. meven added a comment. Small changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65981&id=67203 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfile

D24010: Fix generating properties that start with an uppercase letter

ngraham added a comment. +1, Works for me REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24010 To: apol, #frameworks Cc: ngraham, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24010: Fix generating properties that start with an uppercase letter

ngraham added a dependent revision: D5961: Adoption of KUserFeedback for Discover. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24010 To: apol, #frameworks Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24367: Some sanity verification

sandsmark created this revision. sandsmark added reviewers: aacid, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision. REVISION SUMMARY Since QImage does sanity checking for overflows and stuff wrt. dimensions a

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. @meven do you think you could address the final comments and land this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, sve

D24363: Fix several build system errors

alexeymin retitled this revision from "Fix several builsystem errors" to "Fix several build system errors". REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel, LeGa

D24363: Fix several builsystem errors

alexeymin edited the summary of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragree

D24363: Fix several builsystem errors

alexeymin added reviewers: mart, Plasma, dfaure. alexeymin added a subscriber: kde-frameworks-devel. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-devel, LeGast00n, T

D24354: Mustache/Handlebars: fix delimiters in HTML tags

dhaumann added a comment. Hm, would it make sense to change this? I.e. if the word itself has a word boundary, also use this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags added a comment. Indeed, WordDetect checks only the boundaries. What happens is that when using WordDetect with `". It's correct to use RegExpr with `https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-dev

D24354: Mustache/Handlebars: fix delimiters in HTML tags

dhaumann added a comment. Would it also be an option to fix WordDetect? I always thought WordDetect ignores the string contents, it should only check on the boundaries left and right REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #fra

D24357: KateModeMenuList: force the vertical position above the button

nibags created this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Always display the menu above the trigger butto

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

meven added a comment. Now we can use it : > dolphin D19989 > plasma-vault > libksysguard (KLsofWidget) > dataengines/devicenotifications/ksolidnotify REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hall

D24308: [DataProtocol] compile without implicit coversion from ascii

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/compile-without-ascii-cast (branched from master) REVISION DETAIL https://phabricator.kde.org/D24308 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

dfaure closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

dfaure added a comment. I suggest do look at kio_file (kio/src/ioslaves/file), the above code was inspired by kio_file, and then ported differently to Windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22727 To: brute4s99, vonreth, dfaure, pino Cc: sredman,