D24245: Add support for passing Unix file descriptors

aacid added inline comments. INLINE COMMENTS > kauthunixfiledescriptor.h:33 > + > +class KAUTH_EXPORT UnixFileDescriptor > +{ Does this class really need to be exported and its header installed? Seems like this is implementation detail? Who would use this header? REPOSITORY R283 KAuth REVIS

D24262: Modernize code: use range-based loops & algorithms in more places

dhaumann added inline comments. INLINE COMMENTS > plugin.cpp:196 > > -QObjectList::ConstIterator it = plugins.begin(); > -for (; it != plugins.end(); ++it) { > -Plugin *plugin = qobject_cast(*it); > -if (plugin && plugin->d->m_library == library) { > -return

D24261: Modernize code: use range-based for loop in more places

dhaumann added inline comments. INLINE COMMENTS > kedittoolbar.cpp:1566 > { > -XmlDataList::Iterator xit = m_xmlFiles.begin(); > -for (; xit != m_xmlFiles.end(); ++xit) { > -if ((*xit).type() == XmlData::Merged) { > +for (auto& xmlFile : m_xmlFiles) { > +if (xmlFile.t

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Thanks for your reply, Christian :) In D23789#538876 , @chehrlic wrote: > In D23789#536338 , @kossebau wrote: > > > Actual questions I have: > > > > - why is QT_DEP

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

dfaure updated this revision to Diff 66975. dfaure added a comment. perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.* REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24252?vs=66932&id=66975 BRANCH 2019_09_okbutton_configurable REVISION DETAIL ht

D24245: Add support for passing Unix file descriptors

volkov edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

volkov updated this revision to Diff 66968. volkov added a comment. moved dbus stuff to DBusHelperProxy REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24245?vs=66946&id=66968 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24245 AFFECTED FIL

D24245: Add support for passing Unix file descriptors

volkov added inline comments. INLINE COMMENTS > aacid wrote in HelperProxy.cpp:25 > i don't think we should have dbus stuff in HelperProxy, dbus stuff should be > in DBusHelperProxy, no? yes, thanks REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvog

D24245: Add support for passing Unix file descriptors

volkov added a comment. yes, thanks REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

aacid added inline comments. INLINE COMMENTS > HelperProxy.cpp:25 > + > +#include > +#include i don't think we should have dbus stuff in HelperProxy, dbus stuff should be in DBusHelperProxy, no? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt,

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

chehrlic added a comment. In D23789#536338 , @kossebau wrote: > Actual questions I have: > > - why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, any plans to change that macro to something else? Just forgot it (and

D24263: edit mode action

ngraham added inline comments. INLINE COMMENTS > corona.cpp:406 > +} else { > +editAction->setText(i18n("Edit Widgets")); > +} This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would make the name better correspond with the text of the opposite

D24263: edit mode action

ngraham added a dependent revision: D24265: support global edit mode. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

mthw added a comment. > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this: > > > > if (plugin == "details" /* this is pseudocode */) { > q->insertPluginAt(plugin, 1); > } else { > q->insertPlugin(plu

D24253: Make 22px squiggle more like 16px squiggle

ndavis added a comment. In D24253#538662 , @trickyricky26 wrote: > Visually I think this is fine and a good improvement. > > I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just cur

D24239: make editMode a corona global property

ngraham added tasks: T10190: (Re)define modes when editing panels and widgets, T11094: Improve discoverability of widget configuration, T10402: The Desktop Toolbox. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg, ngraha

D23951: Improve desktop layout and panel editing UX

ngraham added tasks: T11094: Improve discoverability of widget configuration, T10402: The Desktop Toolbox. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D24263: edit mode action

ngraham added tasks: T10190: (Re)define modes when editing panels and widgets, T11094: Improve discoverability of widget configuration, T10402: The Desktop Toolbox. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma Cc: kde-frame

D24263: edit mode action

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY needed for the context menu entry TEST PLAN with the p-w- portion the action shows in the co

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT TEST PLAN Tests pass, KParts-based apps work as before. REPOSITORY

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

ngraham added a comment. +1 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24261: Modernize code: use range-based for loop in more places

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT TEST PLAN Test pass, KXMLGUI-based apps showed no regressions incl. e

D24259: WIP: Save file directly if possible when root privileges are required

volkov added a dependency: D24245: Add support for passing Unix file descriptors. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24259 To: volkov Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dh

D24245: Add support for passing Unix file descriptors

volkov added a dependent revision: D24259: WIP: Save file directly if possible when root privileges are required. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel, LeGast00n, GB_2

D24259: WIP: Save file directly if possible when root privileges are required

volkov created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. volkov requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24259 AFFECTED FILES src/b

D24245: Add support for passing Unix file descriptors

volkov updated this revision to Diff 66946. volkov added a comment. fix breaking API and ABI of KAuth::ActionReply REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24245?vs=66905&id=66946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24245 A

D23926: Move "Details" tab to second place in Properties dialog

GB_2 added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jgu

D24253: Make 22px squiggle more like 16px squiggle

trickyricky26 added a comment. Visually I think this is fine and a good improvement. I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just curious if there is any benefit to using one approach above the other. Also, judging by

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R304:140c0d0b7be8: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets) (authored by leinir). CHANGED PRIOR TO CO

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

cfeck added a comment. I think it needs to be named 'buttonOk' instead of 'buttonOK'. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH 2019_09_fix_qtimeline_warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D24254 To: dfaure, cfeck, ngraham, elvisangelaccio Cc: kde-frameworks-devel

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. Right, unless i hear otherwise, i'm going to push this 13:00 CEST (that is, in three hours). I realise this is short notice, but the patch has also been sitting here since before Akademy. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D2172