KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 09 Sep 2019 16:53:39 + Build duration: 2 days 13 hr and counting

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas updated this revision to Diff 65870. hallas added a comment. Use QStandardPaths::findExecutable to locate lsof REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23884?vs=65869&id=65870 BRANCH fix_unittest_if_lsof_is_not_installed REVISION DETAIL

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas added inline comments. INLINE COMMENTS > dhaumann wrote in klistopenfilesjobtest_unix.cpp:34 > Can't you simply use QStandardPaths::findExecutable()? > > https://doc.qt.io/qt-5/qstandardpaths.html#findExecutable Yes, this seems to do exactly what we need :) > ngraham wrote in klistopenf

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

dhaumann added inline comments. INLINE COMMENTS > klistopenfilesjobtest_unix.cpp:34 > + > +bool HasLsofInstalled() > +{ Can't you simply use QStandardPaths::findExecutable()? https://doc.qt.io/qt-5/qstandardpaths.html#findExecutable REPOSITORY R244 KCoreAddons REVISION DETAIL https://phab

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

ngraham added inline comments. INLINE COMMENTS > klistopenfilesjobtest_unix.cpp:37 > +QProcess lsofProcess; > +lsofProcess.start(QStringLiteral("lsof"), > QStringList(QStringLiteral("-v"))); > +lsofProcess.waitForFinished(); A prior career in build engineering tells me that this wil

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas created this revision. hallas added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY The KListOpenFilesJob unit test on Unix expected lsof to be installed, but the KDE buil

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Sep 2019 16:10:39 + Build duration: 1 hr 16 min and counting JUnit Tests Name: pro

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. I wouldn't offer both variants, but rather recommend always adding a hint. At worse that hint can be "See method documentation" or an empty string. I think we're just over-complicating things otherwise, for no actual gain, since providing a hint is good practice anywa

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir added a comment. In D23875#529442 , @dhaumann wrote: > Since this crash is in KCoreDirLister, I wonder whether we can find a unit test that reproduces this without the KFileWidget. I think the main issue here is kdirlister inse

D23879: Add Qt Designer icon symlink

GB_2 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

ndavis added a reviewer: ndavis. ndavis added a comment. We should probably redo or completely remove the current Qt icons since they're very Qt4 and look outdated. Unless the current Qt icons are updated, I don't think we should have this symlink. REPOSITORY R266 Breeze Icons REVISION DE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/30/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 11 Sep 2019 16:10:39 + Build duration: 7 min 55 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/80/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Sep 2019 15:30:04 + Build duration: 46 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 78 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 11 Sep 2019 16:10:39 + Build duration: 4 min 47 sec and counting BUILD ARTIFACTS abi-compat

D21760: Add KListOpenFilesJob

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY This symlink was missing, so the desktop file was using the default icon. TEST PLAN The Qt Desi

D23879: Add Qt Designer icon symlink

GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

hallas updated this revision to Diff 65856. hallas added a comment. Updated @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=65500&id=65856 BRANCH add_list_processes_with_open_files (branched from master) REVISION DETAIL https://phab

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:87 > I'm having trouble parsing the "only" in this sentence. > > `deprecated API only`... that seems redundant, it's only API that gets > deprecated :-) > > Maybe you mean "to disable only at build

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 65854. kossebau marked 3 inline comments as done. kossebau added a comment. - reword documentation based on dfaure's comments - bump since-version to 5.64.0, as currently targetted introduction version Hope is review can be finished at 5.63 tagging

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Sep 2019 13:36:00 + Build duration: 1 hr 15 min and counting JUnit Tests Name: proj

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

ngraham added a comment. If the on;y thing that `EmptyTrashJob::slotFinished()` does now is call `SimpleJob::slotFinished()`, do we even still need to override the base class's implementation of `slotFinished()`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23851 To

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure, chinmoyr Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Sep 2019 12:11:52 + Build duration: 1 hr 23 min and counting JUnit Tests Name: pro

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. @dfaure Thanks for first in-detail feedback, good to get a feeling this is not totally insane over-engineered stuff to other people'e eyes :) In D23789#528994 , @dfaure wrote: > Great work. Not really easy to grasp

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dhaumann added a reviewer: chinmoyr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure, chinmoyr Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dhaumann added a comment. A different patch was proposed with D21197 in May 2019. By the way, this will likely also fix: - https://bugs.kde.org/show_bug.cgi?id=411353: Gwenview crashed during file copy - https://bugs.kde.org/show_bug.cgi?id=411

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dhaumann edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dhaumann added a comment. Since this crash is in KCoreDirLister, I wonder whether we can find a unit test that reproduces this without the KFileWidget. But in any case - thanks for having a look into this, since it will fixes a crash in many applications. Bug https://bugs.kde.org/sh

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dhaumann edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When creating multiple nested new folders, one at a time, in the "save as" dialog, where folders are created and

D23861: Port away from Qt's foreach: loop directly over pimpl member

This revision was automatically updated to reflect the committed changes. Closed by commit R263:efc2e0c3dbe9: Port away from Qt's foreach: loop directly over pimpl member (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23861?vs=65814&id=

D23832: Backup on save: Support time and date string replacements

This revision was automatically updated to reflect the committed changes. dhaumann marked 3 inline comments as done. Closed by commit R39:a32b79d9394a: Backup on save: Support time and date string replacements (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https

D23832: Backup on save: Support time and date string replacements

dhaumann updated this revision to Diff 65843. dhaumann added a comment. - Avoid running the backup when no backup prefix/suffix was provided REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23832?vs=65754&id=65843 BRANCH bug REVISION DETAIL https://p

D23819: [KConfigWidgets] port away from deprecated API in Qt 5.14

dfaure closed this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D23819 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D23842 To: dfaure, cfeck, dhaumann, aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23827: Add manual tests for PC3

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4ecdbe9622cc: Add manual tests for PC3 (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23827?vs=65735&id=65836 REVI

D23832: Backup on save: Support time and date string replacements

dhaumann added inline comments. INLINE COMMENTS > cullmann wrote in katedocument.cpp:2594 > Why not, saves useless evals. No: that's exactly the point: I currently don't think it's possible, but both evals could result in empty strings. Can you do the integration? Author does not matter. REPO

D23828: Disable DBus pieces on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R307:82c681f7ff27: Disable DBus pieces on Android (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23828?vs=65736&id=65823 REVISION DETAIL h

D23828: Disable DBus pieces on Android

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH dbus REVISION DETAIL https://phabricator.kde.org/D23828 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23827: Add manual tests for PC3

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. cool! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23827 To: davidedmundson, #plasma, apol Cc: apol, kde-frameworks-devel, LeGas

D23819: [KConfigWidgets] port away from deprecated API in Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D23819 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23832: Backup on save: Support time and date string replacements

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:2594 > Shall we wrap all this with > > if (!(backupSuffix.isEmpty() && backupPrefix.isEmpty())) {...} Why not, saves useless evals. REPOSITORY R39 KTextEditor BRANCH bug REVISION DETAIL https://phabr