D10362: Change reveal password button logic

GB_2 requested review of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n, The-Fere

D10362: Change reveal password button logic

GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitell

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540&id=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILE

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework (Librar

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/25/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 06:00:12 + Build duration: 6 min 1 sec and counting CONSOLE OUTPUT

D22173: [kactivities] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R6:004b16aaf129: [kactivities] Use new activities icon (authored by GB_2). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22173?vs=60874&id=65539 REVISION DETAIL ht

D22172: [kio-extras] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R320:a4efa5e997df: [kio-extras] Use new activities icon (authored by GB_2). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22172?vs=60873&id=65538 REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 158 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/158/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Sep 2019 06:00:12 + Build duration: 1 min 6 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/49/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 07 Sep 2019 06:00:12 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 222

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 06:00:12 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncat

D22155: Add new activities and virtual desktops icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5261c6e3b69: Add new activities and virtual desktops icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22155?vs=60836&id=65532 REVISIO

D22143: Add proper logging using ECMQtDeclareLoggingCategory

rikmills added a comment. This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong? REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #fra

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 202 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/202/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Sep 2019 04:51:09 + Build duration: 24 min and counting BUILD ARTIFACTS acc/KF5KIO-5.62.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/59/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 04:49:46 + Build duration: 6 min 50 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 201 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/201/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 06 Sep 2019 16:09:29 + Build duration: 12 hr and counting BUILD ARTIFACTS acc/KF5KIO-5.62.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/58/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 15:55:14 + Build duration: 12 hr and counting JUnit Tests Name: projectroot Faile

D23761: Make small recent documents icons look like documents and improve clock emblems

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a8556bfda27b: Make small recent documents icons look like documents and improve clock emblems (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.

D23761: Make small recent documents icons look like documents and improve clock emblems

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH tweak-recent-document-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23761 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, meven, LeGast00n, G

D23761: Make small recent documents icons look like documents and improve clock emblems

ndavis added a comment. In D23761#526874 , @ngraham wrote: > While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the text

D23761: Make small recent documents icons look like documents and improve clock emblems

ngraham added a comment. While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the text in the stylesheet) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabr

D23761: Make small recent documents icons look like documents and improve clock emblems

ndavis added a comment. In D23761#526872 , @ngraham wrote: > This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the a

D23761: Make small recent documents icons look like documents and improve clock emblems

ngraham added a comment. This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the area claimed by the clock emblem. I can fix that too, or we could delete the 24p

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. In D7446#526837 , @meven wrote: > But the feature in kactivitymanagerd D23112 , its improvement D23737 and gwenview D23741

D23761: Make small recent documents icons look like documents and improve clock emblems

ngraham retitled this revision from "Make recent documents icons look like documents and improve clock emblems" to "Make small recent documents icons look like documents and improve clock emblems". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23761 To: ngraham,

D7446: [Places panel] Revamp the Recently Saved section

ngraham edited the summary of this revision. ngraham added a dependency: D23760: Create new "Recent folders" icon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreas

D23760: Create new "Recent folders" icon

ngraham added a dependent revision: D7446: [Places panel] Revamp the Recently Saved section. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23760 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, bruns

D23761: Make recent documents icons look like documents and improve clock emblems

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Companion to D23760 TEST PLAN F7325407: re

D23760: Create new "Recent folders" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c58bedafd926: Create new "Recent folders" icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23760?vs=65526&id=65527 REVISION DETAIL

D23759: Remove unneeded media icons

ndavis abandoned this revision. ndavis added a comment. In D23759#526814 , @broulik wrote: > -1 we've had do much trouble when we touched media icons last, and still get bug reports about "missing icons" so i prefer not touching them again for n

D23760: Create new "Recent folders" icon

meven added a comment. In D23760#526842 , @ngraham wrote: > The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next. G

D23760: Create new "Recent folders" icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH recent-folder-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23760 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB

D23760: Create new "Recent folders" icon

ngraham added a comment. The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23760 To: n

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. >> Conditionalize the code here with version ifdefs so that people only get both new entries when using kio-extras from 19.12.0 It is already the case : users won't get the new entries without recentlyused:/ installed, `KProtocolInfo::isKnownProtocol(QStringLitera

D23760: Create new "Recent folders" icon

ngraham updated this revision to Diff 65526. ngraham added a comment. Use @ndavis' 16px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23760?vs=65524&id=65526 BRANCH recent-folder-icon (branched from master) REVISION DETAIL https://phabri

D23760: Create new "Recent folders" icon

ndavis added a comment. In D23760#526835 , @meven wrote: > Also it seems to me the icon is not very similar to > F7325279: Screenshot_20190906_224006.png > The thickness of the clock pen in particular

D23760: Create new "Recent folders" icon

meven added a comment. Also it seems to me the icon is not very similar to F7325279: Screenshot_20190906_224006.png The thickness of the clock pen in particular. They should be somewhat reminiscent of one another IMHO. REPOSITORY R266 Breeze Ico

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:67acfe3c9c46: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg (authored by kossebau). REPOSI

D23760: Create new "Recent folders" icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Use this 16px icon. It's more similar to the style of the 22px icon. F7325261: Screenshot_20190906_163400.png F7325259: folder-open-recen

D23753: Fix test failing

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, this works for me both with the busted setup, and also with French properly installed (thanks for the tip on how to do that). REPOSITORY R249 KI18n BRANCH master REVISION DETA

D23755: Fix no device available text

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH fix REVISION DETAIL https://phabricator.kde.org/D23755 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23758: [CopyJob] Use resolved URL in copyingDone so undo can rename back using local file

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works and makes sense, thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23758 To: dfaure, broulik, ngraham Cc: kde-frameworks-devel, LeGast00

D23759: Remove unneeded media icons

broulik added a comment. -1 we've had do much trouble when we touched media icons last, and still get bug reports about "missing icons" so i prefer not touching them again for no good reason. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23759

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. +1, no objection to that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andrea

D22155: Add new activities and virtual desktops icons

ngraham added a comment. And in fact it was. :( Looks like that was a typo on the wiki, and 5.62 is the correct one. Feel free to land this right now. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabr

D23760: Create new "Recent folders" icon

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Needed for D7446 . BUG: 411635 FIXED-IN: 5.62

D7446: [Places panel] Revamp the Recently Saved section

dfaure added a comment. Sounds to me like KIO depends at runtime on this particular ioslave, so THAT ioslave should move to KIO. Just like I did with KIO trash some time ago. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelac

D23759: Remove unneeded media icons

ndavis added a comment. In D23759#526784 , @Leon0402 wrote: > > unless all icons were removed from the desktop theme (all icons would come from the icon theme) > > What's the drawback with that? That not every icon theme has all icons?

D23759: Remove unneeded media icons

Leon0402 added a comment. > unless all icons were removed from the desktop theme (all icons would come from the icon theme) What's the drawback with that? That not every icon theme has all icons? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/

D23759: Remove unneeded media icons

ndavis added a comment. A few things to consider: If a user uses an icon theme besides Breeze (e.g., Papirus), but keeps using the Breeze desktop theme, they could see a mix of icons from their icon theme and icons from the desktop theme. This is actually already the case in different p

D23759: Remove unneeded media icons

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These are already provided by most icon themes and there aren't enough sizes in this

D7446: [Places panel] Revamp the Recently Saved section

ltoscano added a comment. In D7446#526741 , @ngraham wrote: > And maybe we should also discuss moving kio-extras to the frameworks release cycle. It's not an app so I'm not sure it makes sense to have it distributed with KDE Applications right no

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

This revision was automatically updated to reflect the committed changes. Closed by commit R159:df52b1a382af: Add Term::Type::files() and Term::Type::directories() to filter only… (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. My version is up at D23758 INLINE COMMENTS > copyjob.cpp:2097 > +// which is why we're passing m_currentSrcURL instead of > m_current

D23758: [CopyJob] Use resolved URL in copyingDone so undo can rename back using local file

dfaure created this revision. dfaure added reviewers: broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY In case of desktop:/ KIO which rewrites URLs, looking up the URL the trashed fi

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. And maybe we should also discuss moving kio-extras to the frameworks release cycle. It's not an app so I'm not sure it makes sense to have it distributed with KDE Applications right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To:

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. So we now have a bit of a problem here. The changes to the IOSlave that support files-only and folders-only modes will land in KDE Applications 19.12.0. But this code is in KIO and will land in Frameworks 5.63, which will be released first. We have a few options

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/57/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 15:24:00 + Build duration: 27 min and counting JUnit Tests Name: projectroot Fail

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65519. meven added a comment. Add two entries to Recent 'Recent Files' and 'Recent Locations' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65199&id=65519 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricat

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. I'm working on it. Unittest done, now looking into potentially better fix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau added a comment. Given ECM 5.62 will be tagged this WE and thus the API of the new macro `ecm_qtdesignerplugin_widget` being frozen, and no-one really gave feedback on the initial API, would take the responsibility and push tonight, unless there is last minute discussion. Only users

D23755: Fix no device available text

nicolasfella updated this revision to Diff 65517. nicolasfella added a comment. - Do same for bluetooth REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23755?vs=65515&id=65517 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D23755 AFFEC

D23755: Fix no device available text

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23755 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23755: Fix no device available text

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH fix REVISION DETAIL https://phabricator.kde.o

D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin

kossebau abandoned this revision. kossebau added a comment. No longer needed with latest change to still alllow CONSTRUCTOR_ARGS_CODE for convenience. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23726 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau updated this revision to Diff 65514. kossebau added a comment. For convenience still enable CONSTRUCTOR_ARGS_CODE, usually simple string without ";" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23725?vs=65396&id=65514 BRANCH crea

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 14:28:05 + Build duration: 15 min and counting JUnit Tests Name: projectroot Fail

D23753: Fix test failing

aacid created this revision. aacid added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Need to set the QLocale manually since when we call setlocale Qt has already create

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 14:07:50 + Build duration: 12 min and counting JUnit Tests Name: projectroot Fail

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23708 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 13:57:34 + Build duration: 9 min 0 sec and counting JUnit Tests Name: projectroot

D21760: Add KListOpenFilesJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This is good to go in :-) If you push it today it'll indeed be in 5.62, to be tagged tomorrow, otherwise we'll need to adjust the @since tag ;-) REPOSITORY R244 KCoreAddons BRANCH

D20433: Use mount point returned from DBus instead of using property value

nicolasfella abandoned this revision. nicolasfella added a comment. The issue has been fixed in another commit REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65506. leinir added a comment. - Also catch the error messages from the non-deprecated error function - Equalize border colour with Breeze REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65236&id=65506 BRANC

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Please commit it. Thanks. REPOSITORY R241 KIO BRANCH ahmad/copyjob (branched from master) REVISION DETAIL https://phabricator.kde.org/D23708 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGa

D23749: Add "preferences-desktop-navigation" icon

GB_2 added a dependent revision: D23750: Use large colorful category icons in Dolphin settings. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23749: Add "preferences-desktop-navigation" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:debde7d66d89: Add "preferences-desktop-navigation" icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23749?vs=65502&id=65503 REVISION DE

D23749: Add "preferences-desktop-navigation" icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23749: Add "preferences-desktop-navigation" icon

GB_2 retitled this revision from "Add preferences-desktop-navigation icon" to "Add "preferences-desktop-navigation" icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23749: Add preferences-desktop-navigation icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 402910 F7324021: preferences-desktop-navigation Icon.png

D21760: Add KListOpenFilesJob

hallas added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfilesjobtest_unix.cpp:34 > (minor) we never check that `new` succeeded, in Qt code. > > The reasoning is that on desktop systems, with swap enabled, before the swap > is exhausted, the user will have given up and rebooted

D21760: Add KListOpenFilesJob

hallas edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

hallas updated this revision to Diff 65500. hallas marked 7 inline comments as done. hallas added a comment. Review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=65494&id=65500 BRANCH add_list_processes_with_open_files (branched fr

Re: Proposing Quick Charts as a new framework

> Am 06.09.2019 um 02:49 schrieb Aleix Pol : > > Does it really have the same features? Otherwise it doesn't make sense > to deprecate anything. It will just frustrate the users of the > framework. Qt has https://doc.qt.io/qt-5/qtcharts-index.html. Does kqtquickcharts or this new framework prov

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Great job, thanks! Do you have a developer account, or shall I commit this? REPOSITORY R241 KIO BRANCH ahmad/copyjob (branched from master) REVISION DETAIL https://phabricator.kde.

D21760: Add KListOpenFilesJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Yep, much simpler indeed. INLINE COMMENTS > klistopenfilesjobtest_unix.cpp:34 > +auto job = new KListOpenFilesJob(path.path()); > +QVERIFY(job); > +job->exec(); (mino

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23736 REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns