kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in kfontsizeaction.cpp:93
> Will test is this works, but IIRC actions() returned a normal left-side value
> thingie, which qAsConst does not want to take.
Yes, `qAsConst(actions())` does not work, as actions() is a r-value type, w
kossebau updated this revision to Diff 65089.
kossebau added a comment.
- align * & & with var name, not type, by current KF coding style
- fix "fir" for "for"
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23597?vs=65032&id=65089
BRANCH
portmos
meven added a comment.
Should we add this to existing users places settings ?
Like we do with `withBaloo` for instance, adding it if it was not added
before.
INLINE COMMENTS
> kfileplacesmodel.cpp:315
> +// Add a Recently Used entry if available (it comes from kio-extras)
> +
ngraham added a comment.
I'm not sure I understand about about localization to figure that out. Would
you be able to help me out?
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D22069
To: ngraham, #localization, #frameworks, broulik
Cc: safaalfulaij, mikeroyal, aspota
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/47/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sun, 01 Sep 2019 02:57:57 +
Build duration:
8 min 18 sec and counting
JUnit Tests
Name: projectroo
cfeck added inline comments.
INLINE COMMENTS
> kacceleratormanagertest.cpp:35
> +const auto menuActions = menu.actions();
> +for (const QAction* action : menuActions) {
> if (action->isSeparator()) {
Please use KF5 coding style: `Type *var` instead of `Type* var` (also for `&`
romangg added a comment.
If the output device - that is the replication source - goes away (hot plug)
we need to clear the `replicationSource` field in the other output device. This
is straight forward with a single connect but question is if afterwards the
replicate event should be send to
romangg retitled this revision from "[server] Introduce cloning and replication
of output devices" to "Introduce cloning and replication of output devices".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D23619
To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast0
romangg added inline comments.
INLINE COMMENTS
> zzag wrote in outputdevice.cpp:391
> Correction: that's not reliable way to check whether a C string is empty. You
> assume that all empty strings have the same address, which in some cases
> cannot be true, e.g. if the string is dynamically allo
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in outputdevice.cpp:391
> That's not safe if the raw string is dynamically allocated, use qstrlen
> instead.
Correction: that's not reliable way to check whether a C string is empty. You
assume that all empty strings have the same addres
zzag added inline comments.
INLINE COMMENTS
> outputdevice.cpp:391
> +Q_UNUSED(output);
> +if (!source_uuid || source_uuid == "") {
> +o->replicationSource.clear();
That's not safe if the raw string is dynamically allocated, use qstrlen instead.
REPOSITORY
R127 KWayland
REVIS
romangg added a task: T11222: Reimagine output cloning.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D23619
To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.
REVISION SUMMARY
The org_kde_kwin_outputdevice and respective org_kde_kwin_outputconfiguration
protocol
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/46/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 31 Aug 2019 18:19:08 +
Build duration:
7 min 54 sec and counting
JUnit Tests
Name: projectroo
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/21/
Project:
kf5-qt5 WindowsMSVCQt5.13
Date of build:
Sat, 31 Aug 2019 18:19:08 +
Build duration:
6 min 16 sec and counting
CONSOLE OUTPUT
[...tr
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b97ce61950c9: Add support for handling QNAM SSL errors to
KSslErrorUiData (authored by vkrause).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23323?vs=64233&id=65061#toc
REPOSITORY
R241 KI
kossebau added a comment.
Thanks for review @dhaumann :) Well, if you like I can give KTextEditor a
try, motivated there with my KDevelop hat on :) Let's see when I am sleepless
at the computer next time ;)
INLINE COMMENTS
> dhaumann wrote in fonthelpers.cpp:97
> Optionally, you could even
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> ktcpsocket.h:416
> +/**
> + * Create an instance and initialize it with SSL error data from @p
> reply.
> + */
@since 5.62
REPOSITORY
R241 KIO
BRANCH
dhaumann added a comment.
PS: could you do the same for kate.git ? :-D
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23597
To: kossebau, #frameworks, cfeck
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dhaumann added a comment.
I think the patch is fine: +1
Please address/comment on `fir` :) besides that, another review won't hurt,
since you simplify the code in 1-2 places, i.e. the changes are slightly more
than just the transition to `for`.
INLINE COMMENTS
> fonthelpers.cpp:97
>
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/12/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 31 Aug 2019 07:39:23 +
Build duration:
1 hr 7 min and counting
JUnit Tests
Name: projectroo
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:76710483c865: Make battery serial property constant
(authored by meven).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23598?vs=65033&id=65041
REVISION DETAIL
htt
vkrause added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23323
To: vkrause, #frameworks, dfaure
Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R245 Solid
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23598
To: meven, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
meven edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23598
To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.
REVISION SUMMARY
Since serial property cannot change and has no NOTIFY function, mark it as
constant, to
26 matches
Mail list logo
