D9175: Migrate some more QRegExps to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R39:74a77b06db27: Migrate some more QRegExps to QRegularExpression (authored by dhaumann, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9175?

D9175: Migrate some more QRegExps to QRegularExpression

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH arcpatch-D9175 REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00

D23365: Add battery-ups icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:69fd363b6412: Add battery-ups icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23365?vs=64364&id=64381 REVISION DETAIL https://pha

D23365: Add battery-ups icons

ngraham added a dependent revision: D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon. REPOSITORY R266 Breeze Icons BRANCH ups-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23365 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n,

D23365: Add battery-ups icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ups-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23365 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b

D23367: make the sizing of the toolbuttons more coherent

camiloh created this revision. camiloh added reviewers: Plasma, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY this makes the toolbutton icons follow a standard size. Maybe one coul

D23352: make button icons follow a reasonable size and layout

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f9736191161b: make button icons follow a reasonable size and layout (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?v

D23352: make button icons follow a reasonable size and layout

camiloh marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH button-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23352: make button icons follow a reasonable size and layout

camiloh updated this revision to Diff 64365. camiloh added a comment. remove white line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64317&id=64365 BRANCH button-style (branched from master) REVISION DETAIL https://phabri

D23365: Add battery-ups icons

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This icon is currently only in the Plasma theme, but a version for the icon theme

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. You asked for it :-) INLINE COMMENTS > CMakeLists.txt:3 > + > +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS > +KIO this was already done by the parent CMakeLists.t

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 22 Aug 2019 20:26:23 + Build duration: 34 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/51/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 22 Aug 2019 20:26:23 + Build duration: 22 min and counting BUILD ARTIFACTS acc/KF5KDE4S

D23336: KDirOperator: Add follow new directories option

daandemeyer added a comment. That is something I hadn't considered yet. Would it be acceptable to only apply this option when the KDirOperator is configured as a tree view? I could also go the hard way and wrap QTreeView myself but that would be unfortunate as KDirOperator almost does ex

D23348: force applicationDirPath into first position when finding plugins

dfaure added a comment. Yep, as documented in https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: sitter, mpyne, dfaure Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michael

D23336: KDirOperator: Add follow new directories option

ngraham added a comment. What happens when this is set but the view isn't an expandable tree view? REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23347: kdelibs4support: port away from deprecated KWindowSystem API

dfaure closed this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D23347 To: dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Could you change your status to Accepted or Resigned?? REPOSITORY R320 KIO Extras

D22922: Implement writing of images

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH write_embedded_image REVISION DETAIL https://phabricator.kde.org/D22922 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas,

D22922: Implement writing of images

astippich added a comment. friendly ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D22922 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D22775: Allow date range filtering of resource events using Date Term

This revision was automatically updated to reflect the committed changes. Closed by commit R159:b64cfb3952ee: Allow date range filtering of resource events using Date Term (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22775

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64347. meven added a comment. Add date and date range filtering after D22775 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=63829&id=64347 BRANCH arcpatch-D22144 REVIS

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2e9cae63d141: KDirOperator: Only enable "Create New" menu if the selected item is a directory (authored by daandemeyer, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https:

D23336: KDirOperator: Add follow new directories option

daandemeyer added a comment. Now, with `followDirectories` set to false, directories simply expand on double click which is what I wanted to achieve. The general behaviour I want to get with this change is to have a project tree view when opening a folder where the root folder stays fixed.

D23336: KDirOperator: Add follow new directories option

ngraham added a comment. In D23336#516944 , @daandemeyer wrote: > I changed the option to apply to directories that are double clicked as well. Previously, double clicking a directory would also change the listed url which now depends on whethe

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

daandemeyer added a comment. Email: daan.j.deme...@gmail.com (added to my profile as well) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer, #frameworks, ngraham Cc: ngraham, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23336: KDirOperator: Add follow new directories option

daandemeyer added a comment. I changed the option to apply to directories that are double clicked as well. Previously, double clicking a url would also change the listed url which now depends on whether the option is disabled. Since it applies to both new and existing directories, `followDir

D23336: KDirOperator: Add follow new directories option

ngraham added a comment. `followDirectories()` seems somewhat ambiguous to me. How about the old one, or else, `openNewlyCreatedDirectories()`? REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, brun

D23336: KDirOperator: Add follow new directories option

daandemeyer updated this revision to Diff 64332. daandemeyer added a comment. - Address comment - Apply option when selecting directories as well - Rename to `followDirectories` CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23336?vs=64273&id=64332 REVISION DETAIL https://phab

D23336: KDirOperator: Add follow new directories option

ngraham added a comment. +1, but you need to add `@since 5.62` to the new public functions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:f0bdbcbf982f: Add FictionBook 2 icons (authored by yurchor). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Do you need someone to commit this for you? If so, can you please provide an email address? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer, #

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH krita (branched from master) REVISION DETAIL https://phabricator.kde.org/D23349 To: davidre, davidedmundson, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22775: Allow date range filtering of resource events using Date Term

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Sorry I missed this one. If I don't react on a ping here, just send me a direct mail. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D9175: Migrate some more QRegExps to QRegularExpression

dhaumann marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D9175: Migrate some more QRegExps to QRegularExpression

dhaumann updated this revision to Diff 64327. dhaumann edited the test plan for this revision. dhaumann removed reviewers: kfunk, mwolff. dhaumann added a comment. Patch should be OK now, please review + approve. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH krita (branched from master) REVISION DETAIL https://phabricator.kde.org/D23349 To: davidre, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64325. apol added a comment. Fix JBB's crash REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64314&id=64325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES src/backends/CMak

D23352: make button icons follow a reasonable size and layout

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM, just fix the whitespace issue INLINE COMMENTS > Button.qml:73 > elide: Text.ElideRight > + > } unnecessary whitespace change REPOSITORY R242 Plasma Framewo

D23352: make button icons follow a reasonable size and layout

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

camiloh edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23352: make button icons follow a reasonable size and layout

camiloh updated this revision to Diff 64317. camiloh added a comment. correct import line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64315&id=64317 BRANCH button-style (branched from master) REVISION DETAIL https://phab

D23352: make button icons follow a reasonable size and layout

camiloh created this revision. camiloh added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. camiloh requested review of this revision. REVISION SUMMARY with the Plasma style buttons which have an icon look wrong. The icon size is to

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64314. apol added a comment. Make it possible to create new contacts REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=63191&id=64314 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED F

D23348: force applicationDirPath into first position when finding plugins

sitter added a comment. That is a solvable problem, there's a property to control where things end up in the build tree: `set_target_properties(kio_ftp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kio")` REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricat

D23348: force applicationDirPath into first position when finding plugins

cullmann added a comment. ;=) Yeah, all ugly. Even with the above code btw. an uninstalled Kate would still not find the plugins as it wants them in some "ktexteditor" subdir in plugins but with the current CMake setup they will end in the build directory in directly the same dir as the ap

D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY BUG:411163 REPOSITORY R266 Breeze Icons BRANCH krita (branched from master) REVISION DETAIL https://phabricator

D23348: force applicationDirPath into first position when finding plugins

sitter added a comment. Perhaps the answer actually is that QT_PLUGIN_PATH should not be necessary ;) This is a bit of a chicken and egg problem. When our software can't find plugins automatically we resort to QT_PLUGIN_PATH, but then because we use QT_PLUGIN_PATH we can't just break it

D23348: force applicationDirPath into first position when finding plugins

cullmann added a comment. Yes, I have some review request that does something similar inside Kate and I am not sure that this would help us either. https://invent.kde.org/kde/kate/merge_requests/8 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: si

D23348: force applicationDirPath into first position when finding plugins

sitter abandoned this revision. sitter added a comment. Agh, you are very right of course. Things are never easy :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: sitter, mpyne, dfaure Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D23348: force applicationDirPath into first position when finding plugins

cullmann added a comment. Hmm, I don't think this is a good thing to do. e.g. look at this setup: You have some globally installed Kate/KDevelop/... You develop a plugin, it is already shipped with the global install by the distro. You compile locally your plugin and setup the

D23348: force applicationDirPath into first position when finding plugins

sitter created this revision. sitter added reviewers: mpyne, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY applicationDirPath technically is already part of libraryPaths BUT it's position

D23341: Fixed Telegram Desktop plugin on Fedora

This revision was automatically updated to reflect the committed changes. Closed by commit R495:1afcf7101db7: Fixed Telegram Desktop plugin on Fedora (authored by xvitaly, committed by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23341

D23341: Fixed Telegram Desktop plugin on Fedora

xvitaly added a comment. My email address is vit...@easycoding.org REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23341 To: xvitaly, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23347: kdelibs4support: port away from deprecated KWindowSystem API

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D23347 To: dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23341: Fixed Telegram Desktop plugin on Fedora

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Thanks! I assume you don't have commit rights, so I'll need your email address please to merge this REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.

D23347: kdelibs4support: port away from deprecated KWindowSystem API

dfaure created this revision. dfaure added a reviewer: zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN builds REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

dfaure added a comment. Probably still valid, yes. Needs investigation, and a unittest REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5856 To: dfaure, aacid Cc: kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, bruns

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

dfaure closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23215 To: dfaure, zzag, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23217 To: dfaure, vkrause, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED

This revision was automatically updated to reflect the committed changes. Closed by commit R278:d458a2295360: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED (authored by dfaure). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R27

D23213: Deprecate slideWindow(QWidget *widget)

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ef202bd54db0: Deprecate slideWindow(QWidget *widget) (authored by dfaure). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R278 KWindowSystem CHANGES

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

dfaure closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23108 To: dfaure, broulik, davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23341: Fixed Telegram Desktop plugin on Fedora

xvitaly updated this revision to Diff 64296. xvitaly added a comment. Added telegram-desktop.desktop launcher to JSON. REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23341?vs=64287&id=64296 REVISION DETAIL https://phabricator.kde.org/D23341 AFFE

D23341: Fixed Telegram Desktop plugin on Fedora

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. Please add this to https://cgit.kde.org/purpose.git/tree/src/plugins/telegram/telegramplugin.json#n136 too REPOSITORY R495 Purpose Library REVISION DETAIL https:

D23344: assert slave command finality

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this changes existing qwarnings in state verification logic to be assertive in order to

D23340: Fix memory leak in KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R237:b9cf875e2e7d: Fix memory leak in KConfigWatcher (authored by dvratil). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23340?vs=64285&id=64290 REVISION DETAIL htt

D23341: Fixed Telegram Desktop plugin on Fedora

xvitaly created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. xvitaly requested review of this revision. REVISION SUMMARY Telegram Desktop on Fedora (from RPM Fusion repository) uses **telegram-desktop.desktop** launcher name. REPOSITORY

D23300: Add FictionBook 2 icons

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23340: Fix memory leak in KConfigWatcher

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. :/ Thanks REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D23340 To: dvratil, davidedmundson Cc: davidedmundson, kde-frameworks-dev

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64286. yurchor added a comment. Use black "fb" for 32px and 64px breeze-dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64281&id=64286 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D23340: Fix memory leak in KConfigWatcher

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D23340 AFFECTED FILES src/core/kconfigwatcher.

D23339: Fix memory leak in ConfigView and Dialog

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23339 AFFECTED FILES src/p

D23300: Add FictionBook 2 icons

ndavis added a comment. Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop shad

D23335: Q_UNUSED doesn't need a ; after it.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8e34c0b97393: Q_UNUSED doesn't need a ; after it. (authored by adridg). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23335?vs=64272&id=64282 REVISION DETAIL

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64281. yurchor added a comment. Realign 32px versions, replace 16px and 22px with icons proposed by Noah Davis, add dark versions REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64236&id=64281 BRANCH ma

D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY The existing macro always inherits from KPluginFactory -- making it hard to use when sub-classing KPluginFactory in orde

D23300: Add FictionBook 2 icons

yurchor reclaimed this revision. yurchor added a comment. This revision now requires changes to proceed. Unexpected free time. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeG

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 22 Aug 2019 09:55:45 + Build duration: 2 min 25 sec and counting JUnit Tests Name: pr

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R278 KWindowSystem BRANCH setmainwindow REVISION DETAIL https://phabricator.kde.org/D23108 To: dfaure, broulik, davidedmundson, zzag Cc: kde-frameworks-deve

D23336: KDirOperator: Add follow new directories option

daandemeyer created this revision. daandemeyer added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. daandemeyer requested review of this revision. REVISION SUMMARY Currently, KDirOperator always calls `setUrl` on newly created directo

D23335: Q_UNUSED doesn't need a ; after it.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23335 To: adridg, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23335: Q_UNUSED doesn't need a ; after it.

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY This reduces compiler warnings (-Wall, or just clang) about unnecessary ;s. REPOSITORY R244 KCoreAddons BRANCH maste

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

dfaure updated this revision to Diff 64270. dfaure marked an inline comment as done. dfaure added a comment. Fix memory leak in new overload REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23108?vs=63893&id=64270 BRANCH setmainwindow REVISION DETAI

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

dfaure marked 3 inline comments as done. dfaure added inline comments. INLINE COMMENTS > zzag wrote in kwindowsystem.cpp:490 > Each time this method is called a new foreign QWindow object will be created. > Can you please explain why leaking those objects is okay? Ah I didn't realize that QWind

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

meven added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

daandemeyer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. daandemeyer requested review of this revision. REVISION SUMMARY Currently, when right-clicking a file in KDirOperator, the "Create New" menu is available and can be used. Howe

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer abandoned this revision. daandemeyer added a comment. KF6 is a long time out so I'm abandoning this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22699 To: daandemeyer, alexmerry Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem,

D22709: Support passing target to ecm_add_app_icon.

daandemeyer abandoned this revision. daandemeyer added a comment. KF6 is a long time out so I'm abandoning this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22709 To: daandemeyer, alexmerry, dschmidt Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsys

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. ping @ivan I guess you are not much available in August. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

yurchor abandoned this revision. yurchor added a comment. I have no time to redo this now. Sorry. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Upon closer inspection, I found a few issues that need to be fixed. Blur can't be used because the Qt SVG renderer doesn't support it. You'll have to use linear or radial grad