D22775: Allow date range filtering of resource events using Date Term

meven added a comment. gentle ping @ivan REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Definitely. Do you have an idea who ? BTW, I have one change planned for this wait

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/29/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 20 Aug 2019 02:58:56 + Build duration: 30 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.62.0

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 95 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 20 Aug 2019 02:58:56 + Build duration: 21 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.62.

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. can I merge this one? 👀 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

brute4s99 added a dependency: D23273: Allow to pass pid in addition to appID try to deduce appID from pid. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh, ngrah

D23282: add `-pid` parameter to Snore backend calls

brute4s99 created this revision. brute4s99 added reviewers: KDE Connect, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY the upcoming change to SnoreToast also accepts `process id`. Sin

D23278: LESS: import CSS keywords, new highlighting and some improvements

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23278 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, micha

D23278: LESS: import CSS keywords, new highlighting and some improvements

jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY New highlighting (same as CSS): - Value Keyword - Color - Number - Unit Improvements a

D23245: New syntax: SASS. Some fixes for CSS and SCSS

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0edc0cb01ab7: New syntax: SASS. Some fixes for CSS and SCSS (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23245?vs=63987&id=64075#toc REPOSITORY R216 Syntax Highlight

D23196: have the app icon as fallback icon in Snore

brute4s99 added a comment. may I land this now? 👀 REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 28 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/28/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 19 Aug 2019 20:07:02 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.62.

D23224: Fix capitalization of Nextcloud

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella, apol Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23272: JavaScript: remove unnecessary "Conditional Expression" context

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The "Conditional Expression"

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added a comment. Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, a

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a comment. In D23266#514605 , @apol wrote: > How about porting it to use ecm_qt_declare_logging_category? I don't see what you mean, there are already two build target that uses ecm_qt_declare_logging_category in this repo.

D23266: Export Plasma core lib log category, add a category to a qWarning

meven updated this revision to Diff 64060. meven added a comment. Add Plasma quick lib category, avoid ECM_VERSION check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23266?vs=64045&id=64060 BRANCH arcpatch-D23266 REVISION DETAIL h

D23188: Fix supported OS attributes for api.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c67827d4274f: Fix supported OS attributes for api.kde.org (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23188?vs=63822&id=64058 REVISION D

D23269: Fix creating archives on Android content: URLs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D23269 To: vkrause, #frameworks, #android, apol Cc: apol, kde-frameworks-devel, LeGast00n,

D23266: Export Plasma core lib log category, add a category to a qWarning

apol added a comment. How about porting it to use ecm_qt_declare_logging_category? INLINE COMMENTS > CMakeLists.txt:226 > > +if (${ECM_VERSION} STRGREATER "5.58.0") > +install(FILES plasma-framework.categories DESTINATION > ${KDE_INSTALL_LOGGINGCATEGORIESDIR}) This is not necessary,

D23269: Fix creating archives on Android content: URLs

vkrause added reviewers: Frameworks, Android. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D23269 To: vkrause, #frameworks, #android Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23269: Fix creating archives on Android content: URLs

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Needs https://codereview.qt-project.org/c/qt/qtbase/+/270849 to work. REPOSITORY R243 KArchive BRANCH master REVI

D23194: Making FileJob behave consistently.

feverfew updated this revision to Diff 64051. feverfew added a comment. Making comments clearer REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23194?vs=63861&id=64051 BRANCH ConsistentRead (branched from master) REVISION DETAIL https://phabricator.kde.org

D23267: Fix log categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98d3b607ee35: Fix log categories file (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64049&id=64050 REVISION DETAIL https:/

D23267: Fix log categories file

meven updated this revision to Diff 64049. meven added a comment. Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64047&id=64049 BRANCH arcpatch-D23267 REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FILES plas

D23267: Fix log categories file

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 To: meven, #frameworks, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampal

D23267: Fix log categories file

meven updated this revision to Diff 64047. meven added a comment. Do not touch ksmserver line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64046&id=64047 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FI

D23267: Fix log categories file

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FIL

D23266: Export Plasma core lib log category, add a category to a qWarning

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN Builds, new context for warning is visible REPOSITORY R242 Plasma Framework (Library) BRANC

D23262: disable autouic again - it breaks builds

This revision was automatically updated to reflect the committed changes. Closed by commit R240:557e5d898bf9: disable autouic again - it breaks builds (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23262?vs=64039&id=64042 REV

D23262: disable autouic again - it breaks builds

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: kde-frameworks-devel, kde-build

D22805: set autorcc and autouic by default

sitter abandoned this revision. sitter added a comment. D23262 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol, kde

D23262: disable autouic again - it breaks builds

sitter created this revision. sitter added reviewers: apol, nicolasfella, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY autouic (like automoc) assumes that eve

D22805: set autorcc and autouic by default

cullmann added a comment. Yep, KTextEditor is broken for me, too. AutoUic error - "/local/ssd/cullmann/kde/src/ktexteditor/src/completion/katecompletionconfig.cpp" Could not find "completionconfigwidget.ui" in "/local/ssd/cullmann/kde/src/ktexteditor/src/

D22805: set autorcc and autouic by default

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: nicolasfella, cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel,

D22805: set autorcc and autouic by default

nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394 Another user has reported that ktexteditor and knewstuff fail too REPOSITORY R240 Ext

D22805: set autorcc and autouic by default

This revision was automatically updated to reflect the committed changes. Closed by commit R240:60ca1a27e539: set autorcc and autouic by default (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64033&id=64037 REVISION

D22805: set autorcc and autouic by default

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64033. sitter added a comment. typo-- REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64032&id=64033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES kde-module

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64032. sitter added a comment. bump version again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62838&id=64032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

Re: clang-format file for KDE Frameworks coding style?

https://phabricator.kde.org/P434 See also https://phabricator.kde.org/T11214 for my plans to update all plasma. (currently blocked on porting old style Qt connects which clang mangles)

D23245: New syntax: SASS. Some fixes for CSS and SCSS

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for working on this. REPOSITORY R216 Syntax Highlighting BRANCH sass (branched from master) REVISION DETAIL https://phabricator.kde.org/D23245 To: jpoelen, #framework_syn

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d62e99460ad9: Allow applets/containments/wallpaper to defer UIReadyConstraint (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22852 To: davidedmundson, #plasma, broulik Cc: broulik, apol, kde-frameworks-devel, LeGast00n, michaelh, n