D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Not having `id="current-color-scheme"` causes stylesheets to not work correctly. INLINE COMMENTS > depth16to8.svg:1 > -http://www.w3.org/2000/svg"; viewBox="0 0 22 22"> > - > -

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. `FIXED-IN: ` refers to the next release (i.e. the one that this fix will make it into). The latest released version of KDE Frameworks is 5.61, s

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. hmmm, now that i think about it LC_ALL probably needs a .UTF-8 suffix or something to be correct But OTOH this is working fine for me. comments? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc: kde-frameworks-devel

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We were only setting LANGUAGE, but that does not set LC_TIME so the time was still set to the "system" locale, we now set

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 added a comment. I am not quite sure of the version for the FIXED-IN tag. Also, this bug was reported in digikam running on Windows 10, are there any additional steps necessary to get this change from breeze-icons to the digikam Windows build? REPOSITORY R266 Breeze Icon

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh,

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-depth-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/

[sysadmin/ci-tooling] craftmaster: Include SnoreToast in the Windows CI system.

Git commit 4015e2bbba5a2eb2719f0979848dc86d28c67a31 by Ben Cooksley. Committed on 12/08/2019 at 19:09. Pushed by bcooksley into branch 'master'. Include SnoreToast in the Windows CI system. This should repair KNotifications builds on Windows and restore the maintainability of the CI system on Wi

Re: KCalendarCore plugins/datasources?

On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > Hello, > > So yesterday I was discussing this with the Volker in #kde-devel, that > currently kcalcore doesn't provide a "plugin interface" to create a > various

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun abandoned this revision. ZaWertun added a comment. No problem. I'm closing revision then. Thanks for the feedback. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: ngraham, rikmills, kde-frameworks-devel, LeGast00n,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Well, we *could* land it, I am also not sure if that is a net-improvement though. As David said we are playing ping-pong with bugs and all of them are symptoms of the larger issue that error handling is done inconsistently, which in turn is why fixing one bug causes a

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ngraham added a comment. > but sure, whatever, if you think it's better with this commit than with the earlier equally broken two versions, I'm not objecting. @sitter so what do you think, should we land this in the meantime? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.k

D21661: add snoretoast backend for KNotifications on Windows

vkrause added a comment. It looks like this made D-Bus and Phonon hard required dependencies on Android again!? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: vkrause, nicolasfella, pino, kde-fra

Re: KCalendarCore plugins/datasources?

On Monday, August 12, 2019 6:49:48 AM EDT Daniel Vrátil wrote: > On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > > > Hello, > > Hi Bhushan, > > > > > So yesterday I was discussing this with the Volker in #k

D23112: Add a event Spy for GtkFileChooser recent files

broulik added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:125 > + > +app.name = attributes.value("exec"); > +// remove "'" caracters wrapping the command and any character after > a space It stores the full `Exec` line of the desktop file, including the `%u`. What you pro

D23112: Add a event Spy for GtkFileChooser recent files

broulik added a comment. Can you check out the `KBookmarks` framework which has classes for processing xbel files REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: broulik, plasma-devel, LeGast00n, jraleigh, fba

D23112: Add a event Spy for GtkFileChooser recent files

meven created this revision. meven added reviewers: Frameworks, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY GtkFileChooser/GtkRecentManager follows https://www.freedesktop.org/wiki/Specifications/deskto

D23061: Possiblity to change Definition data after loading

sirgienko added inline comments. INLINE COMMENTS > dhaumann wrote in definition.h:339 > Please improve the API documentation and add, for instance: > > - Only existing keywordLists() can be changed. For non-existent keyword > lists, false is returned. > - @see keywordList(), keywordLists() > >

D23061: Possiblity to change Definition data after loading

sirgienko updated this revision to Diff 63599. sirgienko added a comment. Add test and change the function description REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23061?vs=63492&id=63599 BRANCH read-write REVISION DETAIL https://phabric

Re: KCalendarCore plugins/datasources?

On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > Hello, Hi Bhushan, > > So yesterday I was discussing this with the Volker in #kde-devel, that > currently kcalcore doesn't provide a "plugin interface" to creat

D23029: Fix the attica pkgconfig file.

leinir added a comment. In D23029#510716 , @cgiboudeaux wrote: > Unless someone has objections, I'll push this tomorrow. You seem to have not set any reviewers on this... It seems fine to me, but pkgconfig isn't really my forte :) REPOS

D23029: Fix the attica pkgconfig file.

cgiboudeaux marked an inline comment as done. cgiboudeaux added a comment. Unless someone has objections, I'll push this tomorrow. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D23029 To: cgiboudeaux Cc: fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, brun

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY All QWidget-based API is now deprecated in this module. TEST PLAN

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Just found another bug on the KDE bugzilla related to this: https://bugs.kde.org/show_bug.cgi?id=410357. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, mi

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#505540 , @dfaure wrote: > The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rig

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#505870 , @ngraham wrote:ut I am all ears for inputs. > Right now by default we only show two: "today" and "last month". We should probably keep it at that, at most; my sense is that even these are very infrequentl

Re: Unified git commit message guideline

Hello Roman, On dimanche 11 août 2019 23:52:55 CEST Roman Gilg wrote: > [1] https://www.conventionalcommits.org I like the idea very much, the changelog does look a bit messy indeed. It would allow me to filter out all style, ci, and test changes, which are not interesting to the user of the fra