D22884: [RFC] Don't show title on page by default

mmustac added a comment. I agree that it looks quite strange or at least unusual to me. Find myself always sliding to the left do regonize which topic is selected currently it seems not self explaining and I would miss the header. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://

D22822: Add "users-other" icon

GB_2 added a comment. In D22822#505557 , @ngraham wrote: > - Can we name it `user-others`? No other icon starts with `user`. Sure. > - Do we really need the 24px version? Well, the other user/group icons also have 24px versions,

D22848: Rust: add missing keywords and minor improvements

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22848 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demskin

D22865: remove drawing a black line segment at the end of the plot

ngraham added reviewers: Plasma, mart. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22865 To: miklosm, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22864: use zero-based coordinate system on the plot

ngraham added a comment. Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm Cc: ngraham, kde-frameworks-devel, LeGast00n, sbe

D22822: Add "users-other" icon

ngraham added a comment. Visually, it looks good to me! Two questions about the implementation details though: - Can we name it `user-others`? No other icon starts with `user`. - Do we really need the 24px version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.k

D22763: [KDirOperator] Use more human-readable sort order descriptions

ngraham added a comment. +1 REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: churaev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add expanding spacers as a customization option for toolbars

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4357ef235ecb: Add expanding spacers as a customization option for toolbars (authored by felixernst, committed by ngraham). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

dfaure requested changes to this revision. dfaure added a comment. The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned a

D22798: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH createdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22798 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH createdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22785 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22531: [KColorSchemeManager] Optimize preview generation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH ondemandpreview REVISION DETAIL https://phabricator.kde.org/D22531 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, br

D22544: [RFC] Deprecate KPassivePopup

ngraham added a comment. In D22544#497637 , @aspotashev wrote: > > The case where no notification daemon is running is IMHO an edge case that we don't need to support. > > Disagree here. I believe a lot of people don't use a notification sys

D20026: Go up in folder hierachy when in "edit mode"

ngraham added a comment. No problem, take your time. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22884 To: ngraham, #vdg, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

ngraham created this revision. ngraham added reviewers: VDG, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY KPageWidgetItems live in a multi-page KPageDialog that already shows the current pa

D22653: Add view-barcode-qr icons

lavender added a comment. Functionally it looks good to me, there are a few improvements/optimizations that can be made for example 16 and 22 have unnecessary attributes such as: fill="currentColor" style="fill:currentColor; And the 32 one has a transform that can be applied:

D22827: Scrollview - Don't fill the parent with the view

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e310144eb8e9: Scrollview - Don't fill the parent with the view (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22827?vs=62791&id=62917 R

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added a comment. I will merge this beginning of next week, if no one objects. REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: churaev, kde-frameworks-devel, LeGast00n, sbergeron, mich

D22653: Add view-barcode-qr icons

mbruchert updated this revision to Diff 62915. mbruchert added a comment. remove paint-order REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62913&id=62915 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES

D22653: Add view-barcode-qr icons

mbruchert updated this revision to Diff 62913. mbruchert added a comment. - remove corners REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62761&id=62913 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES i

D22827: Scrollview - Don't fill the parent with the view

mart accepted this revision. REPOSITORY R296 KDeclarative BRANCH scrollview (branched from master) REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart, ngraham Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22827: Scrollview - Don't fill the parent with the view

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This looks like a sane and simpler implementation to me, but let's get @mart's opinion too. REPOSITORY R296 KDeclarative BRANCH scrollview (branched from master) REVISION DETAIL h

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a99c14d1eac9: Consistently use Units.toolTipDelay instead of hardcoded values (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22867?vs=62879&id=

D22365: KNotification macOS native support by NSNotificationCenter

rjvbb added a comment. As I thought this needs some hacking on OS X < 10.10 but a priori all one loses is the user notifications. I'm missing a test case in this diff, i.e. a description how you can test these new notifications because I wouldn't know off the top of my head which applic

D22875: Offer toolTipDelay as a plasma unit

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Keeps the value from being introduced several times, sometimes with a different value. If us

D22061: Add a logging category for logs warnings

meven marked 2 inline comments as done. meven added a comment. I have opted for the file name kconfig_core_log_settings.h for the log settings header file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: cgiboudeaux, mikeroyal,

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 62903. meven added a comment. Rename kconf_desktop_debug.h to more appropriate kconfig_core_log_settings.h, do not run an unnecessary install REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=61897&id=62903 BRANCH

D22724: Add ECMAddQtDesignerPlugin

kossebau added a comment. Seems people so far are fine with this, any comments were rather positive. No changes requested. So unless someone objects, would then proceed to push soon after KF 5.61 has been branched upcoming WE. Scheduling myself for Tuesday, August 6th currently, so ther

D10362: Change reveal password button logic

GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n, sbergeron, jraleig

D22860: introduce FallbackTapHandler

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e634bda6331c: introduce FallbackTapHandler (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22860?vs=62891&id=62894 REVISION DETAIL https:

D22860: introduce FallbackTapHandler

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/fallbacktaphandler REVISION DETAIL https://phabricator.kde.org/D22860 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbe

D22860: introduce FallbackTapHandler

mart updated this revision to Diff 62891. mart added a comment. - get completely rid of acceptedMouse§Buttons REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22860?vs=62890&id=62891 BRANCH phab/fallbacktaphandler REVISION DETAIL https://phabricato

D22860: introduce FallbackTapHandler

davidedmundson added inline comments. INLINE COMMENTS > fallbacktaphandler.cpp:50 > +{ > +setAcceptedMouseButtons(buttons); > +emit acceptedButtonsChanged(); m_buttons = buttons or change the getter for acceptedButtons to call QQuickItem::acceptedMouseButtons REPOSITORY R296 KDeclar

D22860: introduce FallbackTapHandler

mart marked 3 inline comments as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22860 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22860: introduce FallbackTapHandler

mart updated this revision to Diff 62890. mart added a comment. - adress comments REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22860?vs=62868&id=62890 BRANCH phab/fallbacktaphandler REVISION DETAIL https://phabricator.kde.org/D22860 AFFECTED F

D22868: Revamp Kirigami.AboutPage

leinir accepted this revision. leinir added a comment. While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D [1] to someone who's tried to fix that bit befo

D22827: Scrollview - Don't fill the parent with the view

davidre added a comment. So the alternative approach would be something like this: diff --git a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml b/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml index 8ef57a2..443f063 100644 --- a/src/qmlcontrols/kcmcontrols/qml/ScrollView.qml

D22860: introduce FallbackTapHandler

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fallbacktaphandler.cpp:71 > +m_mouseDownItem.clear(); > +m_mouseDownPos = QPointF(); > + You're clearing before doing the tap

D22609: Add expanding spacers as a customization option for toolbars

dfaure added a comment. Agreed. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure, ngraham Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 To: hein, #frameworks, mart Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol,