D22848: Rust: add missing keywords and minor improvements

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** - Add new

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/23/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 31 Jul 2019 03:13:07 + Build duration: 1 hr 0 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xml

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/15/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 31 Jul 2019 03:14:02 + Build duration: 48 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.61.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 155 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/155/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 31 Jul 2019 03:13:07 + Build duration: 37 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 31 Jul 2019 03:13:07 + Build duration: 37 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 31 Jul 2019 03:11:47 + Build duration: 29 min and counting JUnit Tests Name: projectroot.aut

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 31 Jul 2019 03:12:32 + Build duration: 24 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 31 Jul 2019 00:50:04 + Build duration: 1 hr 49 min and counting JUnit Tests Name: proj

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504361 , @pino wrote: > Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, For the record, actually I care more for having docs av

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. I find myself in line with what @aacid said ;) The whole idea of this patch is to plug in api.kde.org back instantly, so everyone working e.g. on apps for which special new API was added to some KDE Frameworks module can see their API dox. Switching the whole

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504394 , @davidre wrote: > In D22836#504355 , @kossebau wrote: > > > That as well, as also discussed on irc today. > > > > Just in case that other scripts on api.k

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

davidre added a comment. @kossebau also wrote In D22836#504355 , @kossebau wrote: > That as well, as also discussed on irc today. > > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504393 , @aacid wrote: > Ok, yep i may have misunderstood :) > > But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :) See my very first comment. REPOSITORY R264 KApi

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid added a comment. Ok, yep i may have misunderstood :) But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau, ochurlaud

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504389 , @aacid wrote: > Pino please take a step back and rethink your position. > Yes, supporting Python2 sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more.

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Pino please take a step back and rethink your position. Yes, supporting Python2 sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more. If

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, and about giving the best impression possible about them (I remember various patches about that in the past). I just don't agree with the "how

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504359 , @kossebau wrote: > In D22836#504358 , @pino wrote: > > > Oh dear, and what about switching the api generation to Python 3 instead? > > > Nobody is stoppe

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504358 , @pino wrote: > Oh dear, and what about switching the api generation to Python 3 instead? Nobody is stopped to work on that. I am not a Python expert, I just providing here the small fix which f

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504357 , @kossebau wrote: > In D22836#504356 , @pino wrote: > > > In D22836#504355 , @kossebau wrote: > > > > > Just in

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504356 , @pino wrote: > In D22836#504355 , @kossebau wrote: > > > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time t

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504355 , @kossebau wrote: > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that, At this point, making Python stuff work with Python3 is priority one.

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504352 , @pino wrote: > Or maybe just drop support for Python 2 entirely? > > - kapidox is rarely used > - Python 2 will be EOL in 5 months > - distros either switched kapidox to Python 3, or will do it

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. Or maybe just drop support for Python 2 entirely? - kapidox is rarely used - Python 2 will be EOL in 5 months - distros either switched kapidox to Python 3, or will do it soon REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D22836 To: ko

D22827: Scrollview - Don't fill the parent with the view

davidre edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: filipf, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau created this revision. kossebau added reviewers: ochurlaud, bshah. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Handling projects where metainfo.yaml are th

D22723: Fix RunnerManager::queryFinished()

davidedmundson added a comment. > Correctly as in "it's supposed to work" yes, but it's not as it was intended to be AFAICT. I've been going over ThreadWeaver. The "decorator" is more of a wrapper, from what I can tell of ThreadWeaver we know the wrapper finishes, we know our wrappe

D22827: Scrollview - Don't fill the parent with the view

filipf added a comment. Also fixes the Virtual Desktops KCM fwiw F7120294: image.png F7120298: image.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, ma

D22365: KNotification macOS native support by NSNotificationCenter

Inoki marked 5 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

Inoki updated this revision to Diff 62797. Inoki added a comment. Add icon from theme as an alternative while pixmap not set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22365?vs=62414&id=62797 REVISION DETAIL https://phabricator.kde.org/D22365 AFFECTED FILES src/CMakeLists.t

D22723: Fix RunnerManager::queryFinished()

apol added a comment. Can someone chim in? because we're in a crazy place where we have a fix for a known bug and we're not moving in any direction. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt, davidedmundson Cc: aacid, kde-fra

D22827: Scrollview - Don't fill the parent with the view

davidre added a comment. An alternative approach could be to set the respective `anchor.*margin` to `view.parent.*padding`. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22827: Scrollview - Don't fill the parent with the view

davidre edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22827: Scrollview - Don't fill the parent with the view

davidre retitled this revision from "Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`." to "Scrollview - Don't fill the parent with the view". davidre edited the summary of this revision. davidre edited the test pl

D22827: Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`.

davidre updated this revision to Diff 62791. davidre added a comment. Commit message REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22827?vs=62790&id=62791 BRANCH scrollview (branched from master) REVISION DETAIL https://phabricator.kde.org/D2282

D22827: Scrollview - Don't fill the parent with the view If the style sets a padding this is not respected if we set `anchors.fill: parent`.

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REPOSITORY R296 KDeclarative BRANCH scrollview (branched from master) REVISION DETAIL https://phabricator.kde.org/D22827 AFFECTED

D22653: Add view-barcode-qr icons

ndavis added a comment. In D22653#504138 , @lavender wrote: > I noticed that only the 22px icons use the viewbox, is this intentional? > > As for the 32px one the validator I used complains that: > > Error: Attri

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 30 Jul 2019 10:54:54 + Build duration: 29 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/64/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 30 Jul 2019 10:44:50 + Build duration: 22 min and counting JUnit Tests Name:

D22653: Add view-barcode-qr icons

lavender added a comment. I noticed that only the 22px icons use the viewbox, is this intentional? The validator I used complains that: Error: Attribute paint-order not allowed on SVG element path at this point. From line 7, column 5; to line 7,

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/12/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 30 Jul 2019 10:54:54 + Build duration: 3 min 24 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Jul 2019 10:54:54 + Build duration: 3 min 29 sec and counting BUILD ARTIFACTS abi-compatibi

D22800: Fix KService build on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R309:99f21c7f7727: Fix KService build on Android (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22800?vs=62709&id=62786 REVISION DETAIL https://p

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22809 To: volkov, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62785. leinir added a comment. - Actually request a downloaditem in NewStuffItem when install/updating REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62049&id=62785 BRANCH knsquick-feature-parity-with-kns (

D22822: Add "users-other" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 407782 Needed to represent permissions for other users. F7118835: users-other Icon.png

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D22809 To: volkov, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:102 > +install(FILES kconf.categories DESTINATION > ${KDE_INSTALL_LOGGINGCATEGORIESDIR}) > +install(FILES kconf.categories DESTINATION ${KDE_INSTALL_CONFDIR}) This line is not useful > CMakeLists.txt:17 > +ecm_qt_declare_log

D22061: Add a logging category for logs warnings

meven added a reviewer: apol. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns