D22763: [KDirOperator] Use more human-readable sort order descriptions

meven updated this revision to Diff 62711. meven added a comment. Capitalize as by https://hig.kde.org/style/writing/capitalization.html REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62628&id=62711 BRANCH arcpatch-D22763 REVISION DETAIL https://

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added a comment. In D22763#503074 , @churaev wrote: > Shouldn't it be "Newest First" instead of "Newest first", to be consistent with other menu items (i.e. "Folders First", etc.)? Now that you mention it, I think so. I took the cod

D22800: Fix KService build on Android

broulik added inline comments. INLINE COMMENTS > kbuildsycoca_main.cpp:26 > #include > +#ifndef __ANDROID__ > #include `Q_OS_ANDROID`? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22800 To: apol, #frameworks, sitter Cc: broulik, kde-frameworks-devel, LeGast00n

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 29 Jul 2019 02:49:40 + Build duration: 53 min and counting JUnit Tests Name: proje

D22800: Fix KService build on Android

apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY DrKonqi isn't working there, so ifdef it out TEST PLAN Built it REPOSITORY R30

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:29 > > +option(BUILD_DESIGNERPLUGIN "Build plugin for Qt Designer" ON) > +add_feature_info(DESIGNERPLUGIN ${BUILD_DESIGNERPLUGIN} "Build plugin for Qt > Designer") Would it make sense to have this option with the macro? This way we

D22789: KZip::openArchive: Don't assert when opening broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22789 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

apol added a comment. +1 LGTM REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau, #build_system, #frameworks Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid, apol Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

RFC: Deprecating KDesignerPlugin in favour of new ECMAddQtDesignerPlugin

Hi, following up on a recent discussion about kdesignerplugin currently providing a single Qt Designer plugin for all of those modules from KDE Frameworks which provide custom QWidgets, and with this coupling running against the idea of mpdularization with KDE Frameworks, a few patches have bee

D22797: Fix typo - GridView -> ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2571616ec547: Fix typo - GridView -> ScrollView (authored by ognarb). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22797?vs=62705&id=62708 REVISION DETAIL

D22797: Fix typo - GridView -> ScrollView

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma, aacid Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Probably the result of a bad copy pasta ;) TEST PLAN Not tested REPOSITORY R296 KDeclarative BRANCH master REVIS

D22798: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to refe

D22797: Fix typo - GridView -> ScrollView

ognarb added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22796: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to refer to

D22795: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having

D22794: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added reviewers: Frameworks, sandsmark. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to r

D22793: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to refer to

D22792: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to refer

D22791: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to re

D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22725 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/63/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 28 Jul 2019 20:05:26 + Build duration: 2 min 45 sec and counting JUnit Tests N

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22785 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Enables the library to provide its own plugin, instead of having to refer to

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. In D22782#503345 , @dfaure wrote: > Yes, I mean all of them. I think it can useful to have such "technical" error messages, obviously not something you'd show the user directly, but maybe in an "advanced" button of

D22789: KZip::openArchive: Don't assert when opening broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's not nice bringing down the application just because the user opens a broken file REPOSITORY R243 KArchive BRANCH

D22784: Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

kossebau retitled this revision from "[WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets" to "Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets". kossebau added a reviewer: Frameworks. REPOSITORY R298 KDesignerPlugin REVISION DETAIL https://phabric

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 62695. meven added a comment. Add comment regarding the origin of a generated cpp file REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=62526&id=62695 BRANCH arcpatch-D22143 REVISION DETAIL htt

D22777: Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau retitled this revision from "[WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin" to "Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin". kossebau edited the summary of this revision. kossebau added a reviewer: Frameworks. REPOSITORY R300 KDEWebKit REVISION DETAIL h

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau retitled this revision from "[WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON" to "Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON". kossebau edited the summary of this revision. kossebau added reviewers: Frameworks, dfaure. REPOSIT

D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau retitled this revision from "[WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON" to "Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON". kossebau edited the summary of this revision. kossebau added reviewers: Frameworks, cfeck. REPOSITO

D22724: Add ECMAddQtDesignerPlugin

kossebau retitled this revision from "[WIP] Add ECMAddQtDesignerPlugin" to "Add ECMAddQtDesignerPlugin". kossebau edited the summary of this revision. kossebau added reviewers: Build System, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 T

D22782: KZip::openArchive: Don't assert when opening broken files

dfaure added a comment. Yes, I mean all of them. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22782 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add expanding spacers as a customization option for toolbars

felixernst added a comment. I kept the names lowercase because I like the visible difference between lowercase separator/spacer and title case actions. I don't mind changing the names to title case though. Judge for yourself: F7109858: Screenshot_20190728_185837.png

D22609: Add expanding spacers as a customization option for toolbars

felixernst updated this revision to Diff 62687. felixernst marked an inline comment as done. felixernst added a comment. Rename to "expanding spacer", Cast to QToolBar instead Remove unrelated comments and documentation REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabri

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY I was wondering if adding this check in KArchive::setRootDir instead but i ended doing it here since i think an assert in

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid added subscribers: apol, dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau updated this revision to Diff 62676. kossebau added a comment. - escape strings to be used as strings in C++ code - use Qt5Core version to decide whether checking only for QtUiPlugin is enough REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/22/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 28 Jul 2019 11:33:00 + Build duration: 23 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xmllog

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, b

D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22785 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R241 KIO BRANCH createdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22785 AFFECTED FILES CMakeLists.t

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 28 Jul 2019 11:33:00 + Build duration: 6 min 57 sec and counting JUnit Tests Name: projectroo

D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

kossebau added dependencies: D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON, D22724: [WIP] Add ECMAddQtDesignerPlugin, D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin. REPOSITORY R298 KDesignerPlugin REVISION DETAIL https://phab

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencr

D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau added a dependent revision: D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets. REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D22777 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau added a dependent revision: D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22725 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Each Frameworks module with widgets generates now an own designer plugin for those, using the new ECMAddQtDesignerPl

D12992: New elisa icon

ndavis added a comment. In D12992#503172 , @KonqiDragon wrote: > In D12992#269399 , @abetts wrote: > > > I think we are trying hard to accommodate and the elements are not lending themselves to turn

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau updated this revision to Diff 62672. kossebau added a comment. - update with new kbusyindivator widget - enable icon for KFontChooser REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22725?vs=62493&id=62672 BRANCH createdesignerplugin RE

D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau abandoned this revision. kossebau added a comment. kelibs4support still sports the `KDEUIMacros.cmale` file, which defines a macro `KDE4_ADD_WIDGET_FILES`, which uses KF5DESIGNERPLUGIN_GENERATOR_EXECUTABLE, so has a runtime dependency on kdesignerplugin with the development files.

D12992: New elisa icon

KonqiDragon added a comment. In D12992#269399 , @abetts wrote: > I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for comm