D22715: Save and load page margins

dhaumann added a comment. I think adding the printer name makes sense. We could go the full road, see: https://stackoverflow.com/a/14979437/2224190 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: ltoscano, aacid, dhaumann, c

D19784: Avoid calling QT_LSTAT and accessing recent documents

meven added a comment. In D19784#503066 , @dfaure wrote: > See KFileItem::isSlow() Interesting but the initial issue happened when a drive is not mounted and isSlow implementation uses statfs that gives information about ... mounted file

D22782: KZip::openArchive: Don't assert when opening broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22782 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in kio_sftp.cpp:383 > sounds like you need to use the *User enums, not the *Owner ones https://www.gnu.org/software/libc/manual/html_node/Permission-Bits.html The link says these bits refer to the owner of the file. Should I still ch

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. I can do that if you prefer but if you look the setErrorString just 8 lines above it's also mega "technical". Want me to change that one too? REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22782 To: aacid, dfaure Cc: dfaure,

D22763: [KDirOperator] Use more human-readable sort order descriptions

churaev added a comment. Shouldn't it be "Newest First" instead of "Newest first", to be consistent with other menu items (i.e. "Folders First", etc.)? REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicol

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure added a comment. See KFileItem::isSlow() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: meven, apol, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, h

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:1992 > Why change this? kdiroperator should definitely be ported to use the new > connect syntax, but it should be done all at once in its own patch, not one > at a time. _k

D22782: KZip::openArchive: Don't assert when opening broken files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I wonder if the end users needs all those technical details. Maybe we should qWarning the technical details, and setErrorString(tr("Invalid ZIP file"))? REPOSITORY R243 KArchive BRANCH

D22780: KZip::openArchive: turn assert into if+return false

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22780 To: aacid, dfaure Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22780: KZip::openArchive: turn assert into if+return false

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22780 To: aacid, dfaure Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau updated this revision to Diff 62654. kossebau added a comment. make use of DEFAULT_ICON_DIR REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22776?vs=62641&id=62654 BRANCH useecmaddqtdesignerplugin REVISION DETAIL https://phabricator.kd

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau updated this revision to Diff 62653. kossebau added a comment. add more options: DEFAULT_HEADER_CASE, DEFAULT_HEADER_EXTENSION, DEFAULT_ICON_DIR REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62642&id=62653 BRANCH addqtdesi

D22782: KZip::openArchive: Don't assert when opening broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's not nice bringing down the application just because the user opens a broken file REPOSITORY R243 KArchive BRANCH

D22780: KZip::openArchive: turn assert into if+return false

aacid updated this revision to Diff 62651. aacid added a comment. better tr string? REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22780?vs=62649&id=62651 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22780 AFFECTED FILES src/kzip.cpp

D22780: KZip::openArchive: turn assert into if+return false

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Asserting just because you opened a broken file is not nice REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D22763: [KDirOperator] Use more human-readable sort order descriptions

ngraham added inline comments. INLINE COMMENTS > kdiroperator.cpp:1992 > +descendingAction->setActionGroup(sortOrderGroup); > +connect(descendingAction, &QAction::triggered, this, [this]() { > +this->d->_k_slotSortReversed(true); Why change this? kdiroperator should definitely be

D22715: Save and load page margins

aacid added a comment. > It seems the QPrinter/QPrintDialog still do not correctly read info from CUPS E_NEEDS_MORE_INFO > neither does it correctly remember print settings This is by design AFAIK, but maybe a patch would be accepted if people would submit one. I'm still not co

D22751: KTar::openArchive: Remove "bad" assert

This revision was automatically updated to reflect the committed changes. Closed by commit R243:70e834050a61: KTar::openArchive: Remove "bad" assert (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22751?vs=62573&id=62647 REVISION DETAIL

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22778: [WIP] Restore option to create a Qt Designer plugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraha

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer updated this revision to Diff 62644. daandemeyer added a comment. Accidentally uploaded the wrong diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22699?vs=62496&id=62644 REVISION DETAIL https://phabricator.kde.org/D22699 AFFECTED FILES modules/ECMQtDeclareLoggi

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michae

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michae

D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R300 KDEWebKit BRANCH useecmaddqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22777 AFFECTED FILES C

D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D22776 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin. REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D22777 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau updated this revision to Diff 62642. kossebau added a comment. - more code comments - fix icon file existance check REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62618&id=62642 BRANCH addqtdesignerplugin REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 27 Jul 2019 12:21:56 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R239 KDELibs4Support BRANCH useecmaddqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22776 AFFECTED FIL

D22775: Allow date range filtering of resource events using Date Term

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Followup after D22717 To be used in D22144 <

D22587: KRun QML proxy: port away from deprecated KRun API

dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D22587 To: dfaure, davidedmundson Cc: #frameworks

D22715: Save and load page margins

ltoscano added subscribers: aacid, ltoscano. ltoscano added a comment. I think @aacid recently (well, some time ago) worked on the Qt printing code and he may at least have an idea of the status of this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: h

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > win32_defaults.notifyrc:90 > +Comment[zh_TW]=程式發生了嚴重錯誤，必須離開 > +Action=Snore > + Can someone please confirm if this file is correctly used? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, br

D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. > QObjects live in their own thread and shouldn't be used outside. > https://doc.qt.io/qt-5/qobject.html#thread > > In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong. Needs a `Qt::QueuedConnecti

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven updated this revision to Diff 62628. meven added a comment. Remove unecessary call REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62612&id=62628 BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 AFFECTED FILES src