D22599: Make first and last name available separately

jbbgameich added reviewers: Plasma: Mobile, apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22599 To: jbbgameich, #plasma:_mobile, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22599: Make first and last name available separately

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY Required for the Plasma Mobile phonebook app where both are separate fields REPOSITORY R307 KPeople BRANCH m

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62159. brute4s99 marked 4 inline comments as done. brute4s99 added a comment. udpated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61972&id=62159 BRANCH arcpatch-D22105 REVISION DETAIL https://phab

D22551: expose new KBusyIndicatorWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R298:92785f974d65: expose new KBusyIndicatorWidget (authored by sitter). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22551?vs=62039&id=62157 REVISION DETAIL

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 20 Jul 2019 22:07:08 + Build duration: 1 min 23 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/7/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 20 Jul 2019 22:01:59 + Build duration: 6 min 44 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 22:02:01 + Build duration: 4 min 26 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/38/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 20 Jul 2019 21:45:27 + Build duration: 21 min and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 22:00:42 + Build duration: 3 min 0 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 21:45:26 + Build duration: 1 min 51 sec and counting CONSOLE OUTPUT [...trunc

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 21:45:26 + Build duration: 2 min 10 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 20 Jul 2019 21:45:27 + Build duration: 1 min 26 sec and counting CONSOLE OUTPUT [...truncated 1

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

This revision was automatically updated to reflect the committed changes. Closed by commit R300:6d14a648156e: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON) (authored by kossebau). REPOSITORY R300 KDEWebKit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D225

D22582: Remove designer plugin generation for KF5WebKit

This revision was automatically updated to reflect the committed changes. Closed by commit R298:729f723f7675: Remove designer plugin generation for KF5WebKit (authored by kossebau). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22582?vs=62115&id=62155

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 21:42:11 + Build duration: 1 min 56 sec and counting JUnit Tests Name: projec

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 144 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/144/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 21:09:49 + Build duration: 24 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xmllo

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 21:12:54 + Build duration: 5 min 31 sec and counting JUnit Tests Name: projec

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 21:09:49 + Build duration: 7 min 10 sec and counting JUnit Tests Name: projectroot

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cullmann added a comment. Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure added a comment. Backported. https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel,

D22567: TypeScript: fix keywords in conditional expressions

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22567 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullma

D22568: Fix generator and test paths of CMake

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b7e23a81a94: Fix generator and test paths of CMake (authored by nibags). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22568?vs=62078&id=62146#toc REPOSITORY R216 Syntax Highlighting CHAN

D22567: TypeScript: fix keywords in conditional expressions

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks! REPOSITORY R216 Syntax Highlighting BRANCH condexp-typescript REVISION DETAIL https://phabricator.kde.org/D22567 To: nibags, #framework_syntax_highligh

D22568: Fix generator and test paths of CMake

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, accident ;=) REPOSITORY R216 Syntax Highlighting BRANCH fix-paths-cmake REVISION DETAIL https://phabricator.kde.org/D22568 To: nibags, #framework_syntax_highlighting, dhaum

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

nxiss7 added a comment. In D22419#498730 , @aacid wrote: > nxisss can we have your real name and email for commit this to the codebase? Enes Selim nxi...@gmail.com REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frame

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. I'm not familiar with KDE release engineering, so I'm asking to do merging someone else. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #f

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

aacid added a comment. nxisss can we have your real name and email for commit this to the codebase? REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22460: DrKonqi: improved lldb integration

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22460 To: rjvbb, kde-frameworks-devel, #plasma, dfaure Cc: plasma-devel, kde-mac, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zre

D22586: KRun QML proxy: fix path/URL confusion

dfaure updated this revision to Diff 62138. dfaure added a comment. You'd think I would remember my own APIs :-) REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22586?vs=62123&id=62138 BRANCH D22586 REVISION DETAIL https://phabricator.kde.org/

D22586: KRun QML proxy: fix path/URL confusion

apol added a comment. LGTM other than that. INLINE COMMENTS > krunproxy.cpp:35 > QMimeDatabase db; > -QMimeType mime = db.mimeTypeForFile(filePath); > -const QString fileMymeType = mime.name(); > +QMimeType mime = db.mimeTypeForFile(fileUrl.isLocalFile() ? > fileUrl.toLocalF

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 143 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/143/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 17:23:06 + Build duration: 17 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xmllog

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

wbauer added a comment. What about the stable 5.16 branch? It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away... REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #fr

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/142/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 17:05:48 + Build duration: 17 min and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.xmllo

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 17:12:12 + Build duration: 5 min 54 sec and counting JUnit Tests Name: projectroot

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

dfaure accepted this revision. REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

nxiss7 updated this revision to Diff 62133. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22419?vs=62067&id=62133 REVISION DETAIL https://phabricator.kde.org/D22419 AFFECTED FILES src/ioslaves/ftp/ftp.cpp To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 17:05:48 + Build duration: 6 min 19 sec and counting JUnit Tests Name: projectroot

D7820: man ioslave: spurious numbers included in clang(1) man page

marten abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller Cc: ltoscano, kde-frameworks-devel, plasma-devel, aprcela, fprice, LeGast00n, sbergeron, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragre

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 141 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/141/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 20 Jul 2019 15:52:28 + Build duration: 9 min 1 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 20 Jul 2019 15:52:27 + Build duration: 7 min 18 sec and counting JUnit Tests Name: projectroot

D18114: FakeInput: add support for pointer move with absolute coordinates

romangg added a comment. @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can have

Re: New framework: KCalCore

El dissabte, 20 de juliol de 2019, a les 12:14:09 CEST, David Faure va escriure: > Hi everyone, > > I just discussed this with Volker IRL and I found a solution to address my > initial concern with the name, the fact that a developer (who's new to all > this) seeing "Cal" might not understand th

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. So it's a bug in the android FTP server? Nice ;-) They should learn from Qt, where QString::toUpper uses the C locale, and one has to use QLocale for locale-aware conversion. Pleas

Re: New framework: KCalCore

On samedi 20 juillet 2019 17:02:40 CEST Alexander Potashev wrote: > сб, 20 июл. 2019 г. в 13:14, David Faure : > > I just discussed this with Volker IRL and I found a solution to address my > > initial concern with the name, the fact that a developer (who's new to all > > this) seeing "Cal" might n

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:721 > +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS) > +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}. Run > ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh to set the environment for > ${CMAKE_PROJECT_NAME}.") > +endif() 'NOTI

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:6d86fd453417: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with… (authored by arrowd). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kd

Re: New framework: KCalCore

сб, 20 июл. 2019 г. в 13:14, David Faure : > I just discussed this with Volker IRL and I found a solution to address my > initial concern with the name, the fact that a developer (who's new to all > this) seeing "Cal" might not understand this as meaning Calendar. > At the same time, KCalendar is u

D22587: KRun QML proxy: port away from deprecated KRun API

dfaure created this revision. dfaure added a reviewer: davidedmundson. dfaure requested review of this revision. REVISION SUMMARY We want runApplication() instead of runService(), and there's already a method doing that in this class --- confusingly named openService() TEST PLAN Builds. N

D22586: KRun QML proxy: fix path/URL confusion

dfaure created this revision. dfaure added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY I'm assuming the QString argument is always a complet

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R300 KDEWebKit BRANCH adddesignerpluginbuild REVISION DETAIL https://phabricator.kde.org/D22581 To: kossebau, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22582: Remove designer plugin generation for KF5WebKit

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH removewebkit REVISION DETAIL https://phabricator.kde.org/D22582 To: kossebau, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off)

kossebau updated this revision to Diff 62118. kossebau added a comment. Comparing with kdelibs4support, there the designer plugin is always build, so defaulting BUILD_DESIGNERPLUGIN=ON feels more consistent REPOSITORY R300 KDEWebKit CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

kossebau retitled this revision from "Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off)" to "Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)". kossebau edited the test plan for this revision. REPOSITORY R300 KDEWebKit REVISION DETAIL https:

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

nxiss7 retitled this revision from "Fix can't enter directory error on Android FTP servers with Turkish locale" to "Fix can't enter directory error on some FTP servers with Turkish locale". REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-fra

Re: kdewebkit tarball gone missing?!

Am Samstag, 20. Juli 2019, 15:00:45 CEST schrieb Friedrich W. H. Kossebau: > As immediate solution for kdewebkit though, given it is tier 3, using > KF5DesignerPlugin as another (optional) dep should be fine though, will see > to prepare a related patches this WE. First versions up: https://phabri

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off)

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Being a "Porting Aids", the KF tier3 kdesignerplugin can no longer do the service of providing such a plugin, as thi

D22582: Remove designer plugin generation for KF5WebKit

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY KF5WebKit has been tagged as "Porting Aids", so as normal KF tier3 oroduct kdesignerplugin shall no longer depend on

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. Hi Marco, Patch works like a charm in standard config dialogs. As a somewhat off topic remark though, it does not work in kcmultidialog (in framework kcmutils), even though it derives from kpageddialog. This shows up for instance in the "window manager

D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0fb0e618bb0c: Re-map default "Switch input mode" shortcut to not confict with konsolepart (authored by ngraham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22

D22419: Fix can't enter directory error on Android FTP servers with Turkish locale

nxiss7 retitled this revision from "Fix cant enter directory error on Android FTP servers" to "Fix can't enter directory error on Android FTP servers with Turkish locale". REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-frameworks-devel, LeG

Re: kdewebkit tarball gone missing?!

Am Samstag, 20. Juli 2019, 08:19:24 CEST schrieb Volker Krause: > On Friday, 19 July 2019 16:03:34 CEST Friedrich W. H. Kossebau wrote: > > Am Freitag, 19. Juli 2019, 09:05:39 CEST schrieb Volker Krause: > > > Even independent of the dependency rules, webkit support in the designer > > > plugin is

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

albertvaka accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sber

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol updated this revision to Diff 62110. apol added a comment. Improve wording REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22580?vs=62108&id=62110 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 AFFECTED FILES kde-m

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

albertvaka added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:721 > +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS) > +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}, remember set the > environment. See ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh") > +endif() Installing in `${CMAKE_INSTAL

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's especially when KDE_INSTALL_USE_QT_SYS_PATHS=OFF that the

D22105: WIP : Fix SFTP Plugin of KIO for Windows

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1946 > // check if destination is ok ... > QT_STATBUF buff; > +QFileInfo copyFile(sCopyFile); Please remove this variable, since yo

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, I'm wrong (not the first time this happens) :-) `kwrite /home/dfaure/.zshrc:20` works `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed. The patch looks fine

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure added a subscriber: kwrite-devel. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesj

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#498393 , @dfaure wrote: > I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. > So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have

Re: New framework: KCalCore

Hi everyone, I just discussed this with Volker IRL and I found a solution to address my initial concern with the name, the fact that a developer (who's new to all this) seeing "Cal" might not understand this as meaning Calendar. At the same time, KCalendar is unclear (does it display a calendar?

D17595: Upstream Dolphin's file rename dialog

dfaure added inline comments. INLINE COMMENTS > renamefiledialog.cpp:59 > +KFileItemList items; > +bool allExtensionsDifferent; > +QSpinBox* spinBox; group the bools together for less padding > meven wrote in renamefiledialog.cpp:60 > I really wish we would enforce use of a code for

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries h

D22577: Remove unused pnm.desktop file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D22577 To: rempt, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22577: Remove unused pnm.desktop file

rempt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rempt requested review of this revision. REVISION SUMMARY Looks like this file isn't used, so let's remove it. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator

D22551: expose new KBusyIndicatorWidget

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH master REVISION DETAIL https://phabricator.kde.org/D22551 To: sitter, alexmerry, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D17500: Get mobipocket extractor up-to-date, but keep disabled

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:7b9cb48d95e4: Get mobipocket extractor up-to-date, but keep disabled (authored by astippich). CHANGED PRIOR TO COMMIT

D21002: Remove kde4 migration agent completely

lbeltrame closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

lbeltrame added a comment. Should be fixed with ff6b077d9200856dc6e393a04c6b3ae82d9792ed . REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid

D21002: Remove kde4 migration agent completely

lbeltrame reopened this revision. lbeltrame added a comment. This revision is now accepted and ready to land. This breaks GPG wallets completely. They are no longer accounted for by kwalletd: reverting this change makes them work again. REPOSITORY R311 KWallet REVISION DETAIL https://pha