This revision was automatically updated to reflect the committed changes.
Closed by commit R309:93107a9532e9: Allow KAutostart to be constructed using an
absolute path (authored by apol).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22387?vs=61535&id=61559
apol added a dependent revision: D22390: ksmserver/autostart: remove
qstandardpaths queries.
REPOSITORY
R309 KService
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22387
To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/2/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Thu, 11 Jul 2019 02:17:05 +
Build duration:
2 min 19 sec and counting
JUnit Tests
Name: projec
ltoscano added a comment.
Apologize for the long delay - I can't reproduce the issue with the current
master. The mentioned structure of the clang man page seems to be the same
(clang 8).
Adding @mkoller too.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D7
ltoscano added a reviewer: mkoller.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D7820
To: marten, #plasma, kfm-devel, mkoller
Cc: kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh,
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh
ltoscano added a comment.
Apologize for the long delay. It looks like that the fix still applies and
works according the comment.
I added @mkoller, the historical maintainer of kio-man, who can probably
validate the change better than me, but let's try to push this for the upcoming
KDE
ltoscano added a reviewer: mkoller.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D9033
To: marten, #plasma, kfm-devel, mkoller
Cc: kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, jraleigh,
gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, m
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22387
To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ngraham added reviewers: bruns, Plasma.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D21760
To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
apol retitled this revision from "Allow the instance to be constructed using an
absolute path" to "Allow KAutostart to be constructed using an absolute path".
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D22387
To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00
kossebau added inline comments.
INLINE COMMENTS
> kbusyindicatorwidget.h:40
> + * is more specific.
> + */
> +class KWIDGETSADDONS_EXPORT KBusyIndicatorWidget : public QWidget
Any chance of getting some samples how this class is supposed to be used?
Sounds one should show & hide the complete wi
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
If we already have found the service we need to autostart, it's a waste
to strip the full
cfeck resigned from this revision.
cfeck added a comment.
You wrote "ported from Device Notifier". I haven't check in detail yet, but
do other copyright holders need to be mentioned?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D21760
To: hallas, davidedmundso
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/7/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Wed, 10 Jul 2019 17:27:29 +
Build duration:
10 min and counting
BUILD ARTIFACTS
abi-compatib
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/130/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Wed, 10 Jul 2019 17:27:30 +
Build duration:
7 min 57 sec and counting
BUILD ARTIFACTS
abi-
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/3/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Wed, 10 Jul 2019 17:27:29 +
Build duration:
4 min 7 sec and counting
JUnit Tests
Name:
JJRcop added a comment.
After some quick research I should have done a while ago, I have determined
that KFormat is not nearly the same as what KUnitConversion does.
KFormat can take an input number and output a string with the input formatted
properly to the desired unit.
KUnitConv
JJRcop updated this revision to Diff 61526.
JJRcop added a comment.
Update version number to 5.60
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20181?vs=59308&id=61526
REVISION DETAIL
https://phabricator.kde.org/D20181
AFFECTED FILES
README.m
davidedmundson added a comment.
As some background:
At a recent Plasma sprint, one comment was that adding protocols to KWayland
was an absolute pain involving writing a tonne of boiler plate. My experience
adding a protocol to Qt was relatively painless.
We said we'd try on a reall
sitter updated this revision to Diff 61522.
sitter marked 14 inline comments as done.
sitter added a comment.
- running property gone since we have no use case + simplified code since we
no longer account for it
- dropped superfluous virtual keywords
- bumped duration to 1.5s
- moved to
apol abandoned this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D22235
To: apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
cfeck added inline comments.
INLINE COMMENTS
> sitter wrote in kbusyindicatorwidget.h:48
> Mimics the QML API, haven't given it any thought TBH. You can have the
> spinner visible but paused, I am not sure why exactly you'd want a paused
> spinner but that's what the property does anyway.
>
>
sitter added inline comments.
INLINE COMMENTS
> broulik wrote in kbusyindicatorwidget.cpp:111
> How about `PM_LargeIconSize`
Oh, that would work!
> cfeck wrote in kbusyindicatorwidget.h:48
> Why is this property needed? If the (parent) widget is no longer busy, this
> spinner needs to be hidde
cfeck added inline comments.
INLINE COMMENTS
> kbusyindicatorwidget.h:48
> + */
> +Q_PROPERTY(bool running READ running WRITE setRunning NOTIFY
> runningChanged)
> +public:
Why is this property needed? If the (parent) widget is no longer busy, this
spinner needs to be hidden anyway.
R
cfeck added a comment.
Ideally you can create it with any size as an overlay to an existing widgets
(also to block input there), but the spinner itself is only rendered at a
smaller centered position.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D22375
To:
broulik added inline comments.
INLINE COMMENTS
> sitter wrote in kbusyindicatorwidget.cpp:111
> I was thinking about it, and honestly I am not sure. I don't think we have
> access to anything to do with icon units, so we could hardcode some
> dimensions (22,22 I guess) but that's about it.
How
sitter added inline comments.
INLINE COMMENTS
> broulik wrote in kbusyindicatorwidget.cpp:111
> Does this widget need a `sizeHint` of a button or default icon size or
> something?
I was thinking about it, and honestly I am not sure. I don't think we have
access to anything to do with icon unit
broulik added a comment.
Cool!
INLINE COMMENTS
> kbusyindicatorwidget.cpp:28
> +
> +class KBusyIndicatorWidget::Private : public QObject
> +{
`Q_DECL_HIDDEN`
> kbusyindicatorwidget.cpp:31
> +Q_OBJECT
> +Q_PROPERTY(qreal rotation MEMBER rotation WRITE setRotation)
> +public:
You
sitter created this revision.
sitter added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
this mimics QQC's BusyIndicator and more specifically our styling of it.
KBIW loads a
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:c450f09e8921: Simplify previous-/nextActivity code in
kactivities-cli (authored by muesli).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22370?vs=61499&id=61502
leinir updated this revision to Diff 61500.
leinir added a comment.
- Add a downloaditemssheet to the entry details page
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21721?vs=61341&id=61500
BRANCH
knsquick-feature-parity-with-kns (branched from maste
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.13/4/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Wed, 10 Jul 2019 10:37:29 +
Build duration:
3 min 24 sec and counting
BUILD ARTIFACTS
abi
apol accepted this revision.
REPOSITORY
R6 KActivities
BRANCH
kactivities-cli-simplify (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22370
To: muesli, ivan, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R6 KActivities
BRANCH
kactivities-cli-simplify (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22370
To: muesli, ivan, davidedmundson
Cc: kde-frameworks-devel, LeGast00n,
muesli added a reviewer: ivan.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D22370
To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
muesli created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
muesli requested review of this revision.
REVISION SUMMARY
Removed unnecessary bool found and directly return from inner loop.
REPOSITORY
R6 KActivities
BRANCH
kactivities-cli
Inoki created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Inoki requested review of this revision.
REVISION SUMMARY
Add macOS native support to KNotification
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D
37 matches
Mail list logo
