D22362: Port keystates to use QtWayland's generator

apol added a comment. As discussed in the Plasma sprint. Removes some boilerplate code and turns it into C++ overrides. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 61478. apol added a comment. --debug REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61477&id=61478 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES CMakeLists.txt src/cli

D22362: Port keystates to use QtWayland's generator

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Saves us some of the boilerplate code TEST PLAN The plasmoid still works REPOSITORY R127 KW

D22340: Update cmake highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:61f3846b0fe4: Update cmake highlighting (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22340?vs=61409&id=61455 REVISION DETAIL

D22340: Update cmake highlighting

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, dom

D22340: Update cmake highlighting

dhaumann retitled this revision from "cmake: bring some missed features" to "Update cmake highlighting". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting Cc: ngraham, kwrite-devel, kde-frameworks-devel,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1939 > QT_STATBUF buff; > const bool bDestExists = (QT_STAT(QFile::encodeName(sCopyFile), &buff) > != -1); > +QFileInfo info(sCopyF

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. looks good REPOSITORY R320 KIO Extras BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: and

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth added a comment. I think you need to ```set(CMAKE_CXX_STANDARD 17)``` to make this compile with mingw REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.13 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.13/3/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 09 Jul 2019 17:27:46 + Build duration: 4 min 36 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Jul 2019 17:27:46 + Build duration: 3 min 47 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 09 Jul 2019 17:27:46 + Build duration: 2 min 47 sec and counting JUnit Tests Name: projec

D22346: Should we install bluezqt_dbustypes.h?

drosca added a comment. Sorry, that slipped in the review. Fixed now: https://cgit.kde.org/bluez-qt.git/commit/?id=185e2c70331f08c61cc6903336eaf25a5193e352 REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22346 To: joselema, drosca, mweichselbaumer Cc: rikmills,

D22346: Should we install bluezqt_dbustypes.h?

rikmills added a comment. > We detected this thing because we have a test in our packaging which checks if the installed headers can be built and fails if they are missing bits. I ran the test in question with the attached patch and it doesn't fail. The KDE CI has the acc test as well:

D22346: Should we install bluezqt_dbustypes.h?

joselema created this revision. joselema added reviewers: drosca, mweichselbaumer. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. joselema requested review of this revision. REVISION SUMMARY Hi, while doing packaging work on bluez-qt for Kubuntu, we det

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > Yes. It is neither related to Windows nor audio. What you can to is to add > Windows to the condition to not look for DBus on Windows, but please do that > in a separate patch. Or move the find call for

D21660: change audio dep logic wrt win32

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGa

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61422. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61421&id=61422 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

nicolasfella added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > I was trying to simplify code there by removing `NOT`. Should I remove this > change? Yes. It is neither related to Windows nor audio. What you can to is to add Windows to the condition to not look for

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > This seems to be entirely urelated to audio? I was trying to simplify code there by removing `NOT`. Should I remove this change? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.

D21660: change audio dep logic wrt win32

brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61421. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59551&id=61421 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This needs rebasing since I recently changed the audio logic for Android INLINE COMMENTS > CMakeLists.txt:38 > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED

D22317: Fix type names casing

apol added a comment. In D22317#492656 , @vatra wrote: > Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake We could consider it. Our toolchain pred

D21660: change audio dep logic wrt win32

brute4s99 added a comment. may I land this? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > kio_sftp.cpp:29 > #include > -#include > this builds without `utime.h` on my system (Arch Linux with latest Plasma, Qt and other packages), . Please inform if someone else has issues without this header. REPOSITORY R320 KIO Extras REV

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61419. brute4s99 added a comment. Updated with `QT_` pre-procs for S_IFDIR, S_IFLNK and others. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61225&id=61419 BRANCH arcpatch-D22105 REVISION DETAIL ht

D22340: cmake: bring some missed features

turbov retitled this revision from "Bring some missed features" to "cmake: bring some missed features". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting Cc: ngraham, kwrite-devel, kde-frameworks-devel, L

D22340: Bring some missed features

ngraham added a comment. Thanks for the patch! Can you change the title to be more specific about the fact that this is for CMake? The title becomes the commit message, so it's important that it be descriptive. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch R

D22340: Bring some missed features

turbov created this revision. turbov added reviewers: Kate, Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REVISION SUMMARY - handle `CMAKE_ARGVn` properly - add so

D22339: Make sure solid backends are reentrant

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Solid will create different backends for each separate thread but then some backends will

D22083: introduce concept of header and footer for kpageview

ngraham added a comment. Yep, I think so. I'd like to get the extra margins removed as well, but this is a good incremental step, and given how D22138 already landed, I think it's better to have this in. REPOSITORY R236 KWidgetsAddons REVISION DET

D20838: Allow to drop one file or one folder on KDirOperator

dfaure added a comment. Strange, I'm pretty sure I was able to reproduce it locally before I wrote my comment here. But now I can't anymore. OK, to be further investigated when either of us have time. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngr

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#491992 , @dfaure wrote: > The test fails in CI, please check. > > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests

D22083: introduce concept of header and footer for kpageview

mart added a comment. can this part go forward? I think ui-wise looks fine even if the other parts won't make it for release? (still hope they will tough :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg Cc: hper