brute4s99 marked an inline comment as done.
brute4s99 added inline comments.
INLINE COMMENTS
> vonreth wrote in kio_sftp.cpp:402
> What about the QFileInfo?
For my use case, I could not find any possibility of symlinks, (traversing
Android filesystem) so I left it blank in here for any future d
nibags added a comment.
> Is there any progress with the licensing?
> Otherwise I assume LGPL would be good enough, if a change isn't possible.
Sorry, I forgot to ask the authors (Franchin Matteo & Janus Weil) about the
license change to MIT. Now I send an email to them asking. When I
apol added a comment.
Big +1.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D22216
To: zzag, #kwin, #frameworks
Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh,
ngraham, bruns
romangg added a comment.
Makes sense to me. Why was it done differently until now?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D22216
To: zzag, #kwin, #frameworks
Cc: romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham,
bruns
Please lets keep in mind that this is not a thread to complain about
Gitlab. No platform is perfect, and we're not yet on production machines.
This thread is about how to make our review process great for both newbies
and experienced developers, *and reviewers* - on Gitlab.
On Sun, Jun 30, 2019 a
nononux added a comment.
Ok, I'll retry after the merge and propose a change to the test file too.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21713
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: nononux, kwrite-devel, kde-framewor
cullmann added a comment.
Hi,
I would propose that we first merge this as is and then start to improve.
For your wanted additions, could you then add matching parts to the test
highlighting file that show the improvements (or are there already parts inside
that will change)?
REPOSITOR
nononux added a comment.
Hi, thanks for the patch. I suggest additionnal changes to improve the syntax
highlighting for Fortran fixed format.
I write fixed format fortran at least once a week using Kate. I can confirm
these modifications will be usefull at least for me ;)
I tested the
brute4s99 added inline comments.
INLINE COMMENTS
> vonreth wrote in CMakeLists.txt:12
> What requires this bump?
ah, I thought QFileDevice needs it. Reverting this.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D22105
To: brute4s99, albertvaka, vonreth, sredman, s
brute4s99 updated this revision to Diff 61035.
brute4s99 marked 6 inline comments as done.
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22105?vs=60701&id=61035
BRANCH
arcpatch-D22105
REVISION DETAIL
https://phabricator.kde.org/D22105
AFFECTED FILES
brute4s99 abandoned this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D1
To: brute4s99
Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde,
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham,
andrebarros, brun
brute4s99 created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
brute4s99 requested review of this revision.
REPOSITORY
R320 KIO Extras
BRANCH
arcpatch-D22105
REVISION DETAIL
https://phabricator.kde.org/D1
AFFECTE
zzag added a reviewer: Frameworks.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D22216
To: zzag, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
zzag added a comment.
> find_package(WaylandProtocols 1.15)
because xdg-decoration was introduced in 1.15.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D22216
To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.
REVISION SUMMARY
So far we've been copying protocol specifications from wayland-protocols
repo to kwayland repo.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6c692309edf7: Better use of Qt APIs in Plasma::Theme
(authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22147?vs=60932&id=61009
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/122/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Tue, 02 Jul 2019 14:47:17 +
Build duration:
8 min 58 sec and counting
BUILD ARTIFACTS
abi-
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/129/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Tue, 02 Jul 2019 14:47:17 +
Build duration:
5 min 43 sec and counting
BUILD ARTIFACTS
abi-
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/132/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 02 Jul 2019 14:47:17 +
Build duration:
4 min 29 sec and counting
JUnit Tests
Na
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D22147
REVISION DETAIL
https://phabricator.kde.org/D22147
To: apol, #plasma, #frameworks, mart
Cc: bruns, tcanabrava, fvogt, broulik, kde-frameworks-dev
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/132/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Tue, 02 Jul 2019 13:20:46 +
Build duration:
10 min and counting
BUILD ARTIFACTS
acc/KF5KIO-5.60.0.xmllo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/142/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 02 Jul 2019 13:20:46 +
Build duration:
8 min 45 sec and counting
JUnit Tests
Name: projectro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/142/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Tue, 02 Jul 2019 13:20:47 +
Build duration:
6 min 35 sec and counting
BUILD ARTIFACTS
acc/KF5KIO-5.60.0
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a6d24222fdc1: [CopyJob] Batch reporting processed amount
(authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21882?vs=60022&id=61005
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0532047f8b97: [CopyJob] Report results after finishing
copy (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19585?vs=53345&id=61004
REVISION DETA
cullmann added a comment.
Is there any progress with the licensing?
Otherwise I assume LGPL would be good enough, if a change isn't possible.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21713
To: nibags, #framework_syntax_highlighting, dhaumann, cul
26 matches
Mail list logo
