KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 30 Jun 2019 06:45:35 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 30 Jun 2019 06:45:35 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS abi-compa

D22157: Use debugging category in taglib extractor/writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ce0b873f1888: Use debugging category in taglib extractor/writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22157?vs=60844&id=6085

D21586: Add syntax definition for ninja build

jpoelen added a comment. After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann

D22155: Add new activities and virtual desktops icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm accepting this, but make sure you don't land this until you've submitted the other patches. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branc

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488192 , @ndavis wrote: > Nice job! > > Are there other patches coming soon to fix the code where `preferences-activities` was used? Yeah, I'll make them soon. REPOSITORY R266 Breeze Icons REVISION

D21563: Fix empty pages in print preview and lines printed twice

dhaumann closed this revision. dhaumann added a comment. Fixed for KF 5.60 with commit 6bbbe6aa51c0a293a58dbca6223e37a73ce32122, thanks for the patch - keep it coming! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I just tested kwrite from master with Qt 5.12.0, and printing was completely broken. It even printed on Letter even though I specified A4 paper. A Qt update to Qt 5.12.3 fixed this - go

D22156: RFC: Add wayland-protocols find module

zzag abandoned this revision. zzag added a comment. In D22156#488219 , @cgiboudeaux wrote: > how many users are there? Hmm, at this moment none. KWayland would be the primary user (and perhaps the only one). Perhaps ECM is not good place

D22157: Use debugging category in taglib extractor/writer

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_logging REVISION DETAIL https://phabricator.kde.org/D22157 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, mic

D22156: RFC: Add wayland-protocols find module

cgiboudeaux added a comment. how many users are there? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22156 To: zzag, #kwin, #frameworks Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D22157: Use debugging category in taglib extractor/writer

astippich updated this revision to Diff 60844. astippich added a comment. - adjust writer cmake REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22157?vs=60843&id=60844 BRANCH taglib_logging REVISION DETAIL https://phabricator.kde.org/D22157 AFFE

D22157: Use debugging category in taglib extractor/writer

astippich updated this revision to Diff 60843. astippich added a comment. - use separate debug src REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22157?vs=60838&id=60843 BRANCH taglib_logging REVISION DETAIL https://phabricator.kde.org/D22157 A

D20526: Fix extracting of some properties to match what was written

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:356 > is this always just one value, or a list as well? as far as I know, asf only allows single entry tags, so just a single value REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.or

D20526: Fix extracting of some properties to match what was written

astippich updated this revision to Diff 60842. astippich marked an inline comment as done. astippich added a comment. - add trimmed(), adjust test - fileExtension REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=60334&id=60842 BRANCH arcpa

D22156: RFC: Add wayland-protocols find module

apol added a comment. LGTM +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22156 To: zzag, #kwin, #frameworks Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

ndavis added a comment. Nice job! Are there other patches coming soon to fix the code where `preferences-activities` was used? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh,

D22147: Better use of Qt APIs in Plasma::Theme

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in theme.cpp:106 > Can we clean up all of this custom refcounting by using a `QSharedPointer`? Implemented with QSharedData. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https:/

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60840. apol marked an inline comment as done. apol added a comment. Address kai's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60802&id=60840 BRANCH master REVISION DETAIL https

D22157: Use debugging category in taglib extractor/writer

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:136 > kde_enable_exceptions() > -ecm_add_test(taglibextractortest.cpp > ../src/extractors/taglibextractor.cpp > +ecm_add_test(taglibextractortest.cpp > ../src/extractors/taglibextractor.cpp ../src/kfilemetadata_debug.cpp

D20526: Fix extracting of some properties to match what was written

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:556 > + > +data.add(Property::Artist, QStringLiteral("Artist1 feat Artist2")); > +data.add(Property::AlbumArtist, QStringLiteral("Artist1 feat. Artist2")); const map properties = { {Artist, "Artist", ...}; for (propert

D22157: Use debugging category in taglib extractor/writer

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_logging REVISION DETAIL https://phab

D20526: Fix extracting of some properties to match what was written

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D22156: RFC: Add wayland-protocols find module

zzag retitled this revision from "Add wayland-protocols find module" to "RFC: Add wayland-protocols find module". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22156 To: zzag, #kwin, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencrea

D22156: Add wayland-protocols find module

zzag created this revision. zzag added reviewers: KWin, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This module can be used to retrieve path of a directory w

D22155: Add new activities and virtual desktops icons

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds new monochrome icons corresponding to the colorful ones. Also deletes the old monochrom

D21204: Ensure no trailing slash in mountpoint read from fstab file.

anthonyfieroni added inline comments. INLINE COMMENTS > fstabhandling.cpp:231 > +// it will match its eventual mounted device regardless whether or not > it ends with a slash > +for (QString device : fstabDevices) { > +QString deviceName = device; get it by const ref. > fstabha

D10747: Implement zwp_linux_dmabuf_v1

zzag added a comment. > Update protocol xml to wayland-protocols master OT: there's a package called wayland-protocols. We could use it in order to avoid copying protocol specs. name=FindWaylandProtocols.cmake #.rst: # FindWaylandProtocols # --- # # Try to fin

D20766: Use appropriate background color for text previews

meven added a comment. For context : F6943088: Screenshot_20190629_110927.png Given D21295 , can we move forward here ? REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: dh

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven added a comment. ping @bruns REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D13048 REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, fi

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales,

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:21 > Instead of relying on an undocumented cpp file name generated by > ecm_qt_declare_logging_category, you rather want to have a separate SRC > variable which carries the source files generated by the macro, and