D17241: WIP:Disable highlighting after 512 characters on a line.

2019-06-17 Thread Christoph Cullmann
cullmann added a comment. Hmm, would a partially highlighted line really preferable? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, d

Re: KInit - Current state and benchmarks

2019-06-17 Thread Albert Astals Cid
El dilluns, 17 de juny de 2019, a les 11:56:15 CEST, David Edmundson va escriure: > Results: > (Showing the median out of 5 runs on a mid range SSD desktop) Are we sure it's fair to assume people have SSD? our of the 4 laptops i own, only 2 have SSD. Do you think it's worth me trying in one of

D17241: WIP:Disable highlighting after 512 characters on a line.

2019-06-17 Thread Milian Wolff
mwolff added a comment. I personally dislike this too. INLINE COMMENTS > katerenderer.cpp:408 > +auto ¤tRange = renderRanges.pushNewRange(); > for (int i = 0; i < al.count(); ++i) > if (al[i].length > 0 && al[i].attributeValue > 0) { couldn't the al.count be lim

Re: KInit - Current state and benchmarks

2019-06-17 Thread David Edmundson
> Which libraries are covered by this mechanism nowadays? The impact is of > course bigger the more of the dependencies of the applications are already > loaded. When this was developed this was a small amount of relatively large Qt > and kdelibs libraries. I'm wondering if the current subset is st

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-06-17 Thread Volker Krause
vkrause added a comment. In D19996#480571 , @kossebau wrote: > Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I completely agree that this is a rather hacky approach. IMHO the challenge here is f

Re: KInit - Current state and benchmarks

2019-06-17 Thread Volker Krause
Thanks for the very interesting and useful research! On Monday, 17 June 2019 11:56:15 CEST David Edmundson wrote: > From API.kde.org: > >Using kdeinit to launch KDE applications makes starting a typical KDE > >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) > Certainly sounds

D21813: RFC: Consider adding more padding to the desktop theme

2019-06-17 Thread Filip Fila
filipf added a comment. In D21813#481152 , @martinsotirov wrote: > I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like m

Re: KInit - Current state and benchmarks

2019-06-17 Thread Christoph Cullmann
Hi, On 2019-06-17 11:56, David Edmundson wrote: From API.kde.org: Using kdeinit to launch KDE applications makes starting a typical KDE applications 2.5 times faster (100ms instead of 250ms on a P-III 500) Certainly sounds like a good thing. ===The current State=== ==Plasma== * Apps launche

D21813: RFC: Consider adding more padding to the desktop theme

2019-06-17 Thread Martin Sotirov
martinsotirov added a comment. I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like more cramped UIs. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL htt

KInit - Current state and benchmarks

2019-06-17 Thread David Edmundson
>From API.kde.org: >Using kdeinit to launch KDE applications makes starting a typical KDE >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) Certainly sounds like a good thing. ===The current State=== ==Plasma== * Apps launched from the plasma menu skip klauncher and therefo

D21813: RFC: Consider adding more padding to the desktop theme

2019-06-17 Thread Andres Betts
abetts added a comment. +1 on visuals! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns