D21002: Remove kde4 migration agent completely

lbeltrame added a comment. +1 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns added a comment. Ping! REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D20967: [UserMetaData] Add method to query which attributes are set

bruns added subscribers: Windows, FreeBSD. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraha

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21002: Remove kde4 migration agent completely

bruns added a comment. Ping! REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

bruns added a reviewer: ngraham. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

bruns edited the summary of this revision. bruns added a dependency: D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21708 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-dev

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns added a dependent revision: D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhniko

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When the 'delete' flag is set, the file was removed from th

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The ModifiedFileIndexer updates the timestamps, which has t

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns added a dependent revision: D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY After modifying a files attributes (like ownership, permiss

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile is quite expensive (much more than QFileInf

D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile yields the wrong type for folders, hardcode

D21704: [FirstRunIndexer] Use correct mimetype for folders

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile yields an incorrect mimetype for folders, j

D21703: [Transaction] Replace template for functor with std::function

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The callback parameter has a specific type, it accepts a do

D21661: add snoretoast backend for KNotifications on Windows

nicolasfella added inline comments. INLINE COMMENTS > knotificationmanager.cpp:140 > if (action == QLatin1String("Popup")) { > -#ifndef Q_OS_ANDROID > -if (d->portalDBusServiceExists) { > -plugin = new NotifyByPortal(this); > -} else { > -

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > albertvaka wrote in notifybysnore.h:45 > Isn't LibSnore abstracting this? Why do we need to call the exe instead of > using some method in LibSnore? Libsnore is something different, yes its an abstract "notification framework" but ... its basica

D21698: Move invariant IndexingLevel out of the loop

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The IndexingLevel is constant, no need to fetch it on each

D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY typesForMimeType("inode/directory") returns an empty list,

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. Yes i know you've mentioned it earlier. In my opinion, that someone is doing things wrong is not a reason to not try to aim and do things better. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma,

D21661: add snoretoast backend for KNotifications on Windows

albertvaka added inline comments. INLINE COMMENTS > notifybysnore.h:45 > +QMap> m_notifications; > +QString program = QStringLiteral("SnoreToast.exe"); > +QLocalServer *server; Isn't LibSnore abstracting this? Why do we need to call the exe instead of using some method in LibSnore?

D21695: Add FindTaglib.cmake

heikobecker added a comment. I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked

D21695: Add FindTaglib.cmake

heikobecker created this revision. heikobecker added reviewers: kde-buildsystem, kde-frameworks-devel. Herald added projects: Frameworks, Build System. heikobecker requested review of this revision. REVISION SUMMARY The old one from KDELibs4 times is used by several projects from Frameworks, K

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns retitled this revision from "[DocuementUrlDB] Avoid manipulation of the whole tree on trivial rename" to "[DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, asti

D21693: [DocumentUrlDB] Catch invalid URLs early

bruns updated this revision to Diff 59451. bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns added a comment. split replace into private helper and wrapper REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21693?vs=59

D21692: [DocumentUrlDB] Remove unused 'rename' method

bruns added a comment. In D21692#476804 , @shubham wrote: > Does this function had any use when it was first implemented? Or may it come to use later? Its last use was removed with commit 23f9a65c215b068dc87dddf7e81a74415d5cfb10

D21692: [DocumentUrlDB] Remove unused 'rename' method

shubham added a comment. Does this function had any use when it was first implemented? Or may it come to use later? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21692 To: bruns, #baloo, ngraham, astippich, poboiko Cc: shubham, kde-frameworks-devel, LeGast00n, domso

D21694: [DocuementUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a file or folder is renamed, only the "name" in the

D21693: [DocumentUrlDB] Catch invalid URLs early

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY DocumentUrlDB::replace calls DocumentUrlDB::put, which sile

D21692: [DocumentUrlDB] Remove unused 'rename' method

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY It is not used anywhere, so remove it. TEST PLAN still c

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > notifybysnore.cpp:46 > +iconDir = new QTemporaryDir(); > +server = new QLocalServer(); > +server->listen(qApp->applicationName()); @brute4s99 Have you heard of the how Qt manages the life time of QObjects? If you pass this class as th

D21661: add snoretoast backend for KNotifications on Windows

vonreth added a comment. In D21661#476607 , @sredman wrote: > In D21661#476571 , @pino wrote: > > > In D21661#476156 , @pino wrote: > > > > > how is snor

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 09 Jun 2019 10:08:08 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.60.

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 44 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/44/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 08 Jun 2019 09:37:58 + Build duration: 1 day 0 hr and counting

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/54/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 09 Jun 2019 10:08:08 + Build duration: 3 min 28 sec and counting BUILD ARTIFACTS acc/KF5Purpose-

D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21681 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D21681 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns