D21379: [UDev Backend] Narrow device queried for

broulik added a comment. Ping :) In D21379#472870 , @bruns wrote: > The question now is, should we also differnentiate here, i.e. map `QVariant()` to `nullptr`, and use `"*"` for wildcards? What do you mean? REPOSITORY R245 Solid

D21459: Always save view settings when switching from one view mode to another

meven added a comment. Any feedback @ngraham ? REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. It seems you uploaded only diff with latest changes, you need to upload the entire diff against master. INLINE COMMENTS > gattapplication.h:47 > */ > -explicit GattAppl

D21586: Add syntax definition for ninja build

jpoelen updated this revision to Diff 59240. jpoelen added a comment. I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile the

D21613: Format focal length as milli meter

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:144 > { Property::AspectRatio,true, 1.8, > QStringLiteral("1.78:1")}, > +{ Property::PhotoFocalLength, true, 2.0, > QStringLiteral("2 mm")}, > };

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59238. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59237&id=59238 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES autotest

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59237. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59236&id=59237 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES autotest

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59236. mweichselbaumer marked an inline comment as done. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59151&id=59236 BRANCH ble_gatt REVISION DETAIL https://pha

D21613: Format focal length as milli meter

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh,

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. @bruns okay for you to merge this one? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spo

D21533: Format photo exposure time as rational when applicable

astippich updated this revision to Diff 59224. astippich added a comment. - rename format function REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59222&id=59224 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFEC

D21533: Format photo exposure time as rational when applicable

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:167 > For a chart of typical exposure times, see > https://www.borrowlenses.com/blog/shutter-speed-chart/ > > I can confirm for my Canon SLR there is at one more value which would give a > deviating result, 0.3

D21533: Format photo exposure time as rational when applicable

astippich retitled this revision from "Format photo exposure time and bias as rational" to "Format photo exposure time as rational when applicable". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich,

D21613: Format focal length as milli meter

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https:

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59222. astippich added a comment. - add unit REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59221&id=59222 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED FILES au

D21533: Format photo exposure time and bias as rational

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:167 > For a chart of typical exposure times, see > https://www.borrowlenses.com/blog/shutter-speed-chart/ > > I can confirm for my Canon SLR there is at one more value which would give a > deviating result, 0.3

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59221. astippich added a comment. - only format exposure time REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59028&id=59221 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AF

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Jun 2019 19:34:25 + Build duration: 7 min 27 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 05 Jun 2019 19:34:26 + Build duration: 5 min 17 sec and counting BUILD ARTIFACTS abi-comp

D21519: Rename ImageMake and ImageModel properties

astippich added a comment. @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, LeG

D21532: Format the aperture values as F numbers.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:553f96769610: Format the aperture values as F numbers. (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21532?vs=59029&id=59218 REVISI

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474771 , @fvogt wrote: > I'm thinking about doing it completely differently now though, with a 0 latency case (untested): > > if(lastMatchChangeSignalled.hasExpired(250)) { > matchChangeTimer.stop();

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474763 , @bruns wrote: > This would emit the signal more often, but wouldn't > > if (!matchChangeTimer.isActive()) > matchChangeTimer.start(100) > > > achieve essentially the same? That wo

D21607: Don't delay emission of matchesChanged indefinitely

bruns added a comment. This would emit the signal more often, but wouldn't if (!matchChangeTimer.isActive()) matchChangeTimer.start(100) achieve essentially the same? REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D21607 To: fvogt, #frameworks, brou

D21604: Fix building with Qt 5.13

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This lacks a proper commit message REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21604 To: carewolf, bruns, ngraham Cc: alexeymin, kde-frameworks-devel, #b

D21604: Fix building with Qt 5.13

carewolf added inline comments. INLINE COMMENTS > alexeymin wrote in regexpcache.cpp:81 > can probably just be `QString suffixMatch(QLatin1String("^.*\\.("));` then, > without `=` Sure, but it hardly matters, copy-elision will make the statements equivalent. REPOSITORY R293 Baloo REVISION D

D21607: Don't delay emission of matchesChanged indefinitely

fvogt created this revision. fvogt added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently the signal is only emitted if there was no change to the matches in

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY ThreadWeaver Job Decorators don't actually hook into an existing job. Instead, they provide the same interface as the job

D21604: Fix building with Qt 5.13

alexeymin added inline comments. INLINE COMMENTS > regexpcache.cpp:81 > // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$" > -auto suffixMatch = QLatin1String("^.*\\.("); > +QString suffixMatch = QLatin1String("^.*\\.("); > suffixMatch += suffixes.join(QChar('|'));

D21604: Fix building with Qt 5.13

carewolf added reviewers: bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21604 To: carewolf, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21604: Fix building with Qt 5.13

carewolf created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. carewolf requested review of this revision. REPOSITORY R293 Baloo BRANCH fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D21604 AFF

D20062: [RFC] Add support for changing volume label.

ngraham added a comment. Ping, any update on this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20062 To: chinmoyr, #frameworks, bruns, broulik Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21599: Disable valgrind detection when compiling with MSVC

vonreth added inline comments. INLINE COMMENTS > database.cpp:49 > +// the macros without ifdef'ing these in place > +#if defined _MSC_VER && !defined NVALGRIND > +#define NVALGRIND 1 Id suggest to use Q_CC_MSVC but it looks ok REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/88/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Jun 2019 13:01:29 + Build duration: 5 min 24 sec and counting CONSOLE OUTPUT [...truncated 743

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/91/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 05 Jun 2019 13:01:29 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 178 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/178/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 05 Jun 2019 13:01:29 + Build duration: 2 min 56 sec and counting CONSOLE OUTPUT [..

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 05 Jun 2019 13:01:29 + Build duration: 1 min 57 sec and counting CONSOLE OUTPUT [...truncated 783

D21599: Disable valgrind detection when compiling with MSVC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:617e371d972f: Disable valgrind detection when compiling with MSVC (authored by bruns). REPOSITORY R293 Baloo CHANGE

D21599: Disable valgrind detection when compiling with MSVC

bruns removed a reviewer: Baloo. bruns added a subscriber: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21599 To: bruns, #windows, bcooksley Cc: #baloo, alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bru

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 84 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 05 Jun 2019 12:51:48 + Build duration: 4 min 55 sec and counting CONSOLE OUTPUT [...truncated 754

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 177 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/177/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 05 Jun 2019 12:51:48 + Build duration: 2 min 48 sec and counting CONSOLE OUTPUT [..

D21599: Disable valgrind detection when compiling with MSVC

alexeymin accepted this revision as: Windows. alexeymin added a comment. This should work. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21599 To: bruns, #baloo, #windows, bcooksley Cc: alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, ast

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/87/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Jun 2019 12:51:48 + Build duration: 1 min 37 sec and counting CONSOLE OUTPUT [...truncated 764

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/90/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 05 Jun 2019 12:51:48 + Build duration: 1 min 37 sec and counting CONSOLE OUTPUT [...truncate

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3282105c6cc6: [FilteredDirIterator] Combine all suffixes into one large RegExp (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21583?vs=59148&id=5

D21599: Disable valgrind detection when compiling with MSVC

bruns created this revision. bruns added reviewers: Baloo, Windows, bcooksley. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MSVC chokes on the inline assembly, use the stub macros there instea

D21574: Update KBruch icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187&id=59189 REVISION DETAIL https://phabric

D21586: Add syntax definition for ninja build

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice, I use ninja here, cool to have! REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from master) REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen, #fr

D21574: Update KBruch icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, mic

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131&id=59187 BRANCH kbruch REVISION DETAIL h

D21584: Add LE Advertising and GATT APIs

mweichselbaumer marked 11 inline comments as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in gattapplication_p.cpp:31 > Shouldn't the caller be made responsible for choosing object path? > If we force a path then we should use "our" namespace - `/org/kde/bluez-qt/`.

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks really good! INLINE COMMENTS > gattapplication.cpp:38 > + > +GattApplication::GattApplication(QObject *parent) : > +ObjectManager(parent), Coding style: ​GattApplica