hallas added inline comments.
INLINE COMMENTS
> bruns wrote in fstabdevice.cpp:88
> By default fuseiso seems to maintain also a file "~/.mtab.fuseiso", there may
> be more information
Yes it does :D After mounting an iso I have the following contents:
/home/dha/test.iso /home/dha/mnt1 fuseis
nibags closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21411
To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
dfaure added a comment.
Writing into the user's home dir is a "hack".
There are better ways for distros to set defaults (such as the global
mimeapps.list) but it seems KIO ignores that... (to be checked...)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D
ngraham planned changes to this revision.
ngraham added a comment.
I don't think it's a "distro hack" to set a default browser, which is why
they all do it. Not having a default browser set seems like an error condition
to me. However I see what you meanabout the bugginess and will work on it
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I agree that we shouldn't remove the underlying feature, in fact it's still
used on other protocols than http.
But we have to ensure the default behaviour matches the KCM and
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator
(authored by mweichselbaumer).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
REPOSITORY
R269 BluezQt
C
ngraham added reviewers: Frameworks, dfaure.
ngraham added a comment.
I'm still not sure whether the feature needs to be removed entirely. I feel
that this minimal patch probably stands on its own well enough as-is.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.o
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0c95c9f799cd: Create specific directory for Qt logging
categories file (authored by mlaurent).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21313?vs=5
mlaurent retitled this revision from "Create specific directory for
kdebugsettings categories file" to "Create specific directory for Qt logging
categories file".
REPOSITORY
R240 Extra CMake Modules
BRANCH
add_specific_kdebugsetting_directory
REVISION DETAIL
https://phabricator.kde.org/D
mlaurent updated this revision to Diff 58952.
mlaurent added a comment.
Fix typo
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21313?vs=58746&id=58952
BRANCH
add_specific_kdebugsetting_directory
REVISION DETAIL
https://phabricator.kde.org
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ac701bd091cf: Make falkon icon a real SVG (authored by
ndavis).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21511?vs=58944&id=58948
REVISION DETAIL
https
abetts added a comment.
+1
REPOSITORY
R266 Breeze Icons
BRANCH
falkon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21511
To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
drosca accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
falkon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21511
To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
ngraham added a comment.
LGTM
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21511
To: ndavis, #vdg, #falkon, abetts
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
ngraham added a reviewer: abetts.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21511
To: ndavis, #vdg, #falkon, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ndavis edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21511
To: ndavis, #vdg, #falkon
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ndavis created this revision.
ndavis added reviewers: VDG, Falkon.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.
REVISION SUMMARY
A falkon icon was recently commited to Breeze that was simply a PNG inside of
an SVG
nibags added a comment.
> Could one adapt the theme and remove the color later?
Yes, it would be ideal, so there is consistency among all the themes
REPOSITORY
R216 Syntax Highlighting
BRANCH
improve-yaml
REVISION DETAIL
https://phabricator.kde.org/D21411
To: nibags, dhaumann, cu
cullmann added a comment.
Hmm, ok, anyways, this change looks ok =)
Could one adapt the theme and remove the color later?
REPOSITORY
R216 Syntax Highlighting
BRANCH
improve-yaml
REVISION DETAIL
https://phabricator.kde.org/D21411
To: nibags, dhaumann, cullmann, #framework_syntax_hig
nibags added a comment.
> Btw., would it be possible to remove the hardcoded color here:
That I added it in a previous commit; use hard background color to mark
indentation with Tabs in some situations (specifically, in the indentation
capture with dynamic rules), since YAML uses indent
cullmann accepted this revision.
cullmann added a comment.
Screenshots look better!
Btw., would it be possible to remove the hardcoded color here:
REPOSITORY
R216 Syntax Highlighting
BRANCH
improve-yaml
REVISION DETAIL
https://phabricator.kde.org/D21411
To: nibags, dhaumann, cul
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
(the hard coded color was already there, therefore this doesn't block this
request)
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_jam (branched from master)
REVISION DETAIL
htt
cullmann added a comment.
Looks reasonable + test case, nice.
Btw., would it be possible to remove the last remaining hard coded color
here, too?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D21508
To: jpoelen, #framework_syntax_highlighting, dhauma
nibags edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
improve-yaml
REVISION DETAIL
https://phabricator.kde.org/D21411
To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,
nibags updated this revision to Diff 58936.
nibags added a comment.
- Some fixes in attributes and update test file
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21411?vs=58663&id=58936
BRANCH
improve-yaml
REVISION DETAIL
https://phabrica
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/36/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Fri, 31 May 2019 10:48:15 +
Build duration:
16 min and counting
JUnit Tests
Name: projectroot Fa
broulik added a comment.
For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER",
null)` doesn't work. If I check for "1" it works but `null` doesn't find any
devices. Since the systemd code uses `fnmatch`, we can probably just pass `*`
to it to match anything.
REPOSITO
broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.
I just reverted it as it indeed causes problems with initial device lookup.
Not just in plasmashell but also in Dolphin. Since Frameworks tagging is
tomrrow, better leave it for now and i
poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
If some folder was renamed while `baloo_file` was not running,
cgiboudeaux added a comment.
Maybe also update the commit message to 'Create specific directory for Qt
logging categories file'
REPOSITORY
R240 Extra CMake Modules
BRANCH
add_specific_kdebugsetting_directory
REVISION DETAIL
https://phabricator.kde.org/D21313
To: mlaurent, dfaure, cgi
cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KDEInstallDirs.cmake:132
> +# ``LOGGINGCATEGORIESDIR``
> +# qt logging categories files directory
> (``DATAROOTDIR/qlogging-categories5``) Since 5.59.0
>
31 matches
Mail list logo
