D21401: Use native dialog overwrite check

cullmann added a comment. I think this is fine then, please remove the decl. of bool KTextEditor::DocumentPrivate::checkOverwrite(QUrl u, QWidget *parent), too and push this, thanks! REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/

D21421: Tcsh: fix operators and keywords

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Change looks reasonable + test case => thanks, please push REPOSITORY R216 Syntax Highlighting BRANCH fix_tcsh (branched from master) REVISION DETAIL https://phabricator.kde.org/

D21235: Add handling of fuseiso filesystem type

hallas added inline comments. INLINE COMMENTS > broulik wrote in fstabdevice.cpp:88 > Can we maybe give it a better description then? For loop devices we show the > name of the backing file as description. Certainly :D I am also struggling a bit with how to best describe these FUSE mounted dev

D21418: KCompressionDevice::seek: Fix previous fix ^_^

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21418 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21421: Tcsh: fix operators and keywords

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - missing `foreach` and `end` - fix folding with `if

D21290: kio_ftp: improve error handling when copying to FTP fails

bruns added a comment. LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21290 To: dfaure, bruns, apol, kossebau Cc: kde-frameworks-devel, pino, michaelh, ngraham, bruns

D21290: kio_ftp: improve error handling when copying to FTP fails

dfaure updated this revision to Diff 58694. dfaure added a comment. Don't leak the file descriptor on error. Thanks for catching! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21290?vs=58687&id=58694 BRANCH 2019_freebsd_fixed REVISION DETAIL https://phab

D21419: Export SortFilterModel sort column to QML

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.cpp:197 > +sort(sortColumn(), order); > +} > + please add a `sortOrderChanged` signal (in a separate patch, if you feel like it) REPOSITORY R242 Pla

D21290: kio_ftp: improve error handling when copying to FTP fails

bruns added inline comments. INLINE COMMENTS > ftp.cpp:2358 > if (cs == statusServerError) { > -sCopyFile = dest.toString(); > +ftpCloseCommand(); > +return; ftpCopyPut calls iCopyFIle = QT_OPEN before calling ftpPut -> ftpSendCmd, so this leaks. RE

D21419: Export SortFilterModel sort column to QML

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Used in model REPOSITORY R242 Plasma Framework (Library) BRANCH or

D21418: KCompressionDevice::seek: Fix previous fix ^_^

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The previous fix that made sure we returned the actual data in KCompressionDevice::readData because it is sometimes buffe

D21415: Fix the alignment of the label of the toolbutton

dkardarakos edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21415 To: dkardarakos, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. @mart If you're not opposed to this patch, I'll go ahead and land this. REPOSITORY R242 Plasma Framework (Library) BRANCH less-custom-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma, mart, filipf Cc: fi

D21290: kio_ftp: improve error handling when copying to FTP fails

dfaure updated this revision to Diff 58687. dfaure edited the summary of this revision. dfaure edited the test plan for this revision. dfaure added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. keep error code; mention pure-ftpd in the commit lo

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

ngraham added a comment. I'm wondering if this really needs to be configurable, and if it really needs to exist as described here. Maybe what would make more sense is to always show whitespace characters for the current/selected line even if the current option is off. Then when the glob

D21415: Fix the alignment of the label of the toolbutton

ngraham added reviewers: Plasma, VDG. ngraham added a comment. Before-and-after screenshots in the Test Plan section are very helpful for patches like this. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21415 To: dkardarakos, #plasma, #vdg Cc

D21415: Fix the alignment of the label of the toolbutton

dkardarakos created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dkardarakos requested review of this revision. REVISION SUMMARY Using the Plasma theme, when only a label exists in a toolbutton, without filling the width of the rowlayout, t

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a subscriber: ngraham. cullmann added a comment. At the moment we have one combobox "Whitespaces" and one checkbox "Highlight tabulators" in "Whitespace Highlighting". I thought one wanted now to collapse/change that into 1-2 comboboxes ;=) Perhaps it would be better t

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar added a comment. > What would be the concrete content of the combobox then? What? Which box? These box can became these 4th "Smart" option but the code should then only work on spacesto be "correct/right". How about one extra bool which covers all normaly hidden stuff to

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a comment. Ah, you mean because of the "show tabs" extra option, yeah, forgot that :/ What would be the concrete content of the combobox then? REVISION DETAIL https://phabricator.kde.org/D19254 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-d

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar added a comment. > Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside Can do, but this combobox reads to me for true spaces only, no tabs. See also Dominiks comment https://phabricator.kde.or

D19785: DocumentPrivate: Review del/backspace

This revision was automatically updated to reflect the committed changes. Closed by commit R39:bcba89914136: Review del/backspace (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19785?vs=53955&id=58682 REVISION DETAIL https://phabric

D21412: Add action to reset font size

This revision was automatically updated to reflect the committed changes. Closed by commit R39:968af10fd4b6: Add action to reset font size (authored by kishoreg, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21412?vs=58680&id=58681

D21412: Add action to reset font size

cullmann added a comment. Thank you for providing the patch! Helping a bit to bring it up to speed is much easier and more motivating than to start from scratch for a thing one doesn't need oneself that much. > Thanks, one bug less! === I hope more people that

D21412: Add action to reset font size

kishoreg added a comment. I don't think I have the permissions for that. Could you please do it for me? Name: Kishore Gopalakrishnan Email: kishor...@gmail.com Also, thanks for helping me with this! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21412

D21412: Add action to reset font size

cullmann added a comment. Btw., if should push, I would need your name + email address for the git commit, thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21412 To: kishoreg, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson,

D21412: Add action to reset font size

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this look OK. Can you commit yourself? Or shall I push for you? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21412 To: kishoreg, #ktexteditor,

D21412: Add action to reset font size

kishoreg updated this revision to Diff 58680. kishoreg added a comment. I've made the suggested changes (use standard reset zoom shortcut, and move zoom option to a submenu). Everything seems to work now. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D19771: Use placeholder instead of label

cullmann added a comment. I think then it is a bit inconsistent. Would it really be that confusing, given until you write your find/replace stuff inside, you have the labels? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg C

D21412: Add action to reset font size

cullmann added a comment. Could you try: KStandardShortcut::shortcut(KStandardShortcut::ActualSize) The sub-menu should be just made in this review request, no need for an extra one, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21412 To: kishoreg,

D21412: Add action to reset font size

kishoreg added a comment. In D21412#470195 , @cullmann wrote: > For the shortcut: I guess you should use KStandardShortcut::ActualSize(). I initially tried using this, but it doesn't compile. It complains that ‘ActualSize’ cannot be used

D21412: Add action to reset font size

kishoreg updated this revision to Diff 58678. kishoreg edited the test plan for this revision. kishoreg added a comment. Get the default font size correctly. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21412?vs=58670&id=58678 REVISION DETAIL https:

D19785: DocumentPrivate: Review del/backspace

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19785 To: loh.tar, #ktexteditor, cullmann Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a comment. I think this feature is nice. Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside. We can later tweak this "Smart" variant like we want it to behave, actually the "always show

D21412: Add action to reset font size

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, this is a good start! Thanks for taking care of this. I think to get the "default font", you need to call KateRendererConfig::global()->font() instead of using a

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/95/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 26 May 2019 08:34:23 + Build duration: 5 min 45 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 26 May 2019 08:34:23 + Build duration: 4 min 13 sec and counting BUILD ARTIFACTS abi-comp