This revision was automatically updated to reflect the committed changes.
Closed by commit R432:2072ac711e15: Display accurate status message during
installation (authored by ngraham).
REPOSITORY
R432 File Sharing (Samba) integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D212
ngraham updated this revision to Diff 58227.
ngraham added a comment.
Rebase
REPOSITORY
R432 File Sharing (Samba) integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21264?vs=58224&id=58227
BRANCH
update-status-message-during-installation (branched from master)
REVISION
ndavis accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R432 File Sharing (Samba) integration
BRANCH
update-status-message-during-installation (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21264
To: ngraham, #vdg, #frameworks, ndavi
ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
Currently, the status message says "Samba is not installed" during the
installation.
Technically this is true, but it really should be describing the current
s
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> legacycodec.cpp:118
> +bool nonCharacter;
> +if (!(nonCharacter = QChar::isNonCharacter(uc)) && uc >
> 0x && uc < 0x11)
bruns added inline comments.
INLINE COMMENTS
> fstabhandling.cpp:140
> +
> +// strips last slash so that the device matches the one returned by
> getmntent when filesystem is mounted
> +// even when fstab mnt_dir ends with a '/' in /etc/fstab
break @ < 80 chars
> fstabhandling.cpp:142
jglogowski updated this revision to Diff 58215.
jglogowski added a comment.
Hope this compiles now. Since I can't test the rebased patch, I hope that is
the last update.
The original working version is based on v5.44. See my previous comment.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Sorry, but this doesn't compile:
/home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp: In member function
‘bool KFileWidgetPrivate::matchFilter(const QString&, const QStr
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:eef093cd6adc: Handle apps which set the desktopFileName
property with filename suffix (authored by kossebau).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
handledesktopfilenamesuffix
REVISION DETAIL
https://phabricator.kde.org/D21098
To: kossebau, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/107/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Fri, 17 May 2019 16:43:22 +
Build duration:
16 min and counting
BUILD ARTIFACTS
abi-compat
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/100/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Fri, 17 May 2019 16:43:22 +
Build duration:
13 min and counting
BUILD ARTIFACTS
abi-compat
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/110/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Fri, 17 May 2019 16:43:22 +
Build duration:
7 min 34 sec and counting
JUnit Tests
Na
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3b950f38ccd5: Update *.qmltypes to current API of QML
modules (authored by kossebau).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21001?vs=574
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
updateqmltypes
REVISION DETAIL
https://phabricator.kde.org/D21001
To: kossebau, #plasma, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added a reviewer: mart.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21001
To: kossebau, #plasma, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added inline comments.
INLINE COMMENTS
> fstabhandling.cpp:136
> {
> if (fstype.startsWith("fuse.")) {
> return fstype + mountpoint;
So this situation could never happen with FUSE mounts? Or should that case be
checked too.
REPOSITORY
R245 Solid
REVISION DETAIL
jglogowski added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21249
To: jglogowski, #frameworks
Cc: michaelweghorn, kde-frameworks-devel, michaelh, ngraham, bruns
jglogowski updated this revision to Diff 58193.
jglogowski added a comment.
Readd dropped QLatin1Char and use them in new code too.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21249?vs=58191&id=58193
REVISION DETAIL
https://phabricator.kde.org/D21249
AFF
jglogowski planned changes to this revision.
jglogowski added a comment.
This patch was developed on KIO v5.44 (git tag) in an Ubuntu 18.04 chroot
(because that's my LibreOffice development environment) and rebased on master.
The test-program was run on Debian Buster via
LD_PRELOAD=./git_ki
jglogowski created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jglogowski requested review of this revision.
REVISION SUMMARY
If KFileWidget's filter list has two matching filters for an extension,
it will always select the first filter,
ngraham accepted this revision.
ngraham added a comment.
I think this can land.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D20838
REVISION DETAIL
https://phabricator.kde.org/D20838
To: meven, ngraham, #frameworks
Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns
meven updated this revision to Diff 58190.
meven added a comment.
Move code change to _k_deviceNameForMountpoint
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=58189&id=58190
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D2
meven marked 2 inline comments as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham
meven updated this revision to Diff 58189.
meven marked 3 inline comments as done.
meven added a comment.
use chop to strip last /
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=58188&id=58189
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phab
meven updated this revision to Diff 58188.
meven added a comment.
Fix code, improved doc, better testing
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=58048&id=58188
BRANCH
arcpatch-D21204
REVISION DETAIL
https://phabricator.kde.org/D21204
AF
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/36/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Fri, 17 May 2019 08:54:12 +
Build duration:
24 min and counting
BUILD ARTIFACTS
abi-compatibility-r
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/44/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Fri, 17 May 2019 08:54:12 +
Build duration:
6 min 41 sec and counting
JUnit Tests
Name: proje
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:ddff2c06d17a: Allow compositors to send discrete axis
values (authored by zzag).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18933?vs=57883&id=58186
REVISION D
29 matches
Mail list logo
