D21146: KProcessInfoList -- add proclist backend for FreeBSD

pino added a comment. What about create a separate kprocesslist_libprocstat.cpp (or so) to implement `KProcessList::processInfoList()` using libprocstat, instead of overloading the existing kprocesslist_unix.cpp? Also, please adjust the coding style to the kdelibs coding style: https://

D21146: KProcessInfoList -- add proclist backend for FreeBSD

apol added inline comments. INLINE COMMENTS > kprocesslist_unix.cpp:59 > > +KProcessInfoList unixProcessListKinfoProcStat() > +{ doesn't that also need `#if HAVE_PROCSTAT`? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg, dav

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 57915. tcberner added a comment. Remove commented line. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21146?vs=57913&id=57915 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21146 AFFECTED FILES

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner added inline comments. INLINE COMMENTS > FindProcstat.cmake:18 > +#documentation and/or other materials provided with the distribution. > +# 3. Neither the name of the University nor the names of its contributors > +#may be used to endorse or promote products derived from this so

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner created this revision. tcberner added reviewers: FreeBSD, adridg, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY This adds - unixProcessListKinfoProcStat() to KProcess

D20958: New menu of syntax highlighting in the status bar

nibags added a comment. Now it's OK REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel

D20958: New menu of syntax highlighting in the status bar

nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#454298 , @ngraham wrote: > Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because //in principle// any app could use it. It's more imp

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#458379 , @filipf wrote: > Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do: > > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2` > > and call it

D20958: New menu of syntax highlighting in the status bar

nibags updated this revision to Diff 57905. nibags added a comment. - Add delimiters « » REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20958?vs=57841&id=57905 BRANCH new-mode-menu REVISION DETAIL https://phabricator.kde.org/D20958 AFFECTED FILES

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 11 May 2019 10:12:00 + Build duration: 1 min 22 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 11 May 2019 10:01:15 + Build duration: 1 min 19 sec and counting JUnit Tests Name: projectr

D17991: Refactor the way device backends are built and registered

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:97d95e3171c3: Refactor the way device backends are built and registered (authored by pino). CHANGED PRIOR TO COMMIT

D20838: Allow to drop one file or one folder on KDirOperator

elvisangelaccio added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:38 > +#include > +#include > + Unused? > kfilewidgettest.cpp:407-413 > +QDir f(tempDir.filePath(dir)); > + > +KFileWidget fw(QUrl::fromLocalFile(tempDir.path())); > +fw.setOperationMode(KFileW

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/102/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 11 May 2019 07:50:30 + Build duration: 8 min 32 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 11 May 2019 07:50:44 + Build duration: 2 min 1 sec and counting JUnit Tests Name: projectro