D17595: Upstream Dolphin's file rename dialog

ltoscano added inline comments. INLINE COMMENTS > meven wrote in renamefiledialog.h:5 > We can email Peter Penz to ask about doing a license change. > > I wish we would ask its contributors to allow the kde foundation to update > code distribution license on their behalf, provided the license s

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/96/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 09 May 2019 23:18:15 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 23:18:15 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5Plas

D21107: Replace qVariantFromValue with QVariant::fromValue

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a40f6e9eb287: Replace qVariantFromValue with QVariant::fromValue (authored by nicolasfella). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21107?vs=57822&id=57828

D21107: Replace qVariantFromValue with QVariant::fromValue

nicolasfella added a comment. In D21107#463157 , @apol wrote: > Maybe it could make sense to have a clazy fixit for it? That sound like a good idea. A quick search showed that qVariantFromValue is used in lots of KDE code I'll give it a

D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fca08ef241ef: FrameSvg: l & r borders or t & b don't need to have same height resp. width (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabr

D21108: Fix build error in uploaddialog.ui

This revision was automatically updated to reflect the committed changes. Closed by commit R304:90eff8941be8: Fix build error in uploaddialog.ui (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21108?vs=57823&id=57827 REVISION DETA

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/99/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 09 May 2019 23:18:15 + Build duration: 2 min 48 sec and counting JUnit Tests Nam

D21107: Replace qVariantFromValue with QVariant::fromValue

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe it could make sense to have a clazy fixit for it? REPOSITORY R237 KConfig BRANCH variant REVISION DETAIL https://phabricator.kde.org/D21107 To: nicolasfella, #frameworks, dfaure,

D21109: Fix KAr

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21109 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21108: Fix build error in uploaddialog.ui

apol accepted this revision. apol added a comment. wird How was this ever generated? :| REPOSITORY R304 KNewStuff BRANCH enum REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, dhaumann, gregormi, #frameworks, ngraham, apol Cc: apol, kde-frameworks-dev

D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixassumptionsvgframeborderelementsareequal REVISION DETAIL https://phabricator.kde.org/D21106 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ng

D21109: Fix KAr

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The bytearray needs to be 60 long if we read 60 chars not 61, otherwise when doing endsWith it compares to the last uninit

D21108: Fix build error in uploaddialog.ui

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH enum REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, dhaumann, gregormi, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20983: Exclude .gcode and virtual machine files from indexing consideration

ngraham retitled this revision from "Exclude .gcode and .vdi files from indexing consideration" to "Exclude .gcode and virtual machine files from indexing consideration". ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20983 T

D20983: Exclude .gcode and .vdi files from indexing consideration

ngraham updated this revision to Diff 57824. ngraham added a comment. Exclude more VM-related files REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20983?vs=57460&id=57824 BRANCH more-excluded-files (branched from master) REVISION DETAIL https://phabrica

D21108: Fix build error in uploaddialog.ui

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Building againt current Qt dev fails: In file included from /home/nico/kde/src/knewstuff/src/uploaddialog

D21108: Fix build error in uploaddialog.ui

nicolasfella edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, #framework_syntax_highlighting, dhaumann, gregormi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21108: Fix build error in uploaddialog.ui

nicolasfella edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, dhaumann, gregormi, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngra

D21108: Fix build error in uploaddialog.ui

nicolasfella added reviewers: Framework: Syntax Highlighting, dhaumann, gregormi. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21108 To: nicolasfella, #framework_syntax_highlighting, dhaumann, gregormi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21107: Replace qVariantFromValue with QVariant::fromValue

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY qVariantFromValue is obsolete (https://doc.qt.io/qt-5/qvari

D21099: Use locale currency for donate icon

ngraham added a comment. Filed an icon request bug for Breeze icons: https://bugs.kde.org/show_bug.cgi?id=407372 In the meantime I think this is safe enough to land given that the fallback mechanic will result in no visual changes until we actually get new icons. REPOSITORY R265 KConf

D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The specification for FrameSvg does not require that all borders exist or that le

D20958: New menu of syntax highlighting in the status bar

nibags updated this revision to Diff 57819. nibags added a comment. - Fixes: Some fixes for locations: - Before, the word wrap was only applied in spaces and, in languages such as German, there are large words that pass under the scroll bar. This is corrected. - Improves the alignm

D21099: Use locale currency for donate icon

davidedmundson added inline comments. INLINE COMMENTS > kstandardaction.cpp:202 > +const QString currencyCode = > QLocale().currencySymbol(QLocale::CurrencyIsoCode).toLower(); > +if (!currencyCode.isEmpty()) { > +iconName = > QStringLiteral("help-donate-%

D20983: Exclude .gcode and .vdi files from indexing consideration

pino added a comment. While you are there adding filters, what about: - `*.qcow2` -- QCOW2 disk images for QEMU - `*.raw`/`*.img` -- typical extensions for raw disk images (there is no fixed extension, as a raw disk image is just a file with bit-by-bit representation of the disk of a V

D20983: Exclude .gcode and .vdi files from indexing consideration

ngraham added a comment. #baloo @bruns ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20983 To: ngraham, bruns, #baloo Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D21099: Use locale currency for donate icon

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kstandardaction.cpp:202 > else iconName = "help-donate" ? That's the default specified in the struct already REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 09 May 2019 15:06:53 + Build duration: 3 min 28 sec and counting BUILD ARTIFACTS acc/KF5Purpose-

D21099: Use locale currency for donate icon

sitter added a comment. For obvious reasons I'd recommend only going for the major currencies :) I've had a quick look at a part of our website visits and the following currencies would be the most relevant based on that: 1. EUR 2. USD (this is actually the default icon so it's not

D21099: Use locale currency for donate icon

broulik added a comment. https://en.wikipedia.org/wiki/ISO_4217#Active_codes if you want to have fun with it I guess :D REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks, #vdg, ngraham Cc: ngraham, sitter, kde-frameworks-devel, mi

D21099: Use locale currency for donate icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Is there a list of currency codes somewhere so that VDG can know what icons we'll need to make to fully support this? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricat

D21100: don't glob everything and the kitchen sink

This revision was automatically updated to reflect the committed changes. Closed by commit R266:009608ce8e5d: don't glob everything and the kitchen sink (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21100?vs=57808&id=57809 REVISION

D21099: Use locale currency for donate icon

sitter added a comment. LGTM REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks, #vdg Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D21100: don't glob everything and the kitchen sink

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21100 To: sitter, #breeze, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21100: don't glob everything and the kitchen sink

ngraham added reviewers: Breeze, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21100 To: sitter, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21100: don't glob everything and the kitchen sink

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY we have two themes. glob the two themes and nothing else. otherwise when keeping the build directory in ./build/ we'd

D21098: Handle apps which set the desktopFileName property with filename suffix

kossebau created this revision. kossebau added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R289 KNotifications BRANCH handledesktopfilenamesuffix REVISION DETAIL https://pha

D21099: Use locale currency for donate icon

broulik created this revision. broulik added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This allows the icon theme to provide a donate icon using the currency symbol

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20844 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

bruns added inline comments. INLINE COMMENTS > renamefiledialog.cpp:60 > + i18nc("@title:window", "Rename Items")); > +QDialogButtonBox *buttonBox = new > QDialogButtonBox(QDialogButtonBox::Ok|QDialogButtonBox::Cancel); > +QVBoxLayout *mainLayout = new QVBoxLayout; space a

D17595: Upstream Dolphin's file rename dialog

meven added inline comments. INLINE COMMENTS > pino wrote in renamefiledialog.h:5 > > The KIO repo's COPYING.LIB file says LGPL 2.1. Is that a mismatch? > > Considering this new code is GPL: yes, it's a mismatch, and it would make the > whole kiowidgets as GPL. We can email Peter Penz to ask a

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > I didn't read the full encyclopedia of discussions here, I only looked at the patch. It's really a pity that you only did that now, because by now I'll have to reverse-engineer my patch (and read the encyclopedia) to remember how I arrived at the patch. >

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH arcpatch-D20844 REVISION DETAIL https://phabricator.kde.org/D20844 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

dfaure requested changes to this revision. dfaure added a comment. I didn't read the full encyclopedia of discussions here, I only looked at the patch. But really, this is far too hacky to my taste. If QHeaderview is indeed missing a feature, it might be best to implement it there, it wi