D21028: add multiple gestures and a handler class to KWidgetsAddons

steffenh created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. steffenh requested review of this revision. REVISION SUMMARY This patch adds the gestures and handler class from gwenview to KWidgetsAddons, so another program you can use this.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/100/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 05 May 2019 03:58:50 + Build duration: 7 min 25 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 22:47:19 + Build duration: 1 hr 43 min and counting BUILD ARTIFACTS acc/KF5Purpose-

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 22:46:42 + Build duration: 1 hr 34 min and counting BUILD ARTIFACTS acc/KF5Wi

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 22:47:04 + Build duration: 1 hr 28 min and counting BUILD ARTIFACTS acc/KF

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 22:46:22 + Build duration: 1 hr 25 min and counting BUILD ARTIFACTS acc/KF5Wayland

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/54/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 04 May 2019 22:44:11 + Build duration: 1 hr 24 min and counting JUnit Tests Na

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 22:43:46 + Build duration: 1 hr 14 min and counting BUILD ARTIFACTS acc/KF5Fi

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:47:24 + Build duration: 1 hr 0 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/97/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:47:05 + Build duration: 58 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:46:42 + Build duration: 54 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:46:25 + Build duration: 52 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 04 May 2019 22:47:19 + Build duration: 48 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.58.0

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/94/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 04 May 2019 22:47:04 + Build duration: 47 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 04 May 2019 22:46:25 + Build duration: 40 min and counting BUILD ARTIFACTS acc/KF5Wayland-5.58

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:45:59 + Build duration: 35 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:45:43 + Build duration: 34 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/41/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 04 May 2019 22:42:17 + Build duration: 35 min and counting JUnit Tests Name: p

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:45:26 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/99/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:44:32 + Build duration: 32 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/93/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 04 May 2019 22:43:46 + Build duration: 23 min and counting BUILD ARTIFACTS acc/KF5FileMet

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/92/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:43:46 + Build duration: 19 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:42:48 + Build duration: 12 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:43:09 + Build duration: 16 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 22:43:21 + Build duration: 16 min and counting JUnit Tests Name: projectroot Fa

D19332: KProcess compile fix for obsolete QProcess members in 5.13

marten abandoned this revision. marten added a comment. Appears to have been already implemented by https://phabricator.kde.org/R244:b2b873d612a018d33866ddfd497f87bb7dd79573 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19332 To: marten, #frameworks Cc: apol,

D15814: show all borders for pop up windows in a dock

filipf added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson, kossebau, #vdg Cc: kossebau, abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Actually popups from Plasma panels itself, at least with non-full-width-non-hide ones, now & then could use some more borders as well. E.g. when popup is shown next to scree

D20958: New menu of syntax highlighting in the status bar

nibags marked 8 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20958: New menu of syntax highlighting in the status bar

nibags added a comment. > Can you make this a QListView? I once heard the QListWidget will be deprecated in Qt6, rule of thumb is: always use Q*View instead of Q*Widget, since this then will also work in QML. I used QListWidget because it's more simpler to implement, but in that case it

D20958: New menu of syntax highlighting in the status bar

nibags updated this revision to Diff 57561. nibags added a comment. - Update: - Select the search text when showing the menu. - Also use Shift, Alt or Meta + Return to select an item without hiding the menu. - Fix style in signals/slots. - Use constant variable for icon size. - Use

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

apol added a comment. Looks good to me, have you checked that it's now not breaking what @broulik found? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 11:39:55 + Build duration: 13 min and counting BUILD ARTIFACTS acc/KF5WindowS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 11:39:55 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#441163 , @croick wrote: > Would you accept now @apol? Or now? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, brun

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 08:05:58 + Build duration: 13 min and counting BUILD ARTIFACTS acc/KF5Widgets

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/32/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 04 May 2019 08:05:58 + Build duration: 3 min 47 sec and counting BUILD ARTIFACTS acc/KF5W

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 04 May 2019 08:05:58 + Build duration: 2 min 6 sec and counting JUnit Tests Name: p