D20672: Add an icon for Thunderbolt KCM

ngraham added subscribers: GB_2, ndavis. ngraham added a comment. +1. @ndavis, @gb_2, or @filipf, any thoughts on this version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, micha

D20672: Add an icon for Thunderbolt KCM

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor updated this revision to Diff 56576. yurchor added a comment. Darker top REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56559&id=56576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 AFFECTED FILES icons/prefe

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/93/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Apr 2019 21:05:44 + Build duration: 23 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/80/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 18 Apr 2019 21:05:44 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/90/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 18 Apr 2019 21:05:44 + Build duration: 8 min 53 sec and counting JUnit Tests Name: projectroo

D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage"

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f8328c008e01: [Properties dialog] Use the string "Free space" instead of "Disk usage" (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20673?vs=565

D20672: Add an icon for Thunderbolt KCM

filipf added a comment. In D20672#452757 , @ngraham wrote: > Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabrica

D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Makes more sense. REPOSITORY R241 KIO BRANCH improve-free-space-string (branched from master) REVISION DETAIL https://phabricator.kde.org/D20673 To: ngraham, #vdg, filipf Cc: filipf

D20672: Add an icon for Thunderbolt KCM

ngraham added a comment. Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor updated this revision to Diff 56559. yurchor added a comment. Smaller, add gradient REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56556&id=56559 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 AFFECTED FILES

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20668 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarrom

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH metadata_add_stretch REVISION DETAIL https://phabricator.kde.org/D20667 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: gennad, domson, ashaposhnikov, ast

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson,

D20672: Add an icon for Thunderbolt KCM

ngraham added a comment. Ooh, I like that! Maybe make the thunderbolt a bit smaller inside the circle though? Also, the circle itself is slightly larger than other circle-background KCM icons and needs to be a tiny bit smaller. You can use `preferences-desktop-font` as a model for how b

D20672: Add an icon for Thunderbolt KCM

yurchor updated this revision to Diff 56556. yurchor added a comment. Use the official blue background REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20672?vs=56553&id=56556 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 AFFECT

D20672: Add an icon for Thunderbolt KCM

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage"

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY "Disk usage" is inaccurate when you happen to be looking at a partition. And "Free space

D20672: Add an icon for Thunderbolt KCM

ngraham added a comment. Thanks! Generally we use colorful icons for KCMs. I think this could use a bit more pizazz. :) Maybe make it yellow, and/or put it on top of a circular colored background or something? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D206

D20672: Add an icon for Thunderbolt KCM

ngraham added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

yurchor created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY An icon for D19011 TEST PLAN none REPOSITORY R266 Breeze Icons BRANCH mast

D20659: Copy container in Component::cleanUp before interating

fvogt added a comment. In D20659#452642 , @ngraham wrote: > Did this fix https://bugs.kde.org/show_bug.cgi?id=406642? No, that particular crash (bug 406426) is already fixed. I marked it as dup. REPOSITORY R268 KGlobalAccel REVISION DE

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

dfaure added a comment. No, it's pretty much the same. The garbage looks a bit different, but switching to another email and back fixes it, so no big deal. I thought this was what this whole effort was about, though :-) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kd

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

davidedmundson added a comment. > Thanks, this fixes the plasma crash on resume. Thanks for the fast reports / testing. > [KMail's webengine view still displays garbage on resume, but that's less critical, and unrelated to this patch] Is it worse than before any of the QSurfaceF

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0aab7d23a2ce: Plotter: Scope GL Program to lifespan of scenegraph node (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20656?vs=56505&id=56549#toc REPOSITORY R29

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

dfaure added a comment. Thanks, this fixes the plasma crash on resume. [KMail's webengine view still displays garbage on resume, but that's less critical, and unrelated to this patch] REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20656 T

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 157 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/157/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Apr 2019 15:43:32 + Build duration: 18 min and counting

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > plotter.cpp:267 > +PlotSGNode(); > +void bind(){ > +m_program->bind(); Coding style REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D20659: Copy container in Component::cleanUp before interating

ngraham added a comment. Did this fix https://bugs.kde.org/show_bug.cgi?id=406642? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks, davidedmundson Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D20620: [balooctl] Switch multiline output to new helper

This revision was automatically updated to reflect the committed changes. Closed by commit R293:812523dfd960: [balooctl] Switch multiline output to new helper (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20620?vs=56403&id=56548 REVISION D

D20619: [balooctl] Use new helper in json output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d0057aebd715: [balooctl] Use new helper in json output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20619?vs=56402&id=56547 REVISION DETAIL

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56545. bruns added a comment. reset column stretch REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56536&id=56545 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524 AFFEC

D20620: [balooctl] Switch multiline output to new helper

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH balooctl_status REVISION DETAIL https://phabricator.kde.org/D20620 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhni

D20619: [balooctl] Use new helper in json output

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH balooctl_status REVISION DETAIL https://phabricator.kde.org/D20619 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhni

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

bruns retitled this revision from "Make the FileMetadataWidget vertical stretch in a sensible way" to "Make the FileMetadataWidget stretch vertically in a sensible way". REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20667 To: bruns, #dolphin, #baloo, #framework

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a dependent revision: D20667: Make the FileMetadataWidget vertical stretch in a sensible way. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashapo

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns edited the summary of this revision. bruns added a dependency: D20524: [FileMetaDataWidget] Allow inline configuration of visible properties. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20667 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich C

D20283: [RFC] [SimpleKCM] Fix height calculation

ngraham abandoned this revision. ngraham added a comment. @mart did this in the correct way instead! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20283 To: ngraham, #plasma, mart, broulik Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngra

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

bruns created this revision. bruns added reviewers: Dolphin, Baloo, Frameworks, ngraham, astippich. bruns added a project: Dolphin. bruns requested review of this revision. REVISION SUMMARY Depends on D20667 REPOSITORY R318 Dolphin BRANCH cleanup REVIS

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns added a dependent revision: D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper.. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D206

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns created this revision. bruns added reviewers: Dolphin, Baloo, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY When the widget size is larger than the required size, the QGridLayout distributes the extra space evenly

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56536. bruns added a comment. Layout cleanup - remove extra spacer - keep checkbox near label (align right) REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56337&id=56536 BRANCH metadata_config_inl

D20665: use the base implementation hints

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d9a0365ccc49: use the base implementation hints (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20665?vs=56534&id=56535 REVISION DETAIL h

D20665: use the base implementation hints

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R296 KDeclarative BRANCH phab/hints REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, michaelh

D20665: use the base implementation hints

mart updated this revision to Diff 56534. mart retitled this revision from "Use the base implementation hints" to "use the base implementation hints". mart edited the summary of this revision. mart added a comment. - remove visual debug REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDAT

D20665: use the base implementation hints

ngraham retitled this revision from "use the base implementation hints" to "Use the base implementation hints". ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma Cc: kde-frameworks-devel, michaelh,

D20665: use the base implementation hints

mart added a comment. F6779963: Screenshot_20190418_164550.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20665: use the base implementation hints

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY with latest kirigami master and kcmutils, the default size hints of scrollablepage are correc

D20606: Add action to toggle folding of child ranges

loh.tar marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann,

D20606: Add action to toggle folding of child ranges

loh.tar updated this revision to Diff 56527. loh.tar retitled this revision from "Toggle folding of child ranges by right click" to "Add action to toggle folding of child ranges". loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar

D20659: Copy container in Component::cleanUp before interating

This revision was automatically updated to reflect the committed changes. Closed by commit R268:78a711361db3: Copy container in Component::cleanUp before interating (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56517&id=5652

D20659: Copy container in Component::cleanUp before interating

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks, davidedmundson Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Copy container in Component::cleanUp before interating

fvogt retitled this revision from "Detach container in Component::cleanUp before interating" to "Copy container in Component::cleanUp before interating". REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-deve

D20659: Detach container in Component::cleanUp before interating

fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

lbeltrame added a comment. I confirm there are no more issues in valgrind after adding this patch. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 156 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/156/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Apr 2019 12:43:36 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT Sta

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 18 Apr 2019 12:43:36 + Build duration: 2 min 2 sec and counting JUnit Tests Name: projectroo

D20617: [balooctl] Factor out file index status collection from output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a9c230f64519: [balooctl] Factor out file index status collection from output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20617?vs=56400&id=565

D20618: [balooctl] Use new helper for simple format output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:634e490b58a4: [balooctl] Use new helper for simple format output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20618?vs=56401&id=56521 REVISION

D20659: Detach container in Component::cleanUp before interating

lbeltrame added a reviewer: Frameworks. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

fvogt updated this revision to Diff 56517. fvogt added a comment. Use auto (which might actually make it build) REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56515&id=56517 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2065

D20659: Detach container in Component::cleanUp before interating

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Might fix crashes similiar to bug 406426 TEST PLAN Not tested, will ask someone to do that with valgrind REPOSITORY R2

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/92/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Apr 2019 12:02:49 + Build duration: 25 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

D20647: [Purpose] Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R495:c1939150503f: [Purpose] Make it compile without foreach (authored by mlaurent). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20647?vs=56511&id=56512 REVI

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/91/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Apr 2019 16:34:40 + Build duration: 19 hr and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllogs

D20647: [Purpose] Make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20647 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20647: [Purpose] Make it compile without foreach

mlaurent updated this revision to Diff 56511. mlaurent added a comment. Add missing const REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20647?vs=56492&id=56511 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phab

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/82/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Apr 2019 11:08:33 + Build duration: 16 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 18 Apr 2019 11:08:31 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/85/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 18 Apr 2019 11:08:33 + Build duration: 4 min 29 sec and counting JUnit Tests Nam

D20579: [FrameSvgItem] Update filtering on smooth changes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:170ff5668f64: [FrameSvgItem] Update filtering on smooth changes (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20579?vs=5

D20579: [FrameSvgItem] Update filtering on smooth changes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH updateframesvgitemsonsmoothchange REVISION DETAIL https://phabricator.kde.org/D20579 To: kossebau, #plasma, broulik, mart Cc: kde-frameworks-devel, michaelh,

D20649: [Notify by Portal] Support default action and priority hints

This revision was automatically updated to reflect the committed changes. Closed by commit R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=565

D20283: [RFC] [SimpleKCM] Fix height calculation

mart added a comment. so, now on master Kirigami should have correct contentHeight and implicitHeight/implicitWidth for Page andScrollablePage. this means that this patch *should* be not necessary anymore (only thing that should happen, is ro remove completely implicitWidth/implicitheight ca

D20649: [Notify by Portal] Support default action and priority hints

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Works for me. I tested both like the default action and urgency. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20649 To: broulik, #frameworks, jgrulic

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a reviewer: dfaure. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20656 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, mi

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently the QOpenGLProgram was static. This works when you only

D20649: [Notify by Portal] Support default action and priority hints

broulik updated this revision to Diff 56504. broulik added a comment. - Support `high` - Handle all switch cases REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=56494&id=56504 REVISION DETAIL https://phabricator.kde.org/D20649 AFFECTED

D20648: [KNotification] Add HighUrgency

This revision was automatically updated to reflect the committed changes. Closed by commit R289:134e131762e9: [KNotification] Add HighUrgency (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20648?vs=56493&id=56503 REVISION DETAIL

D20655: Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids introspection calls when creating the manager or devi

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 18 Apr 2019 08:09:45 + Build duration: 34 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

D20648: [KNotification] Add HighUrgency

dfaure added a comment. Ah, great, thanks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20648: [KNotification] Add HighUrgency

broulik added inline comments. INLINE COMMENTS > dfaure wrote in knotification.h:283 > Isn't the change of value BIC? Even if it was, this stuff isn't released yet REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause,

D20648: [KNotification] Add HighUrgency

dfaure added inline comments. INLINE COMMENTS > knotification.h:283 > +DefaultUrgency = -1, > +LowUrgency = 10, > +NormalUrgency = 50, Isn't the change of value BIC? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #fra

D20648: [KNotification] Add HighUrgency

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel, michaelh, ngra

D20158: Allow to set urgency for notifications

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/89/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 18 Apr 2019 08:09:45 + Build duration: 9 min 52 sec and counting JUnit Tests Name: projectroo

D20648: [KNotification] Add HighUrgency

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel,

D20649: [Notify by Portal] Support default action and priority hints

broulik created this revision. broulik added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, untested as I couldn't figure out the flatpak build system stuff REPO

D20648: [KNotification] Add HighUrgency

broulik created this revision. broulik added reviewers: Frameworks, dfaure, vkrause, ogoffart, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Freedesktop notifications only know low, n

D20158: Allow to set urgency for notifications

broulik added a comment. Good point, I shall space them apart a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20647: [Purpose] Make it compile without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pastebinplugin.cpp:50 > { > QJsonArray urls = data().value(QStringLiteral("urls")).toArray(); > const REPOSITORY R495 Purpose Libra

D20643: Fix invalid memory write on malformed tar files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20643 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns