D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

GB_2 added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20565: Ensure not to fold the end marker

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to avoid a deceptive look With recent fixes wa

D20536: Use consistent default Kickoff user icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, assuming D20564 is approved and lands. REPOSITORY R266 Breeze Icons BRANCH use-consistent-default-kickoff-user-icon (branched from master) R

D20536: Use consistent default Kickoff user icon

GB_2 added a dependency: D20564: Change default user avatar. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20536 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

cullmann accepted this revision. REPOSITORY R39 KTextEditor BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham, cullmann Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, d

D20536: Use consistent default Kickoff user icon

GB_2 updated this revision to Diff 56263. GB_2 added a comment. Change name of blue user icon, will need to make a patch for `user-manager` too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56196&id=56263 BRANCH use-consistent-default-kic

D20556: Keep empty Json metadata docs out of DocumentData DB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20556 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mich

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH antialiasoxygenclockhands REVISION DETAIL https://phabricator.kde.org/D20550 To: kossebau, #vdg, #plasma, ngraham Cc: kde-frameworks-devel, michaelh, ngraham,

D19850: Make AppStream generation opt-in

ngraham added a comment. Ping! Can we land this or a variant of it? REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D20536: Use consistent default Kickoff user icon

GB_2 added a comment. In D20536#450246 , @ngraham wrote: > This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd. Ok, then we could rename that 128px icon to something different. REPOSITO

D20536: Use consistent default Kickoff user icon

ngraham added a comment. This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20536 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, mic

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R39 KTextEditor BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham Cc: cullmann, kossebau, kwrite-dev

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > Why are you using it without Android.cmake? I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some variables as it expects to run as a toolchain. Later today, I will su

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56257. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56243&id=56257 BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D2

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

This revision was automatically updated to reflect the committed changes. Closed by commit R240:24538afeaf61: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56244&

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450198 , @sh-zam wrote: > Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. Sure, add it. Why are you using it without Android.

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me, can you land it? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kd

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-framewo

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Apr 2019 22:07:42 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/67/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 14 Apr 2019 22:07:43 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5Plas

D20557: Install krcc.h header

This revision was automatically updated to reflect the committed changes. Closed by commit R243:4b1927e954fb: Install krcc.h header (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20557?vs=56242&id=56251 REVISION DETAIL https://phabricat

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/77/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 14 Apr 2019 22:07:43 + Build duration: 3 min 15 sec and counting JUnit Tests Nam

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:18a2ca50ab09: SvgItem, IconItem: drop "smooth" property override, update node on change (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabric

D20557: Install krcc.h header

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can't remember what use case I had in mind back then... Probably someone asked me to implement this REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kd

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam updated this revision to Diff 56244. sh-zam added a comment. improved name and code flow REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56151&id=56244 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 AFFECT

D20557: Install krcc.h header

aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20557 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

sh-zam created this revision. sh-zam added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Find C++ shared lib path using regex. This change makes finding path independent

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadatawidget.h:93 > + * Switch between regular (view) and configuration mode. > + * @since 5.58 > + */ Should be `@since 19.08.0` (baloo-widgets follows the KDE Applications versioning) REPOSITORY R824 Baloo Widgets

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Please bump the minimum required version for `KF5BalooWidgets` to 19.07.70. INLINE COMMENTS > informationpanelcontent.cpp:121 > +connect(m_configureButtons,

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio added a comment. About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing. We could fix this by disabling the entry once clicked. Another idea: make the entry checkable i

D20557: Install krcc.h header

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20557 AFFECTED FILES src/CMakeLists.txt To: aac

D20556: Keep empty Json metadata docs out of DocumentData DB

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a document is marked for content indexi

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 14 Apr 2019 18:51:13 + Build duration: 23 min and counting JUnit Tests Name: p

D20519: Fix double delete on broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20519 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure added a comment. Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't have d pointers at all...) About KBookmarkOwner, the lack of an explicit construc

Re: New framework: KCalCore

вт, 9 апр. 2019 г. в 20:10, Volker Krause : > > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an implementation of the

D20555: Don't use qAsConst over a temporary variable

This revision was automatically updated to reflect the committed changes. Closed by commit R268:abe32ec59939: Don't use qAsConst over a temporary variable (authored by mlaurent). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20555?vs=56238&id=56239 REVI

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Apr 2019 18:15:18 + Build duration: 7 min 14 sec and counting BUILD ARTIFACTS acc/KF5Packag

D20555: Don't use qAsConst over a temporary variable

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH dont_use_on_temporary (branched from master) REVISION DETAIL https://phabricator.kde.org/D20555 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote: > On 14 April 2019 12:31:41 BST, David Faure wrote: > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an im

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 14 Apr 2019 18:15:18 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS acc/KF5Packag

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 14 Apr 2019 18:15:17 + Build duration: 1 min 15 sec and counting JUnit Tests Name: proje

D20555: Don't use qAsConst over a temporary variable

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY BUG: 406426 REPOSITORY R268 KGlobalAccel BRANCH dont_use_on_temporary (branch

D20552: Don't use qAsConst over a temporary variable

dfaure closed this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D20552 To: dfaure, mlaurent, cfeck, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20552: Don't use qAsConst over a temporary variable

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. I used you command and see the same problem. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20552 To: dfaure, mlaurent, cfeck, apol Cc: kde-

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added inline comments. INLINE COMMENTS > davidedmundson wrote in kprocesslist.cpp:69 > With the QSharedDataPointer you can delete this method. > > The point of the shareddatapointer is that when you copy KProcessInfo you > don't copy all the members, we just increase the internal ref-cou

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas updated this revision to Diff 56237. hallas added a comment. Review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20007?vs=54949&id=56237 BRANCH adds_kprocesslist (branched from master) REVISION DETAIL https://phabricator.kde.org/

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. Hi @dfaure - I looked into this a bit more and have run into a problem, I hope you can help solve. The problem is that when I add a getter and a setter for the number of open tabs, I need to store the value somewhere in `KBookmarkOwner` but I guess I cannot add a memb

D20519: Fix double delete on broken files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The double star looks very C-ish to me, but OK, I just realized that the recursive call itself would probably look more cumbersome, so I won't insist. INLINE COMMENTS > karchive.cpp:871 >

D20519: Fix double delete on broken files

aacid added a comment. In D20519#450066 , @dfaure wrote: > Any input on my "cleaner solution: return a two-field structs" suggestion? I can do it if you want, but i feel that for a function that is private and called in one just place the

D20519: Fix double delete on broken files

dfaure added a comment. Oops indeed, I stopped working on the unittest when I managed to make it reproduce the crash. Thanks for integrating it and fixing it. Any input on my "cleaner solution: return a two-field structs" suggestion? REPOSITORY R243 KArchive REVISION DETAIL https://

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. Yes, the pitfalls are well known. 1. don't modify the container being iterated upon (from inside the loop) 2. don't use qAsConst on temporaries and for performance reasons, "don't use range-for over a non-const container", but that's of course not as bad as

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

meven marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in katedialogs.cpp:1294 > Given this text ends on a button , use "&Close File". > See also https://hig.kde.org/style/writing/capitalization.html > > More perfect might be even to use User Interf

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

meven updated this revision to Diff 56231. meven added a comment. Capitalization & add context for translation REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20542?vs=56211&id=56231 BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org

Re: New framework: KCalCore

On 14 April 2019 12:31:41 BST, David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on > libical, > > I wonde

D20552: Don't use qAsConst over a temporary variable

dfaure updated this revision to Diff 56230. dfaure added a comment. Improve regexp to avoid catching kbuildsycoca.cpp REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20552?vs=56229&id=56230 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20

D20552: Don't use qAsConst over a temporary variable

dfaure created this revision. dfaure added reviewers: mlaurent, cfeck, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY (will crash because the temporary will be destroyed before being used)

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ECMAndroidDeployQt.cmake:41 > if (NOT VALUE STREQUAL "") > -string(FIND "${VALUE}" ".so\"" OUT) > -math(EXPR OUT "${OUT}+4") > -

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dropsmoothoverrideproperty REVISION DETAIL https://phabricator.kde.org/D20510 To: kossebau, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, mic

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

cullmann added a reviewer: ngraham. cullmann added a comment. Perhaps Nate has feedback, too. I have no issues with this change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham Cc: cullmann, kossebau, kwrite-devel, kde-fram

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

kossebau added a comment. Before: F6771686: Screenshot_20190412_191738.png After: F6771688: Screenshot_20190414_184746.png See also notes for the need at https://techbase.kde.org/Development/Tutorials/Pl

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

kossebau created this revision. kossebau added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH antialiasoxygenclockhands REVISION DETAIL

D20519: Fix double delete on broken files

aacid updated this revision to Diff 56218. aacid added a comment. update with test from dfaure + local tweak REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20519?vs=56161&id=56218 BRANCH arcpatch-D20519 REVISION DETAIL https://phabricator.kde.org/D20

D20519: Fix double delete on broken files

aacid added a comment. In D20519#449595 , @dfaure wrote: > Good catch. > I'd still prefer if such changes would come with a unittest, because it will be hard otherwise to immediately detect (while developing) that changes don't introduce any

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

kossebau added a comment. A good example to see how the smooth property was broken is the animation of the analog clock's hands (best enable second hand to see often): the Hand.qml has "smooth: !anim.running" set as property for the SvgItem. Without this patch, the hand during animation loo

D20284: Fix l/100 km to MPG conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R292:bc7495095baa: Fix l/100 km to MPG conversion (authored by madcatx, committed by aacid). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=56203&id=562

D20284: Fix l/100 km to MPG conversion

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik, #frameworks, aacid Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

kossebau added inline comments. INLINE COMMENTS > katedialogs.cpp:1294 > } else { > -QAction * closeFile = new QAction(i18n("&Close"), this); > +QAction * closeFile = new QAction(i18n("&Close file"), this); > > closeFile->setIcon(QIcon::fromTheme(QStringLiteral("doc

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added inline comments. INLINE COMMENTS > dfaure wrote in kbookmarkowner.h:120 > Every version of KF5 is source and binary compatible (just like Qt5). > The next time for a possible BC breakage will be KF6 (when Qt6 comes out), so > not just yet. > > Two alternative solutions: > > - crea

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

meven created this revision. meven added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 406305 REPOSITORY R39 KTextEditor BRANCH close-file REV

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns marked 4 inline comments as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56206. bruns added a comment. add apidox, cleanup REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56166&id=56206 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524 AFFECT

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a comment. In D20524#449784 , @ngraham wrote: > In D20524#449668 , @elvisangelaccio wrote: > > > Hmm, it seems you need to rebase this patch: > > > Worked for me: > >INFO B

D20526: fix extracting of some properties to match what was writen

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. In D20526#449780 , @bruns wrote: > In D20526#449560 , @astippich wrote: > > > I

D20284: Fix l/100 km to MPG conversion

madcatx marked an inline comment as done. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik, #frameworks, aacid Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On Sunday, April 14, 2019 7:31:41 AM EDT David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > I w

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. In D20525#449788 , @ngraham wrote: > +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow: > > F6771538: Screenshot_20190414_081327.png

D20489: [KIO] Make it compile without foreach (Step 1)

cfeck added a comment. Do we understand all possible regressions that this can cause? If yes, where are they documented so that we can verify? See bug 406426. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cfeck, aacid, cgiboudeaux, kde-f

D20284: Fix l/100 km to MPG conversion

madcatx marked 2 inline comments as done. madcatx added inline comments. INLINE COMMENTS > aacid wrote in fuel_efficiency.cpp:36 > I understand what you mean here, but i don't think that reciprocal is the > word that describes this (are you a native speaker? if so maybe it's juts > that my engl

D20284: Fix l/100 km to MPG conversion

madcatx updated this revision to Diff 56203. madcatx added a comment. More obvious explanation of the meaning of `m_isReciprocal` REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=56201&id=56203 REVISION DETAIL https://phabricator.kde.org/D

D20525: [InformationPanel] Use the new inline configuration mode

ngraham added a comment. +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow: F6771538: Screenshot_20190414_081327.png I imagine it would be even worse in German or with a Romance language. Ma

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

ngraham added a comment. In D20524#449668 , @elvisangelaccio wrote: > Hmm, it seems you need to rebase this patch: Worked for me: INFO Base commit is not in local repository; trying to fetch. Created and checked out branch ar

D20525: [InformationPanel] Use the new inline configuration mode

ngraham added a reviewer: VDG. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20526: fix extracting of some properties to match what was writen

bruns added a comment. In D20526#449560 , @astippich wrote: > IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. > How about inserting the

D20284: Fix l/100 km to MPG conversion

madcatx updated this revision to Diff 56201. madcatx added a comment. Added an inverse test with initial value in MPG REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=55574&id=56201 REVISION DETAIL https://phabricator.kde.org/D20284 AFFEC

D20529: add license to python test files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH py_license REVISION DETAIL https://phabricator.kde.org/D20529 To: astippich, bruns Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, ast

D19445: Handle variant list in formatting functions

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > propertyinfotest.cpp:91 > { Property::BitRate, true, 1470, > QStringLiteral("14.7 Mbit/s")}, > +{ Property::BitRate,

D20528: Change properties attributes for consistency

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. 10 lines removed, 1 added, 10 times more functionality 👍 REPOSITORY R286 KFileMetaData BRANCH properties_consistency REVISION DETAIL https://phabricator.kde.org/D20528 To: astippich,

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20534: avoid conflicting shortcuts for switching tabs

cullmann added a comment. Upsa, pushed it with my copyright update :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadatawidget.h:47-49 > Can you add some apidox for this enum? In particular, it's not so clear what > `ReStart` is used for. Sure, just wanted to see if the (UI) design itself is deemed appropriate. REPOSITORY R824

D20534: avoid conflicting shortcuts for switching tabs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:9f2ffd36c587: avoid conflicting shortcuts for switching tabs (authored by cullmann). REPOSITORY R39 KTextEditor CHAN

D20525: [InformationPanel] Use the new inline configuration mode

bruns edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20529: add license to python test files

bruns added a subscriber: bcooksley. bruns added a comment. @bcooksley - these tests currently fail to run under Windows: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 WindowsMSVCQt5.11/149/testReport > "C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5 WindowsMSVCQt

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. :=) Nice that it helps. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added a comment. Yes! A short test looked very promising. Will play a little more, because had done some changes to this patch here :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, c

D20536: Use consistent default Kickoff user icon

GB_2 updated this revision to Diff 56196. GB_2 added a comment. Use symlinks instead of copying the icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56195&id=56196 BRANCH use-consistent-default-kickoff-user-icon (branched from master)

D20536: Use consistent default Kickoff user icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add the 22px default user icon that is used everywhere else. F6771466: Consistent Default

  1   2   >