D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @ngraham Are you still working on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Are you working on it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, p

D20467: Allow to close a document whose file was deleted on disk

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. INLINE COMMENTS > katedialogs.cpp:1298 > +m_message->addAction(closeFile, false); > +connect(closeFile, SIGNAL(triggered()), this, > SIGNAL(closeTrigg

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 153 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/153/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 03:52:13 + Build duration: 26 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 03:52:18 + Build duration: 22 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.57.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/61/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Apr 2019 03:52:13 + Build duration: 9 min 33 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/68/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Apr 2019 03:52:13 + Build duration: 8 min 25 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/71/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 12 Apr 2019 03:52:13 + Build duration: 3 min 25 sec and counting JUnit Tests Nam

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga added a comment. With `krarc`, users can open 7z and RAR files as folder in Dolphin (with patches [1] [2]). This is also useful for Gwenview - if you have pictures in a 7z or RAR archive, then you can view them in Gwenview without decompressing the whole archive to another location. Ho

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

kossebau added a comment. For the hint as introduced with D20112 . Looks like this then: F6767766: Screenshot_20190412_015729.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricat

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

kossebau created this revision. kossebau added reviewers: Plasma, VDG, mart, davidedmundson, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH adaptbreezec

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 11 Apr 2019 23:56:48 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5Plas

D20477: Avoid indirection when inserting basic data

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY When setFileItem() is called, m_fileItems.size() is always 1, for setFileItems() there are always multiple element

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 11 Apr 2019 23:41:57 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Apr 2019 23:47:28 + Build duration: 3 min 30 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 152 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/152/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Apr 2019 23:46:25 + Build duration: 2 min 17 sec and counting CONSOLE OUTPU

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/70/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 11 Apr 2019 23:45:29 + Build duration: 2 min 8 sec and counting JUnit Tests Name

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/66/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Apr 2019 23:41:57 + Build duration: 5 min 29 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 151 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/151/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Apr 2019 23:41:57 + Build duration: 3 min 49 sec and counting CONSOLE OUTPU

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 11 Apr 2019 23:41:57 + Build duration: 3 min 25 sec and counting JUnit Tests Nam

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

This revision was automatically updated to reflect the committed changes. Closed by commit R242:38ba8beee3a5: Keep desktoptheme SVG files uncompressed in repo, install svgz (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20166?vs=55383&id=56025#toc REPOSITORY R24

D11828: Simplify orPostingIterator and make it faster

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8fcd690fe853: Simplify orPostingIterator and make it faster (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=53527&id=56021 REVISION DETA

D20332: Ensure QFileInfo is valid for the first FilteredDirIterator entry

This revision was automatically updated to reflect the committed changes. Closed by commit R293:899ed35c6872: Ensure QFileInfo is valid for the first FilteredDirIterator entry (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20332?vs=55621&id=

D20331: [MTimeDB] Allow timestamp newer than the newest document in range match

This revision was automatically updated to reflect the committed changes. Closed by commit R293:94c39a1d5c69: [MTimeDB] Allow timestamp newer than the newest document in range match (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20331?vs=556

D20330: [MTimeDB] Use exact match when exact match is requested

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c6fc67aba070: [MTimeDB] Use exact match when exact match is requested (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20330?vs=55619&id=56018 REV

D20460: [balooctl] Cleanup handling of different positional arguments

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6f4f31b89b0f: [balooctl] Cleanup handling of different positional arguments (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20460?vs=55951&id=5601

D20459: [balooctl] Extend options help text, improve error checking

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f235bbf2ed93: [balooctl] Extend options help text, improve error checking (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20459?vs=55950&id=56016

D11828: Simplify orPostingIterator and make it faster

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Let's get this in. REPOSITORY R293 Baloo BRANCH speedup_orpostingoperator REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: n

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger updated this revision to Diff 56009. ekurzinger added a comment. removed C-style casts REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18824?vs=51709&id=56009 REVISION DETAIL https://phabricator.kde.org/D18824 AFFECTED FILES src/server/CMak

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, #kwin Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

lbeltrame added a comment. +1. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20332: Ensure QFileInfo is valid for the first FilteredDirIterator entry

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. REPOSITORY R293 Baloo BRANCH fileinfo REVISION DETAIL https://phabricator.kde.org/D20332 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-

D20331: [MTimeDB] Allow timestamp newer than the newest document in range match

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh gosh. REPOSITORY R293 Baloo BRANCH fix_mtimedb REVISION DETAIL https://phabricator.kde.org/D20331 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks

D20330: [MTimeDB] Use exact match when exact match is requested

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_mtimedb REVISION DETAIL https://phabricator.kde.org/D20330 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham added a comment. In D20424#448303 , @bcooksley wrote: > @ngraham The people you will be finding will be those who hold developer accounts - because their information is available in kde-common/accounts, that information is also made acc

D11828: Simplify orPostingIterator and make it faster

bruns marked 5 inline comments as done. bruns added a comment. Ping ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks, poboiko Cc: fvogt, kde-frameworks-devel, #frameworks, gennad, domson, ashaposhnikov, michaelh, astippich, spoo

D20459: [balooctl] Extend options help text, improve error checking

bruns added a comment. In D20459#448252 , @ngraham wrote: > Aaargh, forgot to click submit. There are some more still open: D20330 , D20331 , D20332

D20358: Force en locale for propertyinfotest

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoor

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

bcooksley added a comment. @ngraham The people you will be finding will be those who hold developer accounts - because their information is available in kde-common/accounts, that information is also made accessible on Identity. The people you're trying to find will likely be non-developers

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik added a comment. I think so, it's the very same patch in that bugreport :) So, this patch makes even more sense, I only considered the Plasma case REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-

D20464: [knotifyconfig] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R305:ad212a667946: [knotifyconfig] make it compile without foreach (authored by mlaurent). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20464?vs=55982&id=56005

D20007: Add GetProcessList for retrieving the list of currently active processes

davidedmundson added a comment. Looks good to me. \o/ Hopefully a windows person can test soon. Failing that, it's near the start of the month and we have a good unit test. We can ship it and see what CI says. INLINE COMMENTS > kprocesslist.cpp:69 > +{ > +d_ptr->valid = other.d_pt

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. Ping - anyone ;) REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. And I propose a different one :) IMHO bundling these two is sub-optimal as it creates an unnecessary dependency on kde-specific libraries and limits its deployment. To me, this is the equivalent of bundling the audio thumbnailer with taglib. Well, if we disag

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. @davidedmundson - could you please take a look at this again? I have implemented all the stuff you suggested ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio

D20460: [balooctl] Cleanup handling of different positional arguments

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20460 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mich

D20459: [balooctl] Extend options help text, improve error checking

ngraham accepted this revision. ngraham added a comment. Aaargh, forgot to click submit. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20459 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashapos

D17500: Get mobipocket extractor up-to-date, but keep disabled

ltoscano added a comment. The proposed solution to remove the loop is moving the extractor to the kdegraphics-mobipocket repository. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel,

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 56002. astippich added a comment. - add comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55760&id=56002 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES a

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. It creates a dependency loop as you pointed out in the first comment REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, ashaposhniko

D20459: [balooctl] Extend options help text, improve error checking

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20459 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mi

D18824: Implement wl_eglstream_controller Server Interface

zzag resigned from this revision. zzag added a comment. I don't have any NVIDIA hardware to test these patches so I'm kinda useless. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, #kwin Cc: ngraham, mati865, schernikov

D18824: Implement wl_eglstream_controller Server Interface

zzag added inline comments. INLINE COMMENTS > eglstream_controller_interface.cpp:58 > +Q_UNUSED(client); > +Private *p = (Private *)wl_resource_get_user_data(resource); > +emit p->q->streamConsumerAttached(SurfaceInterface::get(surface), (void > *)eglStream, attribs); Please don't u

D20467: Allow to close a document whose file was deleted on disk

meven marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks Cc: ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D20467: Allow to close a document whose file was deleted on disk

meven updated this revision to Diff 55999. meven added a comment. Add a comma REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20467?vs=55987&id=55999 BRANCH arcpatch-D20467 REVISION DETAIL https://phabricator.kde.org/D20467 AFFECTED FILES src/dia

D18824: Implement wl_eglstream_controller Server Interface

ngraham added a comment. @romangg, are you satisfied with this now? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, bruns

D20467: Allow to close a document whose file was deleted on disk

ngraham added inline comments. INLINE COMMENTS > katedialogs.cpp:1296 > + > closeFile->setIcon(QIcon::fromTheme(QStringLiteral("document-close"))); > +closeFile->setToolTip(i18n("Close the file discarding its > content.")); > +m_message->addAction(closeFile, false); `fil

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham added a comment. In D20424#448184 , @aacid wrote: > In D20424#448115 , @ngraham wrote: > > > Unfortunately the search on that page is largely non-functional and I can't find you there. Can y

Re: New framework: KCalCore

On Monday, 8 April 2019 02:44:46 CEST Alexander Potashev wrote: > вс, 7 апр. 2019 г. в 17:24, Alexander Potashev : > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an implementation o

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

aacid added a comment. This patch also seems to show there's an architectural shortcoming here. KIO should not know about some protocol that is krusader specific. I don't want to block on this, but it'd be good to open a bug so maybe someone at some point finds a better solution.

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

aacid added a comment. In D20424#448115 , @ngraham wrote: > Unfortunately the search on that page is largely non-functional and I can't find you there. Can you put the info in a comment here? For the record, search is functional, it's jus

D20467: Allow to close a document whose file was deleted on disk

meven added a comment. In D20467#448127 , @ngraham wrote: > > There is still a confirmation dialog afterwards currently. > > I might be in favor of removing it. > > +1, once you've made the decision to close the deleted file, the confirmat

D20464: [knotifyconfig] make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20464 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, brun

D20467: Allow to close a document whose file was deleted on disk

ngraham added a comment. > There is still a confirmation dialog afterwards currently. > I might be in favor of removing it. +1, once you've made the decision to close the deleted file, the confirmation dialog is unnecessary and annoying. REPOSITORY R39 KTextEditor REVISION DETAIL

D20467: Allow to close a document whose file was deleted on disk

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20467: Allow to close a document whose file was deleted on disk

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

ngraham added a comment. Unfortunately the search on that page is largely non-functional and I can't find you there. Can you put the info in a comment here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20424 To: nhiga, kde-frameworks-devel, ngraham Cc: ngraham, micha

D20169: Add profile support interface for TerminalInterface

ngraham added reviewers: cfeck, hein. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: michaelh, ngraham, bruns

D20467: Allow to close a document whose file was deleted on disk

cullmann added reviewers: Kate, Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=379887? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20467: Allow to close a document whose file was deleted on disk

meven edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20467: Allow to close a document whose file was deleted on disk

meven created this revision. meven added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY There is still a BUG: 406305 FIXED-IN: 19.09 TEST PLAN Manuall

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It asks kuiserver whether we need to display a widget job tracke

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D20464: [knotifyconfig] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R305 KNotifyConfig

D19445: Handle variant list in formatting functions

apol added a comment. Patch looks good to me, @bruns note that you still have it set as "changes required". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhniko

D20284: Fix l/100 km to MPG conversion

madcatx marked an inline comment as done. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik, #frameworks, aacid Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

nicolasfella added a comment. In D20433#447667 , @bruns wrote: > This approach is completely wrong. > > The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the property

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame, kossebau, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the process providing the kuiser

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd marked an inline comment as done. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:8072a6acf221: Add support for passing cursor information via URL parameters when running… (authored by arrowd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18296?vs=55879&id=55973#toc REPOS

D19908: [ConfigModule] Pass initial properties

This revision was automatically updated to reflect the committed changes. Closed by commit R296:238a49139fd6: [ConfigModule] Pass initial properties in push() (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19908?vs=54398&id=55969 R

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:890 > This is wrong in case someone uses details > 3, should be `case 0: > reserve(5)`, `case 3: default: reserve(15)` . > all checks below do e.g `if (details > 2)`, so handle 5 the sa