D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-09 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > dfaure wrote in urlinfo.h:77 > But then you can't do `kde-open5 www.google.fr` anymore, right? > > I see what you mean with typo handling, but there is no perfect solution. > Either we treat typos as URLs (but it means we also treat actual URLs as

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-09 Thread Gleb Popov
arrowd updated this revision to Diff 55879. arrowd marked 5 inline comments as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=54774&id=55879 BRANCH cursor REVISION DETAIL https://phabr

D20367: Add alternatives icon

2019-04-09 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

2019-04-09 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

2019-04-09 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20367: Add alternatives icon

2019-04-09 Thread Björn Feber
GB_2 added a comment. I made a revision to improve it here: D20426 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg, ngraham Cc: Codezela, abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20426: Improve "widget-alternatives" icon

2019-04-09 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

2019-04-09 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. TEST PLAN Open Cuttlefish and search for `widget-alternatives`. REPOSITORY R266 Breeze Icons BRANCH master R

D20233: Add syntax highlighting for fish shell

2019-04-09 Thread Arnd Diestelhorst
adiestelhorst added a comment. I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code. When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

D20425: KateIconBorder: Code cosmetic

2019-04-09 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: cullmann. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY There should be no logic cha

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

2019-04-09 Thread N. Higa
nhiga created this revision. nhiga added a reviewer: kde-frameworks-devel. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY If Krusader is installed, the `krarc` protocol is available and Dolphin may use it to open ZIP archives. In this case, when the

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 34 - Failure!

2019-04-09 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

2019-04-09 Thread Nathan Shearer
nathanshearer added a comment. Hi Christoph, I just wanted to say thanks for working on this. It will be great when I can interact with these files again via KDE and its suite of apps. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #frameworks, #d

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 75 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 00:42:50 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/80/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 00:42:51 + Build duration: 8 min 25 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 147 - Still unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/147/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Apr 2019 00:42:50 + Build duration: 3 min 7 sec and counting JUnit Tests

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/80/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 00:42:51 + Build duration: 1 min 13 sec and counting JUnit Tests Name:

D20422: KZip: fix Heap-use-after-free in broken files

2019-04-09 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid, apol Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 146 - Still Failing!

2019-04-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/146/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 31 min and counting CONSOLE OUTPUT [

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/79/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/79/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

D20422: KZip: fix Heap-use-after-free in broken files

2019-04-09 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY when compiling with no asserts Broken oss-fuzz file doesn't crash anymore REPOSITORY R243 KArchive BRANCH master

D20422: KZip: fix Heap-use-after-free in broken files

2019-04-09 Thread Albert Astals Cid
aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 57 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 26 min and counting BUILD ARTIFACTS acc/KF5Plas

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-09 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > arrowd wrote in urlinfo.h:39 > > const QString & > > There is `path.chop(match.capturedLength());`, which requires non-const > `QString`. > > > And what if it's a URL? At this point this string is pathOrUrl. > > Well, `if (QFile::exists(path))`

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/63/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/67/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 16 min and counting JUnit Tests Name: pro

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

2019-04-09 Thread Albert Astals Cid
aacid added a comment. In the "Add Action..." combo you should have an "Abandon" option REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham,

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Albert Astals Cid
aacid added a comment. In D17500#446937 , @astippich wrote: > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think

D20417: Add invokable public API for emitting contextualActionsAboutToShow

2019-04-09 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This signal is emitted just before showing the context menu to al

D19908: [ConfigModule] Pass initial properties

2019-04-09 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19445: Handle variant list in formatting functions

2019-04-09 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > propertyinfo.cpp:650 > +for (const auto& entry : valueList) { > +displayList << (d->formatAsString)(entry); > +} `displayList << d->formatAsString(entry);` REPOSITORY R286 KFileMetaData REVI

D20042: Show the plasmoid context menu on long tap

2019-04-09 Thread Aleix Pol Gonzalez
apol added a comment. In D20042#446770 , @ngraham wrote: > That seems... quite sub-optimal to me. > > Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab t

D20367: Add alternatives icon

2019-04-09 Thread Hazem Salem
Codezela added a comment. I think in small size it will be difficult to recognize this icon because it has a lot of datils we need to use more simple version of it I found this on the web as example of what I mean we can review them as a base https://pngtree.com/free-icon/replace_78422

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2019-04-09 Thread Stefan Brüns
bruns added a comment. In D10657#446950 , @broulik wrote: > Superseded by D10657 Superseded by itself? D19677 ? REPOSITORY R245 Solid REVISION DETAIL https://ph

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/78/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 22 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/78/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 145 - Still Failing!

2019-04-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/145/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 9 min 32 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 2 min 17 sec and counting BUILD ARTIFACTS acc/KF5F

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2019-04-09 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Herald added a subscriber: kde-frameworks-devel. Superseded by D10657 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc:

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2019-04-09 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D14290 To: broulik, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

2019-04-09 Thread Kai Uwe Broulik
broulik added a comment. Pingeliping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Alexander Stippich
astippich added a comment. The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient. REPOSITORY R286 KFileMetaDa

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Luigi Toscano
ltoscano added a comment. So no plans for moving it to kdegraphics-mobipocket? It's a dependency loop. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, ashap

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in file.cpp:850-870 > No, he means using a const& for the argument, e.g: > > inline static uint16_t stat_mode(struct statx &buf) { return buf.stx_mode; } Thanks REPOSITORY R241 KIO BRANCH a

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven updated this revision to Diff 55850. meven added a comment. Fix src/ioslaves/file/ConfigureChecks.cmake REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55849&id=55850 BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven updated this revision to Diff 55849. meven added a comment. Use passing references to stat_xxx accessors, use a signed long long for file size REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55709&id=55849 BRANCH arcpatch-D20096 REVISION DETA

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

2019-04-09 Thread Ahmed Bilal
ahmedbilal added a comment. In D20312#446923 , @svuorela wrote: > In D20312#445122 , @ahmedbilal wrote: > > > > > > > > > @svuorela If system have user with same Real Name it would return t

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

2019-04-09 Thread Sune Vuorela
svuorela added a comment. In D20312#445122 , @ahmedbilal wrote: > > @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there see

D17500: Restore mobipocket extractor

2019-04-09 Thread Alexander Stippich
astippich updated this revision to Diff 55848. astippich added a comment. - rebase and update - update test - disable mobi extractor REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47335&id=55848 BRANCH mobi REVISION DETAIL https://p

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Alexander Stippich
astippich retitled this revision from "Restore mobipocket extractor" to "Get mobipocket extractor up-to-date, but keep disabled". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano

D20358: Force en locale for propertyinfotest

2019-04-09 Thread Alexander Stippich
astippich added a comment. https://bugreports.qt.io/browse/QTBUG-75069 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abr

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

2019-04-09 Thread Alexander Stippich
astippich added a comment. windows build fails https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20133 To: bruns, #baloo, #frameworks, #windows, #freebsd, ngrah

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > meven wrote in file.cpp:850-870 > Unfortunately this is not possible here : statx is also a function, the > compiler gets messed up when removing the struct keyword interpreting it as a > function call. > > > /file/file.cpp:850:34: warning: inline

D19960: bluez-qt: remove warnings

2019-04-09 Thread David Rosca
drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Actually ... INLINE COMMENTS > a2dp-codecs.c:59 > AAC_OBJECT_TYPE_MPEG4_AAC_SCA, */ > -AAC_INIT_FREQUENCY( > +AAC_INIT_FREQUENCY(( > /*AAC_SAMPLING_FREQ_8000 |

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in file.cpp:850-870 > Do you mean the struct keyword in the argument in "inline static uint16_t > stat_mode(struct statx buf) { return buf.stx_mode; } " for instance ? Unfortunately this is not po

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in file.cpp:850-870 > We can get all stat_xxx functions buf as reference, struct is not needed when > you use C++. Do you mean the struct keyword in the argument in "inline static uint16_t stat_mode(struct statx buf) { return

Re: New framework: KContacts

2019-04-09 Thread Volker Krause
On Tuesday, 9 April 2019 03:11:57 CEST Aleix Pol wrote: > On Sat, Apr 6, 2019 at 6:02 PM Volker Krause wrote: > > Hi, > > > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > > > KContacts is essentially an implementation of the vCard standard, covering > > the data mode

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Nathaniel Graham
ngraham added a dependent revision: D20404: Allow the baloo widgets to display creation date and access date.. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bco

D19960: bluez-qt: remove warnings

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. @drosca I think you'll have to land this for @carneirogustavo. REPOSITORY R269 BluezQt BRANCH remove_compile_warnings REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca Cc: ngraham, pino, kd

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > file.cpp:850-870 > +inline static uint16_t stat_mode(struct statx buf) { return buf.stx_mode; } > +inline static uint32_t stat_dev(struct statx buf) { return > buf.stx_dev_major; } > +inline static uint64_t stat_ino(struct statx buf) { retu

Re: New framework: KCalCore

2019-04-09 Thread Volker Krause
On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > covering the dat

D19960: bluez-qt: remove warnings

2019-04-09 Thread David Rosca
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH remove_compile_warnings REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca Cc: pino, kde-frameworks-devel, m

D19445: Handle variant list in formatting functions

2019-04-09 Thread Alexander Stippich
astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20042: Show the plasmoid context menu on long tap

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. That seems... quite sub-optimal to me. Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab task for it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://

D19736: Add view-orientation-auto/landscape/portrait

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. How about a lock icon inside the rectangles to show that they're locked to that orientation? Those vertical and horizontal lines in the current version conjure up movement in my mind, which doesn't seem appropriate. REPOSITORY R266 Breeze Icons REVISION DETAIL h

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. So are we ready to land this, or is there anything left to do? REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-deve

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/62/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 7 min 7 sec and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 56 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 4 min 22 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

2019-04-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/66/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 3 min 42 sec and counting JUnit Tests Nam

D20342: Update KDE logo to be closer to original

2019-04-09 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1bc240faf1c0: Update KDE logo to be closer to original (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20342?vs=55772&id=55818 REVISION DET

D18933: Allow compositors to send discrete axis values

2019-04-09 Thread Vlad Zagorodniy
zzag retitled this revision from "Allow compositors to send discrete axis deltas" to "Allow compositors to send discrete axis values". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraha

D18933: Allow compositors to send discrete axis deltas

2019-04-09 Thread Vlad Zagorodniy
zzag retitled this revision from "Send optional events from wl_pointer v5" to "Allow compositors to send discrete axis deltas". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, brun

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-09 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

2019-04-09 Thread Noah Davis
ndavis retitled this revision from "Add screen-rotate-auto-on/off" to "Add view-orientation-auto/landscape/portrait". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To

D19736: Add screen-rotate-auto-on/off

2019-04-09 Thread Noah Davis
ndavis updated this revision to Diff 55804. ndavis added a comment. - Change to 3 icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=53826&id=55804 BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736

D15318: Automatically re-upload saved files located on remote locations instead of asking first

2019-04-09 Thread John Maverick
maverick74 added a comment. That would be great! It looks very bad the way it is ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: maverick74, elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngra

D19960: bluez-qt: remove warnings

2019-04-09 Thread Tomaz Canabrava
tcanabrava added a comment. ping? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

2019-04-09 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > broulik wrote in coronatest.cpp:216 > why not make the container `const`? Because this variable is use in code see line 228 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure