D20332: Ensure QFileInfo is valid for the first FilteredDirIterator entry

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY FilteredDirIterator returns its own path for th

D20331: [MTimeDB] Allow timestamp newer than the newest document in range match

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the timestamp in a LessEqual match is n

D20330: [MTimeDB] Use exact match when exact match is requested

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY As MDB_SET_RANGE moves the cursor to the first

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 23:15:45 + Build duration: 15 min and counting BUILD ARTIFACTS acc/KF5Baloo-5.57.0.xm

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 23:07:15 + Build duration: 8 min 29 sec and counting BUILD ARTIFACTS acc/KF5Baloo-5.5

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 06 Apr 2019 23:07:15 + Build duration: 8 min 46 sec and counting BUILD ARTIFACTS abi-compatibility

D20329: [DocumentIdDB] Silence non-error debug message, warn on errors

This revision was automatically updated to reflect the committed changes. Closed by commit R293:765b4c7cccbe: [DocumentIdDB] Silence non-error debug message, warn on errors (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20329?vs=55609&id=556

D20327: [baloosearch] Allow specifying a time when using e.g. mtime

This revision was automatically updated to reflect the committed changes. Closed by commit R293:67ab4d69d483: [baloosearch] Allow specifying a time when using e.g. mtime (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20327?vs=55607&id=55617

D20299: [indexcleaner] Avoid removing included folders below excluded ones

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0a154d1470f1: [indexcleaner] Avoid removing included folders below excluded ones (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20299?vs=55537&id

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/50/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 06 Apr 2019 23:07:15 + Build duration: 2 min 50 sec and counting JUnit Tests Name: projectro

D20318: [MTimeDB] Add some tests which include a 0 mtime

This revision was automatically updated to reflect the committed changes. Closed by commit R293:55fb8db5e227: [MTimeDB] Add some tests which include a 0 mtime (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20318?vs=55589&id=55615 REVISION D

D20317: [MTimeDB] Fix lookup for the LessEqual range

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9f395a0b0b65: [MTimeDB] Fix lookup for the LessEqual range (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20317?vs=55588&id=55614 REVISION DETAI

D20316: [MTimeDB] Fix lookup when time range should return empty set

This revision was automatically updated to reflect the committed changes. Closed by commit R293:fe7c3f13ecac: [MTimeDB] Fix lookup when time range should return empty set (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20316?vs=55587&id=55613

D20315: Correct asserts/error handling in MTimeDB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:93ee76ba3659: Correct asserts/error handling in MTimeDB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20315?vs=55586&id=55612 REVISION DETAIL

D20299: [indexcleaner] Avoid removing included folders below excluded ones

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice catch. Can confirm that it fixes this annoying issue. Please land prior to tagging. REPOSITORY R293 Baloo BRANCH indexcleaner REVISION DETAIL https://phabricator.kde.org

D20329: [DocumentIdDB] Silence non-error debug message, warn on errors

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20329 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

ngraham added inline comments. INLINE COMMENTS > main.cpp:139 > +stream << "GivenINode:" << Baloo::idToInode(fid) << " > ActualINode:" << Baloo::idToInode(actualFid) << "\n"; > +stream << "GivenDeviceID:" << Baloo::idToDeviceId(fid) << " > ActualDeviceID:" << Bal

D20327: [baloosearch] Allow specifying a time when using e.g. mtime

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20327 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20318: [MTimeDB] Add some tests which include a 0 mtime

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20318 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, ast

D20316: [MTimeDB] Fix lookup when time range should return empty set

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20316 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, ast

D20315: Correct asserts/error handling in MTimeDB

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nicely done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20315 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ge

D20317: [MTimeDB] Fix lookup for the LessEqual range

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20317 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, ast

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 22:25:39 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5FileMet

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 06 Apr 2019 22:25:39 + Build duration: 5 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 06 Apr 2019 22:25:39 + Build duration: 2 min 47 sec and counting BUILD ARTIFACTS abi-comp

D20324: Fix build with exiv2 0.28

This revision was automatically updated to reflect the committed changes. Closed by commit R286:50d14ea058b5: Fix build with exiv2 0.28 (authored by nicolasfella). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20324?vs=55610&id=55611 REVISION DETAIL

D20284: Fix l/100 km to MPG conversion

ngraham added reviewers: Frameworks, aacid. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik, #frameworks, aacid Cc: aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

ngraham edited the summary of this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik Cc: aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

ngraham added a comment. Yeah, we should land this after 5.57 tagging so we have a month of pre-release testing, so it should be `FIXED-IN: 5.58`. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcook

D20324: Fix build with exiv2 0.28

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH exiv REVISION DETAIL https://phabricator.kde.org/D20324 To: nicolasfella, mgallien, astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michael

D20324: Fix build with exiv2 0.28

nicolasfella added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:152 > Why not just `#if EXIV2_TEST_VERSION(0,28,0)` ? That makes an awful lot of sense REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20324 To: nicolasfella, mgallien, astip

D20324: Fix build with exiv2 0.28

nicolasfella updated this revision to Diff 55610. nicolasfella added a comment. - Use EXIV_TEST_VERSION REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20324?vs=55600&id=55610 BRANCH exiv REVISION DETAIL https://phabricator.kde.org/D20324 AFFECT

D20329: [DocumentIdDB] Silence non-error debug message, warn on errors

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MDB_NOTFOUND is not an error, remove the messag

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/68/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 06 Apr 2019 21:34:32 + Build duration: 36 min and counting JUnit Tests Name: projec

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY balooshow allows to query file information by d

D20327: [baloosearch] Allow specifying a time when using e.g. mtime

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, the search results can only limited

D20324: Fix build with exiv2 0.28

bruns added inline comments. INLINE COMMENTS > exiv2extractor.cpp:152 > > +#ifdef HAVE_EXIV_028 > +Exiv2::Image::UniquePtr image; Why not just `#if EXIV2_TEST_VERSION(0,28,0)` ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20324 To: nicolasfella, mgalli

D20315: Correct asserts/error handling in MTimeDB

dfaure added a comment. +1 from me, thanks for the quick patch. Needs approval from someone who knows the code though. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20315 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, g

D20324: Fix build with exiv2 0.28

nicolasfella edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20324 To: nicolasfella, mgallien, astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 21:34:32 + Build duration: 2 min 48 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/68/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 06 Apr 2019 21:34:32 + Build duration: 3 min 14 sec and counting BUILD ARTIFACTS abi-comp

D20310: Use nullptr instead of NULL

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1de8b370725b: Use nullptr instead of NULL (authored by nicolasfella). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20310?vs=55577&id=55603 REVISION DETAIL

D20324: Fix build with exiv2 0.28

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: mgallien, astippich, bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20324 To: nicolasfella, mgallien, astippich, bruns Cc: k

D20324: Fix build with exiv2 0.28

nicolasfella created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH exiv REVISION DETAIL https://phabricator.kde.org/D20324 AFFECTED FILES

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. My systems have several users named "Sune Vuore

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

bruns added a comment. In D20280#444616 , @bruns wrote: > The assert is just plain wrong ... See D20315 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20280 To: bruns, #baloo,

D20299: [indexcleaner] Avoid removing included folders below excluded ones

bruns added a comment. As this fixes a regression introduced between KF 5.56 and KF 5.57, it would be nice to have this fixed prior to tagging. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20299 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-fr

D20318: [MTimeDB] Add some tests which include a 0 mtime

bruns created this revision. bruns added reviewers: Baloo, Frameworks, dfaure, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Checks for D20315

D20317: [MTimeDB] Fix lookup for the LessEqual range

bruns added a dependent revision: D20318: [MTimeDB] Add some tests which include a 0 mtime. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20317 To: bruns, #baloo, #frameworks, dfaure, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, m

D20316: [MTimeDB] Fix lookup when time range should return empty set

bruns created this revision. bruns added reviewers: Baloo, Frameworks, dfaure, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MDB_RANGE_SET sets the cursor to the fi

D20317: [MTimeDB] Fix lookup for the LessEqual range

bruns created this revision. bruns added reviewers: Baloo, Frameworks, dfaure, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MDB_RANGE_SET sets the cursor to the fi

D20315: Correct asserts/error handling in MTimeDB

bruns created this revision. bruns added reviewers: Baloo, Frameworks, dfaure, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Mtime == 0 is valid (see commits 784214

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

aacid added a comment. This code seems like it could live in Okular instead of kcoreaddons? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 17:59:57 + Build duration: 2 min 42 sec and counting BUILD ARTIFACTS ac

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demskin

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags updated this revision to Diff 55583. nibags added a comment. - Ok! Adding autotest references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19438?vs=55475&id=55583 BRANCH arcpatch-D19438 REVISION DETAIL https://phabricator.kde.org/

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added reviewers: Frameworks, kde-frameworks-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: Okular. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added reviewers: Okular, okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. This helper function will be needed in places where we only have access to author/user's Full name. For Example, PDFs have Full Name in authors. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal Cc: kde-frameworks-d

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added inline comments. INLINE COMMENTS > elvisangelaccio wrote in urlinfo.h:45-52 > Why doesn't it parse the URL if the file already exists? If the file is named `foo:123`, it refuses to search for cursor infomation and just open it. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#444642 , @elvisangelaccio wrote: > Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? I just copied this from Kate p

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmedbilal requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH usernameFromFullname REVISION DETAIL https://phabricator.kde.org/D20312 AFFECTED FILES

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

elvisangelaccio added a comment. Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? INLINE COMMENTS > urlinfo.h:45-52 > +if (QFile::exists(path)) { > +/** > + * create absol

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added a comment. I think the code itself is good to go now. Can you please update the summary somewhat (and better do it directly in phabricator, as arc will throw away any changes in the commit message, unless you do a - `arc amend`, update the commit message in git, `arc diff -

D20310: Use nullptr instead of NULL

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH nullptr REVISION DETAIL https://phabricator.kde.org/D20310 To: nicolasfella, #frameworks, bruns, mgallien, astippich Cc: kde-framewor

D20197: Fix desktop link to file or directory

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kurlrequester.cpp:262 > bool m_startDirCustomized; > +bool m_fileDialogModeWasDirFile; > KUrlRequester * const m_parent; // TODO: rename to 'q'

D20197: Fix desktop link to file or directory

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20310: Use nullptr instead of NULL

nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, bruns, mgallien, astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20310 To: nicolasfella, #frameworks, bruns, mgallien, astippich Cc: kde-frameworks-devel, #bal

D20310: Use nullptr instead of NULL

nicolasfella created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH nullptr REVISION DETAIL https://phabricator.kde.org/D20310 AFFECTED FIL

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

bruns added a comment. In D20280#09 , @dfaure wrote: > Somewhere around this commit, the unittest started to fail. > > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.10/job/baloo/job/kf5-qt5%20SUSEQt5.10/47/ > > QFAT

D20264: Add test for "Auto Reload Document" option

loh.tar updated this revision to Diff 55576. loh.tar edited the summary of this revision. loh.tar added a comment. - Enhance the test by checks for proper cursor position While adding your tiny change, it pointed out, that the test was not correct regarding needed waiting times. Pls compa

New framework: KContacts

Hi, I'd like to propose KContacts for review to move from KDE PIM to KF5. KContacts is essentially an implementation of the vCard standard, covering the data model as well as parsing and creating of vCard files. As the recent CI issue showed it's used outside of KDE PIM as well, therefore we wo

D20284: Fix l/100 km to MPG conversion

madcatx updated this revision to Diff 55574. madcatx added a comment. 1. Tweaked conversion factor to match those used by Google online converter 2. Added test to convert l/100 km to other representations and back REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabric

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 15:24:51 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS acc/KF5Archive

D20260: Fix crash in KArchive::findOrCreate with broken files

aacid added a comment. In D20260#444580 , @dfaure wrote: > OK, fair point. Assuming someone keeps running oss-fuzz regularly :-) oss-fuzz runs automatically daily (or twice daily not sure). "Public" (i.e. discovered and more than 90 days

D20260: Fix crash in KArchive::findOrCreate with broken files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:ad3cf347e44a: Fix crash in KArchive::findOrCreate with broken files (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20260?vs=55461&id=55573 RE

D20284: Fix l/100 km to MPG conversion

aacid added a comment. is having an autotest for this possible? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To: madcatx, broulik Cc: aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, fair point. Assuming someone keeps running oss-fuzz regularly :-) REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20260 To: aacid, dfaure Cc:

D20260: Fix crash in KArchive::findOrCreate with broken files

aacid added a comment. In D20260#443721 , @apol wrote: > Looks good, would it be possible to get a test case? Do we want a lot of crashy/broken files on the source code repo? Honestly i'm not sure it's worth it given that oss-fuzz will ju

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

nicolasfella added a reviewer: broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. The patch is currently quite naive. Should I add a check if (!device.endsWith('/') ? Is it sound enough ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a reviewer: lukas. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven created this revision. meven added a reviewer: bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The nfs mounted device are listed without a trailing / according to my testing, preventing t

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. Looking good to me, @bruns: any addiitonal comments? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added inline comments. INLINE COMMENTS > fvogt wrote in file.cpp:1033 > This check seems to be wrong with me - there can be files with legitimate > zero `tv_nsec`. > > Use `buff.stx_mask & STATX_BTIME` instead. Thanks for the feedback, I read about stx_mask after writing this. REPOSITOR

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55539. meven marked an inline comment as done. meven added a comment. Use stx_mask to check for btime availability REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55183&id=55539 BRANCH arcpatch-D20096 REVISION DET

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

dfaure added a comment. Somewhere around this commit, the unittest started to fail. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.10/job/baloo/job/kf5-qt5%20SUSEQt5.10/47/ QFATAL : WriteTransactionTest::testRemoveRecursively() ASSERT: "mtime > 0" in file /home/jen

KDE CI: Frameworks » modemmanager-qt » kf5-qt5 SUSEQt5.12 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/modemmanager-qt/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:28 + Build duration: 1 hr 12 min and counting BUILD ARTIFACTS acc/KF5

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 10:05:56 + Build duration: 41 min and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kemoticons » kf5-qt5 SUSEQt5.12 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:39 + Build duration: 1 hr 9 min and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.12 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:31 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.12 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:35:56 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » kunitconversion » kf5-qt5 SUSEQt5.12 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:27 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kjs » kf5-qt5 SUSEQt5.12 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:27 + Build duration: 1 hr 5 min and counting BUILD ARTIFACTS acc/KF5JS-5.57.0.xml

KDE CI: Frameworks » kcrash » kf5-qt5 SUSEQt5.12 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:22 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » kguiaddons » kf5-qt5 SUSEQt5.12 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:36:25 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS acc/KF5GuiAdd

  1   2   >