D20220: AppArmor & SELinux: remove one indentation in XML files

nibags added a dependent revision: D20221: AppArmor: don't highlight variable assignments and alias rules within profiles. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20220 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55326. astippich added a comment. - rebase on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54956&id=55326 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.org/D19445 A

D20220: AppArmor & SELinux: remove one indentation in XML files

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY This only removes an indenta

D20219: Propose Stefan Bruns as KFileMetaData maintainer

astippich added a comment. I think @bruns is much more qualified than me as a maintainer as I lack overall experience in programming. He still finds wrong stuff in almost any revision of mine :) also +1 for baloo REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://p

D20219: Propose Stefan Bruns as KFileMetaData maintainer

mgallien added subscribers: bruns, mgallien. mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for all the work going on. I am really happy to see all the work done by @bruns REPOSITORY R286 KFileMetaData BRANCH master REV

D20219: Propose Stefan Bruns as KFileMetaData maintainer

ngraham added subscribers: astippich, ngraham. ngraham added a comment. I'd say Baloo too, or instead. In fact @astippich has been doing a lot of high quality work for KFileMetadata too. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20219 To: apol, #framewor

D20219: Propose Stefan Bruns as KFileMetaData maintainer

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY He has been doing most of the work lately and seems very active, I'd say he is

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Apr 2019 00:15:53 + Build duration: 9 min 1 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/61/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Apr 2019 00:14:36 + Build duration: 6 min 11 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Apr 2019 00:09:11 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/60/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Apr 2019 00:09:11 + Build duration: 5 min 24 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/61/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Apr 2019 00:11:04 + Build duration: 1 min 48 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/60/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Apr 2019 00:09:11 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

D20032: Convert string formatting tests to be data driven

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4d48330829d9: Convert string formatting tests to be data driven (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20032?vs=55073&id=55322 R

D20031: Declare PropertyInfo as QMetaType

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e02feb62049e: Declare PropertyInfo as QMetaType (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20031?vs=54740&id=55321 REVISION DETAIL

D20032: Convert string formatting tests to be data driven

bruns added a comment. In D20032#442635 , @apol wrote: > Whatever. > @bruns Have you considered becoming the module maintainer? :) Thats fine for me. Where do I have to deliver my soul? ;-) REPOSITORY R286 KFileMetaData BRANCH sub

D20031: Declare PropertyInfo as QMetaType

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20031 To: bruns, #baloo, #frameworks, ngraham, astippich, apol Cc: apol, kde-frameworks-dev

D20032: Convert string formatting tests to be data driven

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Whatever. @bruns Have you considered becoming the module maintainer? :) REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #balo

D20031: Declare PropertyInfo as QMetaType

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20031 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20032: Convert string formatting tests to be data driven

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: mgallien, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abraham

D20033: Default string formatting test to C locale, add localized run

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20033 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20046: Verify mimetypes for all existing sample files, add some more

bruns added a subscriber: bcooksley. bruns added a comment. hexdump -n 11 -C autotests/samplefiles/test.AppImage 7f 45 4c 46 02 01 01 00 41 49 02 |.ELFAI.| grep -v comment /usr/share/mime/packages/freedesktop.org.xml | grep -B13 '*\.appimage'

D18604: Implement support for writing rating information for taglib writer

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH rating_write2 REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, a

D20121: Test ffmpeg extractor using mime type helper

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_mimetypes REVISION DETAIL https://phabricator.kde.org/D20121 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippic

D20216: Export path of kwalletd binary for kwallet_pam

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D20216 To: davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18365: Add a flag to keep a window on top

broulik added a comment. +1 also needed for critical notifications, cf D20154 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: broulik, apol, zzag, kde-frameworks-devel, michaelh, ngraham, brun

D20216: Export path of kwalletd binary for kwallet_pam

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY kwallet_pam requires the path to the kwalletd binary. Currently this is hardcoded. TEST PLAN Looked a

D20210: [Label] Bump import version so padding properties are available

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN The following works now PlasmaComponents.Label { leftPadding: ... } REPOS

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55303. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Set proper start/end column independent from selection direction. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D194

D20121: Test ffmpeg extractor using mime type helper

astippich updated this revision to Diff 55301. astippich added a comment. - add friend and use member function REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20121?vs=55059&id=55301 BRANCH ffmpeg_mimetypes REVISION DETAIL https://phabricator.kde

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas created this revision. hallas added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Add support for KBookmarkOwner to communicate if it has tabs open. This is

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55298. astippich added a comment. - cleanup and formatting REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=55127&id=55298 BRANCH rating_write2 REVISION DETAIL https://phabricator.kde.org/D18604 AF

D18845: authority: add support for passing details to polkit

ngraham added a comment. Landed and changed the comment. @chinmoyr, what's next for T8075: Fix security issues with KAuth support in KIO ? REPOSITORY R563 Polkit-1 Qt Library REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks

D18845: authority: add support for passing details to polkit

This revision was automatically updated to reflect the committed changes. Closed by commit R563:f26ada834aea: authority: add support for passing details to polkit (authored by mgerstner, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18845?vs=54931&id=55297#toc REP

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 02 Apr 2019 18:29:11 + Build duration: 6 min 59 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 18:29:11 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS abi-comp

D20046: Verify mimetypes for all existing sample files, add some more

astippich added a comment. This causes one test failure on FreeBSD: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20046 To: bruns, #baloo, #frameworks, astippich, ngraha

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/59/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 18:29:11 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

D20082: Safeguard against invalid files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1ac4253f3cf0: Safeguard against invalid files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20082?vs=54958&id=55296 REVISION DETAIL

D20208: Fix uninitialized memory read in KZip

This revision was automatically updated to reflect the committed changes. Closed by commit R243:299f5cae228c: Fix uninitialized memory read in KZip (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20208?vs=55293&id=55295 REVISION DETAIL

D20208: Fix uninitialized memory read in KZip

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20208 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

This revision was automatically updated to reflect the committed changes. Closed by commit R39:81a8d573ecaf: DocumentPrivate: Add option "Auto Reload Document" to View menu (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19517?vs=55199

D20208: Fix uninitialized memory read in KZip

aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20208 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20208: Fix uninitialized memory read in KZip

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We were passing handledextralen instead of n to parseExtraField We could also do a n < parseExtraField check earlier an

D18845: authority: add support for passing details to polkit

davidedmundson accepted this revision. REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns, davidedmundson Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

D18845: authority: add support for passing details to polkit

ngraham added a comment. So what's next for this? Can this land now or do we need to change the comment first? REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

D20197: Fix desktop link filter

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This doesn't work. Try creating a symlink to a directory. In the file picker dialog, the Open button doesn't work. See https://bugs.kde.org/show_bug.cgi?id=357171 for more c

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol retitled this revision from "Depends on D20191" to "Expose locked keystates on KModifierKeyInfo when on wayland". apol edited the summary of this revision. apol added a dependency: D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work. REPOSITORY R273 KGu

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20193: Expose locked keystates on KModifierKeyInfo when on wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20197: Fix desktop link filter

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55284. loh.tar added a comment. - QCOMPARE also the selection in tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55280&id=55284 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES autotests/src/katedocument_test.

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar added a comment. >> Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block > > Hmm, I think this counts as a bug. Have trouble to reproduce now. Was that fixed somewhere

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55280. loh.tar edited the test plan for this revision. loh.tar added a comment. - Add some auto tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55272&id=55280 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES a

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. After this patch I intend to update KFileItemPrivate::init to add birthtime there in the same manner. Perhaps it would be good to group the stax/QL_STAT code somewhere rather than spread. And then there is baloo-widgets and perhaps some dolphin work for this to

D20202: FrameSvgItem: add "mask" property

kossebau added a dependent revision: D20203: desktoppackage: add "panelMask" property for Panel.qml. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20202 To: kossebau, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20202: FrameSvgItem: add "mask" property

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This property allows e.g. the Plasma shell to query the shape a panel has when de

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55272. loh.tar added a comment. - Rebase on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=52906&id=55272 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexted

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/59/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 12:38:09 + Build duration: 11 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/58/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 12:04:16 + Build duration: 33 min and counting JUnit Tests Name: pro

D20193: Depends on D20191

dfaure added a comment. Still no description visible here :) REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D20193 To: apol Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/47/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 12:09:12 + Build duration: 3 min 53 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/55/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 02 Apr 2019 12:09:11 + Build duration: 3 min 59 sec and counting BUILD ARTIFACTS abi-c

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

davidedmundson added inline comments. INLINE COMMENTS > keystate.xml:34 > + > + > + I would just send the initial stateChanged on bind REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, mi

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/54/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 02 Apr 2019 12:04:16 + Build duration: 4 min 53 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/46/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 12:04:16 + Build duration: 4 min 55 sec and counting BUILD ARTIFACTS abi-c

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9de0def99f96: [Dialog] Don't forward hover event when there is nowhere to forward it to (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabrica

D20199: [Menu] Fix triggered sign

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9aa249e86a34: [Menu] Fix triggered signal (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20199?vs=55263&id=55267 REVISION

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We have a bug report about infinite loop in the notifications. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20200 To: broulik

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Dialog has this clever way of re-sending a mouse event inside the bounardies of the d

D20199: [Menu] Fix triggered sign

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20199 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20199: [Menu] Fix triggered sign

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It casted the `QAction` to a `MenuItem` which fails because it isn't such. Instead,

Re: CI system maintainability

On Sat, Mar 30, 2019 at 10:46 PM Volker Krause wrote: > > On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > > I fear that a mandatory reviews would add too juch strain on smaller > > > teams. If there's just one person with an int

D20197: Fix desktop link filter

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Set FileMode of the QFileDialog to QFileDialog::AnyFile instead of QFileDialog::Directory if KUrlRequest

D20196: RFC: Add Notify capability to KConfigXT

davidedmundson added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:217 > */ > template < typename T > class KConfigSkeletonGenericItem: public > KConfigSkeletonItem > { Can you move the new flag into KConfigSkeletonItem which is d-pointered and expose write flags with a protecte

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. I think this is good enough as it is. I would prefer that we in the future just switch over to use the syntax-highlighting themes, but that is a lot of work :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.

D20196: RFC: Add Notify capability to KConfigXT

broulik edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Lets you specify `Notifiers=` in `.kcfg` for config entries

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/66/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 01 Apr 2019 23:56:50 + Build duration: 8 hr 11 min and counting BUILD ARTIFACTS abi-compatibility-r