CI system maintainability

Hi all, We currently have a rather substantial issue, in that the CI system has been once again left in a position where it isn't possible to make any changes to the system. This means we can't update to newer versions of packages, add new packages or correct for binary incompatible changes which

D20083: Multiple level of autobrace

loh.tar added a comment. This patch looks similar to D12295 My suggestion to the issue D19608 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20083 To: cactus Cc: loh.tar, kwrite-devel, kd

D20085: Expose a method to show the context menu of an applet from QML

apol created this revision. apol added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Decouples the code that shows it and exposes it to the different containments and applets

D17302: Add test for adding properties to result

bruns added a comment. IMHO this test is pointless, as the contents of the variant map is inaccessible, it is only an intermediate storage. The correct way to retrieve the data is via `Result::document()`. Or you can just accept D19087 , which already chec

D20083: Multiple level of autobrace

cactus created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cactus requested review of this revision. REVISION SUMMARY Currently, only one level of autobrace is working. If the user type (()), the result is (())). Th

D20063: Sublime Merge Icon.

ngraham added a comment. In D20063#439575 , @ndavis wrote: > but for some reason I see myself as the author of the commit instead of @otavva F6726093: Screenshot_20190327_182023.png That's how it lo

D20063: Sublime Merge Icon.

ndavis added a comment. Oh wait no, it's not there yet, but it still looks pretty good. However, I did notice this on a closer inspection of the shapes: F6726111: Screenshot_20190327_182820.png @otavva, could you make the top shape more like h

D20063: Sublime Merge Icon.

ndavis added a comment. In D20063#439465 , @ngraham wrote: > I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you. No, it's there, but

D20026: Go up in folder hierachy when in "edit mode"

ngraham added a comment. This doesn't build: /home/nate/kde/src/kio/src/widgets/kurlcombobox.cpp: In member function ‘void KUrlComboBox::setUrls(const QStringList&, KUrlComboBox::OverLoadResolving, KUrlComboBox::OldUrlPolicy)’: /home/nate/kde/src/kio/src/widgets/kurlcombobox.cpp:19

D20011: Be more precise with mimetype detection

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH mimetypes REVISION DETAIL https://phabricator.kde.org/D20011 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngr

D20011: Be more precise with mimetype detection

astippich edited the summary of this revision. astippich edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20011 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngrah

D20011: Be more precise with mimetype detection

astippich updated this revision to Diff 54959. astippich added a comment. - use new mime type helper REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20011?vs=54649&id=54959 BRANCH mimetypes REVISION DETAIL https://phabricator.kde.org/D20011 AFFECTED FIL

D20082: Safeguard against invalid files

astippich added a comment. Seems like a good idea in general, and a patch for upstream to fix the crash was rejected. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, mi

D20082: Safeguard against invalid files

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Invalid vorbis files may crash in taglib due to a dereference on an

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/25/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 19:45:02 + Build duration: 4 min 27 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/54/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 19:42:21 + Build duration: 7 min 34 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 19:45:02 + Build duration: 4 min 21 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 19:45:02 + Build duration: 3 min 19 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 19:42:21 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/54/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 19:42:22 + Build duration: 1 min 3 sec and counting JUnit Tests Name: p

D17302: Add test for adding properties to result

astippich added a comment. ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

ngraham added a comment. @dfaure is this good now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/53/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 19:28:41 + Build duration: 2 min 49 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 19:28:44 + Build duration: 2 min 36 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/47/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 19:26:06 + Build duration: 2 min 37 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 19:26:06 + Build duration: 2 min 34 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/53/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 19:27:21 + Build duration: 1 min 1 sec and counting JUnit Tests Name: p

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 54956. astippich marked an inline comment as done. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54651&id=54956 BRANCH generic_display_list REVISION

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/52/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 19:26:06 + Build duration: 1 min 13 sec and counting JUnit Tests Name:

D20012: Fix number localization for properties

This revision was automatically updated to reflect the committed changes. Closed by commit R286:607286e97229: Fix number localization for properties (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20012?vs=54950&id=54953 REVISION

D20013: Use Qt function for string list formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R286:3a83a49a4350: Use Qt function for string list formatting (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54951&id=54954 REVI

D20013: Use Qt function for string list formatting

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Worst that can happen is a translators just happens to translate it **now**, and then it is just some unnecessary, but trivial work done without need. REPOSITORY R286 KFileMetaData BRANCH

D20013: Use Qt function for string list formatting

astippich added a comment. Is removing a string allowed during string freeze? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bru

D20012: Fix number localization for properties

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_value_localization REVISION DETAIL https://phabricator.kde.org/D20012 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, as

D19445: Handle variant list in formatting functions

astippich removed a dependent revision: D20013: Use Qt function for string list formatting. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, s

D20013: Use Qt function for string list formatting

astippich removed a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D20013: Use Qt function for string list formatting

astippich updated this revision to Diff 54951. astippich added a comment. - rebase directly on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54653&id=54951 BRANCH string_list_formatting REVISION DETAIL https://phabricator.kde.or

D20012: Fix number localization for properties

astippich updated this revision to Diff 54950. astippich added a comment. - remove unit test changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20012?vs=54650&id=54950 BRANCH fix_value_localization REVISION DETAIL https://phabricator.kde.org

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. BTW - I tried locally chaning the D19989 patch to use the new `KProcessList::processInfoList` function and that enables us to achieve the same thing but without the KSysGuard dependency, so that's great :) Another thing, shoul

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. In D20007#438640 , @adridg wrote: > On FreeBSD, `/proc` is not necessarily mounted (it might be a Linuxism). So while I do **have** `/proc`, it's empty because procfs isn't mounted there. If I **do** mount it, then there'

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added inline comments. INLINE COMMENTS > davidedmundson wrote in kprocesslisttest.cpp:38 > KUser::KUser() > > (fortunately it's in kcoreaddons!) Nice :) I didn't know that one > davidedmundson wrote in kprocesslisttest.cpp:52 > qint64 QCoreApplication::applicationPid() Got it - I have

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas updated this revision to Diff 54949. hallas marked 7 inline comments as done. hallas added a comment. Implemented review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20007?vs=54827&id=54949 BRANCH adds_kprocesslist (branched from ma

D20032: Convert string formatting tests to be data driven

bruns added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:71 > First 2 rows expanded, just for you: > > QTest::addRow("%s", > PropertyInfo(DiscNumber).displayName().toUtf8().constData()) << > PropertyInfo(Property::DiscNumber) << true << QVariant(2018) << > QStringL

D20063: Sublime Merge Icon.

ngraham added a comment. I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This is very nice. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-dev

D20063: Sublime Merge Icon.

ngraham added a comment. Ooh, I like it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, Io

D19990: Switch URLs to https

This revision was automatically updated to reflect the committed changes. Closed by commit R304:b05ec5ed5c0c: Switch URLs to https (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19990?vs=54598&id=54943#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE htt

D20063: Sublime Merge Icon.

otavva added a comment. F6725369: Screenshot_20190327_191302.png Maybe this color will be better? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg

D20077: Accept any HTTP status between 100 and 199 as benign

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D20077 To: leinir, #knewstuff, #frameworks, ngraham Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D18845: authority: add support for passing details to polkit

ngraham added a comment. @mgerstner can you provide your email address so we can land this patch with correct authorship information? REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: ngraham, mati865, kde-frameworks-devel

D18845: authority: add support for passing details to polkit

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thanks REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: ngraham, mati865, kde-frameworks-devel

D20042: Show the plasmoid context menu on long tap

mart added a comment. In D20042#439381 , @ngraham wrote: > Don't we want long-press-for-context-menu when using a touchscreen on the desktop? this patch is not "on desktop specific" also, in the desktop area, long press always was selec

D19850: Make AppStream generation opt-in

ngraham added a comment. In D19850#439332 , @sitter wrote: > LGTM technically. Also looks crazy scary invasive though from a packaging POV :O > > What if a third party user of kpackage actively relied on the appstream data being auto-generat

D20042: Show the plasmoid context menu on long tap

ngraham added a comment. Don't we want long-press-for-context-menu when using a touchscreen on the desktop? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20042 To: apol, #plasma, #frameworks, mart Cc: mart, ngraham, kde-frameworks-devel, michael

D20063: Sublime Merge Icon.

trickyricky26 added a comment. I think the cyan color is too bright and saturated. It fits the original branding well, but stands out from other Breeze icons. I would suggest using a darker, more blue than cyan color. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.

D20063: Sublime Merge Icon.

otavva added a comment. I think that Sublime Merge use Sublime Text license. It is free for use, too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pix

D20063: Sublime Merge Icon.

otavva updated this revision to Diff 54935. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54864&id=54935 REVISION DETAIL https://phabricator.kde.org/D20063 AFFECTED FILES icons-dark/apps/48/sublime-merge.svg icons/apps/48/sublime-merge.sv

D20042: Show the plasmoid context menu on long tap

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. for now we could go with this... can you make it work *only* when the applet's formfactor is horizontal or vertical? so this codepath wouldn't touch the desktop case at all REPOS

D20042: Show the plasmoid context menu on long tap

mart added a comment. what happens on long tap on the desktop? this introduces different behavior between long tap on panel and desktop REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20042 To: apol, #plasma, #frameworks Cc: mart, ngraham, kde-fr

D20042: Show the plasmoid context menu on long tap

ngraham added a comment. Much better now, thanks! I'll let a real #plasma person do the final code review. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20042 To: apol, #plasma, #frameworks Cc: ngraha

D19850: Make AppStream generation opt-in

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 54934. hoffmannrobert marked 4 inline comments as done. hoffmannrobert added a comment. - Fix cmp() #2 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54932&id=54934 BRANCH add_skipStat REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert added a comment. KFileItemTest::testCmp() failed - fixed. JobTest also fails, but this fails in master, too. Something with FileCopyJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-fr

D19850: Make AppStream generation opt-in

sitter added a comment. LGTM technically. Also looks crazy scary invasive though from a packaging POV :O What if a third party user of kpackage actively relied on the appstream data being auto-generated? Wouldn't this change in behavior essentially break backwards compatibility? Perhaps

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 54932. hoffmannrobert added a comment. - Fix cmp(), SkipMimeTypeFromContent rename, change isDir() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54862&id=54932 BRANCH add_skipStat REVISION DETAIL http

D19990: Switch URLs to https

vkrause added a comment. Yep, those were checked, which is also why some of those are still on http. See also D19996 for the tools used for this. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D19990 To: vkrau

D20078: RFC fix race on kcrash auto-restarts

sitter added subscribers: broulik, davidedmundson. sitter added a comment. Still fairly messy and very verbose but working. @broulik @davidedmundson I'd love some thoughts on this. Also, @davidedmundson since you suggested the registration queuing. I do wonder if that isn't actually

D18845: authority: add support for passing details to polkit

mgerstner updated this revision to Diff 54931. mgerstner added a comment. Now using `constData()` as suggest by chinmoyr. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18845?vs=51753&id=54931 REVISION DETAIL https://phabricator.kde.org/D18845 AFFECTED FILES core/polkitqt1-auth

D20078: RFC fix race on kcrash auto-restarts

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY When kcrash is set to auto restart Unique service processes we have potential for a race. Because KCrash will want to id

D19990: Switch URLs to https

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM, as long as all the various sites being pointed at there actually resolve on https, which i'm guessing (going by your summary) you've checked? :) REPOSITORY R304 KNewStuff BRANCH

D20077: Accept any HTTP status between 100 and 199 as benign

apol added a comment. LGTM REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D20077 To: leinir, #knewstuff, #frameworks Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20077: Accept any HTTP status between 100 and 199 as benign

leinir updated this revision to Diff 54928. leinir retitled this revision from "Accept HTTP status 103 as benign" to "Accept any HTTP status between 100 and 199 as benign". leinir edited the summary of this revision. leinir added a comment. Just accept any informational status as benign, rathe

D20077: Accept HTTP status 103 as benign

leinir added a comment. In D20077#439290 , @apol wrote: > And why are 101 and 102 bad? > Should we just accept between 100 and 200? Hmm... You're probably right, yes, 100 is supposed to be all benign status type stuff, so... yeah, i'll

D20077: Accept HTTP status 103 as benign

apol added a comment. And why are 101 and 102 bad? Should we just accept between 100 and 200? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D20077 To: leinir, #knewstuff, #frameworks Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

apol added a comment. etc. INLINE COMMENTS > datamodel.cpp:309 > > -foreach (const QString &key, m_dataSource->data()->keys()) { > +const auto lst = m_dataSource->data()->keys(); > +for (const QString &key : lst) { same? Also this should clearly be using iterators, no? > toolt

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1b56cc62c93d: kio_smb: Change incorrect use of QUrl::adjusted() (authored by marten). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19439?vs=52884&id=54927 REV

D20077: Accept HTTP status 103 as benign

leinir created this revision. leinir added reviewers: KNewStuff, Frameworks. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In December 2017, a new status code was

D18845: authority: add support for passing details to polkit

mgerstner added inline comments. INLINE COMMENTS > chinmoyr wrote in polkitqt1-authority.cpp:336 > Nitpick; constData() because the API seems to take const gchar* Strictly spoken it already returns `const gchar*`, since `toUtf8()` returns a `const QByteArray` temporary object and thus the `cons

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in kdiroperator.h:916 > Missing @since 5.57 Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven updated this revision to Diff 54924. meven added a comment. fix copyright REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54869&id=54924 BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES src/filewidg

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

sitter accepted this revision. sitter added a comment. Ha, this is also much nicer looking. I love it! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew,

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks. Did you also run the kio unittests to ensure they still pass? INLINE COMMENTS > kfileitem.cpp:203 > // stat() local files if needed > // TODO: delay this un

D19875: [Kactivities-stats] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R159:5b969c5e6a55: [Kactivities-stats] compile without foreach (authored by mlaurent). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19875?vs=54294&id=54

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fix_recent_documents_kicker_hang REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: apol, ngraham, plasma-devel, jral

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, nav

D19875: [Kactivities-stats] compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure, ivan Cc: kde-frameworks-devel, michaelh, ng

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 07:50:18 + Build duration: 3 min 1 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 07:50:18 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 54920. mlaurent added a comment. Fix comment reported by Apol REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=54407&id=54920 BRANCH compile_without_foreach (branched from master) REVISION