D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#437715 , @dfaure wrote: > ... > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this co

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Mar 2019 06:49:21 + Build duration: 3 min 35 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Mar 2019 06:49:21 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS abi-comp

D20021: Add support for extracting data from ogg and ts files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2a76b11e1e9f: Add support for extracting data from ogg and ts files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54726&id=

D19930: [kwallets] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R311:0da6f73eddc0: [kwallets] compile without foreach (authored by mlaurent). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19930?vs=54455&id=54750 REVISION DETAIL h

D19967: [kpeople] make it compile without foreach

mlaurent updated this revision to Diff 54749. mlaurent added a comment. Fix error reported by david REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54563&id=54749 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://ph

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/41/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Mar 2019 04:54:20 + Build duration: 45 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Mar 2019 04:54:24 + Build duration: 27 min and counting BUILD ARTIFACTS abi-compatibility-res

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Mar 2019 04:54:19 + Build duration: 9 min 14 sec and counting BUILD ARTIFACTS abi-c

D20034: Pass focus to child searchbar when KPluginSelector is focused

ngraham added reviewers: Plasma, Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D20034 To: jayeshbhoot, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20034: Pass focus to child searchbar when KPluginSelector is focused

jayeshbhoot created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jayeshbhoot requested review of this revision. REVISION SUMMARY This commit is a precursor to autofocusing on searchbar in plasmasearch kcm module. BUG: 399516 REPOSITORY

D20032: Convert string formatting tests to be data driven

bruns added a dependent revision: D20033: Default string formatting test to C locale, add localized run. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhniko

D20031: Declare PropertyInfo as QMetaType

bruns added a dependent revision: D20032: Convert string formatting tests to be data driven. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20031 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh,

D20033: Default string formatting test to C locale, add localized run

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Using the user locale leads to random test failures, as

D20032: Convert string formatting tests to be data driven

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Less boilerplate code in the actual test data. Depe

D20031: Declare PropertyInfo as QMetaType

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Required for data driven unit tests, probably useful els

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#437670 , @arvidhansson wrote: > In D19952#437419 , @ndavis wrote: > > > This can be done in the system tray widget instead of making a separate icon for off. Ever n

D19887: Proposal for KFileItem to skip stat()

dfaure added a comment. OK so I read about the use case in https://phabricator.kde.org/D19784 and it confirms my suspicion: the right fix is to do the stat on demand, called from those methods that need the information it gathers -- with a boolean to check that we only do it once of course.

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure added a comment. > If they point to files on a network drive, and the network or the drive is not responding Well that's exactly the problem with network mounts, and the reason they are a sucky technical solution. KIO's async jobs never have that problem. You will never be

D20005: Report human-readable error if Qt5Widgets is required but is not found

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D20005 To: aspotashev, #frameworks, apol Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK so this is about KFileItem::text() and KFileItem::iconName(). Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KF

D19930: [kwallets] compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19930 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

aacid added a comment. Makes sense to me REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D20005 To: aspotashev, #frameworks Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The added signal seems fine to me. Much less black magic than an event filter (which would have been the other option). INLINE COMMENTS > kdiroperator.h:916 > +/** > + *

D20021: Add support for extracting data from ogg and ts files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, as

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#437419 , @ndavis wrote: > In D19952#436853 , @arvidhansson wrote: > > > In D19952#436834 , @taskf wrote: > > >

D19876: Fix: apply correctly the text colors of the chosen scheme

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. one minor nit, otherwise looks like a good improvement INLINE COMMENTS > katehighlight.cpp:78 > +if (schema == QLatin1String("Normal")) { > +return QLatin1String("Defa

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#436919 , @taskf wrote: > Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state

D20016: Don't set a null completer on a non-editable combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R284:c955994053a7: Don't set a null completer on a non-editable combobox (authored by elvisangelaccio). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20016?vs=54683

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/68/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Mar 2019 17:51:26 + Build duration: 2 hr 38 min and counting JUnit Tests Name: projectroot

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss added a task: T10716: Add check for accidental http: usage. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54726. astippich added a comment. - Add failing ogg video test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54725&id=54726 BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabricator.kde.org/D

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. forgot rebasing... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54725. astippich added a comment. - Add failing ogg video test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54707&id=54725 BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabricator.kde.org/D

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

ngraham added a comment. To update it, you just run `arc diff` again while on your branch. No need to even do `git add`! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

ngraham added a comment. Do you need a hand with navigating Phabricator's weirdness? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20025 To: krutovmikhail, #dolphin, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20025 To: krutovmikhail, #dolphin, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. This was created as a new revision due to --amend prior to arc diff. Not sure on how to update diff on previous one properly, previous is abandoned now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dol

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail retitled this revision from "Initial adaptation of patch from Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy when in "edit mode"". krutovmikhail edited the summary of this revision. krutovmikhail added reviewers: ngraham, Dolphin. REPOSITORY R241 KIO REVI

D20026: Initial adaptation of patch from Dolphin; keyUp -> goUp

krutovmikhail created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. krutovmikhail requested review of this revision. REPOSITORY R241 KIO BRANCH mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode REVISION DETAIL https

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

krutovmikhail retitled this revision from "WIP: Initial adaptation of patch from Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy when in "edit mode"". krutovmikhail edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2

D20025: WIP: Initial adaptation of patch from Dolphin; keyUp -> goUp

krutovmikhail retitled this revision from "Initial adaptation of patch from Dolphin; keyUp -> goUp" to "WIP: Initial adaptation of patch from Dolphin; keyUp -> goUp". krutovmikhail added reviewers: Dolphin, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20025 To:

D20025: Initial adaptation of patch from Dolphin; keyUp -> goUp

krutovmikhail created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. krutovmikhail requested review of this revision. REPOSITORY R241 KIO BRANCH mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode REVISION DETAIL https

D20021: Add support for extracting data from ogg and ts files

bruns added a comment. In D20021#437531 , @astippich wrote: > What I meant is that no metadata is currently extracted at all. Is it possible to mark a complete test row as expected failure? `QEXPECT_FAIL("Vorbis Video", "Not yet supporte

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Mar 2019 18:56:51 + Build duration: 2 min 27 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/47/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Mar 2019 18:56:51 + Build duration: 2 min 26 sec and counting BUILD ARTIFACTS abi-comp

D20020: Split ffmpeg tests into video properties and metadata tests

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6ee3df16ab20: Split ffmpeg tests into video properties and metadata tests (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20020?vs=547

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. What I meant is that no metadata is currently extracted at all. Is it possible to mark a complete test row as expected failure? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-de

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with that. In the long run we should use only the syntaxhighlighting themes and provide UX for that. Volunteers? REPOSITORY R39 KTextEditor BRANCH fix-schemas REVISION DETA

D20020: Split ffmpeg tests into video properties and metadata tests

ngraham accepted this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrah

D20016: Don't set a null completer on a non-editable combobox

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kcombobox.cpp:94 > Q_D(KComboBox); > d->init(); > setEditable(rw); Hmm? This calls init() on editable comboboxes too. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricat

D20012: Fix number localization for properties

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:97 > This will of course fail as soon as someone translates fps, e.g. german > "B/s", even more in RTL locales. > > Probably the better solution is to provide the whole string verbatim, and > mark it with i1

D20020: Split ffmpeg tests into video properties and metadata tests

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, micha

D20020: Split ffmpeg tests into video properties and metadata tests

astippich updated this revision to Diff 54708. astippich added a comment. - rephrase comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20020?vs=54705&id=54708 BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020

D20020: Split ffmpeg tests into video properties and metadata tests

bruns added a comment. ..., otherwise, LGTM INLINE COMMENTS > ffmpegextractortest.cpp:53 > > -void ffmpegExtractorTest::videoTest() > +//test only for testing intrinsic video properties > +void ffmpegExtractorTest::testVideoProperties() a little bit to much "test" here ;) and missing space

D20020: Split ffmpeg tests into video properties and metadata tests

astippich retitled this revision from "Split ffmpeg tests into common properties and metadata" to "Split ffmpeg tests into video properties and metadata tests". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54707. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54686&id=54707 BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabricator.kde.org/D20021 AFFECTED FILES a

D20020: Split ffmpeg tests into common properties and metadata

astippich updated this revision to Diff 54705. astippich added a comment. - rename tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20020?vs=54685&id=54705 BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020 AFFE

D20021: Add support for extracting data from ogg and ts files

bruns added a comment. In D20021#437489 , @astippich wrote: > For reasons unknown, the metadata is not correctly extracted and "title" is not found for ogg videos, that's why it is not included there. I would like to investigate this later.

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. For reasons unknown, the metadata is not correctly extracted and "title" is not found for ogg videos, that's why it is not included there. I would like to investigate this later. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: nibags, #ktexteditor, #kate, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags updated this revision to Diff 54702. nibags added a comment. - Pass schema name as parameter I've also done debug and everything works as it should. Any problem or detail to change, don't hesitate to say REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricat

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/67/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Mar 2019 15:52:03 + Build duration: 1 hr 59 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Mar 2019 17:14:09 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compatibility-result

D20005: Report human-readable error if Qt5Widgets is required but is not found

aspotashev updated this revision to Diff 54695. aspotashev retitled this revision from "WIP: Find Qt5Widgets, required for Qt5::uic" to "Report human-readable error if Qt5Widgets is required but is not found". aspotashev added a comment. Implement probably the most lightweight behaviour. REP

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436853 , @arvidhansson wrote: > In D19952#436834 , @taskf wrote: > > > There is one issue I'm not sure about. The user might feel pressured to check something if th

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/50/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Mar 2019 17:14:09 + Build duration: 9 min 38 sec and counting BUILD ARTIFACTS abi-compatibility-

D20008: Fix uninitialized value in SimpleJobPrivate

This revision was automatically updated to reflect the committed changes. Closed by commit R241:920d2c4ca7d5: kjobs: Fix compiler warning for uninit value in SimpleJobPrivate. (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20008?vs=54642&id=54

D20012: Fix number localization for properties

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:97 > QCOMPARE(framerate.formatAsDisplayString(QVariant(23)), > QStringLiteral("23 fps")); > -QCOMPARE(framerate.formatAsDisplayString(QVariant(23.976)), > QStringLiteral("23.98 fps")); > +QCOMPARE(framerate.formatA

D19812: Add a web page to view and compare icons of different sizes

pino added a comment. In D19812#436174 , @guoyunhe wrote: > In D19812#436154 , @pino wrote: > > > - please harden the script using at least -e and -u flags for set: this way, it will not keep executi

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ngraham added a comment. In D19952#436919 , @taskf wrote: > Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state of th

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54688. guoyunhe added a comment. Fix typo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54546&id=54688 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES .gitignore

D19812: Add a web page to view and compare icons of different sizes

ngraham added inline comments. INLINE COMMENTS > generate_web_data.sh:7 > +then > +echo "Error: Directory $DIR/icons does not exists." > +exit exists -> exist > generate_web_data.sh:13 > +then > +echo "Error: Directory $DIR/icons-dark does not exists." > +exit ditto REPOSITORY

D20021: Add support for extracting data from ogg and ts files

bruns added a comment. According to ffplay, the ogg file has title and the like, so it should be listed in the MetaData test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson,

D20020: Split ffmpeg tests into common properties and metadata

bruns added inline comments. INLINE COMMENTS > ngraham wrote in ffmpegextractortest.h:33 > What is metadata data? :p Data for testing metadata ;-) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #balo

D20020: Split ffmpeg tests into common properties and metadata

bruns added a comment. Can you rename the `videoTest()`, so it is clear one is about intrinsic video properties, and the other about explicit information stored in tags/metadata bitstreams? Also add a comment saying so. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.k

D20020: Split ffmpeg tests into common properties and metadata

ngraham added inline comments. INLINE COMMENTS > ffmpegextractortest.h:33 > +void videoTestMetaData(); > +void videoTestMetaData_data(); > }; What is metadata data? :p REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns C

D20020: Split ffmpeg tests into common properties and metadata

astippich added a dependent revision: D20021: Add support for extracting data from ogg and ts files. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, ast

D20021: Add support for extracting data from ogg and ts files

astippich added reviewers: ngraham, bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

astippich added a dependency: D20020: Split ffmpeg tests into common properties and metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20021: Add support for extracting data from ogg and ts files

astippich created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY CCBUG: 399650 REPOSITORY R286 KFileMetaData BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabri

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/63/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Mar 2019 15:52:03 + Build duration: 18 min and counting BUILD ARTIFACTS abi-compatibility-result

D20020: Split ffmpeg tests into common properties and metadata

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_ffmpeg_tests REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Mar 2019 15:52:03 + Build duration: 6 min 53 sec and counting BUILD ARTIFACTS abi-compatibility-

D20016: Don't set a null completer on a non-editable combobox

elvisangelaccio updated this revision to Diff 54683. elvisangelaccio added a comment. - David's suggestion REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20016?vs=54660&id=54683 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20016 AFF

D20016: Don't set a null completer on a non-editable combobox

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in kcombobox.cpp:60 > Are you sure the line shouldn't be moved under this if()? It wouldn't warn > here, since that's the case where it's editable. > > At least this seems safer, unless you did the additional research of whet

D20016: Don't set a null completer on a non-editable combobox

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcombobox.cpp:60 > > if (q->isEditable()) { > q->lineEdit()->setContextMenuPolicy(Qt::DefaultContextMenu); Are you sure the line shouldn't be moved unde

D19967: [kpeople] make it compile without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > matchessolver.cpp:62 > //because they are the same > -QList keys = destinationResolver.keys(urlB); > -foreach (const QStri

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54680. knauss added a comment. fixing a typo. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54679&id=54680 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTED F

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/62/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Mar 2019 14:16:16 + Build duration: 24 min and counting BUILD ARTIFACTS abi-compatibility-result

D18793: Handle text completion with block selection mode

loh.tar added a comment. In D18793#421367 , @ahmadsamir wrote: > In D18793#420599 , @loh.tar wrote: > > > Fix this patch also Bug 382213 ? > > > No, it doesn't fix it. But this may D19

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Mar 2019 14:16:16 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibility-result

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54679. knauss added a comment. make parallel network requests. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54663&id=54679 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D

D19979: Don't create thumbnails for encrypted Vaults

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bc42a1b2f913: Don't create thumbnails for encrypted Vaults (authored by ivan). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19979?vs=54673&id=54678 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/66/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Mar 2019 14:16:16 + Build duration: 6 min 5 sec and counting JUnit Tests Name: projectroot

D20007: Add GetProcessList for retrieving the list of currently active processes

hallas added a comment. Thanks a lot for the feedback guys, I will spend some time and implement it and push an updated patch. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: elvisangelaccio, kde-frameworks-devel, mi

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann added a comment. I still need to test that again ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19517 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, br

D20018: Update URLs to use https

yurchor requested changes to this revision. yurchor added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > argparserutils.py:62 >'generate dependency diagrams.\n' > - 'See .') > +

D20018: Update URLs to use https

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Largely using the tools from D19996 . REPOSITORY R2

D19979: Don't create thumbnails for encrypted Vaults

davidedmundson accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19979 To: ivan, davidedmundson, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   >