D19992: Update URLs to use https

2019-03-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R238:b690b99104e3: Update URLs to use https (authored by vkrause). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19992?vs=54626&id=54643 REVISION DETAIL https://ph

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

2019-03-23 Thread Albert Astals Cid
aacid added a comment. That not ideal, ki18n should be usable for projects that don't use widgets too. I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there? REPOSITORY R249 KI18n REVISION DETAIL

D20008: Fix uninitialized value in SimpleJobPrivate

2019-03-23 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The patch is OK, but the commit message is scarier than the truth. There is no actual use of an uninitialized value in practice. Please add "compiler warning" to the commit log. REPOSITORY

D20008: Fix uninitialized value in SimpleJobPrivate

2019-03-23 Thread Michael Pyne
mpyne created this revision. mpyne added reviewers: dfaure, Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY As reported in bug 404474 , GC

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54640. knauss added a comment. remove BLACKLSIT for httpcheck REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54639&id=54640 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D1

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54639. knauss added a comment. add httpupdate and split out blacklist file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54617&id=54639 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricat

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss added a comment. In D19996#436824 , @winterz wrote: > this would be a nice addition to Krazy. on my todo list. we are actually planing to push the list of blacklisted matches to a single file, so other scripts can take the list to

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-03-23 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > kprocesslist.h:56 > + */ > +KProcessList GetProcessList(); > + This method should follow the Qt naming style, i.e. `processList()`. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmu

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-03-23 Thread David Edmundson
davidedmundson added a comment. To give a context for people who haven't seen the prior conversation. Right now kdevelop (optionally) pulls in libksysguard from plasma to show a simple process list, which isn't ideal. We're not technically API stable and we'll go to Qt6 at a different

D19876: Fix: apply correctly the text colors of the chosen scheme

2019-03-23 Thread Dominik Haumann
dhaumann added a comment. I think such a workaround is ok, but the real issue here is that KTextEditor does not fully use the KSyntaxHighlighting Theme colors. Instead, it still has its own configuration, such that hacks like this are introduced to somehow make it work. But it's just a matte

D19974: Add extensions to groovy highlighting

2019-03-23 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19974 To: apushnov, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer,

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-03-23 Thread David Hallas
hallas added inline comments. INLINE COMMENTS > CMakeLists.txt:246 >util/kformat.h >util/kuser.h >util/kshell.h Should util/kprocesslist.h also be added here? > kprocesslist.h:1 > +/** > +** Is this

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-03-23 Thread David Hallas
hallas created this revision. hallas added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Add GetProcessList for retrieving the list of currently active processe

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

2019-03-23 Thread t-ask
taskf added a comment. Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state of this icon object. Currently, I think it would be good to add both icons to Breeze icon

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

2019-03-23 Thread Alexander Potashev
aspotashev added a comment. I'm not sure about this because 1. Not a find_package() guru 2. We may need to add Qt5Widgets as a new dependency of ki18n. For now ki18n won't pull qtwidgets, and your projects may fail compiling which is not very developer-friendly. REPOSITORY R249 KI18

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

2019-03-23 Thread Alexander Potashev
aspotashev created this revision. aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REVISION SUMMARY If I have find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUI

D19811: Add Smali syntax highlighting file

2019-03-23 Thread Dāvis Mosāns
davispuh updated this revision to Diff 54631. davispuh added a comment. Reduce size of test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54120&id=54631 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECT

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

2019-03-23 Thread Arvid Hansson
arvidhansson added a comment. In D19952#436834 , @taskf wrote: > There is one issue I'm not sure about. The user might feel pressured to check something if the symbol is stroked as it fells like "something is wrong". In that case I would suggest

D19318: compile without foreach

2019-03-23 Thread Kurt Hindenburg
hindenburg added a comment. There's a FOREACH still in the macpoller.cpp file REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D19318 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

2019-03-23 Thread t-ask
taskf added a comment. There is one issue I'm not sure about. The user might feel pressured to check something if the symbol is stroked as it fells like "something is wrong". In that case I would suggest just using the ON version and make it 50% transparent in OFF mode. REPOSITORY R266 Br

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

2019-03-23 Thread Dominik Haumann
dhaumann added a comment. Looks good to me. Anyone else? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraha

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

2019-03-23 Thread t-ask
taskf added a comment. Here is another try with rounded corners to mimik a keyboard key. To me the stroke is not that a of problem if it goes the other direction, as it feels more natural. Right handed people would probably stroke something that way than it is done with traffic signs or is i

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Allen Winter
winterz added a comment. this would be a nice addition to Krazy. on my todo list. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19992: Update URLs to use https

2019-03-23 Thread Yuri Chornoivan
yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19992 To: vkrause, yurchor Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19992: Update URLs to use https

2019-03-23 Thread Volker Krause
vkrause updated this revision to Diff 54626. vkrause added a comment. Update build from source link. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19992?vs=54600&id=54626 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19992 AFFECTED FI

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > PythonInterp is also not a solution :) See 6c1db934e > > in ki18n. > > CMake 3.5.0 was found acceptable for most framew

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

2019-03-23 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demski

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

2019-03-23 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc:

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

2019-03-23 Thread Nibaldo González
nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 405585 There is a problem of folding in rules with beginRegion + endRegion. Example:

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54617. knauss added a comment. search for http://\S and update blacklist. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54615&id=54617 BRANCH arcpatch-D19996 REVISION DETAIL https://phabr

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > vkrause wrote in KDECMakeSettings.cmake:189 > Right, the feature is just silently ignored in older versions. We can > probably switch that to PythonIterp if we want this for older versions as > well. But let's first see if this approach actua

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > FindPython3.cmake only exists in CMake >= 3.12.0 Right, the feature is just silently ignored in older versions. We can probably switch that to PythonIterp if we want this for older versions as wel

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54615. knauss added a comment. add more excludes. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54613&id=54615 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECT

D19876: Fix: apply correctly the text colors of the chosen scheme

2019-03-23 Thread Nibaldo González
nibags updated this revision to Diff 54614. nibags added a comment. - Add some comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19876?vs=54404&id=54614 BRANCH fix-schemas REVISION DETAIL https://phabricator.kde.org/D19876 AFFECTED FILES s

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54613. knauss added a comment. update http regex REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54612&id=54613 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTE

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Sandro Knauß
knauss updated this revision to Diff 54612. knauss added a comment. update python script. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54611&id=54612 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFF

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:189 > > +find_package(Python3 COMPONENTS Interpreter QUIET) > +function(httpcheck) FindPython3.cmake only exists in CMake >= 3.12.0 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is supposed to trigger a unit test failure when using http: rather than https: URLs.

D19974: Add extensions to groovy highlighting

2019-03-23 Thread Aleksei Pushnov
apushnov updated this revision to Diff 54602. apushnov added a comment. Updated groovy.xml version from 5 to 6 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19974?vs=54559&id=54602 REVISION DETAIL https://phabricator.kde.org/D19974 AFFECTED

D19992: Update URLs to use https

2019-03-23 Thread Yuri Chornoivan
yurchor added a comment. Thanks in advance for fixing the Techbase link. INLINE COMMENTS > install-compile.docbook:4 > For information on how to compile and install &kde; > -applications visit the http://techbase.kde.org/";> > +applications visit the https://techbase.kde.org/";> > &kde; Te

D19992: Update URLs to use https

2019-03-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY I haven't touched affected localized content in here, assuming that will be updated via

D19979: Don't create thumbnails for encrypted Vaults

2019-03-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > previewjob.cpp:307 > > +auto mountsList = KMountPoint::currentMountPoints(); > +KMountPoint::List encryptedMountsList; Did you profile the impact of this call? I don't think it's cached. Can this maybe be moved to the thumbnail KIO so i

D19990: Switch URLs to https

2019-03-23 Thread Kai Uwe Broulik
broulik added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19990 To: vkrause, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19990: Switch URLs to https

2019-03-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Also remove two apparently dead services from the KMoreTools preset. REPOSITORY R304 KNewStuff BRANCH master REVI

D19974: Add extensions to groovy highlighting

2019-03-23 Thread Dominik Haumann
dhaumann added a comment. You also have to increase the "version" from 5 to 6. Could you provide an updated patch? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19974 To: apushnov, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel, kde-framewor