D19896: [kdnssd] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R272:d13c11a4a68d: [kdnssd] compile without foreach (authored by mlaurent). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19896?vs=54360&id=54385 REVISION DETAIL http

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/39/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Mar 2019 01:54:00 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-resul

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 20 Mar 2019 01:54:00 + Build duration: 8 min 40 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Mar 2019 01:54:00 + Build duration: 2 min 24 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 20 Mar 2019 00:52:50 + Build duration: 23 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Mar 2019 00:52:50 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/63/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Mar 2019 00:52:50 + Build duration: 8 min 29 sec and counting JUnit Tests Name: projectroo

D7700: Show list of tags in PlacesView

This revision was automatically updated to reflect the committed changes. Closed by commit R241:523acf53dadc: Show list of tags in PlacesView (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=54298&id=54383 REVISION DETAIL https

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 131 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/131/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 19 Mar 2019 23:55:40 + Build duration: 15 min and counting JUnit Tests N

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Mar 2019 23:55:39 + Build duration: 14 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Mar 2019 23:55:40 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/49/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Mar 2019 23:55:39 + Build duration: 4 min 12 sec and counting JUnit Tests Nam

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0ffe183d71fd: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0 (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.k

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixtilingtexture REVISION DETAIL https://phabricator.kde.org/D19787 To: kossebau, #plasma, mart Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19887: Proposal for KFileItem to skip stat()

ngraham added reviewers: dfaure, Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

ngraham added a comment. Aleix and I talked, and yeah, your original idea was good. So here's what we need: - An icon for auto-rotation mode - An icon for "locked to portrait" mode - An icon for "locked to landscape" mode REPOSITORY R266 Breeze Icons REVISION DETAIL https://phab

D19900: Set category on Attica entries

This revision was automatically updated to reflect the committed changes. Closed by commit R304:88ffd3cce725: Set category on Attica entries (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19900?vs=54368&id=54375 REVISION DETAIL https

D19900: Set category on Attica entries

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19900 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19896: [kdnssd] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19896 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19891: Use https for the pastebin backend and publicly accessible documentation

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19891 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19900: Set category on Attica entries

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, we had forgotten to set t

D19897: [kservice ] Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R309 KService BRANC

D19896: [kdnssd] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R272 KDNSSD BRANCH

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. So far I have not yet seen another tiled-border theme on store.kde.org, so restoring the Plasma4 behaviour should be fine. Both tiled-border themes I know are now up at stores.kde.org/GHNS also to allow testing: - Fluffy Bunny: https://store.kde.org/p/12951

D19806: Allow selecting only supported audio files

This revision was automatically updated to reflect the committed changes. Closed by commit R305:5e2b9c838f3f: Allow selecting only supported audio files (authored by broulik). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19806?vs=54014&id=54358 REVISI

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. In D19736#434274 , @ngraham wrote: > Maybe the rectangle itself doesn't need to be so big? Or maybe it could be even bigger and have the arrows inside? I can make the rectangle slightly smaller. I can't make the re

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. In D19736#434616 , @apol wrote: > How about having 3 icons? autorotate, locked portrait and locked landscape? > > This way we don't need to have a weird red strike-through. That's what I asked about the first ti

D19895: Use https for links in the UI and documentation

ognarb added a comment. I made sure that all the links are still working. So +1 INLINE COMMENTS > kproxydlg.ui:45 > Automatic detection is performed using the Web Proxy Auto-Discovery > Protocol (WPAD).

> -NOTE: This option might not work properly or not work at > all in s

D19895: Use https for links in the UI and documentation

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks from the doc team. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19895 To: vkrause, yurchor Cc: yurchor, kde-frameworks-devel, kde-doc-engl

D19888: Add runtime guard that pages are KCMs in KCMultiDialog

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Approving since it's similar to what i did in https://phabricator.kde.org/D19889 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D19888 To: davided

D19895: Use https for links in the UI and documentation

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19895 AFFECTED FILES

D19891: Use https for the pastebin backend and publicly accessible documentation

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19891 AFFECTED FILES README.md src/

D19889: Fix crash when doing kontact->settings->configure

aacid abandoned this revision. aacid added a comment. Discarding in favor of https://phabricator.kde.org/D19888 i guess REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D19889 To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

apol added a comment. How about having 3 icons? autorotate, locked portrait and locked landscape? This way we don't need to have a weird red strike-through. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-framew

D19889: Fix crash when doing kontact->settings->configure

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 405440 TEST PLAN Doesn't crash anymore REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phab

D19888: Add runtime guard that pages are KCMs in KCMultiDialog

rikmills added a comment. Patch seemed to fix the crash. I don't use Kontact (apart from testing things like this), but on a quick test all seems functional once more. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D19888 To: davidedmundson Cc: rikmills, kde-framew

D19888: Add runtime guard that pages are KCMs in KCMultiDialog

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This situation can come up if a KCMultiDialog subclass adds pages directly that aren't KCModules. B

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. In D19784#431683 , @ngraham wrote: > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm? No, unfortunately it do

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. See https://phabricator.kde.org/D19887 INLINE COMMENTS > dfaure wrote in recentusagemodel.cpp:261 > How do you expect isFile() and isDir() to work without a QT_LSTAT call? A document should always be a file, so

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54339. hoffmannrobert added a comment. - Use new KFileItem constructor with skipStat set to true REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=53951&id=54339 BRANCH fix_recent_documents_kicker

D19887: Proposal for KFileItem to skip stat()

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY This adds a KFileItem constructor for passing a boolean skipStat. If true, KFileItemPrivate::init(), K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/48/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Mar 2019 13:53:16 + Build duration: 33 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Mar 2019 13:53:17 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Mar 2019 13:53:17 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compati

D19821: Fix breeze dialog background with Qt 5.12.2

rooty added a comment. In D19821#434410 , @fvogt wrote: > In D19821#434405 , @rooty wrote: > > > This wasn't supposed to land in Plasma 5.15 as well as master? > > > Plasma Framework is (in this

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434405 , @rooty wrote: > This wasn't supposed to land in Plasma 5.15 as well as master? Plasma Framework is (in this case unfortunately) a Framework, so no stable branches. REPOSITORY R242 Plasma Framew

D19821: Fix breeze dialog background with Qt 5.12.2

rooty added a comment. This wasn't supposed to land in Plasma 5.15 as well as master? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma, rooty Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, astu

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434371 , @rikmills wrote: > I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. I agree - as this touches binary files, appl

D19821: Fix breeze dialog background with Qt 5.12.2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54176&id=5

D19821: Fix breeze dialog background with Qt 5.12.2

rikmills added a comment. I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasm

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434345 , @acooligan wrote: > Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ? Yes. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phab

D19869: [kglobalaccel] Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R268:4c81ab60e689: [kglobalaccel] Make it compile without foreach (authored by mlaurent). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19869?vs=54278&id=54310 RE

D19870: [kactivities] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R6:7fcb7c58ffd9: [kactivities] compile without foreach (authored by mlaurent). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19870?vs=54279&id=54309 REVISION DETAIL

D19877: [kdeclarative] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d36616622eae: [kdeclarative] compile without foreach (authored by mlaurent). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19877?vs=54296&id=54308 REVISION D

D19821: Fix breeze dialog background with Qt 5.12.2

acooligan added a comment. Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ? REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma, rooty Cc: acooligan, filipf, heikobecker, falqueto, r

D12647: Move the inline preview button into the menu

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

ngraham abandoned this revision. ngraham added a comment. I don't think this makes sense anymore. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12327: Show Detailed Tree View by default

ngraham updated this revision to Diff 54303. ngraham added a comment. Rebase (I still think this makes sense) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12327?vs=32511&id=54303 BRANCH arcpatch-D12327 REVISION DETAIL https://phabricator.kde.org/D12327

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham abandoned this revision. ngraham added a comment. The " 'Too much magic' trap" makes sense to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7700: Show list of tags in PlacesView

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, works for me too now. REPOSITORY R241 KIO BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ng

D15983: React to config updates inside indexer

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D15983 REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov,

D15983: React to config updates inside indexer

poboiko added a comment. In D15983#434247 , @ngraham wrote: > Can you rebase this on master again? Sorry for the radio silence. :( Nevermind, I also kinda forgot about this :) Seems like this patch still applies to current master:

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven added a comment. In D19824#434053 , @ngraham wrote: > Makes sense, thanks. This fix works and looks sane to me. > > Maybe wait until at least one more #dolphin and/or #frameworks

D19736: Add screen-rotate-auto-on/off

ngraham added a comment. In D19736#434176 , @ndavis wrote: > This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px. > F6701152: montage.png

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 54298. nicolasfella added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=48246&id=54298 BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700 AFFECTED FILES src/file

D7700: Show list of tags in PlacesView

ngraham added a comment. Can you rebase this on current master? I'll give it another shot and report back. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham, broulik Cc: broulik, kde-frameworks-devel,

D19870: [kactivities] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19870 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19869: [kglobalaccel] Make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19869 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19877: [kdeclarative] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19877 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15983: React to config updates inside indexer

ngraham added a comment. Can you rebase this on master again? Sorry for the radio silence. :( REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh

D19821: Fix breeze dialog background with Qt 5.12.2

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. If it works for you ship it, I'm nowhere near a computer right now REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvog

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: filipf, heikobecker,

D15983: React to config updates inside indexer

poboiko added a comment. Ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko edited the summary of this revision. poboiko added reviewers: bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich

D17167: Provide a method of assigning custom default icons for non-XDG dirs

dfaure added a comment. IMHO this falls into the "too much magic" trap. If a user creates ~/Games it will have a special icon, but if he creates ~/Videogames, ~/mygames, ~/Steam, or choose a different translation than the translators picked, it won't trigger that magic -- with no indication

D19877: [kdeclarative] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R296 KDeclarative B

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags edited the summary of this revision. nibags added reviewers: KTextEditor, Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: nibags, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cu

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 398758 Since the implementation of KSyntaxHighlighting in KF5.50, KTextEditor always uses the