D19875: [Kactivities-stats] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R159 KActivities Sta

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px. F6701152: montage.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D1973

D19736: Add screen-rotate-auto-on/off

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. @ngraham Here's something similar to what you asked for: F6701127: Screenshot_20190318_235338.png This is 22px. I couldn't get it to work for 16px. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org

D7700: Show list of tags in PlacesView

nicolasfella added a comment. In D7700#382897 , @ngraham wrote: > Bugs found: > > - If there are no tags, creating one does not cause the Tags section to appear in the Places panel until Dolphin is restarted. > - If the Tags section is alrea

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham added a comment. Ping? Any opinions regarding what I wrote in https://phabricator.kde.org/D17167#383242? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

ngraham abandoned this revision. ngraham added a subscriber: nicolasfella. ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Doesn't make sense; @nicolasfella's new Places Panel section makes more sense to put in once it's ready. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/41/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Mar 2019 00:05:15 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/46/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Mar 2019 00:04:26 + Build duration: 2 min 53 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Mar 2019 00:01:07 + Build duration: 4 min 7 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Mar 2019 00:01:07 + Build duration: 3 min 18 sec and counting BUILD ARTIFACTS abi-comp

D19846: [ffmpegextractor] Add Matroska Video test case

This revision was automatically updated to reflect the committed changes. Closed by commit R286:50a91ff61037: [ffmpegextractor] Add Matroska Video test case (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19846?vs=54148&id=54290 REVI

D19845: [ffmpegextractor] Convert test to be data driven

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5e1db0848d0b: [ffmpegextractor] Convert test to be data driven (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19845?vs=54146&id=54289 RE

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. They should all go into the build dir IMO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#434089 , @ngraham wrote: > Thanks, it compiles with CMake now! \o/ > > I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing

D18915: Fix batchrename changing extension to lower case

bruns added a comment. LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. Thanks, it compiles with CMake now! \o/ I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing an out-of-source build so the source dir isn't cluttered up with transient and rapidly-

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#433941 , @guoyunhe wrote: > In D19812#433916 , @ndavis wrote: > > > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colo

D19870: [kactivities] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R6 KActivities BRAN

D19869: [kglobalaccel] Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R268 KGlobalAccel B

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense, thanks. This fix works and looks sane to me. Maybe wait until at least one more #dolphin and/or #frameworks

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 54269. cfoster added a comment. - Add unit tests. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=53914&id=54269 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde.org/D18915 AFFECTED FILES auto

D19795: Add Variable interface to KTextEditor::Editor

dhaumann added a comment. It's committed now: - quoting is now not supported at all anymore - expandText() now returns void REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19795 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson,

D19795: Add Variable interface to KTextEditor::Editor

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a4083c7cf0d6: Add Variable interface to KTextEditor::Editor (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=54264&id=54265 REVISI

D19795: Add Variable interface to KTextEditor::Editor

dhaumann updated this revision to Diff 54264. dhaumann added a comment. This revision is now accepted and ready to land. - Drop KWordMacroExpander in favor of own simple implementation (50 slocs) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=54

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven added a comment. In D19824#433831 , @ngraham wrote: > Thanks for the patch, and for adding a test! > > Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code? In

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54257. guoyunhe added a comment. Use typical Breeze background colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54252&id=54257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#433916 , @ndavis wrote: > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? Like this? F6700542: image.png

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breez

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432424 , @ngraham wrote: > Getting closer: > > Scanning dependencies of target generate-web > make[2]: generate_web_data.sh: Command not found > CMakeFiles/generate-web.dir/build.make:57: recipe fo

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54252. guoyunhe added a comment. Add ${CMAKE_SOURCE_DIR} prefix to script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54051&id=54252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D198

D19811: Add Smali syntax highlighting file

cullmann added a comment. Hmm, if the license is ok, perhaps the smaller RealSmaliFileTest.smali you linked above would make a better test case, >> 5000 lines is a bit large for reviewing changes later ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D

D19806: Allow selecting only supported audio files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D19806 To: broulik, #frameworks, dfaure, bruns Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D18845: authority: add support for passing details to polkit

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you address the last nitpick from @chinmoyr ? REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: ngraham, mati865, kde-

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

ngraham added a comment. Thanks for the patch, and for adding a test! Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #framewo

D19845: [ffmpegextractor] Convert test to be data driven

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19845 To: bruns, #baloo, #frameworks, astippich, mgallien, ngraham Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, as

D19846: [ffmpegextractor] Add Matroska Video test case

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_ext REVISION DETAIL https://phabricator.kde.org/D19846 To: bruns, #baloo, #frameworks, astippich, mgallien, ngraham Cc: kde-frameworks-devel, gennad, domson, ashapo

D19858: Handle unsupported OCS commands, and don't over-vote

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2a40085fc3d2: Handle unsupported OCS commands, and don't over-vote (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54235&id=54238 R

D19858: Handle unsupported OCS commands, and don't over-vote

leinir added a comment. In D19858#433788 , @ngraham wrote: > Thanks! Makes sense, and fixes the bug. :) > > Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it

D19858: Handle unsupported OCS commands, and don't over-vote

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Makes sense, and fixes the bug. :) Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should

D19858: Handle unsupported OCS commands, and don't over-vote

leinir updated this revision to Diff 54235. leinir marked an inline comment as done. leinir added a comment. Copypasta error... thanks Nate :) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54233&id=54235 REVISION DETAIL https://phabricator.kd

D19858: Handle unsupported OCS commands, and don't over-vote

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ngraham wrote in itemsviewdelegate.cpp:287 > Why do we need to do this twice? ehrm... we don't, we need to undo it, and i forgot to swap that true for a false ;) Thanks! REPOSITORY R304 KNewStuff REVISI

D19858: Handle unsupported OCS commands, and don't over-vote

ngraham added inline comments. INLINE COMMENTS > itemsviewdelegate.cpp:287 > rating->setRating((entry.rating() - 20) * 10 / 60); > +rating->blockSignals(true); > // put the rating label below the install button Why do we need to do this twice? REPOSITORY

D19858: Handle unsupported OCS commands, and don't over-vote

leinir created this revision. leinir added reviewers: KNewStuff, ronaldv, ngraham. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY When the server does not support c

KDE CI: Frameworks » kinit » kf5-qt5 WindowsMSVCQt5.11 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20WindowsMSVCQt5.11/31/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Mar 2019 14:57:27 + Build duration: 2 min 33 sec and counting

D19850: Make AppStream generation opt-in

ngraham edited the summary of this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kinit » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Mar 2019 12:43:34 + Build duration: 2 min 32 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks » kinit » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20WindowsMSVCQt5.11/29/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 18 Mar 2019 12:27:29 + Build duration: 2 min 18 sec and counting CONSOLE OUTPUT [...

D19828: [Kinit] Compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R303:1b4c6832298c: [Kinit] Compile without foreach (authored by mlaurent). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19828?vs=54177&id=54206 REVISION DETAIL https:

D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter added a comment. setting server to keepalive=false? what is this? the 90's? :O wouldn't it be simpler to `finishDav` and recurse `rename` with the redirected url? the code inside the conditional block is basically a code copy of the code above, so why not just throw away the dupli

D19805: Manager: Don't require Media1 interface for initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R269:5da57e174696: Manager: Don't require Media1 interface for initialization (authored by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19805?vs=54013&id=5418

D18315: Device: Check object path in interfaces removed slot

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R269:9197a45652be: Device: Check object path in interfaces removed slot (authored by drosca). REPOSITORY R269 BluezQt CH

D19850: Make AppStream generation opt-in

ngraham added a comment. Conceptual +1; giving everything autogenerated yet sparse AppStream data doesn't provide much value and causes various problems with how app store apps (e.g. Discover) present our software. See https://bugs.kde.org/show_bug.cgi?id=403120. AppStream data should ideall

D19850: Make AppStream generation opt-in

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY After discussing the feature over it became apparent that developers will need to be pro-activ

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, when using single-click mode, when you're saving a file and click

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven retitled this revision from "In saving single file mode an enter/return press on the KDirOperator triggers slotOk" to "KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ngraham added a comment. We actually could not for technical reasons due to the following Phabricator bug: https://secure.phabricator.com/T1022 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: bcooksley, ngraham, ndavis, kde-fram

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

bcooksley added a comment. I see. If possible please do try to batch the commits together into a single push to avoid such breakages in the future. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: bcooksley, ngraham, ndavis, kde-

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Mar 2019 08:31:03 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Mar 2019 08:31:03 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/62/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Mar 2019 08:31:03 + Build duration: 8 min 1 sec and counting JUnit Tests Name: projectroot

D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R241:534ebe58c4ca: Delete/Trash confirmation dialogue: Fix misleading title (authored by marten). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19847?vs=54145&id=54178 REV

D19828: [Kinit] Compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19828 To: mlaurent, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19828: [Kinit] Compile without foreach

mlaurent updated this revision to Diff 54177. mlaurent added a comment. Fix comment reported by Pino REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19828?vs=54173&id=54177 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://pha

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt updated this revision to Diff 54176. fvogt added a comment. One more file. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54143&id=54176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 AFFECTED FILES

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. There's a special case in `./src/desktoptheme/breeze/icons/audio.svgz` and `.../battery.svgz`: It has color scheme definitions both in a `

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Mar 2019 07:59:33 + Build duration: 5 min 9 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Mar 2019 07:59:42 + Build duration: 5 min 3 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Mar 2019 07:56:38 + Build duration: 2 min 53 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Mar 2019 07:56:38 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS abi-compa

D19655: [kfilemetadata] Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R286:31f4a5c07585: [kfilemetadata] Make it compile without foreach (authored by mlaurent). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19655?vs=54174&id=54175

D19828: [Kinit] Compile without foreach

pino added inline comments. INLINE COMMENTS > kinit_win.cpp:301-303 > +for (const ProcessListEntry *ple : qAsConst(m_processes)) { > delete ple; > } qDeleteAll? > kinit_win.cpp:454 > +const auto list = processList.list(); > +for (const ProcessListEntry *ple : lst) { >