D19655: [kfilemetadata] Make it compile without foreach

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19655 To: mlaurent, dfaure, bruns, #baloo Cc: bruns, kde-frameworks-devel, #baloo

D19655: [kfilemetadata] Make it compile without foreach

mlaurent updated this revision to Diff 54174. mlaurent added a comment. Fix code as requested REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19655?vs=53597&id=54174 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://ph

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Mar 2019 06:01:30 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/38/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Mar 2019 06:01:27 + Build duration: 3 min 49 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/37/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Mar 2019 05:56:07 + Build duration: 5 min 18 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Mar 2019 05:56:07 + Build duration: 5 min 21 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Mar 2019 05:59:12 + Build duration: 1 min 41 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/37/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Mar 2019 05:56:07 + Build duration: 2 min 58 sec and counting JUnit Tests Name: projectr

D19828: [Kinit] Compile without foreach

mlaurent updated this revision to Diff 54173. mlaurent added a comment. Fix typo REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19828?vs=54091&id=54173 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19

D19828: [Kinit] Compile without foreach

mlaurent marked an inline comment as done. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D19828 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19749: [baloo] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1d45ad27d2ac: [baloo] make it compile without foreach (authored by mlaurent). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19749?vs=53857&id=54172 REVISION DETAIL

D19750: [attica] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R235:5840e54feea0: [attica] compile without foreach (authored by mlaurent). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19750?vs=54075&id=54171 REVISION DETAIL http

D19778: [kitemmodels] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R275:8327e0e0654a: [kitemmodels] make it compile without foreach (authored by mlaurent). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19778?vs=54073&id=54170 REVI

D19827: [kbookmarks] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R294:9eb7c8d2fd87: [kbookmarks] compile without foreach (authored by mlaurent). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19827?vs=54088&id=54169 REVISION DETAI

D19821: Fix breeze dialog background with Qt 5.12.2

falqueto added a comment. I believe that src/desktoptheme/breeze/translucent/widgets/tooltip.svgz must be corrected too. It has an

D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19847 To: marten, #frameworks, dfaure, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent

ngraham added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19847 To: marten, #frameworks, dfaure, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19795: Add Variable interface to KTextEditor::Editor

dhaumann planned changes to this revision. dhaumann added a comment. Will do another change: since recursive expansion of macros is not supported by KMacroExpander (e.g. %{JS:if(true) %{Document:Selection}}), I'll provide an implementation that does not use KMacroExpander at all. Have that wo

D19828: [Kinit] Compile without foreach

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in kinit_win.cpp:442 > How can this compile? The variable is called list instead of lst. Windows code :) I can"t test it. thanks for pointing me it. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D19828 To:

D18793: Handle text completion with block selection mode

ahmadsamir added a subscriber: loh.tar. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, mwolff Cc: loh.tar, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, c

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54150. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: KDevelop. ahmadsamir removed subscribers: loh.tar, mwolff. ahmadsamir added a comment. Verbatim REPOSITORY R39 KTe

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54149. ahmadsamir added a comment. - Split the code responsible for inserting text in block selection from typeChars() to a new function - Don't add words where the block selection cursor is inside to the possible completion matches from the document

D19847: Delete/Trash confirmation dialogue: Fix misleading title and make consistent

marten created this revision. marten added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY The misleading title that brought this dialogue to my attention is where ther

D19845: [ffmpegextractor] Convert test to be data driven

bruns added a dependent revision: D19846: [ffmpegextractor] Add Matroska Video test case. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19845 To: bruns, #baloo, #frameworks, astippich, mgallien, ngraham Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mi

D19846: [ffmpegextractor] Add Matroska Video test case

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The test file was generated by converting the

D19845: [ffmpegextractor] Convert test to be data driven

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Make it easier to extend to more file types, n

D19655: [kfilemetadata] Make it compile without foreach

bruns added a reviewer: Baloo. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19655 To: mlaurent, dfaure, bruns, #baloo Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D19655: [kfilemetadata] Make it compile without foreach

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19655 To: mlaurent, dfaure, bruns Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D19749: [baloo] make it compile without foreach

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19749 To: mlaurent, dfaure, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashap

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt updated this revision to Diff 54143. fvogt added a comment. Keep the style element, but assign id and type. Fix tooltip.svgz as well. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54076&id=54143 BRANCH master REVISION

D19828: [Kinit] Compile without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kinit_win.cpp:442 > +const auto list = processList.list(); > +for (const ProcessListEntry *ple : lst) { > if (!ple->path.isEmpty() && > ple->

D19827: [kbookmarks] compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19827 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19750: [attica] compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19750 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19778: [kitemmodels] make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19778 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19785: DocumentPrivate: Review del/backspace

loh.tar added a comment. I had recently submit a patch which was also affected by RTL text D19621 . Should this patch here be accepted I can upload my current state of the mentioned playing, which works similar as that D19621

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Mar 2019 18:40:23 + Build duration: 14 min and counting BUILD ARTIFACTS abi-compatibility-resu

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 18:37:45 + Build duration: 7 min 41 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Mar 2019 18:26:03 + Build duration: 14 min and counting BUILD ARTIFACTS abi-compatibility-resu

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 18:26:03 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-resu

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 18:29:17 + Build duration: 2 min 59 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 18:26:03 + Build duration: 3 min 10 sec and counting JUnit Tests Name: projectr

D19811: Add Smali syntax highlighting file

davispuh updated this revision to Diff 54120. davispuh added a comment. Add a test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54046&id=54120 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECTED FILES aut

D17162: Harmonize handling of underscore in query parser

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1799816357b4: Harmonize handling of underscore in query parser (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17162?vs=46225&id=54108 REVISION D

D19821: Fix breeze dialog background with Qt 5.12.2

rooty added a comment. In D19821#432780 , @Zren wrote: > Another option I believe is to keep the `

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 16:31:01 + Build duration: 27 min and counting BUILD ARTIFACTS abi-compatibility-result

D19785: DocumentPrivate: Review del/backspace

safaalfulaij added a comment. Wow! Great :) Thanks for looking into this, but I'm afraid that the problem isn't with backspace/del, but with the cursor positioning, at least for RTL and mixed text. I actually found this to be a problem in Qt after trying to solve it myself in KTextEditor:

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/34/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Mar 2019 16:44:06 + Build duration: 8 min 52 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 16:44:06 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 16:44:06 + Build duration: 1 min 57 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/57/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 17 Mar 2019 16:31:01 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/61/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 16:31:01 + Build duration: 6 min 9 sec and counting JUnit Tests Name: projectroot

D17162: Harmonize handling of underscore in query parser

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17162 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astip

D19821: Fix breeze dialog background with Qt 5.12.2

Zren added a comment. Another option I believe is to keep the `

D18845: authority: add support for passing details to polkit

ngraham added a comment. Three LGTMs and +1 are pretty good :) REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: ngraham, mati865, kde-frameworks-devel

D18845: authority: add support for passing details to polkit

chinmoyr added a comment. I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry. INLINE COMMENTS > polkitqt1-authority.cpp:336 > + > +polkit_details_insert(ret, key.toUtf8().data(), > value.toUtf8().data())

D19767: Fix malloc/delete mismatch

hallas closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter, aacid Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emma

D19795: Add Variable interface to KTextEditor::Editor

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable to me and the interface is nicely minimal ;=) REPOSITORY R39 KTextEditor BRANCH variable-interface REVISION DETAIL https://phabricator.kde.org/D19795 To: dhauma

D19821: Fix breeze dialog background with Qt 5.12.2

arojas added a comment. Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: arojas, rikmills, asturmlechner, kde-frameworks-de

D19828: [Kinit] Compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R303 KInit BRANCH

D19795: Add Variable interface to KTextEditor::Editor

dhaumann updated this revision to Diff 54089. dhaumann added a comment. - Enum: Use NoQuoting and ShellQuoting REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=54078&id=54089 BRANCH variable-interface REVISION DETAIL https://phabricator.kde.

D19827: [kbookmarks] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R294 KBookmarks BRA

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven updated this revision to Diff 54082. meven added a comment. Add deleted blank line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54081&id=54082 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES src/filewidg

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven updated this revision to Diff 54081. meven added a comment. Remove blank line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54080&id=54081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES src/filewidgets/k

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 385189 "Save dialog: Return key only bound to Save button when text field has focus" Draw inspiration from inspi

D19805: Manager: Don't require Media1 interface for initialization

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH bug405478 REVISION DETAIL https://phabricator.kde.org/D19805 To: drosca, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19795: Add Variable interface to KTextEditor::Editor

cullmann added a comment. Ok, then I am fine with this beside that I think the Quoting stuff should be more explicit that it is "Shell" quoting. Isn't it even different for Windows vs. unices? I still think QuotationMode NoQuoting + ShellQuoting would be more easy to understand. WhenNeede

D19795: Add Variable interface to KTextEditor::Editor

dhaumann added a comment. In D19795#432612 , @cullmann wrote: > Hmm. the Variable class and files is just an artifact now or? Yes, it's just used internally. Without it, I'd need to add ugly std::tuple into the QHash. It's still in the KT

D19795: Add Variable interface to KTextEditor::Editor

cullmann added a comment. Hmm. the Variable class and files is just an artifact now or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19795 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullma

D19491: generic config interface

cullmann added a comment. See https://cgit.kde.org/ktexteditor.git/commit/?id=b3b4aba3201c48d0160fbb65e520b8bb08830339 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19491 To: cullmann, #ktexteditor, dhaumann, loh.tar Cc: kwrite-devel, kde-frameworks-devel,

D19491: generic config interface

cullmann added a comment. Yes :=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19491 To: cullmann, #ktexteditor, dhaumann, loh.tar Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19491: generic config interface

dhaumann added a comment. Agreed, do you plan to migrate more config options now? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19491 To: cullmann, #ktexteditor, dhaumann, loh.tar Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns,

D19795: Add Variable interface to KTextEditor::Editor

dhaumann updated this revision to Diff 54078. dhaumann added a comment. - Support optional quoting, default is Never REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=54069&id=54078 BRANCH variable-interface REVISION DETAIL https://phabricato

D19767: Fix malloc/delete mismatch

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH fix_malloc_delete_mismatch (branched from master) REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter, aacid Cc: aacid, kde-frameworks-de

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY style elements without type="text/css" were ignored before, but now they act as if type w

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 added a comment. In D19733#432498 , @bcooksley wrote: > This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable) > > See https://build.kde.org/job/Admi

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19811: Add Smali syntax highlighting file

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think we will need a auto-test file for this ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19811 To: davispuh, cullmann, dhaumann

D19750: [attica] compile without foreach

mlaurent updated this revision to Diff 54075. mlaurent added a comment. Rename variable REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19750?vs=53859&id=54075 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde

D19491: generic config interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d41689757fcb: generic config interface (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19491?vs=54021&id=54074 REVISION DETAIL https://p

D19778: [kitemmodels] make it compile without foreach

mlaurent updated this revision to Diff 54073. mlaurent added a comment. Add missing const, Remove C cast REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19778?vs=53939&id=54073 BRANCH compile_without_foreach (branched from master) REVISION DETAIL h

D19795: Add Variable interface to KTextEditor::Editor

cullmann added a comment. Hmm, I am actually not sure we want the quoting per default at all. You use expandMacrosShellQuote, I am not sure that that is that often wanted (at least not if not passing to commandline/shell). Perhaps the Enum should more state "NoQuoting, ShellQuoting, ..."

D19491: generic config interface

cullmann added a comment. Performance must later be profiled after it is used a lot. Then we can e.g. still switch to a vector indexed with the enum value, that should make lookup fast. REPOSITORY R39 KTextEditor BRANCH arcpatch-D19491_1 REVISION DETAIL https://phabricator.kde.org/D

D19795: Add Variable interface to KTextEditor::Editor

dhaumann added a comment. Unfortunately, I still see one issue: In the unit test, expanding the variable to "World" works, but expanding it to "Smart World" leads to single-quoted text "'Smart World'" because of the space. That of course makes sense, but is not always what you want. The

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

bcooksley added a comment. This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable) See https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20WindowsMSVCQt5.11/lastFailedBui

D19795: Add Variable interface to KTextEditor::Editor

dhaumann updated this revision to Diff 54069. dhaumann added a comment. - Hide class Variable REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=53975&id=54069 BRANCH variable-interface REVISION DETAIL https://phabricator.kde.org/D19795 AFFEC

D19696: Add blender thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R373:2da545defff9: Add blender thumbnailer (authored by chinmoyr). REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53971&id=54065 REVISION DETAIL h

D19500: [KDirModel] Fix job urls change signal connection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If there was a unittest for this code, it wouldn't remain broken for so long... Feel free to add one :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D195

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. Getting closer: Scanning dependencies of target generate-web make[2]: generate_web_data.sh: Command not found CMakeFiles/generate-web.dir/build.make:57: recipe for target 'CMakeFiles/generate-web' failed Are you able to test this yourself? REPOSITO

D19491: generic config interface

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. I see two possible performance issues: 1. Using std::map. ...but the size() is small. 2. See comment. But that needs profiling later. Please push.