D19767: Fix malloc/delete mismatch

hallas added a comment. Good catch ;) I have changed it to call `ssh_string_free_char` instead REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, sp

D19767: Fix malloc/delete mismatch

hallas updated this revision to Diff 54054. hallas marked 2 inline comments as done. hallas added a comment. Use ssh_string_free_char instead of free as documentated by libssh REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19767?vs=53911&id=54054 BRANCH

D19771: Use placeholder instead of label

loh.tar added a comment. In D19771#432157 , @ngraham wrote: > In D19771#431727 , @loh.tar wrote: > > > Not answered are the questions about the removed label > > > The idea is that we don't nee

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54051. guoyunhe added a comment. Move outside of generate_binary_resource REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54050&id=54051 BRANCH master REVISION DETAIL https://phabricator.kde.org/D198

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432348 , @bcooksley wrote: > I assume this fetches the icons from your local system? yes. it depends on text files generated by scripts, which contains list of all icons REPOSITORY R266 Breeze Icons

D19750: [attica] compile without foreach

dfaure added a comment. Everything else looks OK. INLINE COMMENTS > providermanager.cpp:106 > { > -foreach (const QUrl &url, d->m_internals->getDefaultProviderFiles()) { > +const auto lstProvider = d->m_internals->getDefaultProviderFiles(); > +for (const QUrl &url : lstProvider)

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. mmm, I'm afraid that didn't work. running `cmake` on it reveals the following: CMake Error at CMakeLists.txt:71 (add_custom_target): add_custom_target cannot create target "generate-web" because another target with the same name already exists. The e

D19812: Add a web page to view and compare icons of different sizes

bcooksley added a comment. I assume this fetches the icons from your local system? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54050. guoyunhe added a comment. Remove unnecessary spaces REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54049&id=54050 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FI

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432326 , @ngraham wrote: > Neato! Looks pretty handy. Two issues I found: > > - generate_web_data.sh isn't executable > - I'd like to see this run as part of the build process, so that `index.html` gets u

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54049. guoyunhe added a comment. Add CMake build steps for web page REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54048&id=54049 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AF

D19812: Add a web page to view and compare icons of different sizes

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

ngraham added reviewers: VDG, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54048. guoyunhe added a comment. Fix data updating issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54047&id=54048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FIL

D19812: Add a web page to view and compare icons of different sizes

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Neato! Looks pretty handy. Two issues I found: - generate_web_data.sh isn't executable - I'd like to see this run as part of the build process, so that `index.html` gets u

D19812: Add a web page to view and compare icons of different sizes

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY This simple web page provides a table of all icons. So developers can easily know which icon size is missing, or no

D19811: Add Smali syntax highlighting file

davispuh updated this revision to Diff 54046. davispuh added a comment. Use MIT license REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54045&id=54046 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECTED FILES

D19811: Add Smali syntax highlighting file

davispuh created this revision. davispuh added reviewers: cullmann, dhaumann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN Open https://github.com/JesusFreke/smali/blob/maste

D19771: Use placeholder instead of label

ngraham added a comment. Can you bring this up in the VDG channel? If we're going to use the correct character, we should do it everywhere. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cfeck, loh.tar, ngraham, kwrite-de

D19771: Use placeholder instead of label

ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that thi

D19778: [kitemmodels] make it compile without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > modelspy.cpp:323 > d << "ModelSpy("; > -Q_FOREACH (const QVariantList &list, (QList)(*modelSpy)) { > +const auto lst = (QList)(*modelSpy); > +

D19786: Fix WebDAV directory renaming if KeepAlive is off

dfaure added a comment. +1. Seems to make sense, but I don't really know this stuff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

This revision was automatically updated to reflect the committed changes. Closed by commit R266:559782c5f5b4: Give applications-games and input-gaming more contrast with Breeze Dark (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1746

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty, filipf Cc: rooty, abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, micha

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

rooty accepted this revision. rooty added a comment. Much better than before REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty Cc: rooty, abetts, ngraham, ps

D19783: [kitemview] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R276:8b7bbad43ea2: [kitemview] compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19783?vs=54016&id=54028#toc REPOSITORY R276 KItemViews CHANGES SINCE

D19806: Allow selecting only supported audio files

bruns added a comment. According to http://0pointer.de/public/sound-theme-spec.html (linked from https://freedesktop.org/wiki/Specifications/sound-theme-spec/) wav and ogg/vorbis are mandatory, but this does not rule out other formats in general. unfortunately, there is no API in li

D19771: Use placeholder instead of label

ngraham added a comment. In D19771#431727 , @loh.tar wrote: > For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and her

D19783: [kitemview] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R276 KItemViews BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19783 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, b

D19806: Allow selecting only supported audio files

apol added a comment. How do we know that's the only ones supported? REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D19806 To: broulik, #frameworks, dfaure Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19533: Don't crash on malformed syntax highlighting files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e540262fb723: Don't crash on malformed syntax highlighting files (authored by davispuh, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D195

D19491: generic config interface

cullmann added a comment. I would like to get this in now. The next step would be converting all existing settings to the new style like tabWidth but keeping the accessors as is, to have a minimal large change. If that then is done, one can start to think about using the generic interface

D19491: generic config interface

cullmann updated this revision to Diff 54021. cullmann added a comment. add command name, too hide data structure REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19491?vs=53063&id=54021 BRANCH arcpatch-D19491_1 REVISION DETAIL https://phabricator.

D19511: ViewPrivate: Disable read-only mode action when doc is modified

cullmann added a comment. I actually would just keep the status quo here ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michael

D19795: Add Variable interface to KTextEditor::Editor

cullmann added a comment. I think without the Variable class it would be nicer. One can extend it later easier, too, by just adding a new overload with a different function type (if needed). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19795 To: dhaumann, cu

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with this change. You can commit yourself now, or? REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde

D19533: Don't crash on malformed syntax highlighting files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. That looks reasonable, if the definition doesn't have any included ones + no own formats it is likely to be broken ;=) REPOSITORY R39 KTextEditor BRANCH malformed REVISION DETAIL

D19783: [kitemview] compile without foreach

mlaurent updated this revision to Diff 54016. mlaurent added a comment. Use iterator REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19783?vs=53950&id=54016 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kd

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Mar 2019 13:22:27 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/56/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 16 Mar 2019 13:22:27 + Build duration: 7 min 29 sec and counting BUILD ARTIFACTS abi-compatibility-

D19806: Allow selecting only supported audio files

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY While Phonon could play all the files, libcanberra as a low-latency notifi

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/60/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Mar 2019 13:22:27 + Build duration: 5 min 58 sec and counting JUnit Tests Name: projectroo

D19805: Manager: Don't require Media1 interface for initialization

drosca created this revision. drosca added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. drosca requested review of this revision. REVISION SUMMARY BUG: 405478 FIXED-IN: 5.57 REPOSITORY R269 BluezQt BRANCH bug405478

D19798: Fix Words & Chars String on katestatusbar.

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fixStatusBarString (branched from master) REVISION DETAIL https://phabricator.kde.org/D19798 To: ppeter, #kate, dhaumann Cc: pino, kwrite-devel, kde-frameworks-devel, gennad

D18845: authority: add support for passing details to polkit

fvogt added a comment. LGTM to me as well - I'm not familiar with this code at all though. REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: mati865, kde-frameworks-devel

D19786: Fix WebDAV directory renaming if KeepAlive is off

broulik added a reviewer: sitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Mar 2019 09:19:01 + Build duration: 1 min 19 sec and counting JUnit Tests Name: projectr

D19762: Only get clearTextPath when used

This revision was automatically updated to reflect the committed changes. Closed by commit R245:185177379cc0: Only get clearTextPath when used (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19762?vs=53892&id=53996 REVISION DETAIL https:

D19798: Fix Words & Chars String on katestatusbar.

ppeter updated this revision to Diff 53989. ppeter added a comment. Use i18nc instead of swaping order. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19798?vs=53985&id=53989 BRANCH fixStatusBarString (branched from master) REVISION DETAIL https://

D19798: Fix Words & Chars String on katestatusbar.

ppeter added a comment. Done, thanks! :D REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19798 To: ppeter, #kate Cc: pino, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53988. kossebau added a comment. Update patch to restore initial logic without stretching, which also resembles Plasma4 one REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19787?vs=53987&id=53988 BR

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. After a first coffee, I realize this very logic actually already does upsampling all the time, given it takes the floor of the nodesize/samplesize expression, not the ceiling. And with eyes made sensitive, I see this now all the time. Rereading the CSS3 spec, i

D19798: Fix Words & Chars String on katestatusbar.

ppeter added a comment. Good idea. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19798 To: ppeter, #kate Cc: pino, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19798: Fix Words & Chars String on katestatusbar.

pino added a comment. In D19798#431847 , @ppeter wrote: > The reason why I just change `%1/%2` to `%2/%1` not swap `wordsInDocument` and `wordsInSelection`, because I want to notify > translators about this change (or those current translation